From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CF17C282DE for ; Mon, 10 Mar 2025 16:52:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8920A280006; Mon, 10 Mar 2025 12:52:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 841B2280004; Mon, 10 Mar 2025 12:52:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E4F4280006; Mon, 10 Mar 2025 12:52:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 508B2280004 for ; Mon, 10 Mar 2025 12:52:54 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4B00E56A9D for ; Mon, 10 Mar 2025 16:52:55 +0000 (UTC) X-FDA: 83206235910.25.D4B8973 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf10.hostedemail.com (Postfix) with ESMTP id 38DAAC001E for ; Mon, 10 Mar 2025 16:52:52 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vu6I8+9a; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741625573; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Hqzm3YDh0Dmu4WiyshUyFvmRxt/1G3zatmGG/ppP4I=; b=6DPBocQ2hK6Z6AfNntDqvvcdaJ32LHLz5bSS3ds1+zp7HDxGUOTdlxwBkxJY0Eoh1EgK/Y nSSYGoY13pB/zTNOjcJDvzS5Gz3N0FwNkQsYBMCzEP2HxOpGs019BI8vIPbArBaD1pzH+h g55Yew88hI+PliK+6Sx/zIxBucJb2PA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741625573; a=rsa-sha256; cv=none; b=6rzJDD+5DpNToQyGgPk45ovJI+LL4z8K6u3buqSwhsvK8vECtiCQzkYtz+jtQK4iTiPjOL BLhVcxGyqwDsQgwwN5FQ8V6AO6RuxhJ48Jj2p/ka1KKai/eas9/jgphqRgxeMyLXUk3MKq txCTIZwaREaFFV6aCmjkD1aY3QZ2BU4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vu6I8+9a; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5499614d3d2so3562024e87.3 for ; Mon, 10 Mar 2025 09:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741625571; x=1742230371; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=2Hqzm3YDh0Dmu4WiyshUyFvmRxt/1G3zatmGG/ppP4I=; b=Vu6I8+9auojlpOtZD9zVBFRgEbX2nbJZr5l0vuGCBUHlCt8ziwEJE0Vb/RypcCVsar bqz3qI+M7O51tJB+4O1mKdmckXkEvIqwIxTmRSBO0qGnvO6JC12D9Dqlspx5px0yT6M3 ceI/3G2ezekJgVuNtx53XMQ4F90Y5vJ7sZdr49iwoAoeuR4UzTxLsjHh0j2/yt5k2aCj OVA7wED6Mhj6OQHTy7OjUbzyBHenqk1+2UFOj+kRHzgMdfl2Fxl5R169e715GbIa0F5u WrFSwlDkcbEYNBxX0qkQ6nYgIylVZCkHYgAXyGdEDqdxmD4rOHrcrkFTfhM5S0mKeBbv B8VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741625571; x=1742230371; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2Hqzm3YDh0Dmu4WiyshUyFvmRxt/1G3zatmGG/ppP4I=; b=r15iZ/KCEOJgiMvQfRKHXrPHbzMqf7sPI2izvr2K+nBsC2U/JKCCv1h72Nu6t06+pp 6y4TnchUq5grCadMhc5VpZkFJWM/twJYvOWNgMcRLuhC/iRVTPlfDcp0/x70nHzsYe0H IjOC8u4SS1c4e5hUPujzRu1Tu7RIRndP9iCMruAmPVCyKmB43q0QBIEod8kYkLGEe2c6 rVyGhg175+jM5zehJs/uvOn9PdXiDxBkQ1Z4Yo5jQSlW9C3r7NB6KPOIGkUKs7EFWVkx iB/mawiZq5918Pf+0ncoiZJ1oFijVG24evKwhovEZSyZoLzAiQ1E1mnQNAce9h8zWb7j lLwA== X-Forwarded-Encrypted: i=1; AJvYcCWUZIWmVAZ3dAje2n+SzWMhQsbYRfBwjdSp03tcvy5d5mB6Tnz79ijALE6Xrz/qEawJGXsda+8Jpw==@kvack.org X-Gm-Message-State: AOJu0YwVbcn+Xnr9xs2f0m8VeIvJ6/gD7S7jMdEdJt2w5yQov6OkLAIn 4zIuJ7lTNJcfEc2CMQJhkOn6mvRtwljk3G2NMQWTM1bB69Z0ZEw+ X-Gm-Gg: ASbGncvQUYABhnD0uRIipX8bFNFnOOxlK7G/dNYhF0Mruzq4f5rPVov1IewIKbxI9Gp vHZYCRpQnwx/1I5YV8i3cvZRbScrNjleYqGHi6LFg6re93bM2pAFPCpQOJiyHZNuYO154Z0wffq N2Ks5Uj5KECKReishapZyrxyMrnAFLHCkBjycqac9aHrdX2lSs+wVDCqH80dPZ3bt3vhxRVUVoF bC8oRr6mA8cCPqzVSH09Ll3cvu2kAvBKTRUKJzMQTHPAHv1GUchl6dOkCZRJr+1PBeLwGAdtk4D wQk6M8nK9Kc7Trltm9MQM9JmNJ0r+Z9AhDXfi0fY324LuqoQRGnfEZTjeS0KsWpTiX4= X-Google-Smtp-Source: AGHT+IGoH6YtfV7nOzsPI+6iIx3aoe54gR+xH8kR3xd/zXrtBaIzhkOOFF2K23Utu/wr4pLZSMn2lw== X-Received: by 2002:a05:6512:224f:b0:549:70ea:27a1 with SMTP id 2adb3069b0e04-54990e67248mr5119839e87.23.1741625570942; Mon, 10 Mar 2025 09:52:50 -0700 (PDT) Received: from pc636 (host-95-203-6-24.mobileonline.telia.com. [95.203.6.24]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5498b0bd148sm1520811e87.139.2025.03.10.09.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 09:52:50 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 10 Mar 2025 17:52:48 +0100 To: Andrew Morton , Liu Ye Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Uladzislau Rezki , Christop Hellwig , linux-mm@kvack.org Subject: Re: [linux-next:master] [mm/vmalloc] ff6f2b81ea: WARNING:at_kernel/fork.c:#vm_area_init_from Message-ID: References: <202503101629.7289b1-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202503101629.7289b1-lkp@intel.com> X-Stat-Signature: zemki9sjdbisbrguxfy4dozt7y7t3y7n X-Rspamd-Server: rspam05 X-Rspam-User: X-Rspamd-Queue-Id: 38DAAC001E X-HE-Tag: 1741625572-769581 X-HE-Meta: U2FsdGVkX1/y6bMwNcgAA9Eo9+DH7ntuFqZh42IUsgssABV4U8zNOPpvozsb/VCUnxqIF6IEzAxhWnnTSks41dcEANl+whbP8na4GZzS7NWJY27Ai52LLPhfxP4wy29rfZU0WlKBmR7rzMQN0TcmztPI4z28flnc3Toz309r7bPwXpdxDzMFXr8V/0GMa2HCMKSJGCJ7ukfwYRSfzdVLrUnAOwMkp9Ba7Vdl61d6+f3krQFFx70YgSw5i+deg2/q+s7IXJt//gViFxWAFtJPXAUiq7417M7+09IfXgO/Pbll84477wTkyS8+c1l2EM5Wwvp3gX/FyRqBUegN6WGob1uryAA7umvEc/zTESO4IqSKKz7ZHnRWEM28O1QSocqCjfgiP8l63NXvcN+IdnNVaOs1a9HFoJMOE8G5Fu4ntRoko5Q4pAcTMDn4Tfc9iRLSsJYTepEH6RGBw6ZQm6cPkdSPJ0leq76N7x8DsfUMlYesoVmJlO2eKjGPMPK2UT+AnAqfJQpmutMYxC+hoG2ouPS9EJ22h+hY4qEcXwg5WbYGk+Klc+ca8lF/4puHNu5sL4M5yaHOu1cpzpc5xTXdR/xlfISB7h9hccZnSAhNQ+6YyqJ25ExBupmYRhyNh76BbPfhnSck/8+xQwGMM08HdD5t01hjFjw79lpNJPPvpvMR48X1Ma834lDI96M+2Ph1ty026RVfE4S78dmoYEjRWeTiS7mcpAPHAhDf859a01noSr5/ffkLQjL+qKWCtzo3kuc7DzsU/khmqIlyKDpmvNY0SAb/EFhVGbIZAqOOgArY1nGEyMLQBayjzn+MbfcrtUy43ttv2xO5fqLZrqbTuNKIVui5Lvbxpz45oqrbv6DB393uTyWj/O6kwdi4E4t1h99R3ehHo65q8qQSPAQdATYYyI0XnNr2/2JB4uioJZnn3ngtZEQ++nSZx22CLsmG+gUE/TxNB6tMCsIIM9n MC8qkB+/ O5EP7mhoQKi57ZnGE8gUkC/NPJ/ipOb+qrM4YWuOrRvwp/dNk8tF+ZTm36lwAcSNOLoT+StEXZxmaegb/ClHTFzPncI7QL8kB3xZjJ0SaI99FEIvBr4v7DVSBZylp81iowdxQQPQdLVQ9rslYExqFX6fgVC+R1rxGrIsM6QlWXnHpkNMTqVsiceRG/mb1F0ezzeWj7CPxF4t5uR8kPA032g4V06yKqj1RjJPsqJU4gTsITImJQ5bCq3vNBmSKKPqxrzngGcA3I1nJ5U3Wp8wG9aVC9UiXth3otjMoTEgLGmELSmqdln7O5V3y/o/wr7NuvEByCXXOCS7igEntGHHUbUS9GIWtmQJZzvSMfnsX8gBYKSlnyq7Ro3t6rSQLW4EJ1dMqQygFIrqQ/H1ylXVviUcOOHkTF39iToRjJ6pmunzuXQCvCo7NcTOFlua6qgcScXCFNHw9D8d0+nmyf/nB0YC5tg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, Andrew, Liu Ye. > > Hello, > > kernel test robot noticed "WARNING:at_kernel/fork.c:#vm_area_init_from" on: > > commit: ff6f2b81eaa8a9fe5d158c6e7b1e58d3929c32c1 ("mm/vmalloc: move free_vm_area(area) from the __vmalloc_area_node function to the __vmalloc_node_range_noprof function") > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > [test failed on linux-next/master 0a2f889128969dab41861b6e40111aa03dc57014] > > in testcase: trinity > version: > with following parameters: > > runtime: 300s > group: group-02 > nr_groups: 5 > > > > config: x86_64-randconfig-101-20250306 > compiler: gcc-12 > test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G > > (please refer to attached dmesg/kmsg for entire log/backtrace) > > > +-------------------------------------------------------------+------------+------------+ > | | fb8faf4337 | ff6f2b81ea | > +-------------------------------------------------------------+------------+------------+ > | boot_successes | 9 | 0 | > | boot_failures | 0 | 6 | > | WARNING:at_kernel/fork.c:#vm_area_init_from | 0 | 6 | > | RIP:vm_area_init_from | 0 | 6 | > | BUG:KASAN:slab-use-after-free_in__vmalloc_node_range_noprof | 0 | 5 | > | WARNING:at_mm/vmalloc.c:#remove_vm_area | 0 | 5 | > | RIP:remove_vm_area | 0 | 5 | > | kernel_BUG_at_mm/vmalloc.c | 0 | 5 | > | Oops:invalid_opcode:#[##]PREEMPT_KASAN | 0 | 5 | > | RIP:__vmalloc_node_range_noprof | 0 | 5 | > | Kernel_panic-not_syncing:Fatal_exception | 0 | 5 | > +-------------------------------------------------------------+------------+------------+ > The patch that is in question, indeed, looks buggy. At least i can see how a use-after-free can occur: static void *__vmalloc_area_node(...) ... fail: vfree(area->addr); return NULL; } ... ret = __vmalloc_area_node(area, gfp_mask, prot, shift, node); if (!ret) { free_vm_area(area); goto fail; } ... vfree() - __also__ frees "vm_struct" where "area" points to. A NULL is returned and free_vm_area() is invoked one more time on already freed "area". Probably it is better to drop the below patch: ff6f2b81eaa8a9fe5d158c6e7b1e58d3929c32c1 ("mm/vmalloc: move free_vm_area(area) from the __vmalloc_area_node function to the __vmalloc_node_range_noprof function") -- Uladzislau Rezki