From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F77AC021BB for ; Mon, 24 Feb 2025 15:52:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 297166B0083; Mon, 24 Feb 2025 10:52:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 247C36B0088; Mon, 24 Feb 2025 10:52:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10F516B0089; Mon, 24 Feb 2025 10:52:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E6B536B0083 for ; Mon, 24 Feb 2025 10:52:01 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 980971CADC5 for ; Mon, 24 Feb 2025 15:52:01 +0000 (UTC) X-FDA: 83155279242.20.8895B9C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id CFCD6C0019 for ; Mon, 24 Feb 2025 15:51:59 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qP4VXbmR; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740412319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J+FNxXVBZwl7yffXOvKolfq89JH5xPgIKGmft+woAV0=; b=XWo421U9Y9NQ9G/DavVbJ9wcQarLChbmWF+ZRQj0VDYOPdHVKTEoV31UUa+oIt3wTrtnIh 8+6wV2C1mK0/8HpXTRNc3RhXd0Yb87bhzIk+rrtUGrCTsi6ic+ySG5YgSOVIeCsJSCYrXG 9MXv6GCBXOuEHvltfrDcVHsVvmtgr7M= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qP4VXbmR; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740412319; a=rsa-sha256; cv=none; b=rjSzfncZ3xObL/ST6Ef3HfFxsI4frju9vArVAUVvseR7XGpJEmTDJemN2uJS5xFInTS6th UuBV/SK6REZEfAtypk+AYTJ9B7Ap98lyXaFMrO4Qw3GwmuqsUY+Hhsv/DQD2nWPehDeark MpVRqJVNcz4uyuhJMaIOigVVxpvOr6M= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=J+FNxXVBZwl7yffXOvKolfq89JH5xPgIKGmft+woAV0=; b=qP4VXbmRvMGXQ3UZk6cclJWoCn 8YE1m0cDFl3Sl9WQsoaPVGFqQo7B3ej+V9YsYTV2HQIUuzQ81ZG7M5QXq/S8A7DcJwQ8HxcuxJjvl rpUsL9qm88a2F6PElI7OJKK1p9sX0yTjN/2ArkkDMvOJ8Wp5UTdRM58pJjbQVQoFsdG14gio7qSJG OE/hNxFFLCR2H8vCdWlflVIRfzMmW3wcZgADCanQ7IK3ehMfMSZTIFNZd4MWpQgDybbtQY5NpVJvF Az4eiirGd2XTJQcvaNYqdkSJb4WVwhTEHyuPSYOfXDl7SGX93+gDzWPep7PTH/Ltpp8nG0qN7a3lu qHz2AM8w==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tmakQ-00000007gS0-1kDH; Mon, 24 Feb 2025 15:51:58 +0000 Date: Mon, 24 Feb 2025 15:51:58 +0000 From: Matthew Wilcox To: "Raphael S. Carvalho" Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, Dave Chinner Subject: Re: [PATCH v2] mm: Fix error handling in __filemap_get_folio() with FGP_NOWAIT Message-ID: References: <20250224081328.18090-1-raphaelsc@scylladb.com> <20250224141744.GA1088@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CFCD6C0019 X-Stat-Signature: rxwtetcjg11fjim3y18nesm7kmoc8oyf X-HE-Tag: 1740412319-816601 X-HE-Meta: U2FsdGVkX1+OAzAm/aJwedDotSgBFLc0cA74Gf4XIps3SwMdK+txizBA45a9HJKoRsQO5syf+ZG+Dnny/+IMwM4lWhoyhepwSGzOa+5sfot30XXGJT2a/nVp8sbkqN0cxPueyFH5gLH3wnr4lkbX7fNi59HsE2884AE3W8Vml8O1wg6ZG/clg7P1AZif384kNjxfFWDAxUZ3iija5zJr78HbPOz+d6vXXKt63YxxKEPV3lnEoY+6uZHTJ83bQH1U48t7rG23gj4x2qG6Jq7NF1NIVLMXXSODOokGvXN4mq2QSYOHp7EccTL127xgxyyfvGNHxn9Wx4zwKmAs/jDCve/Qs9096dsjiqLZY/x/NcPxnXy9blCgHSxQ06FdjSOrrlilQ0vz/YnQdKXHWSkMoWRuQg2somOfld4J+pDsd2zrQJUCbs9oczPWb2Z2Z7zUeAR/MxMQWChqmZ4mtuVbJcChmqWabg4wTU8QDbWJPu9M6O2VEVrZrAxhQfzmiG/Ocep048+/c0DiIxRBVQDEjVAt4HsoF/ONzPNjgAkVQkKZ+YWxlunORqt9e7/6WG4uBGIrorEkTkrgF/vWJrxT+OxfDaMS4AZnPUOoHtiZSuw7DTYBPGT9Wl583XA7YiWLhOSqpNGGy8+gmMKOKFMWag7MKGDxEDawKlqb1gFWOkY8fodEK/qdanN9IpIWVSU/JjXD45twItVMEW3g14ahi+IAMCeSbBBP1xkblbM4zt8+hIcUEkJCTzy+RaJZTgSZJdbiaNR3XfQnKmnpZ+TC6V08K2diugUaoyjYoKoJML/d6iKdTQ+xz8wxr6WMvRs+KvCrnlA2aQj1fULH+IYVnlBPySp9hRH5R5WixEp5VuR7VsAHi4df7umjU7GgT8gcwGVr7583bYo6XOYNI/LNC+/lnUwA0keO6rL7f+ZEIbhezSL6AaddCeoUenobwhKsdcBELcmlbh7mS0szPSQ lrcFhLg8 2XPeP1VM7jsdveLPy6n+qxU4dpAfl5Bg8mZke1YSC3gDhXwyQxC0gjlARnEcPLScZ2AezfvtH1wX78X4Bt/DhN8DIMoljP4kY7CaOd5z4aIRmogNp9LhT7qQ7UcIjVQcxaLi35AoqVK5wF5eJjjFlsA//SsV6Tk2ctJkg7kdPE9AgdXEJv5i78oxImcU5jOxzKrAq1I1diVQWiN99ukAhQrQMDDIjzrZc/Ukk3n6FOV4nZjMbHG8JwKn3fgVRPYThz+La1EcEBglpW418EFsuRSP8Rw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 24, 2025 at 12:50:48PM -0300, Raphael S. Carvalho wrote: > Ok, so I will proceed with v4 now, removing the comment. No. Give Christoph 24 hours to respond.