From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F4EC021B6 for ; Mon, 24 Feb 2025 04:22:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE49B6B007B; Sun, 23 Feb 2025 23:22:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D945A6B0083; Sun, 23 Feb 2025 23:22:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C82DD6B0085; Sun, 23 Feb 2025 23:22:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AFFB86B007B for ; Sun, 23 Feb 2025 23:22:19 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0A42FB1B9C for ; Mon, 24 Feb 2025 04:22:19 +0000 (UTC) X-FDA: 83153541198.23.203CEB3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 66B39A0004 for ; Mon, 24 Feb 2025 04:22:17 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vEXYWsVN; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740370937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iaczR1coIXW0K2GHIHJRj7av80M15T1OEBjJcS+PABI=; b=I7x3/kLNUdpgO5Vk6l5t3dcV/vLzoT85HRdQt7pmB+3CCdV963srdA5NUXRes7m9IUYIqR UFzGD2aySp5HTWiXZvsbaoe27MvaRTyktRQ3iEWBDHtAEG/KVNq5TeH8kTAZ/hIvp7Q/X2 yik69l3OvoU/chBoSFGXOLTpMrnBhD8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vEXYWsVN; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740370937; a=rsa-sha256; cv=none; b=s3JwQZnb3fuKWDbKRX7w0sANgmmlDBPcwOaHwIIOVpH7i890C92JDNTt5N/B+oYZOn+/Cc 9vp0hVph8xYcRrLLvHt/Ndp+U4RSnM1b1k01DY6+dUei4jKGyjlX2UTwIbRESRBwvY/Rl2 VbaGSLqGR1m4rxTaWKF6UFpcmutX2bE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=iaczR1coIXW0K2GHIHJRj7av80M15T1OEBjJcS+PABI=; b=vEXYWsVNZmSC6fJflbK4roRpzw COLzWOzK9Cu+LfmKoID6WpMtt7xfOUn0/Vo58r2NfQ7lkx69qtRCSwBpoXZK4wNgVmHM0x/iQO+12 eEArtR/elg9oz3meMrPGoQN3A0fznJvC464+7SwjSIpPj/BThhBdNHkf6RXA5Iw47mCs7T2Ze0ARi PwqN0WJnk2/PQDp3AUXFvuxO4YczRKkBukMXuFPqA8bhzQ+CulUh7coT6TTMgi+z5kTqlA9TJ3VRg wcOlppGvFehzkQ1lNm823O3gSVpAFmOKVc8zXWFWNDFbMNtx4AxcnCAGzd898HuXhVvbhbpf2pp7+ +qJb1K3w==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tmPyo-00000005nw2-2pFg; Mon, 24 Feb 2025 04:22:06 +0000 Date: Mon, 24 Feb 2025 04:22:06 +0000 From: Matthew Wilcox To: mawupeng Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, david@redhat.com, kasong@tencent.com, ryan.roberts@arm.com, chrisl@kernel.org, huang.ying.caritas@gmail.com, schatzberg.dan@gmail.com, hanchuanhua@oppo.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: swap: Avoid infinite loop if no valid swap entry found during do_swap_page Message-ID: References: <20250222024617.2790609-1-mawupeng1@huawei.com> <2c7dfa44-266a-4aa6-9401-7528368f171e@huawei.com> <61566a74-04aa-44f1-9aa9-624644f06450@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <61566a74-04aa-44f1-9aa9-624644f06450@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 66B39A0004 X-Stat-Signature: cwpop5pgzh5d6gg9eiq7uynykkoxxkwd X-HE-Tag: 1740370937-566670 X-HE-Meta: U2FsdGVkX19ADJXR+o/d7SjMZIIrfuJVf5KCqFTI+VuSYFo14wkQZcRVCsPVuItkAkXo8BmNtOOyHB7SUQBbvU9p37puzNz13MhY63FC8514w7WZ9cR/0YM0yqZhnRTbIAjme72IPVC3M7E31KsLrF/LOO0zU83Py0RZ2/sM8w9aZ5Nzoa5iZ0qzsPKv2nbAaSiizNnKRbDIyb0GKI2iraf6+vB453TYIce7dgXwvZ6edDcGO0NxNlLgIQUpErodXl0GjU/Sl+TfdgTgwdFtpdnTL0j2X4tIT6q4mk6lrF+TBjK8FdvWdNNFVEkZ4cXPO7fQRfC+S7yCV/HyEkfam6oZ0nyMab0vs5d8jZ7NixO3g1vq3pMbzzwBIHHgPUSwRkh8NljR/3pkC/jQ+5GQfuePA9Zhh5neLm8lnv2RZ6GQ2ALnM5saLCgMSzqXfk4Dyn9fDcV1HLvUqD3l6Bfedzdcs75vIizOdt9KVR+i6waBRHMudJfRiSPvdCZ5vJ8zJ7FUEVlgjWZyTV5Deqr7ohj7pQJ7/omokx3e7SMpQ6s2qKKYscvjHPLLmthVSjuUBpJq2LJvTvktdmTIzxAcqlwvs9M8U7rHcuyYv8Eot5TDrmQ2bk3/hO0mqT1Eiv8Nar2Tx8v/vQ55gsq4hgcgsuXHgpHsdW7baoENpVgUJijSUOwcvkh2BRPVxTyh5OIkgh523RjJ6vDVR2J/K2/Cht6uWizy7S79u4368B6DNckGIjkZu7SHGvKOKtweMxQumx0uVcDQ4LYjESdMgqULKmRnpsiMNsj6aTPbBiMwymaHgNDZK+EnCdiZ7gVGaMh9pDkzvWhB7N/WqOQPE+PmD0xkgPTNwZr9sukaPNa3kY1xz+AcKx6z2kcu6wVPjZKk+DP/YUFio2YH5SYVTKmM8ncW+zPDFulq+QV+FJHsadvtOFX3Wsj8wThoAJ5hsMxcbNQwd9BnI05Pj3WhK16 mCUAoiI6 22mdsCvxaoYJwEegmYsffL2RAVQrl04di82VkNn4I5agO/vArH+lIBeq4gvyXrXDuftU9NGTfDb453sQb17Zum/AXZq95U1Cf/+bEMJMoL49Pmfr4y6KOc+rsfNSg/Rspi2sltDqvucdW+xlQxCInoJjZJ/IpQf24XYjQjR/1DcxZrtM9Cpng7PLG8Ow52cGSRR0rqjlPBl2aPqun0ukemhmoBkgK9Wo8jKCNiT3V5ILNDAGJ9NjS1Cv5B9jBtqb23W26cblFWHdWFQCMiM4N0B1K3hXJ/uPm8BQNJUHLjiL1e5kBCJfKjwyCAvekN5fZzco+0MkYxXgCvk28YwSfiZazCtmrbkQvFLiMAb1LLcDQQL5PvqCxY5ZQQHsqRH+85m0dJD06q4/thGjeryL0piT6wnMYXh8/ex2cKOGr8xNw7yKkhSAAqxNe3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 24, 2025 at 09:27:38AM +0800, mawupeng wrote: > On 2025/2/23 14:18, Barry Song wrote: > > On Sun, Feb 23, 2025 at 3:42 PM Matthew Wilcox wrote: > >> On Sat, Feb 22, 2025 at 11:59:53AM +0800, mawupeng wrote: > >>> On 2025/2/22 11:45, Matthew Wilcox wrote: > >>>> On Sat, Feb 22, 2025 at 10:46:17AM +0800, Wupeng Ma wrote: > >>>>> Digging into the source, we found that the swap entry is invalid due to > >>>>> unknown reason, and this lead to invalid swap_info_struct. Excessive log > >>>>> printing can fill up the prioritized log space, leading to the purging of > >>>>> originally valid logs and hindering problem troubleshooting. To make this > >>>>> more robust, kill this task. > > Yes, log flooding is not the main issue here, endless #PF is rather a more serious > problem. Then don't write the report as if the log flooding is the real problem.