From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 494B2C021B5 for ; Sun, 23 Feb 2025 00:14:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B34E6B007B; Sat, 22 Feb 2025 19:14:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 262D06B0082; Sat, 22 Feb 2025 19:14:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12B0C6B0083; Sat, 22 Feb 2025 19:14:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E8B7D6B007B for ; Sat, 22 Feb 2025 19:14:18 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4DCDD160CA2 for ; Sun, 23 Feb 2025 00:14:18 +0000 (UTC) X-FDA: 83149287396.11.8748105 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf16.hostedemail.com (Postfix) with ESMTP id B3B8E180007 for ; Sun, 23 Feb 2025 00:14:15 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=q5Dcun0r; spf=pass (imf16.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740269656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z4R6SM3uMAflgdLS3XK/87m5Avt06drqLQsC39J3eto=; b=10n6twmzWdRnaFa9IYAySUPCy2HszNGA2F/ib0zg4pTZsNcBtvasFra9s1XS6iQ7QYOylw qRhqvl/cR5AoecVFR+HBJH4F1wqIR2qF9fIpBwez2ULQozVpyZUhTF8QtoaJFTPB9iuGED E1GCrKOxSVjWXv6155Gq2RjN64Jbe2E= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=q5Dcun0r; spf=pass (imf16.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740269656; a=rsa-sha256; cv=none; b=IwYqmYf71GFE3RwIg2fAve7BscWapC99dmcENEEUSr3QNY5AfM1oKrb2quqVZ9jP/95uXt 0NKqPVwNgGOuqPfZalehVX3YBcrwro01gk9EjnUY8ByTHDWX2dELs7xathrzXzuVJocu88 +UJEZSkPBJPuxCGu8xPpDiICzzxr5fM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Z4R6SM3uMAflgdLS3XK/87m5Avt06drqLQsC39J3eto=; b=q5Dcun0rIjPHdiQEvc+TsWlVjO qfEulbqPSm1YCIQw448xmfW1TkybphHEX6yKfXavyR2KBzXt36j7bIomETl3MRnb1hfmxYlgYgBIt vdRsOH4QOySTeySbbN1huKEdKjBRiNkl4e8a0tUz3hRcuR+DlcHEEnTJxeLrLkAVKafY0p1YxBxPq I8pLP3aa5KqyCI2x3mXGp1tjkEaO+mSORMqCOsnuMmdONDFW0doKTdDBCYrN8Vl0kiS3J4LouY7tI pVUVeN8av0eq06PgNdVUjFJxJKYGPNX6+hfD1ubmUmUMPMFNf05Nn43nM1yrbQ29aOZQrhTRW1uhR ggmWTw0A==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1tlzdG-000wKT-1M; Sun, 23 Feb 2025 08:14:07 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sun, 23 Feb 2025 08:14:06 +0800 Date: Sun, 23 Feb 2025 08:14:06 +0800 From: Herbert Xu To: Sergey Senozhatsky Cc: Barry Song <21cnbao@gmail.com>, Yosry Ahmed , Minchan Kim , "Sridhar, Kanchana P" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" Subject: Re: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B3B8E180007 X-Stat-Signature: ewzzru74fyjmx8ntmnpgjnfzus81d15d X-HE-Tag: 1740269655-417911 X-HE-Meta: U2FsdGVkX18vkyjPdqs7Vnn7SMrdx8L5iDIjG+uJyflCagqXq7fwBVOD0qiZYRUUu01jW+lwx1L7wI9L5BeYVPBbRaXkuWYkjQP5uHeCT21zURcBnT3ni734VFfv1Ofm6LT1UnyWDNi0MXhKBx4WZKi1rUuNUquFHHYowD7CLHajLZw3w/8hiYzu+ABCj9uw/t4LOAEe4gTBJ5qNcNeocHEZudN5YaGirn0UBhknYHOBj16gwnYteN7EEktjM2N5AldkG4cys0gyi0Cjfe6wGyuzpYnx4TQonTbcbSOE62dgrJtpOI6f9Nxzqh9rlXNfVk2ey/8cHD05rMUK/H7mBoEhi9dO6ZG0fEJvg8SZoEG5gfzUIGG5ZDNAvdewI0FAY5EFW5/Gk/znLJpITvbdOUeNFWGY0zIHlU9AjTQmFzTI140rrM9kt+c/UEVN6gSwVdS3DQPG0Rn7wtAH4WmwPXdCK64OLD7b1qXoSd1dxPNnC4c1EHkshjGKj2wItIAtc82qy3zOYb1NS882LVrTonNy/+9QXleuZsF77Kj8pkl9hVnzSNnoVJMyuxUL+FnFA47a6Vri1LipV1cwgDIcCHA6NDa24TsVZWK6jxdyQ/VVssBxJXnACsK1A6t09jpN7jXSH9sws0PL3Be98rTqjytsORmJQOPo4TP/fPVDf8uRoGrSIGdJRsqlkMMKSxNXFoPSn93hBXkBQ4BAX77/HKsDfpXA3TxgnczwcBUh0uJXyipASkrCgFePqFEQmnoyIoVRn0xqnQQdqairVs5rxgV6qyDlMFhl8bP7z7EcLRepH7pUDy+vgVyghO+zv5GOPjilflrIja+X0XBld7nGAHGV/0weMf6rv7Eff2hy6hJl1yQcSXI8/4arS6lxZmOuLlT5WaHy8imuGsedecIZJYwh8gqKQq6S7PkGyXQMpOPpkjRcLrXys2UljM7xJRZwgMyoHEEKy7S1OCjGEle NeLlkINR liaSBaMzafw7KMhpj9b3U9FoeTqS2q8OiSjUBJb/JR3SOUrLvbWy0zFg8Dha6yLeLYBq7xhhChcpsanq0NdZwRQkDJwAM1Eu6e19/cvF1Nsz/LwXErvaFacgbiVM5mwfZdgrqq/poFxBuJ4PZH5ae4P5GVYBgiIAN/EJZTCicuq2ySK6VXRJu6/1q2YlFBSvhZ0w7qPmrbWXt6IZ8KvLbrruai1b7sRol1Tzfe9TDBhYAbEPNkTSKpC5i9ohiddec1dDpAoKLDpHxo878OllF8eOpOMukc3NH2tJYZNJGzyqySCg+9RyHioLKxlWks2hKySKAY8i+lBEnOVx1inYrQSBRHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 22, 2025 at 11:27:49PM +0900, Sergey Senozhatsky wrote: > > So I didn't look at all of them, but at least S/W lzo1 doesn't even > have a notion of max-output-len. lzo1x_1_compress() accepts a pointer > to out_len which tells the size of output stream (the algorithm is free > to produce any), so there is no dst_buf overflow as far as lzo1 is > concerned. Unless I'm missing something or misunderstanding your points. I just looked at deflate/zstd and they seem to be doing the right things. But yes lzo is a gaping security hole on the compression side. The API has always specified a maximum output length and it needs to be respected for both compression and decompression. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt