From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBEE9C021B2 for ; Sat, 22 Feb 2025 11:56:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C94B6B007B; Sat, 22 Feb 2025 06:56:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 452DF6B0083; Sat, 22 Feb 2025 06:56:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F3076B0085; Sat, 22 Feb 2025 06:56:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0F9B26B007B for ; Sat, 22 Feb 2025 06:56:52 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 768CB14141E for ; Sat, 22 Feb 2025 11:56:51 +0000 (UTC) X-FDA: 83147429022.05.CA270D4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id B7F19180007 for ; Sat, 22 Feb 2025 11:56:49 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740225409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M6gW/I1mf2mjWjZBwnLuibAjaEGD/kCLfNNrvt9WDCc=; b=S7+z747wkZdIDru73N+NA2cVfVvkFaUHebLLpMADPQXbCiwjAWseJ4M0K4BYmGO2GmK/Ya YzGbMZyymeSzotF7os3LrmEhvVrmW/Tco2tODUuAG7Jfjvaxy31jdc1nenXKgHmH03Q7LK tZ9qS7IYIhFsbWz5yF56+91+Ojxgf6s= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740225409; a=rsa-sha256; cv=none; b=rKcgjPQtzv7PjTjBxEalxbN+YvPId/rTAcaqklUyAMxiJEWVvnuEA30NPbbv/LAZknoBFF e21x9Y2OtNVGVNwZl0LoPx0TsSzGbF7A8oC3dxQeXLiO9MPmyEd57C8TJJ/0Sj5KirK//Q cepkUtL/VvqZFkyZRn5zT1RttdtciwY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A127A5C55E8; Sat, 22 Feb 2025 11:56:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7D3DC4CED1; Sat, 22 Feb 2025 11:56:45 +0000 (UTC) Date: Sat, 22 Feb 2025 11:56:43 +0000 From: Catalin Marinas To: Ryan Roberts Cc: Will Deacon , Pasha Tatashin , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Alexandre Ghiti , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 06/14] arm64/mm: Hoist barriers out of set_ptes_anysz() loop Message-ID: References: <20250217140809.1702789-1-ryan.roberts@arm.com> <20250217140809.1702789-7-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250217140809.1702789-7-ryan.roberts@arm.com> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B7F19180007 X-Stat-Signature: etu1sj5kywfj3hkcecgbonb93ht7j1xy X-HE-Tag: 1740225409-904461 X-HE-Meta: U2FsdGVkX18sgBM0yIcPA4uvJ8JLddze2pck5ZqEy4aTA6VXkH6xFLQeVbDRuHraTRNfm2WUo8UW86C6wzTngLjn49dPAJVA/PGi7AYR6BRhwp82sJev0sopqR5cAitddl8G+Mbel8Tj5Rsj4M2GNmTzmxgsATGGSWnvSVIjv4gBfuvbkxWaPX/95hPT9tSz3zqWB+x13btDqfRmM23AdLB9Cal6yOWEer7uZluc+14SIOe03NceCoXl3AoJs3BRhQEChCWfhdIDSbwp9/okiGLL1dMYcPPmp7nMvXJ+xUapJXh4x2BUqYK85a05Hm0WJszCRx9XYd/IzFCPWPX7MaWAPdGaijd3WVLlVAmkrCH8fO/u3ZEVQQv0hFgMeMAq9MRJNPX/q4toT5GuHLT1NoGcfmzKQciLgQGxw/csElUL52HBkOarigrLL7IvYU+qTDEJT5kquMw14Zf6HN4qJqfTk1wligxRg6n4x0soFWjC2hAf/yJifDH/xjUMrwLj08sYQn/CIQ2RSPDYU6kX916XhICc60Rd7hVOZ7ez8hyVTkt7jhS0o7xqOqL41dtdQteOIUWdsIY1NuHptUi0vHpZCuxFTO44mkPDBbGUNvM0lRyx67lSujIQeR6SlCzIsuXTodk6LkFT/xuJLFXIyGljTLngWw6EvsHGzeurASUfUS6ZthtO2/kjqyvNQZkRY2hS9L5viaLpmjLWrZhqk81c+lMBbh5njcihRCKJbVnlc3BbrPt4bOe2yvM1D2yJv1uj6XizTHRVU0nQk/y296Kx6NCM5RJM6cG7FN7yy/4Kk4k+zdiExarQcOrIevf+p3iF485PadPt45zER5GsExRYJALh3hocfuKjbjVwy+XVgWMNImVtQxe/CAxRueYAGW6f46TtlzHhe/zASlb6hLnQhgLC7eB8XxpB2nh61vWoS+Hv5V0julrO1P/Ll+Dk5K5bcpQu6+fZzZRe0HO MCj2iqZ8 vSjJKgOrslo8cSkI9gO4K+Bq2E5ohW2S7htSMwDY1huwFicP+ysXMOMtTLLX6SIQzE6PB9NjpKrRwUvGOEaUPjFLfLhObg1MzxAQBIseMUmlHH+V+PGebG63VO36ttSuAg5UZDWZN7snzSVxgMHCJANtFBCC+G3XwmHbWVRHxCsmP8mV+P2LBZvWSiVVkKWcNGJBtFClkbLJOBelBBaucKrSu6LLm925dL+QsvdJaFzjURqy8awz3diPF3FdGDjmCdBTQMG4YKi2lgr6eoywZnKVn8C4uJbylXKi1BUnsYPrNcADyddHpSO5uIPF3AaBlqV6Uh0RPnda0ecvRYsyoJTdTEqAMfbWOJ/HrxUc8nrHX+b/mF+9L85ixVUfGiuwLFB6Ab6sois97tW4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 02:07:58PM +0000, Ryan Roberts wrote: > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index e255a36380dc..e4b1946b261f 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -317,10 +317,8 @@ static inline void __set_pte_nosync(pte_t *ptep, pte_t pte) > WRITE_ONCE(*ptep, pte); > } > > -static inline void __set_pte(pte_t *ptep, pte_t pte) > +static inline void __set_pte_complete(pte_t pte) > { > - __set_pte_nosync(ptep, pte); > - > /* > * Only if the new pte is valid and kernel, otherwise TLB maintenance > * or update_mmu_cache() have the necessary barriers. Unrelated to this patch but I just realised that this comment is stale, we no longer do anything in update_mmu_cache() since commit 120798d2e7d1 ("arm64: mm: remove dsb from update_mmu_cache"). If you respin, please remove the update_mmu_cache() part as well. Thanks. -- Catalin