From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3729BC021B2 for ; Sat, 22 Feb 2025 06:34:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 783216B007B; Sat, 22 Feb 2025 01:34:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 733C46B0083; Sat, 22 Feb 2025 01:34:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FA5C6B0085; Sat, 22 Feb 2025 01:34:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 40E666B007B for ; Sat, 22 Feb 2025 01:34:27 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C14CBC078B for ; Sat, 22 Feb 2025 06:34:26 +0000 (UTC) X-FDA: 83146616532.13.1E43CE6 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf04.hostedemail.com (Postfix) with ESMTP id 1C11440002 for ; Sat, 22 Feb 2025 06:34:23 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=lWVdYTKu; spf=pass (imf04.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740206065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cP8dZ8a5inH0cvrY/8bl+epQJ00yB6YFykqQ0v13Kcc=; b=LuRMQlTZ0mmMLHIXi/90qxQvuxP88CniwQpHwgRr5u4+S+N70RM/F9EmlG3cKKAFQcxdHY uwSA3lR3siC31xGCXOejoeiNVYUeSh2qLTfDszisdsZBiCm0Jv9A6/koG8F5li0Y8NXokd vwlBq1X733467J0O8tDO3z+ZYbrhwiA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=lWVdYTKu; spf=pass (imf04.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740206065; a=rsa-sha256; cv=none; b=jrgTTucok4binY+iHQ4UY7wYFPoOFP2u+Gc9EgzK5YYdXOeSQ+ZAf++fhdB43BvOXFXsKp Iv6GwhyEwVkaDpTLkfcsuQRrFAJWIU0JCxyRenJN0/FHTbwtniTpwMxnYN4h4+WN9hZTjS VE3/os5GE7byRzrIoZpWUywZ3Mt1ZTQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cP8dZ8a5inH0cvrY/8bl+epQJ00yB6YFykqQ0v13Kcc=; b=lWVdYTKuLzQRnBVboT8tXq9Vow 6eTAiryEHkGoLKOXCxPbTDeGoCZ6JDAbmPN0kPz33P8vhxOuM/ya4BMUhuzrxI7sOeVhG9b7igoVH UVsnR5i3gqSwx+BPn92irFcA64wla50twjUYBKt9rNcaQvIgLS8Y12xj/Hi5F6xFcHLJfD5vD743y ezZfUzGag4bAjc3aCm3WA3QH5qnrPWN6emwNdpO6HsIpNdtkGwDLI87iT0J7JIQEs2/WRU/W4/WFH B7CdBHwkDnTIufwzVmlEOudzqtqvVV5dvUACCdjeEYOxLbBHvVs03yYIoXiIfkSOSPi3WMi7ybU3w LTkND8ZQ==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1tlj5c-000nn7-2l; Sat, 22 Feb 2025 14:34:17 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sat, 22 Feb 2025 14:34:16 +0800 Date: Sat, 22 Feb 2025 14:34:16 +0800 From: Herbert Xu To: Barry Song <21cnbao@gmail.com> Cc: Yosry Ahmed , Minchan Kim , Sergey Senozhatsky , "Sridhar, Kanchana P" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" Subject: Re: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 1C11440002 X-Stat-Signature: jboudwybz4yxatx5ew44sqeneiur5pe9 X-Rspamd-Server: rspam03 X-HE-Tag: 1740206063-71532 X-HE-Meta: U2FsdGVkX19/dLyQV15XUpyjQp7GxeBupPOMmOEGvPcfclcnC4jyFeD7hD+LcW8CoAA7A1XXTW2ZXI7UooUmHN1zbzKr6xQktjazyHiMAKF3YhW8A8/P3cS2J4wt1w3SU6yzYZiVTW5LZFMrqzNFesIasaFd9rA/xJn9T2Tw/wuoQrbUWWIZpiVvmU4MlTn5ipPzqO2/tZYXkeLrY8VjbtKyMztiajiuRWIq3Hlee92f9Xp6ZSR/NnF0rkWfz4ETl2UBvMt1T/bKQGgxU9KdTcezjRbOSTJ2xunYtawP7aqvamaNxO6mjweAocESuYIHR4ey0lbuB31rRoPF4OediSZLaofB3qsJ0q60r8yy7HvCRJdxgBL+dDcmqzan6sj0snRoXmPhGYud8l/e5BVLb9gxaJROqWdXgYcBF9UOilJ4JsAXPOHSnJHSX8dRezVNpYSDxB0HmIuYc62ShWzzqOlRz/wEPeZzRAxdA6MPpfZLM9N3lbZd5uJpyJGQwafT8WRe77wtOMCwz8Lo5KUeDYxmi1s9iPWWIF+suvFl+8g1WhcS8i2V0g4ABsB9yb16uvq6/19ElfE4qV5LX23+nz4FUV90vtQLJ/ng+3fKNG720Ca2OOjsxFzZABwPZiy+JjCk0K1UW7GSZKU65e2vc05WhBS4fyFgJ2+tbwKPbqlnWmdAyjUCNPTPSfYfC8moO4ryk2V3bUSIpVUpz1u/a724pvcuZ9MEVlmPDKxsmM7ov3YhFn6nUf84IR3uSExRkAoEuDFg9Qofsp24gv2iWn8+q6SBh40Rs2PgiATHFv/hT4tqMv1MYe8J9OKb2AYGsLvP9EqP3N5vtMrrXUY9XyQusE/nZUK0es6Hz2jZqQlABMg3Jj3dZcfZSxVM0EIVCfzf+58GJycjVmFmZDyDWBqrdDdOZq2AGGtOGrhaeesz1NmwbJdHWUiSidT4HL632KmiY38p8Kcw+RHJuVf 6UuuJHjT hWCtdMuR7eJE1GsLXWrGrsrsvC1sYIPGbWRyrNssEs/LEZsKM4YP/bZGp0kc4SKufl5WmO4Tc025UOluhB7MwkJXXDmAnyLHCGZswccnEtwaFSPyrU6MkNVuWUX2Lr7jCrwNDgeOi8FA5VgI7VsQfHfdSRKzNHGJ2xCJFh8tvcIBoGCEMkq/a4sRzmi6VHGbB63XwfhhnnGhV4mw//rf4LyLHlXrSzadIHHCINKu74kqSZHdWauCqO8PEhTu9VzIJ6DBLXJJ6CGS9XtQVKtAObiqmBALlxYiYmMRqn8wZhTGTXY4DIP9N+dutEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 22, 2025 at 07:26:43PM +1300, Barry Song wrote: > > After reviewing the zRAM code, I don't see why zram_write_page() needs > to rely on > comp_len to call write_incompressible_page(). > > zram_write_page() > { > ret = zcomp_compress(zram->comps[ZRAM_PRIMARY_COMP], zstrm, > mem, &comp_len); > kunmap_local(mem); > > if (unlikely(ret)) { > zcomp_stream_put(zstrm); > pr_err("Compression failed! err=%d\n", ret); > return ret; > } > > if (comp_len >= huge_class_size) { > zcomp_stream_put(zstrm); > return write_incompressible_page(zram, page, index); > } > } Surely any compression error should just be treated as an incompressible page? I mean we might wish to report unusual errors in case the admin or developer can do something about it, but for the system as a whole it should still continue as if the page was simply incompressible. > As long as crypto drivers consistently return -ENOSP or a specific error > code for dst_buf overflow, we should be able to eliminate the > 2*PAGE_SIZE buffer. Yes we could certainly do that. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt