From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C066DC021B2 for ; Sat, 22 Feb 2025 03:45:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A58F6B007B; Fri, 21 Feb 2025 22:45:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 355746B0082; Fri, 21 Feb 2025 22:45:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 243BA6B0083; Fri, 21 Feb 2025 22:45:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 07BA76B007B for ; Fri, 21 Feb 2025 22:45:58 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ABB62A1683 for ; Sat, 22 Feb 2025 03:45:57 +0000 (UTC) X-FDA: 83146191954.16.84BC46F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 39CBB4000C for ; Sat, 22 Feb 2025 03:45:53 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=k+X+VAFn; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740195956; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EJqk0UQEhOZmXQKWkQUinNzoojW8Gzj2QfhEYNkICwA=; b=6XBUjGvaIYBp6BrR7TW2NIAs8WSLNA3RMg/cR7UVp5lRv/DTnh2vEsa3RoHtdi6SWZ5rY0 /LJrLZEim/twnEFLCULHz6XSVvtYrVvXvb5NRINe4jclMEyb+C0ZVlMQTigWS/zCpMjDgU jCE8Q48wJ2x+5SOXTbuONAiHAlTetWk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=k+X+VAFn; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740195956; a=rsa-sha256; cv=none; b=OQHHI3lAO+ehWXE1tX9cFu5NwkI4YgJGdj+F9+2J+v1zqWmCnHI3OUJK0HwcF9UOffnO9R zeNvM4HqPSDAbDmoOs/L9GPTe+pGxT1mOQuprWKV+n3XyTBQvAY8wdw64JxyQxVUatzxc9 1wE8vOnfxAjucp8uqON11wJHLY/8i1Q= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EJqk0UQEhOZmXQKWkQUinNzoojW8Gzj2QfhEYNkICwA=; b=k+X+VAFnxQOr0Dvvy2QBtrlVhO DOkRSMw5NY23oSC5K+vYxLI2GhMd14KYTbprSqRI18zLq4XaERGG0ivu+7SMQMygYuOZPmvblEoGz Ctk+Gcn9Lh++OlAc4p8jd0EneFuE9Vtt8XbUkbe2L2hDKHguJRtci8ng7Rc3z5VlBgr1/a4oar8Ah ol9MsZbX/Un2NQH8aFf3xAQrcz+7nt7ZYg+irm2AvAK1CILqKJl6aqiu7Pgf9vC+gemCV0ItdwP+2 c3uI/i/ihndayKujuNbP6yejazIpakkTv2U3nIMG706fBFbzxYJc2RRpzDV3JhM8zS7NWV7A/vNk7 eKsgR+Ow==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tlgSR-0000000G93v-126g; Sat, 22 Feb 2025 03:45:39 +0000 Date: Sat, 22 Feb 2025 03:45:39 +0000 From: Matthew Wilcox To: Wupeng Ma Cc: akpm@linux-foundation.org, david@redhat.com, kasong@tencent.com, ryan.roberts@arm.com, chrisl@kernel.org, huang.ying.caritas@gmail.com, schatzberg.dan@gmail.com, baohua@kernel.org, hanchuanhua@oppo.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: swap: Avoid infinite loop if no valid swap entry found during do_swap_page Message-ID: References: <20250222024617.2790609-1-mawupeng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250222024617.2790609-1-mawupeng1@huawei.com> X-Rspam-User: X-Stat-Signature: nwu6udu438b48xg6wpnknacmuuxhwcyc X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 39CBB4000C X-HE-Tag: 1740195953-634872 X-HE-Meta: U2FsdGVkX195j972sLYHiVRr9hP5UVs4xxQMDs5F1y9YIZMLxLVgvbUC7gOq7CcBbxsOVAYxQpYBBavTpnKU3/YVlKNAEXApc5HOl/hmpHFNzO452GqnFR/6rGKYyuE8n1e0IQSxcS1z6C94MBHUKljqIvhOFYx8q5dfMw+2O0nTUJTqrC6ZnrFUBkNBPgbiOWhvxiVAU+gTAJN0ZAWDJl/HnyvKc8rmwpCOc25sPZPOely0z3QZbyn7u5422r0DCBrHw0O8B+JIAm2ZUq4oBLOOAnbLQzEnx1iQ3D9TqS5JJ5U6ubkvAN26qsqLd6acbN9WsVtya4QJrOBNhWSphDiJ8LRxBeAXSogeY1LqJPI7lLVa1Fw15oFqP4f4LxPooehwale0PF7IGAJJ6kdL88CsPR8Oz2ap0S0uQlWUB8B2+LnWlj2u5Y8RkR1Kd3psGWoCBMjpN7vGP59vgUhGlbYmJJKyceAZOi8DLDI1XPdIuE9YqwAiP2PnAt/u6oLhZO8R2HeaYLPMB9D8kVKgibHoE1yr1unNVjl3ZaDHTZ5GLye0mS9HljOWuXjwvGe6m4nKKiYlgN6SDuvvC/UMs3Ytspcssx+buS7gc8cCO5ufZND/uofd9z0FPgEbBqbf24C4W40kzENSX6aiLSyr5klnuGUaFTI0yKmXBeAd7ZhLDxYsVuqW6htYoHWSZbYm/2WU4qLgDBEjDD+hzFP5Fiik8DK/STnCU5EQrKxPpLZN0uX7O20bNqQWw7F1relFzlF345gZS2IZAZO04TmUw69NDuv2/9ctmjZmRZ2+wLxK5uxkK4ITRNAkAXLVeSzfzBmf5ZoWfiBuiMkxg10mgdApu+x3k0e+lGZlshpxyUPitBEY1XjmzSsT5Ecgv4/ATKGR+zFLs9zh+WOg848XFbq0ykYfmz8FXVEI0hzAUiBCAHTrC6GtNEBpVzJlEQ/fle83dlZTEfWhf9hUyz2 N8SuvR22 3rZV9TKuN6yQ806jvoNLq8ibS8cm/un/hVquxU7F87UHu6J5XAqkfq6kEt0XnrZcmec1zvHiWIk7Y3c9ro4HfvwQ6mi5TkIu8eCfbzMZ+ovMfm6jmPLz/bTvvxfoGrnphrFbbklvBToK7CtClkspwh2Ovp2x7EBk7c/+spyw8n1VKqG6zLH1C7di2SsOIOXFdmDnPJLFu9kBJtaV2+tbWZdNS1L6/7QA+I+QZTO5lUMEqRnUDUwAmPRIBQnMOhjRgd9gW7M7Bq9ySlXstI0PIz/8yMHqK0It0fr6oV/3hfMfm2e7KE0WoKeMUsMuOjSWORIZQoeXCT0nb/qBIatOcfN+NTwTC4H0CcPAc X-Bogosity: Ham, tests=bogofilter, spamicity=0.173613, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 22, 2025 at 10:46:17AM +0800, Wupeng Ma wrote: > Digging into the source, we found that the swap entry is invalid due to > unknown reason, and this lead to invalid swap_info_struct. Excessive log > printing can fill up the prioritized log space, leading to the purging of > originally valid logs and hindering problem troubleshooting. To make this > more robust, kill this task. this seems like a very bad way to fix this problem