From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A22A5C021B2 for ; Sat, 22 Feb 2025 07:22:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31CBB6B0083; Sat, 22 Feb 2025 02:22:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CCDE6B0088; Sat, 22 Feb 2025 02:22:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 147126B008A; Sat, 22 Feb 2025 02:22:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E9B8F6B0083 for ; Sat, 22 Feb 2025 02:22:58 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8964B140905 for ; Sat, 22 Feb 2025 07:22:58 +0000 (UTC) X-FDA: 83146738836.12.62539DC Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf26.hostedemail.com (Postfix) with ESMTP id 553A7140003 for ; Sat, 22 Feb 2025 07:22:55 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=YN+ZeC6I; spf=pass (imf26.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740208977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I/4UvPoi6I0ViXmTPRlmADW8zPALMISxjuds0SuIec8=; b=sDTCOYWbmywxuNYmoGxlTSJEX3MvdXPIuWpcP9ldjv0n5LmBAzgqwA2bTNm2hwVQinAsin OF+rYd+duI6fXYV7yqtRvC4zfcHmkPdbnx6POis+4FO6qK439XC4UzInbWPpEWPDMebiYM tV5IAi+n+e0aR1bBwAb0MV2TXmCYbVI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=YN+ZeC6I; spf=pass (imf26.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740208977; a=rsa-sha256; cv=none; b=hR/HMgByYoNaxB1K/xkrO8O4OnXCg9koIhLlwphotaWCsPsMxEMt7PPozzIOS0+kGB/Q4N p97sovlRX4SG2y4+J45YQ3oKcNHYuLVxQkIo71Z8AbDfQgI26yhClQNpZyXU8uys0oxvd9 OxgF4w/wcTbRcYhJV63Mkz5tKpwB5VQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=I/4UvPoi6I0ViXmTPRlmADW8zPALMISxjuds0SuIec8=; b=YN+ZeC6IPKT9Xdiy3YssrGh0s0 UneqlVSOITrVq7w8oV+qqaVRx9w+WtaWkWB1zihcEzsBwl4x6hJCZcfNVs+Gc4N2aOnBPKiRyfbGz wiVYHvYEuqeObFeh0EZ2ls4IGLggBl5JanJIRnDEfGBwj3sfpZawyrsBEqTkJ5wQLKfyJ1rCY+Ja9 1wwzafEGEOf2k4jQxpL1dUJfyEsrrQ1jF0IBw74uFB9QqKsDhzUPynBoenMne1l1eStp58VSKs9tz 4AUxtuPFuLMcYSQ9OKlqNT1YPufV1JLlRoE0v+xAyo6nM6dfaIz2QgjFKoFR5VJb3G3axJZcck0Sy SWPni4Gg==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1tljqa-000o9k-0r; Sat, 22 Feb 2025 15:22:49 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sat, 22 Feb 2025 15:22:48 +0800 Date: Sat, 22 Feb 2025 15:22:48 +0800 From: Herbert Xu To: Barry Song <21cnbao@gmail.com> Cc: Yosry Ahmed , Minchan Kim , Sergey Senozhatsky , "Sridhar, Kanchana P" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" Subject: Re: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 553A7140003 X-Stat-Signature: rzgrsye4eh6jgz3cgm9gafidgsfqmsjh X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740208975-225976 X-HE-Meta: U2FsdGVkX1+B8+PlQxuRiF+Crist4RKnbKda+smDYCnKZK3J75k0Y3UrBlIcSHcQSj7FdbKk2T4ZpktzfSv4DzLkCJYltI84NR/3gs0lOwOaVAJgHfoVt2E7eHpUVENgPN4V3a/WwDn7b7PXbeckOvcWkv/mNEXsV52DniluZqyL46I65YTCfI3CSFcMXNKYGlw/zda2lwRUdU5epXCEi+78aQG57KAOdF9QDGzTv8tjEWS80dp6UIiOegSrCbv+yWEP6odcE1IjcgtmMBtRdOl/H81tdxazg4rPG+iy6+mQwjeFyHI+7Bl1/GbHNj4Q2bWdRO9eBzDCwzW/JLu5Koo7tmrb+Q2hTVrOTB1u7GaWgKNwp8ek4rPTQ9qgJZiA4msPHDGv4KZhn0MbF3lzWTaVewCtsJUgeWqiafxzUxGB07krgfnWY/c8b5N/4IZmnTGXpBC8UhXygz3Y4FfxbVfh50stnOHAlerlCCMjVc0ewr2btQxJF6ThFgckS9/vCOxnZWcZ3O9EYJ1EdO0HnEGs54Mjvgu74cDcLrtVFjau5icu9dw9F3JXJc8VklrPQDEkDyxHjOjwRmAq60X+cYs7SxJZuP/6b1+YficybmFwTNRFf+DHWOO5kyMLhmrLboNBmvLXM6+uEo4qVC5Ob1Y4wqwZuv5cUcQPam0npGGlZmFVx7fCAcZcxH0+SVdo0E8rLl4LPONJMuCiWp6n1Supy2rs8l1xMOxcQjmxk89G2TYKa3PyOuBzNBtw2AC2So0ewrPfql5hMpogtDGHBJoM+8bLKQ5czryEPPWl0scIRDJfk2kiO0tSF7Bazt5ogNsmvbH6OySFrnSuhhL+h9i78EX+0aOqyXEGYV/I3ci5b2ruz507tMg+6Gq2+Lkz8Ttf27JdTZRu5xjjBEOOpRmBXMlDfXHL8R6axGKOQ15B62M8ydfWm2UcrM+W1ZxBHgzdk6PJhpiW7feRIut Wrz7cFAI YcpIJiZfc5cm1yqUjwQ9gGlVNVkJfEGkG+JP2LLRB/bVlXelXHQqBe2HHW3IhG7jHQtzpk7cacSYmOTSf2mdPHR72+EI2+Ex6eej7C2yyRneB2VoXhVF6yC+vojacoc81QzYw+OcgxIEIWjgNuaLn0u1/OqOtiHI80DnjqQw2FmNKktwDiXU2Gd1QOjF7p63crLNh8bC7rrhqCIBLxqz54S497PkVkeO6BQGLc/6NBaPSr6XS5gDiMNYbqwNOG8v17I5hN0JpYmw//dimIckULemR/K4ab5dw3k7GNem3MW42O7Pb9vAacthgyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 22, 2025 at 08:13:13PM +1300, Barry Song wrote: > > Somehow, I find your comment reasonable. Another point I want > to mention is the semantic difference. For example, in a system > with only one algorithm, a dst_buf overflow still means a successful > swap-out. However, other errors actually indicate an I/O failure. > In such cases, vmscan.c will log the relevant error in pageout() to > notify the user. I'm talking specifically about the error from the Crypto API, not any other error. So if you werer using some sort of an offload device to do the compression, that could indeed fail due to an IO error (perhaps the PCI bus is on fire :) But because that's reported through the Crypto API, it should not be treated any differently than an incompressible page, except for reporting purposes. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt