From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39BEEC021B3 for ; Sat, 22 Feb 2025 00:49:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 616FF280004; Fri, 21 Feb 2025 19:49:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D101280003; Fri, 21 Feb 2025 19:49:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48E39280004; Fri, 21 Feb 2025 19:49:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2B4E4280003 for ; Fri, 21 Feb 2025 19:49:02 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BE3D8C0CFD for ; Sat, 22 Feb 2025 00:49:01 +0000 (UTC) X-FDA: 83145746082.15.2F710C7 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf25.hostedemail.com (Postfix) with ESMTP id D8A27A000C for ; Sat, 22 Feb 2025 00:48:59 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EKpE9QCu; spf=pass (imf25.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740185340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p4Zst46Y7pj1nzoh7gV1XNEH5xnb01/ZQglbBvg9mw0=; b=cVd91NVx0G8m5c69KQDcfrPnoYdf8tJp8m2yTs+KZDemOybyKvsQONk7bG9EcSstTShiTr /CycCnLMJQcy69YfAjAuo3IBu2bnCbi+uwwe7b9aJdg7/hATMHni/YeRSnmiNMazUUhO8y xuvlp4+yWqQ/qFqigd+6eTLrvG1Mm3M= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EKpE9QCu; spf=pass (imf25.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740185340; a=rsa-sha256; cv=none; b=wK5kVf95wgAR33GUZWyYk0WW9ISvgMnzdFtDvfIKLieP9JY0cuGeCGu3zHucJeUdCfdVyo Q+OyzPqkVWCZnLS4A3gZ3WI1KdEmryw2BBUm725sjqrCTonfHD0Y4LiZ9PfwwDMFEUEg6v J2shNDe9tAQWlBuTJGBM1C0ftdhXnpw= Date: Sat, 22 Feb 2025 00:48:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740185337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p4Zst46Y7pj1nzoh7gV1XNEH5xnb01/ZQglbBvg9mw0=; b=EKpE9QCuth3FK6o61yyUqeyKAPhA00/7ADQUR9v8193RzSpKlzdjxgWPUfacvo7zElF8oM nvUPPeCgOoacI43Lg9vpl+g0kSx8+zijAmxLgqDfsctdKKhS3z8oA5xcDKTiJfvJ4uTXQt kYpMMq4H4+5bItmteexJDETFIJnrOS0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Ira Weiny Cc: syzbot , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, chengming.zhou@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [mm?] kernel BUG in sg_init_one Message-ID: References: <20240318204212.36505-1-21cnbao@gmail.com> <0000000000009221d60613f58726@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: dd3poq7jxb8yufrq1qm19k9g9tx77zow X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D8A27A000C X-HE-Tag: 1740185339-61437 X-HE-Meta: U2FsdGVkX18+nNmTQ8fRyw7zgLoLizJ0+l3qrk7jk6VmRhIcPkAtQ1UNdT6QjYzhCMXemzvIdxn/1D/OnjyIokLArz5jWFmcBF/2mPb3bkGWjOweEH06E+hlRAVxG/BGvFHtPXHgdzEbrqhGySldHiyiYzdeQUOHVm3WFF1yzTj78FEQN2oz4xd7/R/K9AKDUTsZI9t6v0Epk2WrmeibfGl9A8N6xkrUR5/8lD0lxenLuRbE67Uq60IZNBIYKV+o4vm8UCxuxaethP3H0aCKnj+pRoHCeqZEty51APH3zy8hWg7Y6AOZKsWYKsA7ie44PonOd9dtX8rgLeCVPmrXJ62OY8/qMUiDQ3djQtCj5PtqMTJh8cXiqLY4Gb4gMVJ8MseMqjy3hIw718h59MagiVE8PAoXrasFi5qxXvF/Xda3vvuFjxnNFuU7MaBSM6Eg6dUeEL/dDmbRu3uGlp3KpBTvH1/VrVOrJYIDXLepd+hgTM4vLTHo90f1zP2CJV78WFxPRtME3REr5EPqpEFKs27VnJ5CwJg3Di8HtB97ZSyFw/V9IFlcwhWSEcLht4+kxD29zYfyQVRJhNsQXvZD4GWduxb0icRBz2M8tcJm4LFDdpYye0jAUC3A29hxjeBMfgywfpJaW8zZmE+AuNJWjfwBSabwOUshLV/o3vZ9/DDLIYfe7xeGcaQxpFEfyWNljDT+Bz8Ein8no2/jM0XR6YVfVGMo9G/xUCPnm8HaUwWjW+Fx+0I1JYr7teHZ2W8ghVqQPymU4gkRsdygwsdYT6NYtQ7nSsdNtnnVCUAd/r5dl1ashIL96WUrUzruUwyGWt1EsGDlRRpVAXfjcz3Hsh8NSWZOEbd8Wf2+qPwLtC6wwvfaR0KLtM7VUdn1MGT0lXDHPQFv5v9GqJ6fi+JzfvNQK+vr+IQaNg/SAxD5GEKnr02YY/MhWgylYZlqMyx9+S48mIj9GntIho5rO74 FysiDyi5 axAT8OT/NjHaeeVQK6m8FDNAoYa6VZYOkIidiXZmukPdpd9km+pEObVFvYW9KNda0AP47z5onGW4E9d3SVvyIS+H6ngGXpHfI5ILflQhJEbt9ZOtiIvLnBCXh/a5FhvvTqzUa0owcoGxGz8ejbRXqJGuniwLlTV6sUl4VC/sqR0+7TcCR5ml7oK6CEJ4X/dB+BG76mlaeVY8laEdvkAjvNyvdvsuaB0c87FxJ89tZSyjgIaCg3haK0vra27YhshOgreofcHuvBMjEV2k6/bJoTn4cjotcaURDJht+J+DRPZlCLZDIcLWsePH4KXCPd7OBbPOHrvNb/lUaDJjuGrQmrOHf5vSoBRVjVj4HhMzS4JbYeHpTHsfPTfmlsSEQfcyhtdahRDtz+JKuBituR39Nt1yTrVjfvYnp7jU7Hl7DhTm+j6QsqwWjWJr/pf7PrzQAhiTiUvFOclezk23WWymO21fMluYcr5+g04CKBXhhXy+ybRMfGpCCZUaPaeWPW2UlTgx6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 12, 2025 at 09:20:24AM -0800, Yosry Ahmed wrote: > On Mon, Mar 18, 2024 at 2:03 PM Barry Song <21cnbao@gmail.com> wrote: > > > > On Tue, Mar 19, 2024 at 9:52 AM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot has tested the proposed patch but the reproducer is still triggering an issue: > > > WARNING in __kmap_to_page > > > > > > ------------[ cut here ]------------ > > > WARNING: CPU: 0 PID: 3529 at mm/highmem.c:167 __kmap_to_page+0x100/0x194 mm/highmem.c:167 > > > Modules linked in: > > > > + Ira > > > > Hi Ira, > > > > I noticed this warning is coming from commit ef6e06b2ef87077. > > > > you have a commit message like > > " Because it is intended to remove kmap_to_page() add a warn on once to > > the kmap checks to flag potential issues early. > > " > > > > Do we have a replacement for kmap_to_page()? The background is that we > > want to pass a highmem buffer to sg_set_page() but we only know its virt > > address. > > I am reviving this thread because new zsmalloc changes will make > mappings sleepable, which will allow zswap to drop the memcpy() in > zswap_decompress() -- except for the !virt_addr_valid() case. We can > get rid of that too if we can use kmap_tp_page() in the scatterlist > code. > > Ira, could you please answer Barry's question above about > kmap_to_page()? It has been a year and kmap_to_page() is still around. (Trying again with Ira as the main recepient just in case) Ira, could you please help us out here? :) > > Thanks.