From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A67F8C021B3 for ; Fri, 21 Feb 2025 20:39:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49847280001; Fri, 21 Feb 2025 15:39:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 421E76B008A; Fri, 21 Feb 2025 15:39:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C299280001; Fri, 21 Feb 2025 15:39:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0A9AB6B0088 for ; Fri, 21 Feb 2025 15:39:31 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B6F4C1204DD for ; Fri, 21 Feb 2025 20:39:30 +0000 (UTC) X-FDA: 83145117300.17.217F15E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id C892012000A for ; Fri, 21 Feb 2025 20:39:28 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EJB+txSt; spf=pass (imf29.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740170368; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J8ttIxXPLu9/x4UigVuneN+rylgkqndOD8Ja24MC+zU=; b=aE6pt9dUSUGAod1a+V0FGh6B20mFjaHum8QKBVDCaEeNzf0FvhkINeSwzYADfybw2YlIAH /zrfqKmMSWoWvlF1t4JkjjQF1g19RljGjWJ2raN6sgBE0WfDrAvPoSk6i/Qc7OVmm+oxY3 OovE0ILcpLtAvLNZ28RNQLy0IA121NY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740170368; a=rsa-sha256; cv=none; b=6IzXysQz1KcDB4KjdnstZu/SEqnc20W+IcqTckDp+Vxn3tcfIkDo+v+rfmCDZgUOwYduzW Cfxb65rOYKGQOiGuAIuFdfj1jkFWlybyUbohC5odAhCt0wm5CvKReYbqsQqPEMj/zkovIy cNlzXrzkk6dBzd/oiADIIVyaMeLEQj4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EJB+txSt; spf=pass (imf29.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F10B75C4A22; Fri, 21 Feb 2025 20:38:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48A91C4CED6; Fri, 21 Feb 2025 20:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740170367; bh=AaAq8ScKNC8Uf0VCPH0436/Qy7v9E5DOBbn/7rwwYEI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EJB+txStwZOOPjF/n00d8dhU+GyXoQAD+7dp35olNNHVeOnt47wVzTVoQuMXbJ2YN 00atFNwAuUKOGCTVvn6UOerfW/7aur8/rUOCERu0bIVPHI/1a140Nx34b2tkiZAji4 +vFwSP/8MnQPR4BpA84R4f9IRfFwWR6vRxtDyTk20GEzTuGQzTMqB3M94A0wbcA5/D nLLGMYX5K00ZVzNiZjLCbcwj1QZEDMNV2rEH/ZK4GQeQE/CBsQZ5JRNc31Dr9FAFCs xo+/DYO8Y5IEBXql++0SaRztis/tJgsKAc1iJ0c1D4cuNhE/pk8x6i2F4Iz+U/EP7g zoWsASugxLc3w== Date: Fri, 21 Feb 2025 12:39:24 -0800 From: Luis Chamberlain To: Matthew Wilcox Cc: Hannes Reinecke , dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org, john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v2 4/8] fs/mpage: use blocks_per_folio instead of blocks_per_page Message-ID: References: <20250204231209.429356-1-mcgrof@kernel.org> <20250204231209.429356-5-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: C892012000A X-Rspamd-Server: rspam07 X-Stat-Signature: gsmbxqjxhwdn5pbqoug5kjdifu1pt596 X-HE-Tag: 1740170368-571525 X-HE-Meta: U2FsdGVkX1+YFrpKQRBT6I9FfRqAUTMTUe+OGo48u/8tYnZzE1XMS9H8Hi8omtmZA8aH0LA/AhAMK+LYiuUvIcG4WjUtU1xHYLyLnRbXKa2i/o/1o7sQNgEiA3SHgjls2H5+pv50WFZxEJNlrE2dfNUAFgAxCO5xndNH+n1B/g/FGaRT6h1x0f7RoqyExi+umoXr/fJrtGeZ/X97nkmxoDoaA2TjQsZe00r/GM62SbUlfnj83cKp9Aps+PLcwgmV12872M6Cxfj+fe3b50grrkCQPcIkaReX3VLGJPoX5TqQqinSrb1JmsSZJVXbMAg9as4Os8GYtrRz3SLGHiUDTVAj6o2z0WW8OyxxXWhldZjU6zcJbDpMMoPebg81h+aSRKEsx6WYsNqqKfzwhelPZMSYchLOGfFFkPdl3qiiSOefTbIjnUdqWR2U2ZvqpeQHuLl3dT7NjniLC7owW0NbASxrtxblzpUvwagxdL05mCI0igCAtAB7sxozXxoDeaHaZYUgENiqaG/5Ad+3WjLYYrugW5h7s39YatmTqiqMcPTgPgiJQrFEyAYF7PXN+dz0B0J7Mg/vS/VmGAtxQFBp6jtqCEf0ewjdx80UoY2ON7wh35MiA11XN7Z2+WC4sIVArzToUIQBrcqy7ooPvx94vEYZF3fpBs12tRekbare+ezCV9nuKb85uG3UQD6urvCNqoCzmMidaxnbdzsHg379QEzygCbAYpCqT/CGknFnweRuCndDcLhXReFyTUjpE/c2ajWkoWQyM0M+VUPkIfQfbnN2I9eYlLV8jwTYaab6WcRQxHU1096WmkpTndJOMYmUnd6HkURMO8wEaS0/5pIhj0iTAyKt30JcbB6WDkHc7YatpkIueob1WY5rZZZcghrJZqq4YWAYZyU2ts/XLfS3AL8egrtOD1zcWHKqjv7H2a/l9+eXytHdx0/b3/VhmOSJr16ky1yQ56rVXbC2N39 Z37lTlBk IPCBW3fIKQBB68XTLhsm0MIx6VN+sZABoe0VrqKpdUy19DgEF31KomEPoZaPjICnrdvZSiff2cTYId02dHrFH+9eAnG5Wfl44MCXzukkDUvPhAVha0EsvZRunI1kJ1jC+ro4jF7SgvM0MlhsR9MKo81ysyA5UwsYfg4Pg/JUn0oI2sRrEqBVb3H/PE63Bf4NElEgu/9UDvjGZ3nb9IAcw1nPveRlVhg4HBYlskQKnK2Qmi1/2NoQ4fV3szp8QVgfkLTlCIWpyzjhstyvinMlkFRPiAaVAqlZhJJ60ZBwI2T0UbTgJQLib8PqRux7AfoL8KLHEtzNPeM0ZMT8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 21, 2025 at 08:27:17PM +0000, Matthew Wilcox wrote: > On Fri, Feb 21, 2025 at 10:58:58AM -0800, Luis Chamberlain wrote: > > +++ b/fs/mpage.c > > @@ -152,6 +152,7 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args) > > { > > struct folio *folio = args->folio; > > struct inode *inode = folio->mapping->host; > > + const unsigned min_nrpages = mapping_min_folio_nrpages(folio->mapping); > > const unsigned blkbits = inode->i_blkbits; > > const unsigned blocks_per_folio = folio_size(folio) >> blkbits; > > const unsigned blocksize = 1 << blkbits; > > @@ -172,6 +173,8 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args) > > > > /* MAX_BUF_PER_PAGE, for example */ > > VM_BUG_ON_FOLIO(folio_test_large(folio), folio); > > + VM_BUG_ON_FOLIO(args->nr_pages < min_nrpages, folio); > > + VM_BUG_ON_FOLIO(!IS_ALIGNED(args->nr_pages, min_nrpages), folio); > > > > if (args->is_readahead) { > > opf |= REQ_RAHEAD; > > Also, I don't think these assertions add any value; we already assert > these things are true in other places. Sure, it may not have been clear to others but that doesn't mean we need to be explicit about that in code, the commit log can justify this alone. Will remove. Luis