From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A52E2C021B3 for ; Fri, 21 Feb 2025 20:38:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2342280004; Fri, 21 Feb 2025 15:38:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CABDF280001; Fri, 21 Feb 2025 15:38:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4CFF280004; Fri, 21 Feb 2025 15:38:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8BF40280001 for ; Fri, 21 Feb 2025 15:38:21 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 059021A04FE for ; Fri, 21 Feb 2025 20:38:21 +0000 (UTC) X-FDA: 83145114402.11.082F455 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 4F453180020 for ; Fri, 21 Feb 2025 20:38:19 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gQqKRZ3S; spf=pass (imf16.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740170299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SZZMwv6ijurKANpuL+ZPv9ZfiHuliG1ddVjJ9nNSpf0=; b=0HR8o3sd9vUvpPu97/aMqyargYk5IkvgEeKPHSuLyR+xZgdBsrkmQ1egBYxFS61v/zMTLr 9+bzwe6cYVXPeT8rHoYlqACL6LgsHuFINYbC6vRutZ4LrCQMtrKcpONZnMz/AS/thbKcAh /hUTismKV2VBaBtjTG2y9Q8BEAIF2gw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gQqKRZ3S; spf=pass (imf16.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740170299; a=rsa-sha256; cv=none; b=zcMgFvBjQv/S3hznQ9UMTD1uuPYiw/Cu/9oLMWON6Rzsajpqe6AsSypDZ6gquoVVIvfJ0t vl2M4OyFWxBngOcupDRs1/bJTo54s/UKcKsKUdlc+eqxNO49E/DtfK5oX+oG2xfY7k6v53 YEALbS0Boq562ZmXvwWjSJ2ND8eeqFM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3E3915C4B73; Fri, 21 Feb 2025 20:37:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9229DC4CED6; Fri, 21 Feb 2025 20:38:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740170298; bh=ghbPgVthWd4oK9iygGhBjUwBaMjNiQM7DAwYcx9mSSk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gQqKRZ3SNc8/8Mj6yqwM9TY4dwiPYD6s+D6wZ3FjcQQqTE0jE621N+S9SSTr57vSq QJZddPqd2xTrtfTrrEVT2qnVjAkH2E814QQMnlOhrVtYD1c0diMlQ6ZdLNKFMZqqbj 954rL9v1PGifG0E7fQnzf76/HyFBUBbBuhDxDTOJe0OMjq/tKNZcIs2waCtNgrKn6h +LZpnsoXfaH/vOr7vQykaTY/LHkggnQwqgesV8vIeaUzPTYGheRcV9ll4pXhhWU8bt Emj5pRbtiqu4MalHZq5GZ9IGvcyAo/DKTxP+silAootvfBT2zxCGrB3A0xwUafjPwO 4afBBY69GWKyw== Date: Fri, 21 Feb 2025 12:38:15 -0800 From: Luis Chamberlain To: Matthew Wilcox Cc: Hannes Reinecke , dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org, john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v2 4/8] fs/mpage: use blocks_per_folio instead of blocks_per_page Message-ID: References: <20250204231209.429356-1-mcgrof@kernel.org> <20250204231209.429356-5-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4F453180020 X-Stat-Signature: 3xrpaf9uoqf9paiyjco4hw71tzw7yrrz X-HE-Tag: 1740170299-483543 X-HE-Meta: U2FsdGVkX1+kXT33LIkUaAeDB0iepnfqzKHgJo17Xl2WUXLcQDc1q5wFZ1rD+Zkp/uJURi0QPPu2LzegU8U6/j8izjrOVD74DZMHlWw1lH7CgPu15AtXPMjeO98RCu6JHe9SX0xpgmYFsdtCph8/fHjgGNhRQYY/ygbU+kTNiaHLVaOLKiH95LXQhISMtTb7htZNT0Kl6XzPW8U5i6NbmmjMRIgMd+J/SyFQbXpWOveEi2/qFce8ghD3U0FJhGuyJCet96LAppyEQPyAgehnsnXmKQVeYZh1mZGCloq8Ve+R6ew9PcOIm4uFROuALyJ9PFS7udu2OnOEfXrPZghmjO/gNErjEvyIuISCErc4yH4bR2WaxGq24lABDWkYGm1NZdf0fSq/zzJant/a7uVaaeTAX3bA8kR4vL/GuKgIH7NqkQAWAExzdHtAw1aNsDrODbr00LFet04oik0h43Lq27TZd3EEP3FCr96GdcZ2ZglJclUxX1vZwB94yakBmVE6pYUqa7kcIkxlSsTGAAOZLa5R39vco5lbZ2ms+zqWrBH2sHNfUXaaihtUgAXVBaGnUKofUub4yUq7ATsrHouQH7TGDmOHoo5VSYnNKGyJ+48TsLZuDeWT1lCx+0LPmSvT0mQW3qs+I0tjxAKP6yWZCeXTQnB0yN/H5EsaZsjnC5tYspLpkLZAJuf0IOefVWbeWjgJwTX+fCfSO1frbZAhmzlc9hB/ZxpgmQG9VSC9brDLKHwt82yLpGovyMEeiGhWYY+CNy/tYQnCb16OsHCsBiW3Ve8V42dzg8oosjP7wSt69a4K09/VT1K8RSFwO2NLAi9dFhNKO/skL9CqPPH/3Gmal49xWWvl7IWIWcFR1LLTPkIH7DnnrUw7zjy0TvuuZwSfJkoD0AV2AEFNGte/jQMSzxSulVY0YY9E7NISFoWwWxWEZaU67RnSsQvszc0khlI2w6bqde8gY8vysog Zza9+mhV Hm9T/OBigkAGpsRcxyGTP0ptoBEEXdQNWg3d39fxXalv2vQHrjXiZxTgvrfNaDWiEtDxlLjw0OGFolbS9QKpWhnZ6JzzeAMWYSd8cgIwy6HlYst/czVV1Q6Kpe5ime+gDGD48UnW4o5xCmhOOQ7yrS5E2bOFP3vKomdsKooVTkjR11wYQME8knz8hH9PIZ8IQpD8EqRvVC0iButxmKucIBXMuKze+AnQi5fmo2xbI5HpDY0Ey9G6ESTo4IaOXaNg1dib8nZnG75ARYlCbPMTfYmNTiVROk36qPeypFr/xRPPmd1MLYP22Z6CPCu5Du7hAi2539M8sHTvmC+o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 21, 2025 at 08:25:11PM +0000, Matthew Wilcox wrote: > On Fri, Feb 21, 2025 at 10:58:58AM -0800, Luis Chamberlain wrote: > > @@ -385,7 +388,7 @@ int mpage_read_folio(struct folio *folio, get_block_t get_block) > > { > > struct mpage_readpage_args args = { > > .folio = folio, > > - .nr_pages = 1, > > + .nr_pages = mapping_min_folio_nrpages(folio->mapping), > > .nr_pages = folio_nr_pages(folio); > > since the folio is not necessarily the minimum size. Will roll this in for tests before a new v3. Luis