From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC775C021B3 for ; Fri, 21 Feb 2025 20:27:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 500B26B0082; Fri, 21 Feb 2025 15:27:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B1436B0083; Fri, 21 Feb 2025 15:27:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 379626B0085; Fri, 21 Feb 2025 15:27:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1942B6B0082 for ; Fri, 21 Feb 2025 15:27:26 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CB4624B330 for ; Fri, 21 Feb 2025 20:27:25 +0000 (UTC) X-FDA: 83145086850.01.3A9B9DE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 35DE040010 for ; Fri, 21 Feb 2025 20:27:23 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=nTk40ATd; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740169644; a=rsa-sha256; cv=none; b=MxvsRpTJ/+V9Y38UyZqCibJdV/f9meiaOn8qtx0HTPjfto4gi2jI3TCwoZfbIOGTZBF5hs 4fEvAK6gHsGfkJvNPE3hXo+3MT/KZQ/uFB8ol/IE6/PTJF2p1zyVpZRgit9zcz9uIhsvXj EcAYxvlbaFrfq3AqfPeWoE7uJ+X8oOI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=nTk40ATd; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740169644; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lz2vU2dsUdlOV7Xg0859QGB32mS/prta9dYKuupqdpU=; b=Uae8X+6OKDBQhrQZIKUqKBk1r+oV6Xtf/zed+klVMVC4EA548vtKd30c6DXyy3IsQ6+9pD ka2OWrbD/QYBhyDIwdRBDfggXGBlDLlcVBfolcV++ql7QwBLdB/L4eQY9G/NQhULtorJKj Q9i/Itr1KFERQC2N8YU9vPfmQGDASqs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lz2vU2dsUdlOV7Xg0859QGB32mS/prta9dYKuupqdpU=; b=nTk40ATdl4bFKKJ47xSJpFqrda YnBx7ynyElatAbZVExdqFV2wIMTPwpxxMIStgQlwfSNDZ0Qzvu+N5dOrr9FxQXfVCmeVJ5hdeZGOx lmBFM3W3iNwr/PxCK0nHYVaiFVqpeH5zkLXOtjErAgASLmpkNPWNFyHFa+RYUaW9y0EFEY/pb2kVK nzU/HBXDDfua2lRcsZIUrgJ9qa1TdmbRvCD0UPKW0xUQavfZTMXBgShNmLQAg34jutsjb9nLmWCsu 6yYmX4FNuDJl78svXJfiots27qTgz0Vzee5X5I5ktXKIzNc9z14QS/24FIxjeQnXiwqSmxN43c7U5 TxbV+glQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tlZcD-0000000F2bY-3NN0; Fri, 21 Feb 2025 20:27:17 +0000 Date: Fri, 21 Feb 2025 20:27:17 +0000 From: Matthew Wilcox To: Luis Chamberlain Cc: Hannes Reinecke , dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org, john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v2 4/8] fs/mpage: use blocks_per_folio instead of blocks_per_page Message-ID: References: <20250204231209.429356-1-mcgrof@kernel.org> <20250204231209.429356-5-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: rhtmnj6dqxw3zix1f3sgtkzsrhapm6so X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 35DE040010 X-Rspam-User: X-HE-Tag: 1740169643-544226 X-HE-Meta: U2FsdGVkX198VBGuS57cDXP1a8Z972hBHWBYq/NQ3I4kBcILl5fvFytw8K3xC7wox/SKJn4EDGJm7l7DOfzxVeRHtQeD3QCCamvD1t5udsjQxFx/XBon0XtSKmDmtK6aAIdS+y1MMoR3PDPP7N/fe8ZqFTdAhQy8QQZPnfJz8s6ziMpZtAilA2uSLyNGuHkog21VuDM/TIHTrU5CDUoQgHdBHIwB+rxzh7XvDDYf3+KDS7NktY1QXzVQ7SoO6UwTna1u9nNjfLGR8W3f6xpiKm95KOMqlOLc2BHZZhn8ASvrGXcByIEfNj8zX0UjTrm86CtI6sIjJysu+sMCBLlGl/9rUnR+vyCBn5Qe8Z+HhtfkSTGwzClw8XKX+IXWQ7LULdGqYIndDVMJ0LpH3IRGmU+qEMw2RPsjM4fF/lCgPa246Nkb3/dmIB4S3GEZWqwSNrJs/ZXlaVRilCRiokEm/K7JkGR4ihBQjPoi21CEN+LDXyKSK+DSzyfRYeRZCCXf2dg4eL7BPjQ3Blx+Z9RMgTiI/xigh5nlVOBHKSy6CbIAWJjga9HGBFVrF1YobCbFN0fXAZxdOY6/YG9W0ykJNt6myiNP8clujaWDV8ip2InqKKtYu9CZ6LC2ifIR3ZqIN77qw6zyeJFcSLIedIUq0SYvPKC1e1zfUnmef4cJymoSJvnMA6P0oVoN+cQoxAgUFZWPbel1mmUOHjEBm7ZNrTOePIKEmV7U8tc7ep7lnP4SfqrWf+J3H28o7PuiT+BH0ZgzvIvLT9/ydKRGBQY40Qtr2UFuPdVqXA61hybI4mkYshcIi3Ra7iEmXFUYd7HPkXLsPMH6deT6EBDTBWJ6veed5jJZk4N6yeBn4GnvmdQP1Edb9mprSVDAR/I7TCDBRPFdmJKK+hQ39Y6ip2iO+7HImRyZBx457HN/scE3Mfi0IoTiR2Vi8KW8nXx0R8ns3sragF9DoP7wuEjj5OI Gpqmef3y 2USuQlCv3YeYWAnGqSzscXZXSSLiRB4SSDR7xd7iAkWob0gSC3i/S/r8obq1q0mEqqffIWG2yOTa8GCdQ3v6Kt5WrQVRjINt7gVwxtcKHpIp0aqWZ6mqeN8eFunmtkrSjJP6sIzWg+THUZMJMjGF21GeEihsal515uAj0glXoZ9RJRDKRH8NKnlJdJrQzFkPL/63cQdQaOzptrSg9Zdl9cJSsgIpBAP26zn2FgnqpAjYzsxerpSD5Tvqzz0eqpMjYBTeH9U2/1gePL5WO3xNMQh5jRejrAHIav5RC4o7MyfSpTs6f9EPtFBiyZGyTJQpnkU80WhwqeArzjHmw9ku1dozUTvJLmDkPmy1K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 21, 2025 at 10:58:58AM -0800, Luis Chamberlain wrote: > +++ b/fs/mpage.c > @@ -152,6 +152,7 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args) > { > struct folio *folio = args->folio; > struct inode *inode = folio->mapping->host; > + const unsigned min_nrpages = mapping_min_folio_nrpages(folio->mapping); > const unsigned blkbits = inode->i_blkbits; > const unsigned blocks_per_folio = folio_size(folio) >> blkbits; > const unsigned blocksize = 1 << blkbits; > @@ -172,6 +173,8 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args) > > /* MAX_BUF_PER_PAGE, for example */ > VM_BUG_ON_FOLIO(folio_test_large(folio), folio); > + VM_BUG_ON_FOLIO(args->nr_pages < min_nrpages, folio); > + VM_BUG_ON_FOLIO(!IS_ALIGNED(args->nr_pages, min_nrpages), folio); > > if (args->is_readahead) { > opf |= REQ_RAHEAD; Also, I don't think these assertions add any value; we already assert these things are true in other places.