From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC78C021B3 for ; Fri, 21 Feb 2025 20:25:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7DCB280004; Fri, 21 Feb 2025 15:25:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2DD3280001; Fri, 21 Feb 2025 15:25:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CE85280004; Fri, 21 Feb 2025 15:25:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6E7C5280001 for ; Fri, 21 Feb 2025 15:25:22 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1FDC3B09BE for ; Fri, 21 Feb 2025 20:25:22 +0000 (UTC) X-FDA: 83145081684.02.473EBD3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id EE930A000E for ; Fri, 21 Feb 2025 20:25:19 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=J1gSTMHP; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740169520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hAm3p9v8B+1l5GQyM7hf4JtpPwNn3Z+XWSql/Do780M=; b=zd3vRroIWLP9lv3qChQCYXoIO+ce6pLSuFQpbL5M2456icP0e6nhFtjGSeaZWIKBwxLseL xqxuyAdplvEsGxKuCEkxu3PyW7Q7RZQHJIxA08EtUW68uoRIpMOImyW4sQA8z+O1D2TiJi xRulFohNTtrZDHsezeUNTt8UgsAxEbs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=J1gSTMHP; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740169520; a=rsa-sha256; cv=none; b=rjDjHRMi3lQhKhszJO8v8D2JAYpYkhX65bvfBJH4ePTsEQixrjZjRH3Q5jIxpAPav8Hrew 14R9ZRJhhPxpfFMWyiYAyhC2v2Vp1W4Xcmer3LMj5WpfSX8heRmpSpafheR9k/m5sL4SHh o9tvNq7lJK8QfxddblilgPKlUYmBUNo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hAm3p9v8B+1l5GQyM7hf4JtpPwNn3Z+XWSql/Do780M=; b=J1gSTMHPzC6//giA6rZgkDCO6G DxyXtoefT1i5AUdWUZA7Cg+LJCCMamTy1ZW/qTIcoBql2Hy0bbCnvWKVEjdyqN7zIWb9L4xtYitJY RCeJrpZL4/N3td4OW+08Fw7LgL30bzwyan50xvHUnZSZvso3D4Q25mn7buBYHkec/JjJHl3IE1f1n aj7JYA5ch9LUPkzfDSzUYnCEYHQn+Vyx5kJrsTIMueYWHqNe4h4anf7dNoaMLfVo0WzhPXXaVJYXn RZ1NwbBCvb2Fu7i2YAi4sa6hDeHsUTjYqOdZVTd4CgS85io6ztutk4zH7l7N4IEtR0aTKznV0SGSF nndq4CVA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tlZaC-0000000F2SA-0UFb; Fri, 21 Feb 2025 20:25:12 +0000 Date: Fri, 21 Feb 2025 20:25:11 +0000 From: Matthew Wilcox To: Luis Chamberlain Cc: Hannes Reinecke , dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org, john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v2 4/8] fs/mpage: use blocks_per_folio instead of blocks_per_page Message-ID: References: <20250204231209.429356-1-mcgrof@kernel.org> <20250204231209.429356-5-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: ksd5y4muapxi8gpjpn6e13buxybgq3me X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EE930A000E X-HE-Tag: 1740169519-412911 X-HE-Meta: U2FsdGVkX1+SMU/vj0bFeu9wnXjEqRNI+gQVtxga3oQxHbtsS3mp8uHz0ZnkbaMu00E4Kc0n9m0DO17qvSqGBOmFyOCPUVtoXWbxlLnW6Q1yCBtd3HQj4VPa/orDxONcEbEotytDKj9YgL9NNG6k+pVoBBkSTd06JHHIS6tcwk2L4ddmjMhX1zxsCC3wn56WJWRktv4DI0atQYL4JVKs9bMBE9cgtu+oo6P0VbRfQgNws7Ih7eZnHD7CHmrD8ao/ymF140sqQ8aZ/O5c1He6yvXocVOWslObhKpLiEB4g8L2LvP2X61uOvFrKpuDav8uqSnzaGcCUQzmouTLvcz0hW3SUg5d50lxhLFhx+qOzys5oYLfAiTFWW+6Jll2rcDRydu2Fe4n5Va93TcVmU9wIH03BVcJVDf3Iv7q/RbA+gc/2/d1ZqOGWHY1AXdqvC/Nk8RAx/VQ5WWFuyRsEOkOKGwsKFkkXSN5KxVwSnzcQmj0py+Or1BRQ/HzQ2V32WRVgEMw6qmbFp0MoeQas4JN/Vz6VWr+xrQXqplznMh3OaKlHmMDzKRkVxx06NCShYUrhUcVYIJ2EkGKMruoYoAp+uHGaQLkdNywGJQa4dN2/UPZU5RRVL9DS8k4KMJp3S7M/jvCJWOwBogdG0uh42VMgdtEzlauYYAP/18+fQxZMsrF1qJ0aeRNa+uBVjCSXQuqtBoFfxw5CMeOAYEg6NNSKkSeYkyWkbQ8ZBwaauFqSbq1VUF8Tx+ui+AG/8ISK5QIprvi/yZEmVDjkPl+VQyxkht6TqqHEC3FbukaRWlyOx9GtfDb3ObrsacyZDjVtZGJ4glDmiSc3GwuXAUFh2SM7ERGt+nINLqz2uA3ARd91AeTRbTJIl9vVZPLvO2DAb20DuSRnPiTIUUFg5JfRH8qeBKjrhHXsFjLEybIayNivF/BNkKj71uRCLSLWX2pvj0y92RO2QqAXPflRHmB2kQ Q114vmSP M3ZjfpxOedJ6nH2iJmsxNyLZNSuFCQZpEUpaS4bL4AFYq6DlbZ1i5aEX0CZCbnAJoVh04dnGEhykge7paavdVFnbNPD1o0oHCqsIIVhKWSBpuEsaGd7WGkqLuWS0+IuBTqJeYCE0+EFoj1hKLivshdKM6eHmealYmkHIy+CBT6wxICp/SeRJukwuC36CAVwzH3bSubjTHmZInG1FxRrUgJTfQWRZUPMthShm6pkrfjDAZXsCfK/TrPoAKMM2XzC0w5r/eiCtn+Fpf4BbunyQ/7Wk1g1b2FcD1pT74D8kCadOYy32tEuAt3z5K9mp4ZrQB/qogDcrI3cPIQW4IMcHZc32YwYDV8dLkkVHh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 21, 2025 at 10:58:58AM -0800, Luis Chamberlain wrote: > @@ -385,7 +388,7 @@ int mpage_read_folio(struct folio *folio, get_block_t get_block) > { > struct mpage_readpage_args args = { > .folio = folio, > - .nr_pages = 1, > + .nr_pages = mapping_min_folio_nrpages(folio->mapping), .nr_pages = folio_nr_pages(folio); since the folio is not necessarily the minimum size. > .get_block = get_block, > }; >