From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34348C021B1 for ; Thu, 20 Feb 2025 17:23:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F30E280004; Thu, 20 Feb 2025 12:23:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A1E6280001; Thu, 20 Feb 2025 12:23:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 843AB280004; Thu, 20 Feb 2025 12:23:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 64FF3280001 for ; Thu, 20 Feb 2025 12:23:03 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0ECFC16282F for ; Thu, 20 Feb 2025 17:23:03 +0000 (UTC) X-FDA: 83140993446.21.D7B71D8 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf11.hostedemail.com (Postfix) with ESMTP id 468CF4002B for ; Thu, 20 Feb 2025 17:23:01 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=av6Tc4h9; spf=pass (imf11.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740072181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uqR3McEPoN/3liWwZxJzw4SmNTxJQsXfHYMg6UfHTuQ=; b=WEzu4DvvTbeVpyfNdPf0l6uKjH97xI5VFQEPAxtDVNKxkK8aOtc7b3Kuqa6EArcCHHYBuM 6GPaj5RE7LDu9HIvMawVLV5/scU++TDGhuiUmEIRdLRsDIVMrFQ0syMdjkDg8hvf0BOYY1 3dYNODq1eEICCXrVuGCG4I0L7ZJ7U5o= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=av6Tc4h9; spf=pass (imf11.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740072181; a=rsa-sha256; cv=none; b=CXcaZrD0eCdfl5so02nOBHmPPdNMZJu8dg5JSUKMoLvCMrt+w/9w+TjRIMZalDwfi9xlG2 IIbdBAfYPsPfkbKMviS2LtkcrcTiAtJiuZmxxMwT67RBB5kmM/Ij0ikFPi7TBzNAvUGUrB sHJf4Wj8giH9hmE112iHYyd3IjWp9f8= Date: Thu, 20 Feb 2025 17:22:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740072179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uqR3McEPoN/3liWwZxJzw4SmNTxJQsXfHYMg6UfHTuQ=; b=av6Tc4h9bvfum3W+ur8r794eb6SWxbWtO8o4WY8kGtBfX2nDcPGXeCHlhlP8Nwq1ul/+VQ eFCEMDy68Oky1ZblBxGCPBP4WwB2cs8dDf5EBD+aJK9qK/GmAfpP5QKzaq9kAhndYCNyDb WsgE0lPhcSkbGhmuQ+7AR4wGdGH+O6I= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Shakeel Butt Cc: JP Kobryn , tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 03/11] cgroup: move cgroup_rstat from cgroup to cgroup_subsys_state Message-ID: References: <20250218031448.46951-1-inwardvessel@gmail.com> <20250218031448.46951-4-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 468CF4002B X-Stat-Signature: 9s5jbu34a8q55qpyj7y9pnm9u44isa1h X-Rspam-User: X-HE-Tag: 1740072181-37023 X-HE-Meta: U2FsdGVkX19tgv+h6h0Q+f6VFoZR2BPGDzs8pTSzVuug/t5f97xaYBeaMwr5ubcTs8iEkjIApOA3g9x2v7ReUQj+bd3HvqQMO9qvaF3RdlzO7bBGG3Z+TA5K+dcw2yiP/5Hp5eQLJOzYluRJV/k3oVl4JfrgKlV4oo415JK13BPrzT8b4RPTq3Li5mCcFzCmmXHwN4MUm8yBjQm4wT8UAispRc6rj5IvItxEi3xy7MtIrWtqSjhSRowIkxhMX1AQ8+DD9JyOAddgD3I+7gI7BHZDMjF1eRWrbTngoXvS8BRdrIG1ys8M+a04C8QnZzCNGdOqDOTMKlHLa6xt1on1hEtpjnAEE9PZPjS080JGJSqHoa3zHTDDPazfIkbasfhujqgXkRV7vN4LYT4SMNp6c9LOB8Y+m/yAikj2eCX7idxQAgy0Fnb48+LsrMpb0wGSb67XQi0cgM6vp4Ie18tkv5PUj2XOR/n3/lkm2m5WjwhIxkrXSnUNMzRqVebziZlhLfD1MgUNye0YLNPuYvvWNEYqk6rTtjdhVfMDHf7WnHBAOzVO/2Cbe73G4F/vgFoJqa1AZZ/4iM7w2Va2uoZJWsUsZ9NM3qEnJjndxaBoGLjGHM2ZOsQ8qNC8FZtYUpdgkUwPQ9rwXSfO3RpcTCxjR+GL9VxkjKK/IDZhzwtv48lKlvwyXb0MsjjpbtitDqDgM4rY986CHUb/5k6dbOXt5HWN8DDgvUgIZY51dcmsH3doVV+kxRD0t7YIbuFu+czkipRLWoHzTN6JFcMKBaCWbysVVWHMPhearsmiJIWDk+e8+1lW2pcBqvvSpH1Vi1RJBop20quIDFFE4XUj9HdFMZAdpzt5w7hygIrJDuDkTrs5k6LzTbe/V/dSBx/czXdw8+0DFtArSFXeUC46gO0RpAUF57LJaD0UOyVALTmRrtZY33a0hqi4c9/wOcEtfydBFfKzmQvaq5Mv03SAGhW BcaK3ZAi qp8JkEQ0tPSQXEfaH0fkqnXVaEWi5uCaOYm3JOpdr0QhDgxdEhjTQSbpZtorBMZ2BHUAxl0rPSCQxhopayo0pMUsSGW73WPQ/MPOk520q/7fz0Ko+xW/OIZkCX5m7J1cBWOzseH3RfL28JFC81z1GIHNm2XoA15os33wJOYdxClZpP/LeWvYa2GLUFOjE6DclIiJf/8Z3Y0bxIZGzT5aLA0NoW7fUpUbtovD4CqXvZeU30YdeIFVrQKsTUnVN+HxsGxlxoxJ7tyxB9I0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 20, 2025 at 09:06:44AM -0800, Shakeel Butt wrote: > On Mon, Feb 17, 2025 at 07:14:40PM -0800, JP Kobryn wrote: > [...] > > @@ -3240,6 +3234,12 @@ static int cgroup_apply_control_enable(struct cgroup *cgrp) > > css = css_create(dsct, ss); > > if (IS_ERR(css)) > > return PTR_ERR(css); > > Since rstat is part of css, why not cgroup_rstat_init() inside > css_create()? > > > + > > + if (css->ss && css->ss->css_rstat_flush) { > > + ret = cgroup_rstat_init(css); > > + if (ret) > > + goto err_out; > > + } > > } > > > > WARN_ON_ONCE(percpu_ref_is_dying(&css->refcnt)); > > @@ -3253,6 +3253,21 @@ static int cgroup_apply_control_enable(struct cgroup *cgrp) > > } > > > > return 0; > > Why not the following cleanup in css_kill()? If you handle it in > css_kill(), you don't need this special handling. Also, I don't think we are currently calling cgroup_rstat_exit() for every css when it is destroyed, so moving the cleanup to css_kill() should handle this as well. > > > + > > +err_out: > > + cgroup_for_each_live_descendant_pre(dsct, d_css, cgrp) { > > + for_each_subsys(ss, ssid) { > > + struct cgroup_subsys_state *css = cgroup_css(dsct, ss); > > + > > + if (!(cgroup_ss_mask(dsct) & (1 << ss->id))) > > + continue; > > + > > + if (css && css->ss && css->ss->css_rstat_flush) > > + cgroup_rstat_exit(css); > > + } > > + } > > + > > + return ret; > > } >