From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B292AC021B3 for ; Thu, 20 Feb 2025 14:54:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13F9B2802EE; Thu, 20 Feb 2025 09:54:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D49B2802ED; Thu, 20 Feb 2025 09:54:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E848F2802EE; Thu, 20 Feb 2025 09:54:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C89972802ED for ; Thu, 20 Feb 2025 09:54:43 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7E8EEA454F for ; Thu, 20 Feb 2025 14:54:43 +0000 (UTC) X-FDA: 83140619646.03.71ED701 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id C4BA2A0004 for ; Thu, 20 Feb 2025 14:54:41 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=InovFzdw; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740063281; a=rsa-sha256; cv=none; b=PRnFT59qciwM9cKtv50T1EWjdyD5uuotdNKepRU4JuMifpaLpYtYRJFMQMbgDSFNpAgiYT 8xn1Suvy9SFEY+ZDAtAHbT/JB6olohUhbcd3xA5B8J3vrxEEp8yOqLV3dNZl7SdFKdaqyp KRz9x01PT5N9z8sNpf08ocUA82KNS78= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=InovFzdw; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740063281; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ywthUrsaZUgbi1jImCfUyZ9XeZtfacq1MlreX2juEEk=; b=BGhEvgFFIHEQVasWVoJfKIveA7v1g3p3PzW5xnqbD3hK4o+H06q7pRSfdQkZYjELR1GEuu yBdULihbLEJ1HOiHQrNnLTCQHL4STMghOixEm3JxhgU8djjCpfFMeraZk6wW2OxlpjhWPl MKsgOfhVmXyQrCgv5JiHSt/R9Cbzo/A= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 771B95C5DAF; Thu, 20 Feb 2025 14:54:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63166C4CED1; Thu, 20 Feb 2025 14:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740063280; bh=BC0dhBX7Eg81uhggtuEZHVM8dUwnpQ+dA2ufHLGdn4c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=InovFzdwowCfkaS3mdofhqdbNRDT0QPSXwLh3w3Ks3gabjyfLh3ZoKBTtSmNarqnX NWSycHqGlN7yNd+0eWaOU0+ODeMj6drkyWUBF0F3RDCZrjku80gpxCYmc+kAAFUIhF cIdOH8Da91vYXQfiFliQAi78+0x05PEFtzKvkt3XktgkdC4Zn64/wMsF41e4w438lb 73um6//H3gzH4CFINfnDIYtLDsWM0e8qrbcvmRP2pP+F9H/e6WTApFpXNGqIxMY23P l5ycIRreRRuogv2tc/sBZpVOPGfjbPnHoaxZx2Ce/d5jWstSBddCKPXyzlLKyYjqF8 fPv0Kjhu6R8bQ== Date: Thu, 20 Feb 2025 16:54:19 +0200 From: Mike Rapoport To: Wei Yang Cc: linux-kernel@vger.kernel.org, Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Krzysztof Kozlowski , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v4 01/14] mm/mm_init: rename init_reserved_page to init_deferred_page Message-ID: References: <20250206132754.2596694-1-rppt@kernel.org> <20250206132754.2596694-2-rppt@kernel.org> <20250218145904.x57chhz3whvckzu3@master> <20250220083601.4p6ehmfhyvs5q5io@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250220083601.4p6ehmfhyvs5q5io@master> X-Rspamd-Queue-Id: C4BA2A0004 X-Stat-Signature: j4jbr6rtgfuud7ez4h3a4q7tec8s7k75 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740063281-581709 X-HE-Meta: U2FsdGVkX1+Q2HGchu7efuW3pgzg+FgCiP0lCVJxVkRmII2BO6TEe44mLK3IRGa9HX/wv+7RE8J2tBUdLeCC0JQjJiyousv1WXZ8/DB/rAmlzQ4hBMnixqDdrxwZ9L6rOwOBUgkVVPhJ9zdkBcwwACYczqMy9XVb1yCyN03mXHJU0w3gIwB8JIohVz9pa5EkipvgQAi65aKpj7lJePNraqXzZuDrZNrtiq3EfvFRe4joE6fipT4JKaFW0KBmvJYT+iusuMvcGlKkfbjZG6xuJsivDd1cy9XpPN64b94QqNC6gwDuvkBuJjcJCRhU8x/O1pDkYNSFN5xYzumu7l4hUt3OA+7sMpjL+BskiWabktYiatpFGtB6rKW+O+j//Lsw9FpPjc7XlD0ak7oRu87z8Ybd9bxvo4f66EwnOouqAeM4Qa50INzShXhE/H7zvI1E3qEVUNUdFiX0SvgS3qXlZCDK6daOAOiVlFIcV6JmdmvsHzjRouC38pdPvpjO1Gs5a26G+KeUd9DWVoIcMl76Ib9pJBaMjVv4jzlXs+auNNgyTxmVxPeIeqfY9eHD9GI7jpkIq3Q7LXBqWIKlD6okYhij8gDM5zaFCX7f0wKvkxQAXAjPIcEbwBkWBMEJZc2h+OhHZVoEouNVlpiwihHXH0OEvnfrfinFJdwsJ/7v8CO81CJ6CuZZlTCTxQbhKSz4NBBLgbUySXVYihXsHElnbS5MYN4ll3YXYreihKCNd8dU8NWj+WkIM28T25DkowD3juKVE6NpzajprGjhEb8o/TyNQPE3ye69Xht/AcVbCxhimw1+qH5r3/THavVF9rO+SeVBMOh8OnGRXXf9ooGeFNQ1zjX0zzZ9KpbrXT4btl6ze5VBhj7xRYHOwtJM5o5GydHLb7rvRXVG0uNURZ8UW2bRxjqo+qD2Cpmmq9AHTZDgVwM7pSicnaPW/Kr5e7mmn5ZzaZ6Y3dy+sI5D0J/ a/9ciwBy rMYNP9weO+KCpPgimM9vx1kupOBqKrXO6q38oG35D37qK967d55BXQYvVk09JAmgyMEoMgHbf/fzn0D4rns7TVZgq/dbiQ4C5yRi0dn43VjyyJ3kWeLsToL9RRfrMG1aKpBmlWQz9B4SUi1Kicf4Cv8eR6VxZn+u1TlssPYtQ9goWPrJJfxcZy+cTHaGhl4bDFhzvIhjOUwIB0bIVAqOQhZNguJ9mgC31I+nIihEVAIWURFHEqQCGaPaCV08kXxaY5c4tig98rveSlOd8bRcMVns29ABNEIPaymHo4T8TY0doJ79qoLj/FcossdHGVUHzb2tiH3l5B6CV95fN4qumoTJYFVqBVBKt2UoNU1xUeMPIUDo20d4xLSEroDH3/bOIUsAhgO8HakFMB8tWpNXn6ygtwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 20, 2025 at 08:36:01AM +0000, Wei Yang wrote: > On Wed, Feb 19, 2025 at 09:13:22AM +0200, Mike Rapoport wrote: > >Hi, > > > >On Tue, Feb 18, 2025 at 02:59:04PM +0000, Wei Yang wrote: > >> On Thu, Feb 06, 2025 at 03:27:41PM +0200, Mike Rapoport wrote: > >> >From: "Mike Rapoport (Microsoft)" > >> > > >> >When CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, init_reserved_page() > >> >function performs initialization of a struct page that would have been > >> >deferred normally. > >> > > >> >Rename it to init_deferred_page() to better reflect what the function does. > >> > >> Would it be confused with deferred_init_pages()? > > > >Why? It initializes a single page, deferred_init_pages() initializes many. > > > > See below. > > >> And it still calls __init_reserved_page_zone(), even we __SetPageReserved() > >> after it. Current logic looks not clear. > > > >There's no __init_reserved_page_zone(). Currently init_reserved_page() > >detects the zone of the page and calls __init_single_page(), so essentially > >it initializes one struct page. > > > >And we __SetPageReserved() in reserve_bootmem_region() after call to > >init_reseved_page() because pages there are indeed reserved. > > > > Hmm... I am not sure we are looking at the same code. I take a look at current > mm-unstable, this patch set is not included. I was looking at Linus tree, it was not there yet :) > So I am looking at previous version with this last commit: > > 8bf30f9d23eb 2025-02-06 Documentation: KHO: add memblock bindings > > Here is what I see for init_deferred_page()'s definition: > > init_deferred_page() > __init_deferred_page() > __init_reserved_page_zone() <--- I do see this function, it is removed? > __init_single_page() > > What I want to say is __init_deferred_page() calls > __init_reserved_page_zone(). This sounds imply a deferred page is always > reserved page. But we know it is not. deferred_init_pages() initialize the > pages are not reserved one. Or we want to have this context in > __init_deferred_page()? If the commit that introduced __init_reserved_page_zone goes in before KHO, I'll just rename both functions, there is nothing about reserved pages there. > >-- > >Sincerely yours, > >Mike. > > -- > Wei Yang > Help you, Help me -- Sincerely yours, Mike.