From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D60C021B3 for ; Thu, 20 Feb 2025 13:22:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E5212802E5; Thu, 20 Feb 2025 08:22:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 392402802E2; Thu, 20 Feb 2025 08:22:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 233EB2802E5; Thu, 20 Feb 2025 08:22:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 059822802E2 for ; Thu, 20 Feb 2025 08:22:29 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3F1921219AA for ; Thu, 20 Feb 2025 13:22:29 +0000 (UTC) X-FDA: 83140387218.22.FE56B8A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 322F51A000D for ; Thu, 20 Feb 2025 13:22:25 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=J0E0nXLx; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740057747; a=rsa-sha256; cv=none; b=VTiSSeCTbm0yvWrARk9JeLAmUDFgVd+MoDOlLJDzFjKgU9VA5JcybNsAeEJUADYUmzGPvw qJXe2mRHDiSlrmP5FdSiYzdOyvfv5FqznFDamoSMj5MEwzhp4YqdGRwCVYe/It+c5vaW00 kvLnZXJ8rNOQOFdQRxXGUB2Ycz7+mGo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=J0E0nXLx; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740057747; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gFDRPAZulNOHSJBDBjwclKNOYUTJihNdrhChS78Y4Zg=; b=wlYfnHMIdaOSmQzpEH6zI+oOVgBSA1V2Q29u9pcMrZI59GA7DJD5etjc19ZKsDQpfmONRo mcL2/ig/N1ERNnyUf4eZ7lMVW8K/OXN7F2h7ma5ebOVjfRnK+PEZy+VdIAR6Nc1bu1+v0j tVigBaZohZxsO0nvjm1k87XSdGaCSaU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gFDRPAZulNOHSJBDBjwclKNOYUTJihNdrhChS78Y4Zg=; b=J0E0nXLxkrXPpSqn7Z4ANpzSF3 DZJGFyPGaLwyK7ubWNbny5cmeOXhJIRJ88xgzSg7k8h/rG/FjhosLCy6yY86l8eAwRwvmPqe3bSDq MTbtJofluAf1dfRQpva3c262JRoJVKsZiW/629TejDGpQOELJyGHzpze2AGNvg7WBteEFYOiWr8vA R0ItP0bhF53EYz2h5kwdkoEyCbk26V+yAHk97aodcKNe3+aCh+BkzGQx6SUMRmPbCVG6Baync7KVr RwIMvF8B5opKQDAunumF5DAumjyP86XzPW3PXWfVzmuqlRuasr/Nvi5hz2fx1tIPgtWFcCFw5jzcE E2jwPIqQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tl6VR-00000009htn-0JKe; Thu, 20 Feb 2025 13:22:21 +0000 Date: Thu, 20 Feb 2025 13:22:20 +0000 From: Matthew Wilcox To: "Shengken.Lin@amlogic.com" Cc: akpm , linux-mm , linux-kernel Subject: Re: Re: [PATCH] mm: Remove redundant PageMemcgKmem(page) call Message-ID: References: <20250212020627.3461237-1-shengken.lin@amlogic.com> <202502201747552959016@amlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202502201747552959016@amlogic.com> X-Rspam-User: X-Rspamd-Queue-Id: 322F51A000D X-Rspamd-Server: rspam12 X-Stat-Signature: mb9ejxnrj6bjod9wwachm9e1ezz6735n X-HE-Tag: 1740057745-491187 X-HE-Meta: U2FsdGVkX19IiItrPv7DCMoLtDiXMsUak7e01Ei/nDXAmFIWZGK7TVw7SSmqIYzn09tsEYpfbgQdQSoVEDfoEj+O6GA1xwkfCHgawT/MKS9lajEyAFWkjlMlANcFdJPwdJMWaNQuD6Brm/yE1dchCy7TlI0e/Pb+sgCch9dvxhUvc6S2+4T0zygn1jTnaFqdpx5PptuPuewmrpW2+/hfmUgK6XWZ3QRueKl+aG7F6SIRoY0wKKmbXvBvIr4JWUuIR1fQ9xbUn30QA3c6X+e2Nn/2XTKeSZ7GW1idW49GVQczVCej9pLxoADmQCNfE691+Ge9k79bcLxOvJL8gFjwOLp/ccNdmfXmx36FFesKEY5F/qUlAm0ejC/fflMgjoxiA8M8npbD6G62K9Ni/Fd71Bo6q6Jlmk0e+18UcVijm7RuIgMz1vBUe+dqZQyVHCyjtz/46xpokPrXPwZrXbGB9sPvAJNRJrLl3ag0MKwNfJ8yQN+HKoBuCJoTJQoEM91gElnyFA/Bd51ePu6kfgLek8HI982SsyGxLQH7sdYLKjhUfrfwtNXYdnied7i/dtL5+OJz/HUJ8BkjI+nY4L/IWEhWbQFGIV5HbdOfV/B+WSxX1uxII+5FCqEfiVaPkS5PMLblG47hyA0xNJVe+wS7Vy6tNXe2PqvYrj/A+XORkRlUPlLUrNQ+Hp9MZcDERazuyNKZIfgb2jOgeFmaKRAmVz4BkrAZCXd/TXIPHciiwrDxBVvvPxTPrfmlBukqtrRS4tiQE8+DBglxI03WXDNbRHwK+n7vtnsWwVx4vznOxTYaQ09ZZSAGAecUNRzA6SZk+JpYfFYyKnaNd/fpInxhXGDOVfFwJD264/qIQ4RinLhjdSElJiX6H5N0NPmaJDpvrzJ1xDxm6cJ+7fpkkogGPyGPHt6GotQksrjrckdjGmjcD7Viv3ty6zbKV0fpYgUsef4E5q3IJqw0NVMfTsZ nssqen3Y 81752UO/Ef3Vzx/Yj/xPWxmzc60kIK0zkpmJwswyx9mesfDPOWOnUW2qkDn2+gCEzUcacXxWlHwnjiquv+iEb8WGFlecggMWqhsxx986lqnUA08l8Gyb5DwSlPqH19dQForX8sch+SNNULjvRL74uSB3X4KJxUuRgrKvXg12woYGl6jp3iNJBa6QHSZ7EuUseqOG077grhCp9LrgjoZF3pSwKL6id1CgOGzFLB2rfW0wod7EGu2LeKsK5qJOsoLXncF03KWYuV+7O/uEhRh+dSqUEjKoVKRImvKfsYklwUbhWnCmGM9qHGEa9OPeVpNLkXA1cEZaL8qixQRSSdwt8Lk+X3q4gtBVHxHyb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 20, 2025 at 05:47:56PM +0800, Shengken.Lin@amlogic.com wrote: > If it can save a function call, then adding PageMemcgKmem(page) > in include/linux/memcontrol.h would make the code more consistent. The code is fine the way it is.