From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B0E9C021B1 for ; Thu, 20 Feb 2025 11:02:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4C2D2802C5; Thu, 20 Feb 2025 06:02:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFB782802C1; Thu, 20 Feb 2025 06:02:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C760D2802C5; Thu, 20 Feb 2025 06:02:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A4FB32802C1 for ; Thu, 20 Feb 2025 06:02:18 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 377171A0F81 for ; Thu, 20 Feb 2025 11:02:18 +0000 (UTC) X-FDA: 83140033956.12.E7E3E59 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf05.hostedemail.com (Postfix) with ESMTP id EDAD3100004 for ; Thu, 20 Feb 2025 11:02:14 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=j3Tt2WSx; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Bm9rOHp0; spf=pass (imf05.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740049335; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rsfFPuQdQ1152jVutTX7PeHLmx6hWYIFzbCjLgxxb8g=; b=I+IZeT2r4fLjhTL0CHve0aTzyTTtmwYQfVG1ZYMvg9A2IbUHobBbtX+UoxgRTaAuBWqr3r /TKjxRrcCUGMjkBv1Pyeb+Kob4EwJiqtaJxKteevu/OCdY1LFWtit579Mf2ZTRZ4/tj02M pr3EKyy/mIxYurciNLwWyl9okAavZmw= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=j3Tt2WSx; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Bm9rOHp0; spf=pass (imf05.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1740049335; a=rsa-sha256; cv=pass; b=28fSpi1o9KMq0QveeXB2trUVZMORSJablcBz3In00PT+LafPv3FSEjbtR+Tp6GSuXz0BP9 fmDCZTBgYsBdPhI2mwRvy4wdw3Eux148ipTl/WbhXtL1s02Fc+zNDzV1nlQnRdUFoTiiJI 0DqEfCXS3TjyDJaeCzdIYxgYxE85s0o= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51K9fbd6001626; Thu, 20 Feb 2025 11:02:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=rsfFPuQdQ1152jVutT X7PeHLmx6hWYIFzbCjLgxxb8g=; b=j3Tt2WSxVmipFflX7Sm5Y+JX0DPT2GqRdN zQSRI5SDK9M/32q+cXQMWfr0PMYF4kPd/0JSDURtGRV5q9QmyHFbAZX/1YEBrNpT /8odt7nDrdKi/ZdbW8wKENzv3CC0UiOPDFEXUwxKPozG6gIUPkv+wWWz0G13HxH0 YpPg5CijH/Oh4uuXL8fKdJz2Xzb7WItcimOsI/hqBdqVsPXfrgRGHXDBTeIuQ27X VeleCOHdNxXWp2ExhBOZ1ny9JWNog1eJ12e97meF2FrE134jC2SpnXjG/82Wj922 ZOBplWdjvgzY8t7F+IVjWDibS+Yw3RQHVt0UuJwUGb6/WPimVoig== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44w00muwbc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Feb 2025 11:02:09 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 51K9UKpv011996; Thu, 20 Feb 2025 11:02:08 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2171.outbound.protection.outlook.com [104.47.58.171]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 44w0b3qvfs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Feb 2025 11:02:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g2lEMmO1gfxHq39y5ApbJ9ikyuIR/baRJ9trkkZ208bVLI8ftOdQbxetO9hb3IjBde22rFEvDHyu5OSJCyLASwf48SDtUMx/cehThho6zbwcEQzHMgcARWZKGL4gJxRbVMS/kUVnWMScWWo0SqvaO25NgFHpkl7EdkKW9sq7WMVRCKjYNIl4zfF1g8uoswOB7LtbMZ/uVCWyvgQEp3fJXskgKHY/+MoXItwEm4ImTk+Cg3FJ/oTynD/oAnatkU5HSImpXXh24iBbGsyojaiK6QDbEpdH4/ZtNCrv91cXwfbzpIb1ZZEcfKptxWZuJDkYGxAjFzZgiJalLIfda566QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rsfFPuQdQ1152jVutTX7PeHLmx6hWYIFzbCjLgxxb8g=; b=LojqE/nnxd+D/Oex5WbtxUWkR5vdEQgxVL4RANzq4j5yWt34ElsIc3/CEBBYMHSJpR6igbeVtPua0e3h5GeiiGVxwdEarj0xmPC97Wkq+b+iByFU8/3VUIeSTXh2FPAFKlyX6aM+Tx9sGAcUDv+41NiwyC5SxiSJLNIZ4XvTKicWUwuGEj573wixCAWkGluzDYeFicV7AWhrJOz3u/zjBxovGLvfcsd7DnV2aJoZflX4xwEHWVnOA2PM0BmiIZmarXueD7ZENv4Au47WBFxM9R0CUU5TVBCcmF7TamfwL7dIRkudVfgwhOXhRgv+Q1EjPIgACW3jBF8hXiuyX+rTPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rsfFPuQdQ1152jVutTX7PeHLmx6hWYIFzbCjLgxxb8g=; b=Bm9rOHp05FbMsyaRqa9ai7SKKrDrnoUswh2I8X8Xl0zdvIakK3ebCCbD3zLilGfmLuGhczpuYS360Kjim1PfRFpOO7yekaWzfgaR9nWYVuwIYCoyYJlz4NX93IFQMrTzFFc7pvwQJ6SFwEj9OjtTxDQgy32RHm7XzvK3E0isfTc= Received: from CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) by IA1PR10MB7141.namprd10.prod.outlook.com (2603:10b6:208:3fd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.14; Thu, 20 Feb 2025 11:02:06 +0000 Received: from CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23]) by CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23%6]) with mapi id 15.20.8445.019; Thu, 20 Feb 2025 11:02:06 +0000 Date: Thu, 20 Feb 2025 20:01:57 +0900 From: Harry Yoo To: Hyesoo Yu Cc: janghyuck.kim@samsung.com, vbabka@suse.cz, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] mm: slub: Print the broken data before restoring slub. Message-ID: References: <20250220033953.1606820-1-hyesoo.yu@samsung.com> <20250220033953.1606820-2-hyesoo.yu@samsung.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250220033953.1606820-2-hyesoo.yu@samsung.com> X-ClientProxiedBy: SL2P216CA0227.KORP216.PROD.OUTLOOK.COM (2603:1096:101:18::19) To CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR10MB7329:EE_|IA1PR10MB7141:EE_ X-MS-Office365-Filtering-Correlation-Id: fc00c9b1-97bd-42c8-87b5-08dd519e033d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ssq1mUwL7L26GL777+xlYvT6TFsrHuNeDI+bjog+N1TOYIAGq6+8OrtH1sV+?= =?us-ascii?Q?qx0oJevPJ1S4OSrOiT9c9LjgFBVfj/H6GsGgnndzUeM1abGyP+3eRt8MHQoH?= =?us-ascii?Q?oMGMAjLWGb0NrrydFJOe0dN7r1vyfzwcfvFp71OcpShzmkNsJXAsRAWOi9mF?= =?us-ascii?Q?LU1Sd6kVOcmJnGtrCGAssH/g9+Grce43s6jTneAn5sa2dxsKigRY1LbjK3dL?= =?us-ascii?Q?cw03cwwHX+2JIL4H+hya2eMhRXHLXuHJYhTxlSTDqSq5G3QLW6kup5lzcX+m?= =?us-ascii?Q?CA2EydjdTq2txeLeRsb8ooHfrRWt2Kq9STfWZy7U/elIrUK7yENxJB4XMjr/?= =?us-ascii?Q?p6aavmyKQ5m9kOWpjDDClkbCS5jFkAJy1WQkm3STqCeGxeM+GmFUPF1NZMsn?= =?us-ascii?Q?RDsvMu8IG+q/vaUDEmt1ha3C8ApHeII/i1b2aOtgdTkA/LwXjOJD0REkNYNJ?= =?us-ascii?Q?bqx1vgbfQ47buXD/EvDnqEBlbyQ1km3rR6kMSH+KZn4Y8MB8cV0BkwK9GMuu?= =?us-ascii?Q?+/cSK/O5mL3O9drue4bdUtXDhohKOdi4+w9soKf3jrmLsSST58q7WzavJGBI?= =?us-ascii?Q?U4ES3EFexj/fhZVrJJVDcrKQ6Z3iWvaM4N5k8NCizWj2FYRVcEVg1GTExZr7?= =?us-ascii?Q?bo0HY/FjR5naE8+vfWE0Ag6e5KREuuTuGZQx+t8dtouKOT/QTusCmnuhG5xe?= =?us-ascii?Q?v6PkE+pzxQhbtvuSyAjbN9x5J8xU0YCsYGQ8CPkN/ityidvkKTWZr1sryuUB?= =?us-ascii?Q?0eFZBGcY6fzsFDz3inIv46bjyoj2SjaFouU/4RWF+TGxZpQ14DRBbVykYvsm?= =?us-ascii?Q?oZd8dwrxiUL3MYMwtn8xxverFzr1ntxk0nazTSqF23k4Tc1e3c2ir7jH9foY?= =?us-ascii?Q?hzcpF4ChVmPf76bOQtISie6hEVsJnHhlRAlhMNuZ1PZ+HNqcyKqCwkiJvwEG?= =?us-ascii?Q?d/uT4quLn3L34YJ3SfoULfk+scML56k2e4NKXQZMoqnwqXneKZ9DhYk47Vnx?= =?us-ascii?Q?4HcI4sSQVtdnyvu6ByE2L1dhaNC5dWYd3Xc63skZC5fvHEKpnvoBV1VmMuwN?= =?us-ascii?Q?v1Ti1UPzPW71m1sbA31RQcBj4NcrJnqwZfU2rFpNpNZWtRDslDpB7N09UV5e?= =?us-ascii?Q?/HisgJJwRtj3RZp3ZGxHikge91NRP+aZCcwVtj0vtPvG1KQUDBYr2T20UJ9D?= =?us-ascii?Q?XVhAO8MgDHtraPUP/AhsN92MG/1Cl0Gfor4joZ4VUrS+a6uz61PeBe4qsacp?= =?us-ascii?Q?CW98x/PjBR9mg7Pyqungn4Lt66m6SiAaoFpCGL9q52SRrWITbdIVRYyN7Tz5?= =?us-ascii?Q?Lw8ZiNohvlUnnkje6g5fvzBRNbyBr1/nnJll1RIl4Mgh2NhW9+nCpMNAVVin?= =?us-ascii?Q?7MbzjOtFcNA6T4tVb1iFWIGgLILa?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR10MB7329.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vzkufBjNUf2EJ7N3ikZZJdZfEOER4CZ4DS1HDi0m9pH4AIeVX6+7dTHkBoS5?= =?us-ascii?Q?76rpl5XI9H/VSOrGEO98l/XJaocM1zxL3hnnsPNkAJiMzYEtFgM/YYre76Sd?= =?us-ascii?Q?r4Cq/BCc/kJfjr6C+a1bT7AI68VVwJek/WDj+Wktw92FfZRqPkTDTA76QVUH?= =?us-ascii?Q?atYqZA1fPRz7ayunCToztueF8WOjXDmyIEt4o0o+b0snWbi6QtlkN7RR5AK8?= =?us-ascii?Q?zjB7k1GZEqUMGhFvImCx+6M4kKrpiYT0gUcyWkIa3UQ6QvLGdl51M0TEaEuA?= =?us-ascii?Q?thyGDq9G9TZk12vzK+SCn8RWhGO8tbMT/BUMTnWf865L9mv12ihLaSot1WsS?= =?us-ascii?Q?mpW83v2wRTO+pD/UQbvIltSY+zEdcI6piIK0Iknbvilq6yDNpfTKbzrD6OtB?= =?us-ascii?Q?jKaFFNWAqzXvyZajp6R4BYAOD7gVkGC4HtyXI0aRwV9kXaVjDMlNwl1Hv3Kp?= =?us-ascii?Q?j5UEPFkGzDwR9u+VeQ88TbhY8AmOcswhd+1nrHqUUscuB03ZD0YuRswkPziU?= =?us-ascii?Q?+ZiOCQW9e8F3NaUCurf4xTXsJJ5/YIyCP4GNf4Ajgh1dqEiRsaoQohkJnJWH?= =?us-ascii?Q?7JSp4wqE09VyZsp3xRPo+LdRV+SbJLT8werk3/lRpKBAMYdfu90sfD1FAZpq?= =?us-ascii?Q?fMuPvUEvcR59RtfyJrt3b4NHwDJ0ZxqmR6M2ttkfTExXp/x01hBrN9EFkX1z?= =?us-ascii?Q?zV1KvenhQMYJKrfOGRNCBmAoe8K5yjJPEf3bustctT9af/6MDH0f0FCSni1B?= =?us-ascii?Q?yutyXy5JGHE8U9TfhL3UC24WrlOYiVv/EDwRLryPBfk7+ooYZBrijeq+G+z+?= =?us-ascii?Q?3c7SdLYP9kV7AQ0Nl9Rg0SQgevdn7i8bx8wJZOR5FyXYpr01HRjljxrVcD1g?= =?us-ascii?Q?0gkwO/Ljvhj39Ff0tQQTDeIdG4Ca3j1Xhk+Q6uw/uTQrZP8X70Cy871aN7mk?= =?us-ascii?Q?K9yFekDe2/20v4J8PKfrtRZDGQSOToxxiy19DU2muitcMon8sF5UktkWoxCZ?= =?us-ascii?Q?gOggKY+QDfx5zdGm1jG6yLdGJdQ4wx645+fV43WQoLiXgPs6Ue5Fm1VU6Wtu?= =?us-ascii?Q?FDl3yGJTZ1MjEzAVM0Emzq0Zuq/qQvVBPKs67/ELQtJOFDLmnHa7t+ZeT8X7?= =?us-ascii?Q?ip7UKCdR+EWfkw/PXjLKXJ+XydiD/FdKixi7p3d1IX5SZiSBsN69Aqbc/CZT?= =?us-ascii?Q?gwZsytB611PQ2VP+H5u5oL0bKca0IiJ9cvixdlSPzI/vXNwN4AeL8H2RXSPs?= =?us-ascii?Q?bsssRsK5Anuy/pZ07srFEPzmLvP+P1jn7G2RNSCq54umYQKAuOR//tYsZVv9?= =?us-ascii?Q?jdF9UvbrZ7kq7q62BQnKlrUdjNiVUMopPZMo4AcXdpQwb6+Tt9S8uCzIw8eJ?= =?us-ascii?Q?JFx/eFBht6VCSeWE5eSmrTKcvNVPpgju4x52KTvZd3Sjyb5o9bz7TCdfbRC3?= =?us-ascii?Q?eF4/fY+QX/L2nZ+eAy9PDUNJMZVLxc5M2ZIYIcYmicvJSSbZ9Ve+L0UBxoXp?= =?us-ascii?Q?lYeKUwds4X4MOW0APPfgobqU0UBam0eku90n2RCJVVDuYdFX59HR5bUSRqTg?= =?us-ascii?Q?FUUzk0ShlFOkt02Ad3jLBQQiYOdsniP9VcDQjgls?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: V8wN3Z8dR1wKzD3sDO1awQ3XHNwUnPpx0NuFrFfPR64aK3iS2QGIxhVMevGUYmuFYXjJpT+DFDqDL8fk9yRn9Zx+Ew3JBVntoP8V8cUhPv5u9s778f735IBSQo0///+Dpqg0Wkpvr9ALaieC3DhwRylxO8Oc1WOmZu5IPk+Yg4lJJnK8LpU7e4kgGHgXpytzqMQbKqfUxz/SrArQnA5dJlPLV2aSLbB+eKpnkgtyK+ZlNLdVzlRhtjbRaKk+9wxME2rECYxnm6G7cOWPn2h6/kLsj8oZrCc5EEhhDXgYr9g4fy7gSRm12d+sSr2S67uuNRqmMPsLccM4XJfmLzZrs2Oz0R2C4cJonb+J2HMIAsKPzSfPvaS9oK5O2xoVhiLdtegMCSWzxA2pDwB7AV8vd+qiG+sZySrNrtFynQQ1sVEIGyquNTVp8SiRd5thYigpABnnfUE7/jLKFVoQdXgK9lOf+NRJ1KBRFBYrE6B9/sGm0Mkapf6PJMBZzEurT5bOkA0wzCYR8k9dAlE0XzhiczweInQP4Ysj7ok80Hu4Eu3lm7do9zPnJsSqhaJpbsHAsmPFDh24Dv/CbkB/SsY94NAZrCT7LWDp6aCvFZ/f0Bc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc00c9b1-97bd-42c8-87b5-08dd519e033d X-MS-Exchange-CrossTenant-AuthSource: CH3PR10MB7329.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2025 11:02:06.1430 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OCdCOw/iXASoWlrFzTKzMGLRE0x/4XpmfeW/CP2FTj1KFmSY0Vk4zGMJehu+5+49xy600rA3NGvpgDKBn6e7AQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7141 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-20_04,2025-02-20_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502100000 definitions=main-2502200082 X-Proofpoint-ORIG-GUID: dqoEH1J3o5Ux0qSQE57wxYymmLDA4KO6 X-Proofpoint-GUID: dqoEH1J3o5Ux0qSQE57wxYymmLDA4KO6 X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EDAD3100004 X-Stat-Signature: 7c5u9dcmsbxiub44iai544iwod8n1p6o X-HE-Tag: 1740049334-935350 X-HE-Meta: U2FsdGVkX189iKw6habe/KnrerCI4SWMQyjtiSbw2IdBpR+TltIH9u16oKGscLSM3k5XuwcuRLJH1S+yan7OmKY1ZKvp27/LnIv7Q0yb253WuE5GD0QrY8lzMgujw0sp6ordhW8iQFNh95vS/sUY8A2GZgDVxDeITJaI1HdMZmDWcFnUG0Z6wug4U17vDdNcXPh8Z5HZoNdUm00YFF2pWo7fe3vFcmDyPBna0zhZX8xdKeKmRSZyp0CHVJvhj0f+s0DgzI/MAsSHxWeHxkGfn3Fi7LJsG6/5rPsA/uWS8WvpjlmRejL5VjollmxQVQt8hbhjW9zSRQRDQ6WF8QNcYf8mnnqm7bM/OHQIxWi1MNuqushx6M//e/zwtWDijhUIVzQtWZ5shQgXnfCeqr4eTxlkyRs6j5UsqsCQslR2NuLxG17cl6WjNpd4waSvGcUjtv1I4Gul+GHHdotCANXUDYbPxnseIelMm2RGa5oE3I2xjWi45ZxpDYfAE29p9z16ZC9KEiVtNmg4f7arlZupf4tqZxG0C+vcKP2snqh8zUEAW0qcOm+d8PYvhnmJ1O8sYoKqxy7J3HGP4i58wZMlxC1EO/XVulBkccKlMrQ/1f9FJHpwAaysY8Hsk45HLwEt/BiwmA+wmjlbPZ3iVSfM3Ki8oREsBvrMYKxg9ZqUJznhkzlVYUEPCClQEGrSZKTmSunSYgLELu908KLXq3eUv9FiJugDxmp1jm251FMggiRhiD0uy4L6nDl21XccLGnulaJ5GDu7hGuqG1nkl96S+hYUZ27dRM2RvnX6PuH5pT9JZmsQ3kpAzxnR9kehQbbK8KvyvrGDHbXI6gtthvqZ2lZfdrhKOEpESl3WwmEhGyx+Y5kZBCjVeKEeWs5NQ3dfgTA2zv3QdAQNIu1MuraUvj+PnNJ2C7MJj5L4Z3ZIi2i39+XOF5qI4liChut+1uAx2GiqZteAI5UNH1muhYo ibs3yptJ gLV9L3yMIRlWJbi6ES0D03G4woXqNkGrYJvGehXzmeDsbQ24U7skKGiM6VVhAJ9C9ulyZs1RrQcqjOV4JWQbEVuSMUDvr3A/wTkwRaL+6PqQ9dhVRmdY7BoESFRzOqzF6Ji3yiqjGCy7CneHiFYeZ/ZQKpT75IpvW1WymQx1YfYdhCfgJOABMY/O7onQhG3qxU+G37GA/8hDvlh1zxoxj1c8AfqXWzPFiA7PonJa3ahejlvCaNOM9jy6NBHnznEciawPxgtSpxajQmgqTYpmfDiTXo0V2Gwok5xN2jILYJpPS2CCjhKxRt38ec72STplzhMy6f0rb13jNBQr5bm+e5dMHh7wm5phdf5cd1TUOS31QuIL3fMCAadHOJYs1//nIuY+C4QWMPKpDUPAFIMDdOpDbb6OK+9gZ1usiJr8Dtv7MZEy4XY2RPW7DmXdMvylJfUZbdNisqMQt+yYmek1DUQyoeSuYOK97GtmlQMp5uPV+fK+bgUnsCJxBQrCAZUYOtMPAG6tgNWXZsXdvJUTt/WdebvLnzdwone62d7W5jChOWLYTisDyRdgu27qUaKHTUorPnyxyWUcPOy0hd1Vv0uPtAz6QaH3EG/8jAdvA9ltlNrvGQUtWDr1ygI7bO8IbWr+eolCXeYHxsY5/nMWNa+i+CIKs3SIUeJ6lZB50B6cZAYc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 20, 2025 at 12:39:43PM +0900, Hyesoo Yu wrote: > Previously, the restore occured after printing the object in slub. > After commit 47d911b02cbe ("slab: make check_object() more consistent"), > the bytes are printed after the restore. This information about the bytes > before the restore is highly valuable for debugging purpose. > For instance, in a event of cache issue, it displays byte patterns > by breaking them down into 64-bytes units. Without this information, > we can only speculate on how it was broken. Hence the corrupted regions > should be printed prior to the restoration process. However if an object > breaks in multiple places, the same log may be output multiple times. > Therefore the slub log is reported only once to prevent redundant printing, > by sending a parameter indicating whether an error has occurred previously. > > Changes in v3: > - Change the parameter type of check_bytes_and_report. > > Changes in v2: > - Instead of using print_section every time on check_bytes_and_report, > just print it once for the entire slub object before the restore. > > Signed-off-by: Hyesoo Yu > Change-Id: I73cf76c110eed62506643913517c957c05a29520 As previously mentioned by others, Change-Id is not used in Linux kernel development. > --- > mm/slub.c | 29 ++++++++++++++--------------- > 1 file changed, 14 insertions(+), 15 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index b3969d63cc04..de62fed12236 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1192,12 +1192,13 @@ static void restore_bytes(struct kmem_cache *s, char *message, u8 data, > > static pad_check_attributes int > check_bytes_and_report(struct kmem_cache *s, struct slab *slab, > - u8 *object, char *what, > - u8 *start, unsigned int value, unsigned int bytes) > + u8 *object, char *what, u8 *start, unsigned int value, > + unsigned int bytes, bool slab_obj_print) > { > u8 *fault; > u8 *end; > u8 *addr = slab_address(slab); > + char buf[100]; > > metadata_access_enable(); > fault = memchr_inv(kasan_reset_tag(start), value, bytes); > @@ -1212,11 +1213,14 @@ check_bytes_and_report(struct kmem_cache *s, struct slab *slab, > if (slab_add_kunit_errors()) > goto skip_bug_print; > > - slab_bug(s, "%s overwritten", what); > pr_err("0x%p-0x%p @offset=%tu. First byte 0x%x instead of 0x%x\n", > fault, end - 1, fault - addr, > fault[0], value); > > + scnprintf(buf, 100, "%s overwritten", what); How about moving this into the if block and changing 100 to sizeof(buf)? > + if (slab_obj_print) > + object_err(s, slab, object, buf); > + > skip_bug_print: > restore_bytes(s, what, value, fault, end); > return 0; > @@ -1279,7 +1283,7 @@ static int check_pad_bytes(struct kmem_cache *s, struct slab *slab, u8 *p) > return 1; > > return check_bytes_and_report(s, slab, p, "Object padding", > - p + off, POISON_INUSE, size_from_object(s) - off); > + p + off, POISON_INUSE, size_from_object(s) - off, true); > } > > /* Check the pad bytes at the end of a slab page */ > @@ -1329,11 +1333,11 @@ static int check_object(struct kmem_cache *s, struct slab *slab, > > if (s->flags & SLAB_RED_ZONE) { > if (!check_bytes_and_report(s, slab, object, "Left Redzone", > - object - s->red_left_pad, val, s->red_left_pad)) > + object - s->red_left_pad, val, s->red_left_pad, !!ret)) I think you don't have to add !! to ret. Converting from int to _Bool is legal in C99 and it will work as intended. > ret = 0; -- Cheers, Harry