From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE5DC021B1 for ; Thu, 20 Feb 2025 10:42:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F1AE4401D3; Thu, 20 Feb 2025 05:42:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2538D2802E1; Thu, 20 Feb 2025 05:42:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F4EC4401D3; Thu, 20 Feb 2025 05:42:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EB1762802E1 for ; Thu, 20 Feb 2025 05:42:03 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6128B80F79 for ; Thu, 20 Feb 2025 10:42:03 +0000 (UTC) X-FDA: 83139982926.27.4B0BC74 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 74318100005 for ; Thu, 20 Feb 2025 10:42:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AfWIpzOr; spf=pass (imf05.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740048121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zJLrvrZATxQwSHFwQqhKMeyeyoM6uX/LJNrP1uXVaNA=; b=QzFsW1uveLaA1LiM0XK2ev6uC15S6BSXDF0PKN+gfNs7T1nE8GCWA3uYB077r3ZtLPYp0h mOPxCOjOj4s/Z5vMR4f0TecttnYKk2asE7fDjQxEhnsdGiez6TpNQ5ALJxVgyBMGpLI/TK 85qyXZRP4GByivgygmbPo5U4oszLNLI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740048121; a=rsa-sha256; cv=none; b=r295ANTAYmNreId3TmqT/SZUr8cpVw3KAoaQYKyZISQyJ9grYC3neOcuxRyXvWyOx8WLMr d+gqJuQ8DOBae/5m/no8YMmmCtbzp3NDVlFqzFCRs61XzZy4ZH/LXzh15z4LnBAqFh4slg 1fSV4XqBgGMf13VTpiQIr01LuPFqg+8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AfWIpzOr; spf=pass (imf05.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740048120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zJLrvrZATxQwSHFwQqhKMeyeyoM6uX/LJNrP1uXVaNA=; b=AfWIpzOrxWjzsDyKcHs2ltKRn1ffUhiX4Zn4ksP0AFAG66RnVIn+2kxTkWMGDIYnHbF7/B ZTb/Ho4b9vjxDDKJHvr89nY1R1NNB9wKuSAmD6LTSlbMrA52ak0YbqFlRe0e1Io5pHfPUg D1enhYpssBoofPiPRuatrGEtd2I6pN4= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-HHkdyKk-M7OVs5y2-Wr8jw-1; Thu, 20 Feb 2025 05:41:56 -0500 X-MC-Unique: HHkdyKk-M7OVs5y2-Wr8jw-1 X-Mimecast-MFC-AGG-ID: HHkdyKk-M7OVs5y2-Wr8jw_1740048114 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E6C2718EB2C3; Thu, 20 Feb 2025 10:41:53 +0000 (UTC) Received: from localhost (unknown [10.72.112.127]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3353A300019F; Thu, 20 Feb 2025 10:41:51 +0000 (UTC) Date: Thu, 20 Feb 2025 18:41:47 +0800 From: Baoquan He To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Chris Li , Barry Song , Hugh Dickins , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , Kalesh Singh , linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] mm, swap: simplify folio swap allocation Message-ID: References: <20250214175709.76029-1-ryncsn@gmail.com> <20250214175709.76029-8-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250214175709.76029-8-ryncsn@gmail.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspam-User: X-Rspamd-Queue-Id: 74318100005 X-Rspamd-Server: rspam07 X-Stat-Signature: c65whed4wi4awd18a6bsowgnzcgiw5be X-HE-Tag: 1740048121-757130 X-HE-Meta: U2FsdGVkX18ZMO3CHxIzu9yIAhdnvTUFvyhWI+agCxHTyIB+kpTPgkpiO8JzPpgIwUV75YxCH8gtB97xH0zgueunU39SPtnetKRoDadz/BsXnUmR9HANBXQwckbD/v56QiZ7JWZJ28TTF5yAoFcLJp/jG4IzkbRSAOxjwL+/I8gBIp/bkxJ7SRBxU+D+VQe+OXSbMf+woDSj1BifyalL6QnuxEXJS3aNIX+Okkjfkioxlxli7cDEnhulpAO9XooiEjYq3TaAhay2KH3oIPPtdQCBZJqUUKUuasqIhmlDn2CjfDdMHTWfmSz34j9FPjoICR/dvxHi6FPM+pJzaxp3qiueEGpDd5Fb7GbOKj3KlrDMhi9y/gZ1/gnbrRtxecSTJ0xldG1LwXFUYRrW2KRXTFipSZZBGHuaXrHyjti+xCRoYELPlaShyqVDRSW7PBhQzphSGxgTUSEADPwKXKZSBrpnNNfGydyN4JW+ORwHNnj0rGeAfj1MiL+UIR/s701rnkiwtUdUlG2ZPx6epMjVpw9k7/8nsbqCW7hecQnMOev73GtJSjdLDnu4hfkLL04rTei12oHm3zB9IH2T3dRO11AsuKXLqRr7mRD2mhfnIiKXwpXGiD4tkBNQoaWJTDScMaSxvEm/8kdT1MgGo7qdsVj/Pw6wHg17+x7pA0HSCCvoBSOST/5yfWA/jXW+xfgMfi3LpreF9BIIN19pHXQ7pK5vgxdCD2EsgBJjfAUIOR1GxclfGXXYccJ11+rYI+q2wiW9tSiFx51fIZ02VOVvp+X0uEIYJ/atMKIsuIW7VQRO1gehHtkqANjwntFA/IBvC0jNkJhEreD/vOrxwrTomWNnxIt5YGWnQKhgwJ7zrhnlka1B7PLWBcoZdS7vtYeAcS29Re18PgG+3F+d4z+1F6eS5em0tt5yMQHrajWHXX3iJttYhYU7r87pPjW61TFOaS4LS6AoG+gt64Z72dN 5dGzpRZE 3Ci6M4WnDW4CqSJyJJUyBkWYG3fmVmagD3Xog+2LUSk2ghDf4fSvQb4w9CwVouFIzacuf4WyFxdXaFCtrD0C1KNwBevT3qwgCKsqsESWpKazMZmNKFT+0Q2lPm7xwmWltHSwih+jxWE7T3YOCgib2fYoc+vJzKbB2hg+XOfJB0n+9EmGpyc785MBu5nNt7tj63w97D7w2w5IjlFMhIQUuaLx+UqXy1kzZgVirJvW0uGCLg6/1ldpBtD9hyvDxsQoroJwqV2bjvNAa3AwQXSOSXSa0+cGg+6NbVF+mY2FCLa/mqwryNDfc2CE+Y7XpuX//cgSAZybhJ0Et/xwtzVnt1j/z88nTXd98RBR41hKT9YCQHtVmMel6aGT61mQJ3NZn5V8FSEDW7lN0dDQnnjpu+ic1/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/15/25 at 01:57am, Kairui Song wrote: ......snip.. > -swp_entry_t folio_alloc_swap(struct folio *folio) > +/* Rotate the device and switch to a new cluster */ > +static bool swap_alloc_rotate(swp_entry_t *entry, > + unsigned char usage, > + int order) The function name is misleading which may make people thing it's a HDD swap allocation. I would call it swap_alloc_slow() relative to the swap_alloc_fast(). > { > - unsigned int order = folio_order(folio); > - unsigned int size = 1 << order; > - struct swap_info_struct *si, *next; > - swp_entry_t entry = {}; > - unsigned long offset; > int node; > + unsigned long offset; > + struct swap_info_struct *si, *next; > > - if (order) { > - /* > - * Should not even be attempting large allocations when huge > - * page swap is disabled. Warn and fail the allocation. > - */ > - if (!IS_ENABLED(CONFIG_THP_SWAP) || size > SWAPFILE_CLUSTER) { > - VM_WARN_ON_ONCE(1); > - return entry; > - } > - } > - > - /* Fast path using percpu cluster */ > - local_lock(&percpu_swap_cluster.lock); > - if (swap_alloc_fast(&entry, SWAP_HAS_CACHE, order)) > - goto out_alloced; > - > - /* Rotate the device and switch to a new cluster */ > + node = numa_node_id(); > spin_lock(&swap_avail_lock); > start_over: > - node = numa_node_id(); > plist_for_each_entry_safe(si, next, &swap_avail_heads[node], avail_lists[node]) { > + /* Rotate the device and switch to a new cluster */ > plist_requeue(&si->avail_lists[node], &swap_avail_heads[node]); > spin_unlock(&swap_avail_lock); > if (get_swap_device_info(si)) { > offset = cluster_alloc_swap_entry(si, order, SWAP_HAS_CACHE); > put_swap_device(si); > if (offset) { > - entry = swp_entry(si->type, offset); > - goto out_alloced; > + *entry = swp_entry(si->type, offset); > + return true; > } > if (order) > - goto out_failed; > + return false; > } > > spin_lock(&swap_avail_lock);