From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2291C021AD for ; Thu, 20 Feb 2025 08:20:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13F6D2802AF; Thu, 20 Feb 2025 03:20:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C7332802AB; Thu, 20 Feb 2025 03:20:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0E4B2802AF; Thu, 20 Feb 2025 03:20:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BF3212802AB for ; Thu, 20 Feb 2025 03:20:25 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3DBE6140D6C for ; Thu, 20 Feb 2025 08:20:25 +0000 (UTC) X-FDA: 83139626010.02.16069BE Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf26.hostedemail.com (Postfix) with ESMTP id BB939140003 for ; Thu, 20 Feb 2025 08:20:21 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=QIg+LWj+; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=eKrGz0YL; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf26.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740039622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eKJow/iLdwHBGL6Xrt+p45rH4F65miZVJkPE7qodWo8=; b=mI3yiZ3owh9dAR+ClzxBOoaqdwcJdedB7nLkOPXI+EzeSGfSDV9Q6pF1Mw9EVv4EHZupmk WOo2rTzEHWMKyo/8SMjnXCSBLaj0Q7fYz3is+bI4/xkiKoUGzgccofwdOdH4qWJeCK+sI4 s+HzOwonKlwprhulOV7IYqR+1xBGB9o= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1740039622; a=rsa-sha256; cv=pass; b=qXyEQXcacQaNyUFXng7kKT6TOcaEFK36cFhpoK83q34PItvUXk89DGjobE5Z1pNYvogDcp /IRwFg2CMBw61x9wBg+kMrBtvwNemstmcJ8T/wcMS1GksIAHzcgIGVx/LCd1A4ddwMDDVF 3C5wGCaHiaU5SRPiTilRW9JQgjFwjcI= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=QIg+LWj+; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=eKrGz0YL; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf26.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51K5fb7r012026; Thu, 20 Feb 2025 08:20:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=eKJow/iLdwHBGL6Xrt +p45rH4F65miZVJkPE7qodWo8=; b=QIg+LWj+DTT5ler/watGWREHNtsl/GGR9L AWBjEriTYYLpf7PBsoVZz+wOvhrjjFVQ2KCuxWWpIYXb7o32NX4PB96oqu8rfMjl wdzx2bOxCi+XjSAvxrjdbvgeo+PYNFvFp4yu4hlyGa/LviEPqyhZ4e7TiZmDMRUz I4INm9nxAb1sbpl8CfQLH34Wvs9pdr1NDyECeZETgnJrPw/5oaCZGJ67M2LQkYLK vSydxv52k/46nIc5s3RVUv+MVpiYFNDK7C7ORxlbf+N8aOj5Vse+9P1GIVreZAlz Gptgax8sPjDLLdwK2GRxwzSFBNR+rebGl8q9BznQaH1U0pMCfFww== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44w00pujp9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Feb 2025 08:20:16 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 51K8EqfG025255; Thu, 20 Feb 2025 08:20:16 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2048.outbound.protection.outlook.com [104.47.55.48]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 44w08xk523-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Feb 2025 08:20:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c/yDKl2GTIn7FjCRam5Mc0kI8GipKfc1zFZ3jv8E2yQW/uumauXa2XhshZ2d2dJ2fwvm+jyvZCNzdTfk5JkHSL4cFna87ZkHfm+LDGGz0kme6S8kE3abARawUmBwkB03bEEL/1nyRkIOKaKpsu2oVMIPGkg1KWDOwI9kG4VMbBwuW1xQS57Z5+ZtnuMEl7avL2MBDKilrToPgvU0Y8E+o+H5/PiCMyfAB+DjsqqhPfw3YsED2iI0JrPVhUHEwE1frhRw+WnDpaM7rKsX+hhHPJDBeGxyz/Lw7fGZPuAHjheyxBm/t6UFR8k6xLpz/zzJBDSHXjEBmrLKbzVXZFpa6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eKJow/iLdwHBGL6Xrt+p45rH4F65miZVJkPE7qodWo8=; b=FOGiJPm24nfUOA/weHCg+hvRCg7EsKMmnlgeW1eHnTojlpsd/YXTjNK8IGLQxB+vWnrfkQ0i75JoEkUSgEoB9D+bBB7ZYcekDWSEyidthyJYLVInVUmVToEPBguWae5vI9nSnoqwk5A+LPsI6s1SCIO58lW7DOt+GEDklGjxUhlm5CS1wXZSz/a2nudbcNDDxtqxOYllGFN42pLsoZibZyhDyFjVPF6HbDRuPbRYgqCxeD1rl9w7h0K1GXNr7Wznusx9LF/NW09LfEzzTPDFJ6rABKDVRFV5sQjNEiV1xXyQupLxfDDdPGoXwz1265JFuR2Dsd3djCDGEMLqRrTRgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eKJow/iLdwHBGL6Xrt+p45rH4F65miZVJkPE7qodWo8=; b=eKrGz0YLQiDpmRDTNsGNNsceZNyNycVFDb94er9tDv+r8KNeDpYsWAKiSkcBP74HUbByCq4PsohhWDV0byWSi5zFAXFnM+X0F7BCDEFB/IUnRMwR5ahPqmPeXyg9sPMhrAJ1Z/r6ZYjPoi2VJyDdUUjooJrHEvOjlPHmmgpR1dM= Received: from CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) by MW4PR10MB5809.namprd10.prod.outlook.com (2603:10b6:303:185::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.16; Thu, 20 Feb 2025 08:20:12 +0000 Received: from CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23]) by CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23%6]) with mapi id 15.20.8445.019; Thu, 20 Feb 2025 08:20:12 +0000 Date: Thu, 20 Feb 2025 17:20:00 +0900 From: Harry Yoo To: Lilitha Persefoni Gkini Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] slub: Fix Off-By-One in the While condition in on_freelist() Message-ID: References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SL2P216CA0206.KORP216.PROD.OUTLOOK.COM (2603:1096:101:19::9) To CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR10MB7329:EE_|MW4PR10MB5809:EE_ X-MS-Office365-Filtering-Correlation-Id: fd8ac8dd-f435-4227-97e4-08dd51876554 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|366016|7416014|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?zJ4/XihyLTQ6qSczQIdIeIiCiZwsR9/4y0OUnwyBT4DCBVk5A9XX2BHzSw3A?= =?us-ascii?Q?KdcLy8nHPawrcocvr/vrKiCUKbSTy+q4+tJTp7pAqnG183NB2F7n65BEpAVb?= =?us-ascii?Q?FW1J3nRV7TCE5NwEjnrpYhKFZg4YZLCujO2NIlwHGdVUYYWHDYn9ETiwmsRw?= =?us-ascii?Q?mZEJN7lTdzxhoOj6fnVaQsdAEo9lg/XZ2dcLvaeNmXLLKilN/YMExu4HurO9?= =?us-ascii?Q?I2k+xAm0hCCMUWXfvZreVY9qScXVTEmvPVv+CxeteW5xzIoretcB2atdgbBe?= =?us-ascii?Q?07WZn3DxTFiG/11sVjPx62eLBS2wFcQjdYUroGxiALO8ypPu77CcRP4WXu2L?= =?us-ascii?Q?MLMaZKiDcrAlQW+3kJk4zrt6fYCjAa0YBgvCZFEdD1D75qtmVnScRSMImWZD?= =?us-ascii?Q?PkliJUKiETjbPe9kuwJ3yyOffp12pwipIBCuZxdJEmmJavK2nv70BJ26X6Mm?= =?us-ascii?Q?wnV+ioPj2swmL5hkmTY9Sx34MOkAVbWYU9/RxrqrQN6QN5pPh9a2L1dHU1hR?= =?us-ascii?Q?xzIpme+HW+vp9yRaGIseCFQ/9AR0S88h14DDAu+ZxLCPJxBEWy6zwB15Fxpz?= =?us-ascii?Q?fNaPdCkCzthVbkgZvTjKyjSV6kAFQCpAvfqtwXicxYAIM4u1lasPw3GyGDzH?= =?us-ascii?Q?tzhZeJe1bZnNAdb2ak998vyHJLg2Q6ipHkCD3/LB1r4BTXgMXC76wCOU7+bh?= =?us-ascii?Q?2E4zTRH+uQwpNgDDI7n0lZ0MoEClDxzUE2uGY3Sd96gYpJ2Fbu6KjAZCH+gk?= =?us-ascii?Q?ksjLbTlJbOByNacLeqrfU9iIVeosy6fsyRjvaglE//mHsp1d+gIUDA9xOWdN?= =?us-ascii?Q?MUW0tqt1/jlg84ToLfqBtHqaeztJ2+4aM4uRZNqoy3BviRRiPa7eUi94VcCO?= =?us-ascii?Q?9fj29f1kVM8kziFjCDK78g38JQ+JjexmVGSILEiHvsS2fso+URfD5L61WPyP?= =?us-ascii?Q?kJ7lWk3ItYgDmsyuSYMnaSKCGlKImssybq10iupIzqdnSPANa9l5c/Hl2RUh?= =?us-ascii?Q?2+mYINS/fZ59ZM/rOPkei+qsmQbLa4gBgvqf3L8V/vXBVgxBCjtwagF2Gp2g?= =?us-ascii?Q?dDLz8O0MlHmGHW0I2pcCYqMZ9/CMerzrK4XQWm+5rowGkk1RpjIPqSbXbjdV?= =?us-ascii?Q?VWT4+5SDp4hYAAZGCAzVBX1VibZSmHtIHKkdX1SX3KNe3VXcCkqfwxoXu9fv?= =?us-ascii?Q?cNzVJIStneVwLBCHbNic7p/jNInDWQfU9282wSDwG+029shn7s+gJ9qwpNOZ?= =?us-ascii?Q?uqoCZX8CdZwTY6Lr85GlsJtPnuJaP365BRGgV+Przydfw0L3MYtpyuYQXUaB?= =?us-ascii?Q?Jy5StZnlKz4q0e4di82qtFroJ3QTb4GxiumSWooNiwbP8Z7kMLKnYJ7vC1Tg?= =?us-ascii?Q?qDB8I0WsUGtET3kJIyYC6c4ojYEM?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR10MB7329.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(366016)(7416014)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?forAEXR0wrmACJLdfyINudattx0+16XKtYNcRjD2f8VpGUgakdclAZjWIxi7?= =?us-ascii?Q?XLvO1ZVoUV4UKMsWFdVul1hcdrYP8hx4vtVVw2qY43hfQE9ManLppaW7Uq+y?= =?us-ascii?Q?mEouKDQtD88tZU87l8cVMzOo4PPn6uyjviABsomsJAOnXXO6FtpZu7vqKChI?= =?us-ascii?Q?IQDQOANgOvHobRoJoMIcbRtBqjdoP+d1c7QWndCHe/yA6zlJ28xcWt8qf+k+?= =?us-ascii?Q?HWQPkarlJNGWgPNmcL1738pB1lHdhcO5wMwbArdLp6XKEApQKKSLe8mAldFY?= =?us-ascii?Q?Oh6K6ay4rlpyJnS2mhb9uIrZMLIneml2evr/U44h+mX4lSc5hQAfoD6O3lZ4?= =?us-ascii?Q?NrTKFHgViIFKsW6aYMAT97lf3suSkfTU7Mf2g5I/iRu5ap8dsiungpvamZJE?= =?us-ascii?Q?xntMMMClTE+lxxLPBgdrQ2RwIX9bHtZjaOS9V69N7FuFZ2P41N2VCfCeluH/?= =?us-ascii?Q?SchgpP1rRuF5bqAWxCbhf2dOlau2L1xD0LI7KHHozJ+dZJ84qysOtZnwU+k4?= =?us-ascii?Q?iHOeB9VY4Zz8mUMt4PmqJn6zy9uYbFwpWUZ0pMBh+PAgmEqmNkpAo9mjMshf?= =?us-ascii?Q?uBoIxMtH7a38JDk/Ko/uN+uWA4akf+NfUplQ6GUAZWZr8bcXPP8TkxLTs/g/?= =?us-ascii?Q?9Xv3+OZUxf4oeuCNUbnOPtj/b2K311rcRMQfduvKGuC2KGjdQRag6298hT8p?= =?us-ascii?Q?2QVh8109jEqPIs64Q8U1FxI5xPHPsT6+qfbr1pY5iwRsVqlPSxypQ7gi+8XN?= =?us-ascii?Q?Rwzv/qbl9vZyx0d5Gl6siwjXrsXXgNTLL3Te78PTjczdAAgMCOzBYEOrAeq1?= =?us-ascii?Q?vgtj7bvD4MUg5TX4EujqBZDfYIIoCeBjujKYTMjtUpRyWBOARG7qpHpPySsi?= =?us-ascii?Q?15VXE34EC/eXWFJN65kf+kiLl9VIzD0ZQV6txSTR9QlJDh/EdI7+mjX5Ubhg?= =?us-ascii?Q?7Gmv7GMYS3Sx+gsgOOeOlSQ+DsNaM6Sy9fc+RYDDk0DrAVsL27QCe25hyHsD?= =?us-ascii?Q?CNbo1CsTIMwCB9EYw8p+0EM+zBnDDX3YSfbxmFbw9onKHIsylK1TNvStx2k6?= =?us-ascii?Q?t0lNy8QdUjvPAIMeGYSY7d5UiAw1ttXeSJji+krSVJ3Z9SLKO1qWXtx6qdHQ?= =?us-ascii?Q?dhUMQ7OSJSvFELL5nG+HTtoI9g4zrfkG/7xYC866CcP83M8C70WLrax8hF97?= =?us-ascii?Q?KHpyMc952CpRNPGE6qkOQZ6UCAwcX7muXWQXH3uB2AqwCj0Oer+OGDmyWg4u?= =?us-ascii?Q?dqXQdqg414ARlZahp6MLObPH4G735jTgS9yDBxjeg5fa39rr6hYOzq/j3bWB?= =?us-ascii?Q?ZT8kFQdGQqOG9JoW67f6C1YJTsnlXNnOsEQemfv/7RXZzisX/5TcU9bvE7Eu?= =?us-ascii?Q?vryZv12J2pTxR2QLrpotqEtVwgPLxe5rD5KofdsQe2nEhVaEEcxhWyoBIG3I?= =?us-ascii?Q?+CkiGAG/FW3NjUcot8tRlyxByN2hHiqXjnjXy7xLPlARCofmiEF9rfOkwR56?= =?us-ascii?Q?8R4yBk774JjD7SsY1Wn0XlBUe79fhzo1dkzvrNyhhgx4r/X0LacEtJmk/hnP?= =?us-ascii?Q?UCjOYSdBwviw533RCCEJtfpH44tbtRHcBwAMgjjaw/kWeImHZQa5b5e7G0F9?= =?us-ascii?Q?fdnqe/AFxzYxqAMNzAb8zQuOdNOJ6R+fNmU+nTSzvI2+?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: l80GQoJ23DxAFdpTc4p1TsEzZn3mEIldxW/UlctqTiJ13O3wcUxi08VS3dH2kSrFcE8jnemDGqYewifWnMxVM8ZIVwdS5YYxhborTGGGrLfVRQ+OGUv+/fLcVKXHneOqVFeSJ5h0x0qS/YaT3JkDZHTzYjR/P+V2pgG50JDd56LcfU5QvALL9em/o2DRSvlee+gKtHL8w3SC26hl9Edox8zjLhH+FCXpOdlmKV+ExEdbZuAQ5VEuiIkGWYCe2YcFaH/UFwUW6mHoqnXfmGTmuMEjwbY0cIM3wDMGg5FRfrNDD72JhwMnZCofjtKJ04ChQdlMNvAXpEJ5DQVINar4mMyAMg7GlSLTyMoVC4AOxAuduJg2dpptm/RmEjfWMisTsMt6IipM6a7/iG+RixK5+/XXefT8LjK1Sdp1JzdobmS3sQOOL3CJ2rQNnCyBuaXanzcZwNYoecDyauWi32camrrZ+SYJorOVZ2yw+s41gsAYkrjeVZr94u1MjTu8VRb9rja6FVyPNFwxh3PoMzObL9puaVupP1g9FEpmb9Cl5yDqRZvMI1mvY1Ny6BTkUVCfIMWk0fdF0zpszvGinkEskjNRfOpi54iwgWJtKiPS+cU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd8ac8dd-f435-4227-97e4-08dd51876554 X-MS-Exchange-CrossTenant-AuthSource: CH3PR10MB7329.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2025 08:20:12.0543 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: himQhiuQG+09PAJGcqNGqfmc6dN/hj5zq+ERW0n3ywmuJw1g+xEjbcrsf1yyXUBSqFR3n9e9MlKHR9XoIJCzwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5809 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-20_03,2025-02-20_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502100000 definitions=main-2502200059 X-Proofpoint-ORIG-GUID: zO9Du8LjIEisu7JBwZ6UYdBwtwW2xZjJ X-Proofpoint-GUID: zO9Du8LjIEisu7JBwZ6UYdBwtwW2xZjJ X-Rspam-User: X-Rspamd-Queue-Id: BB939140003 X-Rspamd-Server: rspam07 X-Stat-Signature: 4ms6rfozt8mwk56nqfig19k7tsw6mci5 X-HE-Tag: 1740039621-70733 X-HE-Meta: U2FsdGVkX1/1LloZxsjl8yN/g6HJvFpX1QE7kF7A3+u++hrQeaapE4jLxd1+AeCFLd6EMERU0Aj4Blsl3AdmsYEE3YFqXJecwRkE01khnnoGx4g5FGRpak8VaZu17GKutmIOMoLyIHlJpvyTzJ4Se4W0aMv3ZtydnaBj2g3Jm6vUQFVqjunzYGtqcaNjpl5AkxzBJn+PXpLyqNFJpyV1Bq/tTAKWMl37enQeyZ4io4NhnN7plnqal0ieOVN98D6r1ln16AhO58PD29AYplnRhA50BJFK44+s8jkSO8a5jmPsh+Ch5vr+wSpzXje4O2ohekOWxs/n/Z3SFR7NZlfFfwhqiow4ug4Nw4VBS+psmDP48DP7348Ah8anmdZKaQ+bsm27b72/u62Juiqz+ioI+vmCIivbOh/BN5XL7S5jfu9NhYvdd/AWZgTTzgXIY4yAyUu2qydGGhT70O65jYOohq8wWCVTnWCe9Lzp8Z2cxZK9navFOFjsx0ShwDqXHQDk7CtClNCgu2UdaozinNn7Hl4XaMZ1wP4fhKz3w8WnxZNLZIl8CwzuJpvbIwtO0ICJuOkFGbx9amD5gOXWRuPr76dUTtU2gu1A2MmjdCEciEwChpf44cCYo7OlPvfDFjgA/CGR/sbrNAZUWALf424+gGSNT+jgrHlQNfMr4gTFiEThRq1v+Gn5RnILIu/IY7ITW+jokNWWWi5YysBx+9Ck1OuqN+bkiYeQ8Bl0XOr9gXf2xWoxJGd/0oYIvEkHH09bkY59Xrm5/C2FgHm96NsZRsOEKLuv7q5ASjqA2DIUu41p51mtFNoDJq/YiKlHQ+ZaBs6IWiWR81Pe20aJ2k8MMZ2dZPQGj0KEp3tOh5Bnl2yk62Miri+2eDtJlVs2KG129VL2PbBqMGw/puWdexnQ2tzsRqHhQgzupFUfAZc9OQmf2PWXIh+kEnom7oiYuAsjRiPd9M0q+27HUL+D7NF KMRmcK8R deFQGhX9CkkzDS7zgQEmAs8ghxKmI2kR+s7grCbW5TirecrCdtV8tlpiGR2kHX7snuT8MPPSR+/ySUDMzSztmT4mlLDaMmlHoTng5yTtyErB3H9TPesFLhN446S89ImaNLH9vf2S1E00QOcWDEWYwvcnOAWRSKcN28sENUmM0yLpyuVobPW0J+SF0d47d9cwk5afXFcKKaGmjYDJrMFLqrLkJfTQoO9mNs4UkulsKGKQ6UndF6KMZC2D/R42gOFflIXKy2S9eOSlbDTMx6UHyuxHKy10JOjMdLgqyh3Q4beb4pplpg8kjzNeWC6QDCNzc4accUuEmGv9RALS3P8zgdeoRO1nNfT5zSGRczqXQcs6Nso8deznNaLShHQolnXXjCLQfUovLxs4pwgAEo3i+0j9DxdmEB2W9jPKzGDys0tHdShQxqfJKNqhILQg9J+UZkuUPHrGKPmi4NIDUqYd8Ksppemn5VOyoZyVH4c56fo+94EPeZLIeSPuQzjPQn/e/UqdT7yfz7EkxFh4TLyZfUkXtC27gBdaA35mcp5V9MMudpKcP4mwdWqme2SoCaINLbuzD/ftEhaCnrzCSId9q5Sy23zFJcjlJawWdLwvoFccGB72cavwboTsMRqsy/HX//IJkvAxWY/NWgDNOQcJccUQTieKe+yGk1iaAlioDLMa9ylIOEzTBkTKe2W9DKWzqVv+PCiFljpWv0nsWs2e60RQaOng7Dpg/wgJt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 15, 2025 at 06:57:01PM +0200, Lilitha Persefoni Gkini wrote: > The condition `nr <= slab->objects` in the `on_freelist()` serves as > bound while walking through the `freelist` linked list because we can't > have more free objects than the maximum amount of objects in the slab. > But the `=` can result in an extra unnecessary iteration. > > The patch changes it to `nr < slab->objects` to ensure it iterates > at most `slab->objects` number of times. > > Signed-off-by: Lilitha Persefoni Gkini > --- > mm/slub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 1f50129dcfb3..ad42450d4b0f 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1435,7 +1435,7 @@ static int on_freelist(struct kmem_cache *s, struct slab *slab, void *search) > int max_objects; > > fp = slab->freelist; > - while (fp && nr <= slab->objects) { > + while (fp && nr < slab->objects) { Hi, this makes sense to me. But based on what the name of the variable suggests (nr of objects), I think it makes clearer to initialize it to 1 instead? -- Cheers, Harry