From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F0DC021BE for ; Thu, 27 Feb 2025 05:56:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAF0A280004; Thu, 27 Feb 2025 00:55:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5E53280002; Thu, 27 Feb 2025 00:55:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C26BC280004; Thu, 27 Feb 2025 00:55:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A49A4280002 for ; Thu, 27 Feb 2025 00:55:59 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2AD2AC0590 for ; Thu, 27 Feb 2025 05:55:59 +0000 (UTC) X-FDA: 83164663638.09.12F0984 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id E2A33C0004 for ; Thu, 27 Feb 2025 05:55:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Fvb1Ijpo; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740635757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pjOMWKX5cZm5qqlTrleQLdM8yGGKiB75apGd9kxx0Nw=; b=qO1PostXyxR0pLQoEDOAa4RvBeJNMwDQ1YMVeHgGGuCjVpyNIqHG1CKGvWgahZM2x1RLBK 5HxjMNTCfNG7qiGAQvYvw6zQitYesOY9+lEWkoF53teuQLAgShC5a5lJUYxWqccypttz8z dt61OVzwtZRBFV3TDGy+JvCab3zceyo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Fvb1Ijpo; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740635757; a=rsa-sha256; cv=none; b=dOp/KyAKnRE2Gw7m1y/+9pA+8LJ6a7VE0AC4BsQaFmgjl75IzmbISaN9zwzs4QFVq9zOkt y6pxpALzDYp7zL7QeCGOUwUTCx4AQa6KIKI216b1/jup2Wmn08cesdI7KAQ3f+do+dRAn8 o6+und2T3nYmoO7ZlBPczL6Ptb2BuZQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pjOMWKX5cZm5qqlTrleQLdM8yGGKiB75apGd9kxx0Nw=; b=Fvb1IjpooHryAvRO8frQnR/6Gw ckfc+d6l49fRoOn8jCyXQ3r748XmMOUpZ1gUL80kulKaV58IiwqKAHnVBDhWkf0TEakaODpvJ5rC0 Mbhe+xnju3Pt+Nqu15PBSTDf88bdlpJPdpswwiKdMgKOPFQXMFAWX2Jc/Wuy9C9dmmciQZMsK0jTR eutzq8XFVm21VIoQnWvILTFLVHGqRD7wVBwNQT5zCXY88NjstC29Pdtwp3xzlm9r8B/hOekVxrgc8 xLWn+aOGYsxuA7mjQr/6PVlXukhtlCby+2bmftgNzt4fudlxkwIEUAAMjWD3ErLBSQg9ofGoFTTZ3 l/HVG+5Q==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tnWs3-0000000H2JW-0sDF; Thu, 27 Feb 2025 05:55:43 +0000 Date: Thu, 27 Feb 2025 05:55:43 +0000 From: Matthew Wilcox To: Zi Yan Cc: linux-mm@kvack.org, Andrew Morton , "Kirill A . Shutemov" , Ryan Roberts , Hugh Dickins , David Hildenbrand , Yang Shi , Miaohe Lin , Kefeng Wang , Yu Zhao , John Hubbard , Baolin Wang , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Kairui Song Subject: Re: [PATCH v9 2/8] mm/huge_memory: add two new (not yet used) functions for folio_split() Message-ID: References: <20250226210032.2044041-1-ziy@nvidia.com> <20250226210032.2044041-3-ziy@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250226210032.2044041-3-ziy@nvidia.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E2A33C0004 X-Stat-Signature: ownais5hcngwdeytzsywxouc71tqng6u X-HE-Tag: 1740635755-972221 X-HE-Meta: U2FsdGVkX19IvD4fGyQH7M1Zw3LLetKBUclLaEiY00PhfEkeRuKQ9JSDMqtqaaisbdosRHoSqtGHgEstP2dkU8ap0fXQSh0tncUDnWUFFjrOjb0xJjDaShRyyhnsAD7yLve2badoQ4mEB3hR7kvoLv2ZGTaFKEs8PmGnaRZhSs9qu5Vy+5nyuf9fdQvCKthFna+C8PVvc4TiocB0Xf6NEJmoC4d9AQmwAQ6Qqu7JfENS3whdYcZFmU5aEMi5+1lACIfgg4bSw0XtvC3W5pc1zwN/SG+PSzwRR5swW7FPnG2Bg4alx3uQ61NRyFfz6c6ll4dER8PrDzDZanfdU4Udom6m3EzgnAxlO7pZqmieUXDcAxulky6mBzrNuyNLmrtjgo7M4mWpt3HTi7pBcxj2qvThh88jiECxOiPNk0DTV5hA2QH3d0aW2Rtv9DsMIqJagV1KcSoFFui6DKQCEY2qXlvwrtil3pswARVNDeP1Ze54Mf9HRHSS9ylEytfQshj57rNeRLjGNXOBdLRa/YKL4XiuCfq6G3+keLiOcnUAsdrqZf29YHkArqtataOnpmoY8ySCwANoAtghH23Zwib/bb89Hy0+I1o77B6bDuoc/FshZWhFninCqG4Tyy3kgo3Ww4zbfIWvA86aEksJo1XZxNxe7k9+Gr3NuNGhRLDiLaLfqMUS2yaB4ElwxBia2DJs1vpLa9tz+7/9Klt8kovW+i6YdoheGIt473OYVBXXGBMHAhkiDcz4piaMU8US0BUYiCKXs0ef1CnNAOQ3TebXxpPrYVV7RuwdNuELifFfbO0WPadtA2yAqFIDeYoI/aaj0Au7AzxDaLAo95MAJxKUjIXahFLC6l2KVt8VngNfDUNLGtbZ+D21fLsdORbZj+ycKBaHViEJRUBaXlVAE8Uat9Wqnp+v85ezSRW3oME9VhXZthZV56ElLbM22iCtNmqSvH7jS62tZYrvbrwV6Z2 J0vVOs6i JpsU3Ge8mX8oQAiyeUTgWgk1YFYke6tTdttIMXGdD+ZYNtD2dS3TW4HIjFReVBz6CkWvWqGsnoRhJI26lGbMBcZ0U1jEu1QwKx/eK5i+WC6m/pEEOlCNiUdYd9ysLmQPxTB2W4Whu9sb9JL94IJvT6hJhmP/Is+aoeamjtRvQGir6xc6q+spY9C6VyrMS2kYgiSXqx2rGHxk0p03THcFIibMJUh762zAoamHvXtSnXxuUpKoyLawS8HyfBpB0C/35mTONxWLyuBKuZNdGsdTenzOvEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 26, 2025 at 04:00:25PM -0500, Zi Yan wrote: > +static int __split_unmapped_folio(struct folio *folio, int new_order, > + struct page *split_at, struct page *lock_at, > + struct list_head *list, pgoff_t end, > + struct xa_state *xas, struct address_space *mapping, > + bool uniform_split) > +{ [...] > + /* complete memcg works before add pages to LRU */ > + split_page_memcg(&folio->page, old_order, split_order); > + split_page_owner(&folio->page, old_order, split_order); > + pgalloc_tag_split(folio, old_order, split_order); At least split_page_memcg() needs to become aware of 'uniform_split'. if (folio_memcg_kmem(folio)) obj_cgroup_get_many(__folio_objcg(folio), old_nr / new_nr - 1); If we're doing uniform_split, that calculation should be old_order - new_order - 1