From: Matthew Wilcox <willy@infradead.org>
To: Zi Yan <ziy@nvidia.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Hugh Dickins <hughd@google.com>,
David Hildenbrand <david@redhat.com>,
Yang Shi <yang@os.amperecomputing.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Yu Zhao <yuzhao@google.com>, John Hubbard <jhubbard@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Kairui Song <kasong@tencent.com>
Subject: Re: [PATCH v9 2/8] mm/huge_memory: add two new (not yet used) functions for folio_split()
Date: Thu, 27 Feb 2025 05:55:43 +0000 [thread overview]
Message-ID: <Z7_-XweaPpfdRz1h@casper.infradead.org> (raw)
In-Reply-To: <20250226210032.2044041-3-ziy@nvidia.com>
On Wed, Feb 26, 2025 at 04:00:25PM -0500, Zi Yan wrote:
> +static int __split_unmapped_folio(struct folio *folio, int new_order,
> + struct page *split_at, struct page *lock_at,
> + struct list_head *list, pgoff_t end,
> + struct xa_state *xas, struct address_space *mapping,
> + bool uniform_split)
> +{
[...]
> + /* complete memcg works before add pages to LRU */
> + split_page_memcg(&folio->page, old_order, split_order);
> + split_page_owner(&folio->page, old_order, split_order);
> + pgalloc_tag_split(folio, old_order, split_order);
At least split_page_memcg() needs to become aware of 'uniform_split'.
if (folio_memcg_kmem(folio))
obj_cgroup_get_many(__folio_objcg(folio), old_nr / new_nr - 1);
If we're doing uniform_split, that calculation should be
old_order - new_order - 1
next prev parent reply other threads:[~2025-02-27 5:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 21:00 [PATCH v9 0/8] Buddy allocator like (or non-uniform) folio split Zi Yan
2025-02-26 21:00 ` [PATCH v9 1/8] xarray: add xas_try_split() to split a multi-index entry Zi Yan
2025-02-26 21:00 ` [PATCH v9 2/8] mm/huge_memory: add two new (not yet used) functions for folio_split() Zi Yan
2025-02-27 5:55 ` Matthew Wilcox [this message]
2025-02-27 15:14 ` Matthew Wilcox
2025-02-27 15:42 ` Zi Yan
2025-03-04 11:49 ` Hugh Dickins
2025-03-04 16:20 ` Zi Yan
2025-03-04 20:29 ` Andrew Morton
2025-03-04 20:34 ` Zi Yan
2025-03-05 21:03 ` Hugh Dickins
2025-03-05 21:10 ` Zi Yan
2025-03-05 22:38 ` Hugh Dickins
2025-03-06 16:21 ` Zi Yan
2025-03-07 15:23 ` Zi Yan
2025-03-10 8:54 ` Hugh Dickins
2025-03-10 15:35 ` Zi Yan
2025-03-05 19:45 ` Zi Yan
2025-03-05 20:50 ` Hugh Dickins
2025-03-05 21:08 ` Zi Yan
2025-03-05 21:49 ` Hugh Dickins
2025-03-06 9:19 ` David Hildenbrand
2025-03-06 16:27 ` Zi Yan
2025-03-07 17:46 ` David Hildenbrand
2025-02-26 21:00 ` [PATCH v9 3/8] mm/huge_memory: move folio split common code to __folio_split() Zi Yan
2025-02-26 21:00 ` [PATCH v9 4/8] mm/huge_memory: add buddy allocator like (non-uniform) folio_split() Zi Yan
2025-02-26 21:00 ` [PATCH v9 5/8] mm/huge_memory: remove the old, unused __split_huge_page() Zi Yan
2025-02-26 21:00 ` [PATCH v9 6/8] mm/huge_memory: add folio_split() to debugfs testing interface Zi Yan
2025-02-26 21:00 ` [PATCH v9 7/8] mm/truncate: use buddy allocator like folio split for truncate operation Zi Yan
2025-03-02 3:52 ` Zi Yan
2025-02-26 21:00 ` [PATCH v9 8/8] selftests/mm: add tests for folio_split(), buddy allocator like split Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7_-XweaPpfdRz1h@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jhubbard@nvidia.com \
--cc=kasong@tencent.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=yang@os.amperecomputing.com \
--cc=yuzhao@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox