From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59E6FC021AA for ; Wed, 19 Feb 2025 19:16:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDE83280264; Wed, 19 Feb 2025 14:16:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB63628025B; Wed, 19 Feb 2025 14:16:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7E26280264; Wed, 19 Feb 2025 14:16:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AA58028025B for ; Wed, 19 Feb 2025 14:16:46 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 406D1121C28 for ; Wed, 19 Feb 2025 19:16:46 +0000 (UTC) X-FDA: 83137651212.17.A6D75CB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 7C05D40014 for ; Wed, 19 Feb 2025 19:16:44 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739992604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qaaRKLnwowLUOhk9r6os3DHgnj1t7KEIhY5aO6KePhk=; b=jpjl6cyKwgukRlNIL4oCumL6PUsT6112bonB/6Yjy5+66gs+yebFGQZgn66fpXHmbFo/rh M3qilV4V5U3St7yE21y6eKdVgX7yYUJ2QOvAJJpFsU6KMvfmUf517/1Ybb6c5TFVir7dT+ y71hJKCDTNd0MUyC2CBtgucfUEwWe3U= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739992604; a=rsa-sha256; cv=none; b=kwL9BwVJOhtmFAgb1d32ubmTP3kZfN0AavIzWNxr1OiTc/Xta1HUu2WKztWHBXuUp1uaCa n3Is0RU7BwFGfLbjjKnyIainVmrSv5bUa8xhCBy1qD8Vp2npurcL1MmB8ryiYTIibs2AGX 0e8BJM7AeQu7b0PaGFCTTubOmSkiGGQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3BD4B5C5AB0; Wed, 19 Feb 2025 19:16:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B914C4CED1; Wed, 19 Feb 2025 19:16:37 +0000 (UTC) Date: Wed, 19 Feb 2025 19:16:35 +0000 From: Catalin Marinas To: Greg Kroah-Hartman Cc: Naresh Kamboju , stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, hargar@microsoft.com, broonie@kernel.org, Linux Crypto Mailing List , linux-fsdevel@vger.kernel.org, linux-mm , Anders Roxell , Dan Carpenter , Arnd Bergmann , Herbert Xu , willy@infradead.org, Pankaj Raghav , Yang Shi , David Hildenbrand Subject: Re: [PATCH 6.6 000/389] 6.6.76-rc2 review Message-ID: References: <20250206155234.095034647@linuxfoundation.org> <2025021959-koala-flypaper-1ad5@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2025021959-koala-flypaper-1ad5@gregkh> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7C05D40014 X-Stat-Signature: u83r5xcucqcxgfudh81c1gj968oahk8z X-Rspam-User: X-HE-Tag: 1739992604-912720 X-HE-Meta: U2FsdGVkX1/kAh0UXGd5sRgMDi8X33knixF1ePe5lk0ikg5TJOKluLQImrPLV366n91kSH5SGIDzVUuep9tpz+SrZrMdvc3qMmVOGb0BoA84xS6WiQqUVep+t1HJUxOzCQwQqoiSbKgU/vQz+r9QElVe56TDO48UBsNVEEuInw6x3lMQVWv16N6Mg9q+z/Boma4pAlOFjWc+Lw5HSEnQOf8HVTNz2VWOiE2uMDjXINbeQUxzHykDgOgRds03MvsEmacH5rNIlLE1YZOr612oJJ0oS6bvCrkGcBAwEMWdd4JcYYeHeKfuBfrXrWlTin4MLZB7bn3EP4rvpWoeTlBET9k517rvgUDPXvjzJVw34ve4qv/fkSwENm5J1rX/cwxPSKpzV10/8YvMsnOCasLmEvlfoZOO633GL4Qr833IxavFMyRWmC79jtwvbxjWObbj6cXEuYU6WkIEtR9KooUlBdOsGtSGq6OiE45rqGPt37Byg1ZBbgqFU3oPvV5KJdVXCea5GEqnh482WrenOWZSHw8wgSh+GEPF0dPwgaqEFzK2aVPRzKEPKUsMYuEc6RBb4PCi/osCH5UEFkmtKoQAyk+KgggLr2nEzkYAy3AqScL4AJX4iq1qXDM+GtCm7L4vhoe3qPyU0a9O4GBM9ezvmzPDoH/l3HfadRBvVMM/yrk8+Ajx1BM7aKidCtstyGYvMCnH6YHQrQCXKnH22FdGCMa3qrMuGkeY83tkrpwUcf0CW1GOiBHt2PHzeewg8YRPOQKGDtP5RTZbpLE24PGYl2eh8PM9UdgQxO76ZLPOHYDOUNpOOrAtBri3H6Mjp3w+PX1+fzYb02J4Wt88KSI5ozgQFKSbpSy6SrRRcfhEVuIkbm8ek4Y52WpDnE0dAJh2a9uY5a2zUOjsSBM5QYHgUnZBptrnvwed4yOjvVD8pPklpLrhGt4Uq8ZjJldJxvCa8XNqUexDVvhVcwmH2pY X4yfROpJ Vv0biuftYsjJ2AXB/UQyYf+Ph0qTZoCnB5DNBL1PlKb/aUthikydaTTDNBNFDnOm1o/Zm0Os+Kpiq4lAMiK3Qi1opir3GuzjwiDiQTrCK2Y+d3VTik6Cf++ptsxEXXtVJMAx0e+wpdFDU9fUHL5r/VsHeOrpME200iDk1FDEh45FUnwBxBwT1TZUGYtWnCoWxIDQX860t/GnvbO388RMGFk44mJVgVtjHYD8AklmcUVXyXXwVB901M+D1sIHyMRDUndQQB6dtnEAvbFa6uwwoKL+Yz40FO8uG6bYDyiQbka06Dcb+t2HH5as7ahZQ6+gjKn1KcS1NC7t7TyLPdW8A9tWQ1DDL4abEGjakiwz9wJDtloR0BYq5ZOeC089gXjGg7UWwZckbX7uPt/7kzAwEwlFaTD3UrTy9h4eUqMUaRdRCgTY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 19, 2025 at 07:09:26PM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 19, 2025 at 05:18:24PM +0000, Catalin Marinas wrote: > > The problem is in the arm64 arch_calc_vm_flag_bits() as it returns > > VM_MTE_ALLOWED for any MAP_ANONYMOUS ignoring MAP_HUGETLB (it's been > > doing this since day 1 of MTE). The implementation does handle the > > hugetlb file mmap() correctly but not the MAP_ANONYMOUS case. > > > > The fix would be something like below: > > > > -----------------8<-------------------------- > > diff --git a/arch/arm64/include/asm/mman.h b/arch/arm64/include/asm/mman.h > > index 5966ee4a6154..8ff5d88c9f12 100644 > > --- a/arch/arm64/include/asm/mman.h > > +++ b/arch/arm64/include/asm/mman.h > > @@ -28,7 +28,8 @@ static inline unsigned long arch_calc_vm_flag_bits(unsigned long flags) > > * backed by tags-capable memory. The vm_flags may be overridden by a > > * filesystem supporting MTE (RAM-based). > > */ > > - if (system_supports_mte() && (flags & MAP_ANONYMOUS)) > > + if (system_supports_mte() && > > + ((flags & MAP_ANONYMOUS) && !(flags & MAP_HUGETLB))) > > return VM_MTE_ALLOWED; > > > > return 0; > > -------------------8<----------------------- > > > > This fix won't make sense for mainline since it supports MAP_HUGETLB > > already. > > > > Greg, are you ok with a stable-only fix as above or you'd rather see the > > full 25c17c4b55de ("hugetlb: arm64: add mte support") backported? > > A stable-only fix for this is fine, thanks! Can you send it with a > changelog and I'll queue it up. Does it also need to go to older > kernels as well? 5.10, that's when we got MTE support in. There may be some slight variations depending on how far 5baf8b037deb ("mm: refactor arch_calc_vm_flag_bits() and arm64 MTE handling") got backported. This goes together with deb0f6562884 ("mm/mmap: undo ->mmap() when arch_validate_flags() fails"), so they may actually go all the way to 5.10. I'll prepare the patches tomorrow, give them a try and send to stable. Thanks. -- Catalin