From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B6C6C021AA for ; Wed, 19 Feb 2025 19:04:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1271B280261; Wed, 19 Feb 2025 14:04:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D73A28025B; Wed, 19 Feb 2025 14:04:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBA62280261; Wed, 19 Feb 2025 14:04:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CAC2228025B for ; Wed, 19 Feb 2025 14:04:17 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 748E01C8033 for ; Wed, 19 Feb 2025 19:04:17 +0000 (UTC) X-FDA: 83137619754.26.97DD13F Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf05.hostedemail.com (Postfix) with ESMTP id DC45A100007 for ; Wed, 19 Feb 2025 19:04:15 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of cmarinas@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739991855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vm03RGeRuGpmRXgI+OezaiNu4LYtVZ2+Q1or+FmDUnM=; b=3pN4VzonWqAmVTF/SF+9XZCTSoS4OTXpMiYJ7geXc2L/xd3WOJxx4h376wvxoli/NqjGyu PyCIOjWraRZL1zsHV9O0XoWU8SMwTYcGQAbMUfFWbXvrx2h3CTLqASMPGUK6yN//Ql2fHd omsuGvRpwBoFfpws3uH4b+fhX8B70ZI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of cmarinas@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739991855; a=rsa-sha256; cv=none; b=Rylr6rSIdgvpI44aJFNdIUpUb8FeVZdGIEy50fhksw3LbtNg3ssCs8iB6f0ag+kuMORzhZ cYnnYtjEfzKsp++Evjqs2WiIfGr5sqYScRhYhy9egy0ZHfE4vM6o93iz5x6mXglXt+u3wT GImoRwvclZT2cwzobOpXXAgWg9qKSHc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D28DD61131; Wed, 19 Feb 2025 19:04:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB9C8C4CED1; Wed, 19 Feb 2025 19:04:08 +0000 (UTC) Date: Wed, 19 Feb 2025 19:04:06 +0000 From: Catalin Marinas To: Ryan Roberts Cc: Will Deacon , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Andreas Larsson , Arnd Bergmann , Muchun Song , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Dev Jain , Kevin Brodsky , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 3/4] arm64: hugetlb: Fix flush_hugetlb_tlb_range() invalidation level Message-ID: References: <20250217140419.1702389-1-ryan.roberts@arm.com> <20250217140419.1702389-4-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250217140419.1702389-4-ryan.roberts@arm.com> X-Rspam-User: X-Rspamd-Queue-Id: DC45A100007 X-Stat-Signature: rs5fdfu7u5z6gxtweo95bieqbdo6o5mc X-Rspamd-Server: rspam03 X-HE-Tag: 1739991855-341328 X-HE-Meta: U2FsdGVkX1/pdBktbJGBg7H3+iPhDaLZdevsyhi/K3H1xonWm4knP4WhRl3gLpC1y9LRkt4EFAavJFLjzIvOHVpZANaOi4IyEvIoaTv2z0G3lTH2MgrtsMf3IQPAXYnLzvBqyLAWtrwnF9gw+V6XY/cA/9vINEY7/esPyXeamfYVY1MqoEFInRegzySAD0LD+HLgGFHuTla+28HK0kqngItpDKXI5HHfI6S4g8G/N7U6+OFxTsHzt9ZEdNdGeBJc38YkC0uW+4xwd3Uk4dhoKX4UTYPvBgyOHsK7nf9dq/AaO3QnZQohPEIMP7DA5PZBbORiEFqDKLORdWj6f6mMtvRhkhyctk+PSvdQ6p96U3mXITGwI2hISTZUx0txKkXRphxMdwyDDgIB36VXswPVWr4JRcphcDcWGtwdY5fH7qjv2mezprdz/Rzqf7xCTLPCqw8NEsy7iXk1zxvaOZ5lBG4veOgtqE0Y8i6L0Vznp4OIsARHEFXIf6BUAH+3u8AMQ2HGHykDGEWCRjxCgHQtZeZJIuEcB8thU4wSuKOhqQrZa1Cn6SbcCE/f37Pi5oWz0h85pU1PYdVIfVYmL7OjVTCw9op9h1XMsv4fys05y4VKlTJHrCvbUN+u3U+DuamNTMz+Irmz1BvPl9mm5IWIYm/M0yj4/SFLg3OgY9l16x1MzbtiRgZM+gyVmbIup1DN7qaOImbXEYdLRr3hhib+QdxYpGMXOrWzC88d9UbxJZbLMmMf1xJhR43JiFuMyNTnbv+C660SShL2LmVt1L5PiprjX10gL3zBfY2Gc+TFXpznokZGvJeQsdqsmrsUH6W5Xfu/NcI+pCUZESS7agOITZMqAm7sL4kRhtfVsozyIB2HZm6FE6ljHoFnCupFcPmUynTxaiiGUqbkFT+I47z6qO92NasFw91Zv3G/8V1oCWbgvacyQKtbEQVO9xKj0Ih+1SRN56yhD5ZJoiK10Rg mNmrbjHm M41Bbdd8bIo8v4dM3+9sCPRNZX+mOgEIqTEiKJqFUKC9BOJ4ls1T33nlYL4M3V7ucdHF9QD4DPiCMQUfGfUN5v5wKN6WLh/hU7lKgT6wLbbhw9/soyJiTQ5kRYEyx3hqjA9PmK7MjrX2PHHGrR0df1kGYUOVtDEihfGf46EJ7aNcNwC7qjQvfTrdTDADaDtOxDAzxpBJR1AzXmiGBxD1jDfevBWPouF3E4M3NnqyOyq+OoFBaNGN2xQN9z3Prnb0XoYQdxO2nRQfACS47jVYmfkRwxAVc5VHoOB70J1TQjtyzOCQFfcOvxDnPhuT15LO327VwXRxH02auBTpcovkNCDV3+5dK4j48eopChdgRMc58hQ6NHbSPvboRXT2X7kkoIPIa9qpRyjT+XpqYBH1EnVmfTXWkuemX5velY2AEnVh1q01ACgRNUzigdPS5EZTZPRClXx/IGJsi/arBBB3s9b3xB2fVTtbqAUbR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 02:04:16PM +0000, Ryan Roberts wrote: > commit c910f2b65518 ("arm64/mm: Update tlb invalidation routines for > FEAT_LPA2") changed the "invalidation level unknown" hint from 0 to > TLBI_TTL_UNKNOWN (INT_MAX). But the fallback "unknown level" path in > flush_hugetlb_tlb_range() was not updated. So as it stands, when trying > to invalidate CONT_PMD_SIZE or CONT_PTE_SIZE hugetlb mappings, we will > spuriously try to invalidate at level 0 on LPA2-enabled systems. > > Fix this so that the fallback passes TLBI_TTL_UNKNOWN, and while we are > at it, explicitly use the correct stride and level for CONT_PMD_SIZE and > CONT_PTE_SIZE, which should provide a minor optimization. > > Cc: stable@vger.kernel.org > Fixes: c910f2b65518 ("arm64/mm: Update tlb invalidation routines for FEAT_LPA2") > Signed-off-by: Ryan Roberts Reviewed-by: Catalin Marinas