From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A45C021AA for ; Wed, 19 Feb 2025 19:03:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F307D280260; Wed, 19 Feb 2025 14:03:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDFCA28025B; Wed, 19 Feb 2025 14:03:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA82F280260; Wed, 19 Feb 2025 14:03:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BB24028025B for ; Wed, 19 Feb 2025 14:03:53 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 68177449B8 for ; Wed, 19 Feb 2025 19:03:53 +0000 (UTC) X-FDA: 83137618746.14.D78B6B1 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf09.hostedemail.com (Postfix) with ESMTP id C5F6514002D for ; Wed, 19 Feb 2025 19:03:51 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739991831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9N8uhomNrvqZSlje3nDu3cVu6aGtjAz3Suivv3MB7Dg=; b=fCdgnSK88z6bGZFP5YIGaA4GCbwUWW6RIyJI37fdaIpVKnpRRWu4jwKcxQwfdNgQRv0J5c 9FXgstUmsYo3h1iI5E+ddl9o+EZSTeqLBmdaBFGTQjJDNsqLpMtssjTaQc8BdGgIw+JyGa 05TA89KurTz4FTgG0HdoY64yLi/iKA4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739991831; a=rsa-sha256; cv=none; b=nJC/aLOGkVBwR8LVNz46blcT3LdN5It+KT9w4MUuw7Rs1pw6HlsfSlzKOP09ueXe3R8V0T Eq6/XwVAFoHlynKWiS9yP5myEpr+BhXsqoj6OkoppSv9kgrCpQIP9z3hqDdZbroRoHBxpw 9SrTDAWhRnfKzkv9cOpkRVOQu9BaQ6s= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=cmarinas@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 022446114B; Wed, 19 Feb 2025 19:03:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13436C4CED1; Wed, 19 Feb 2025 19:03:43 +0000 (UTC) Date: Wed, 19 Feb 2025 19:03:41 +0000 From: Catalin Marinas To: Ryan Roberts Cc: Will Deacon , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Andreas Larsson , Arnd Bergmann , Muchun Song , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Dev Jain , Kevin Brodsky , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 2/4] arm64: hugetlb: Fix huge_ptep_get_and_clear() for non-present ptes Message-ID: References: <20250217140419.1702389-1-ryan.roberts@arm.com> <20250217140419.1702389-3-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250217140419.1702389-3-ryan.roberts@arm.com> X-Rspam-User: X-Rspamd-Queue-Id: C5F6514002D X-Rspamd-Server: rspam07 X-Stat-Signature: hbamfq9rn4p5i4863xzmemxowdye8ixr X-HE-Tag: 1739991831-335957 X-HE-Meta: U2FsdGVkX1+sZ6aCcWRbv3HtUP/h94wce411DiYZDRYzHIGK5sugFnRmdvraFFH1TMGSgu98AI3r4oY8pcJLtmUrt2+XMionqljPNnsBCIrcioKxIEeN+xjP4vUwDQaPOQp1/DKSRSqshbxqwnDWfmQAw+WYOb2LQDt9cDiQpoaEQiq+xrXjWG2lAirnYbPclFtB2mR6rxiSzRVqY+LtMWsCz+QHwhGWhzI4GJKX98S4NqH2NH4WNfrMnA+WTgE0K/k4Vjxdf2daWDdUPdzNzJ5vSdXRuVT9elGw2f5e0+mv0Exnm53iR5gxwClNGFv3LA+2+5yRKGDKJb6917VEVfz9gLzzYKq23U6uNLWusDggArh4eJecC630tiJNBztshLvAvpXCjq6tmXNPO/sGOp2UITcH+Dq60RJzet8VNB9oCfoFakcOxeAbnE8x4amwj+Ip4jmgGXqn5BLsbpYGsLnq0OhDjo89Cr+WXMVoxzdIzc8Nv4kBoxyUm0ZENa19oMKEMLzhZGfNwZssZjB5UAhTYolsRlHcSJCqP4+HmYDnkkIFwpM9ZsTVoKhCfVDD29X0EXdQ18JwMw+JajS8lpbubze1fiswoq/gUw3yiD3BESAgtDBaUpq/1dNDGS1/yYw0HQFb4yvgDCW3rRtoB9BijfqK//vPuFIiuZbMIbsERi+HMog5j0r2jSLjVkz5dZN0rPbQbYw/huv7anPYdIhGfsTIdLDTYP7wnvg8wwedC0SACKP9ZMHCtPq6+xOcbk/xNIcanp3ynpzM8tBNzGS3PVD2t+A3ah+OKRUV79ophgWAY5FzkDEZnvdnsX8gcUyod7VaHYSZTMqKCSq8CNzPY21YKd/3iRAdHYSKG6pHk3z6AU4j8pKbWiTRjAULIEXffGAK80U9OB2sJWMqNLT9nAlf2pxXHIuIvhHNEcuCV9U/GHFsFRTvv91nqLyzu69ePlGg/g5qsylEzxs FfDd1oVl Vsjx85kdjKb3FEDZnWnhHVEpG57vS747cazRKr/Wpr8m9vKE2e9PAWaDLd+SSrxlicjTipjTF1jsVRhcuWyH8meBHuOcxJaXvjXEVLj6yBzSR+aSmJOsKRopEl+RKNiMFTeGHfqqXKfNImsbLtw4YJCJGZtHsFx7KGWi7ALK/GatQt3Ok/PN3SUob7OhYvLnFqvHNK5YiQ9aIl2FEcd+QPw9O/bKncqKqgkU3ao7HOOBNZhDZYXjSVmPU4IExELK1WihWg68qWeib9omcfSkvry98f2QEbhmH3gnWSZ7Du+grQIAIuY2I5MOu990xZhFodcVSc8s/UlTJPpK3Ba91CI48P9e5UrMKOUcTtdOddcrj3j6e9wde7aRaCWR/PbKxxpgVqTweRhlafrgJMVsc9yYI0JIX0qNCnbRRj9EHBq0aYoTgbbWuEh7YTiNYcO9Qaz2oimHg91TDO00= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 02:04:15PM +0000, Ryan Roberts wrote: > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > index 06db4649af91..614b2feddba2 100644 > --- a/arch/arm64/mm/hugetlbpage.c > +++ b/arch/arm64/mm/hugetlbpage.c > @@ -163,24 +163,23 @@ static pte_t get_clear_contig(struct mm_struct *mm, > unsigned long pgsize, > unsigned long ncontig) > { > - pte_t orig_pte = __ptep_get(ptep); > - unsigned long i; > - > - for (i = 0; i < ncontig; i++, addr += pgsize, ptep++) { > - pte_t pte = __ptep_get_and_clear(mm, addr, ptep); > - > - /* > - * If HW_AFDBM is enabled, then the HW could turn on > - * the dirty or accessed bit for any page in the set, > - * so check them all. > - */ > - if (pte_dirty(pte)) > - orig_pte = pte_mkdirty(orig_pte); > - > - if (pte_young(pte)) > - orig_pte = pte_mkyoung(orig_pte); > + pte_t pte, tmp_pte; > + bool present; > + > + pte = __ptep_get_and_clear(mm, addr, ptep); > + present = pte_present(pte); > + while (--ncontig) { A 'for' loop may be more consistent with the rest of the file but I really don't mind the 'while' loop. Reviewed-by: Catalin Marinas