From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF3EC021B0 for ; Wed, 19 Feb 2025 19:07:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 597A144017B; Wed, 19 Feb 2025 14:07:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F912440179; Wed, 19 Feb 2025 14:07:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C09844017B; Wed, 19 Feb 2025 14:07:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 20215440179 for ; Wed, 19 Feb 2025 14:07:25 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D08E6160327 for ; Wed, 19 Feb 2025 19:07:24 +0000 (UTC) X-FDA: 83137627608.01.C5D2781 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 2F7AC140021 for ; Wed, 19 Feb 2025 19:07:23 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739992043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w5oOzMK2JlDQqDWdY37veBc8sIrd6Hyk8XP3lPFCDLs=; b=w/S6rGe1AJ9Hl4y2X5VRp6pT9dQY/+x3HoB5/qDVJrMn9YyfkvhkoG05JoT+YIZYmPYVhf CbQUQPKq1/SpRwUucXlkR4xTW2eQ95DuIL/kxG+a80+8tzxgbR5uh1tNR8vRtNNWA15KW9 BWUnNzqAUztFebHEUKXZEe1huAvwvZo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739992043; a=rsa-sha256; cv=none; b=6jT1GT0Qt99jCN1Tjg6o1T0M8HKj4nKyfszGG3t1DmqOZa+c5LG6/RQKMinoq/AHL0WfaC uD8zgpHfJKLEon5YIrzxt4LVRZd/FRd0bXudRAo6TtA4N3veaS+3dm6lHRhXF8oKok5fHX WBJwXtaqPxeM4EkhIsbEuVkYyLAJIho= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B48D85C5C06; Wed, 19 Feb 2025 19:06:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CAF3C4CED1; Wed, 19 Feb 2025 19:07:15 +0000 (UTC) Date: Wed, 19 Feb 2025 19:07:12 +0000 From: Catalin Marinas To: Ryan Roberts Cc: Will Deacon , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Andreas Larsson , Arnd Bergmann , Muchun Song , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Dev Jain , Kevin Brodsky , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 4/4] mm: Don't skip arch_sync_kernel_mappings() in error paths Message-ID: References: <20250217140419.1702389-1-ryan.roberts@arm.com> <20250217140419.1702389-5-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250217140419.1702389-5-ryan.roberts@arm.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2F7AC140021 X-Stat-Signature: bophi7jri5hky9p9hds1mton7wfbe97c X-Rspam-User: X-HE-Tag: 1739992043-929668 X-HE-Meta: U2FsdGVkX1/NIYLyoBWSeeYqx5JY4P2o4IDtAs8dg+egjC5HZ3bqr/2YgqDwLnO515+pKGNSYLAPziityFE3FKXWeZPQNaeIRqsJd+kxNB4zjjbkjl3Fch+RunhQXWvE7scjltSkoFByWoLzcBaQlZl0zNL437oBIeeLzrryaqOnt7D++WtEoAEoQnuV24sY3f2GPnlFTyHHjAOlJFHECqupWAY1KFcyqWN8DZfF2vnRk5SSQZQwmZQ7tf5ztV7TTQZMfhfBBwIebV2ikC/wgCk7SvqiPeEkt5Wf3++TLgb+Ptt9XfuJZRXmCvt/2vrRW6II2d4ASK7vltH9VcNqIvM0k2E2Ur7U7KySMumjbnd34o5oUJFkG4NGnuEKhrbV5L5/rnjwTQfv9Thjd/tM2Sk2dPJj4fBxk/2I7NEYjWUWvkWg7khD6W5cba4TEdjqk1DZybEokiyIVICKAQK/r9guZXqKZu3PcR1wf7bn0IK61ewluS7p4mJHpQdqU7veGYuPyXIZz/nWo4KrZqHWzueIUdYSLdJxGrDm125Bge8BSUrcdEXAxRXFHv1AV3frZYE9YE+KwrY875kRll+/QRYzp4v1fddvPtD+UMRSbG7NY1C/wtW6U8l7oZ5OqDc35vYFzDT5ZOA5qfoO+jdDy3miGOYnVX88czSsprAebrV8yMbppo64RSybbPu0E9h9b2+IHLFhOs9xW3vDOY6R3eunQwAUdQeab5ORvwCe3HTPRPBm3Vxi8s+TxLPf9qN1P3rwtw9hLFHOdda0dcKGztIt7h9rhRQZe5e2dSfhl5di3UbCBXCgh8IZpzsFrh5Q1fF4MAEKVem2z8LZObFIwsG9C/DqARcw1/0pMh0jxG2yS4SKlDZf8t2M2JE3dKygcEb3l+h4PbFKVWVSoYUtD9/el6Vc+DKGdDk2Ec6n9jwRzNRPhqg39oxHezor+XTPkVvrS9KmVLdZB5ARRDr nVb/wQlL RwPIZPIACw417LChlNmVt3WN8rpYHGGolPm76hv1rlHjnV44F5fGqk/JwuAyzVhsoKRTY9GrQdBZa/WQT6h0sLADRpMIlavua9xYDpWm310XOYTb8tGUKQ/6VP+jWcPHUkC5wb0I9efA0dhsgEAypQXQ0a+LiXnjiSRViD5rLy6bwtmHrBOH64P52LNWjrJh0q6NJQ+7r9XxdfB3sfisU295emB351iffM5xONjtZM49BtwHZ3w2TIcyduMEWFHSLrjHWNV1arWFfJA2ixubh9tVTHXgyAl5GCPycVz9hEpKZfLPCCca7FvdpUdTWNSQaNMgp43oU6HQk917KlqoJpvEswgoOW4ha9yrBn7qDjwKwbCmW87b9n0DQtONwoU+G7C5hXZfVZFsqLsHxVvtPhvU5EGRS12jm0rLE/ft0q1iH3vFvdiKxyJ8Dqqc06ikJrka/PL0mVSPA6Muo4N07n9iP6BXj4TvhZuEI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 02:04:17PM +0000, Ryan Roberts wrote: > Fix callers that previously skipped calling arch_sync_kernel_mappings() > if an error occurred during a pgtable update. The call is still required > to sync any pgtable updates that may have occurred prior to hitting the > error condition. > > These are theoretical bugs discovered during code review. > > Cc: stable@vger.kernel.org > Fixes: 2ba3e6947aed ("mm/vmalloc: track which page-table levels were modified") > Fixes: 0c95cba49255 ("mm: apply_to_pte_range warn and fail if a large pte is encountered") > Reviewed-by: Anshuman Khandual > Signed-off-by: Ryan Roberts Reviewed-by: Catalin Marinas