From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B203CC021B0 for ; Wed, 19 Feb 2025 19:00:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 210E128025E; Wed, 19 Feb 2025 14:00:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BDF028025B; Wed, 19 Feb 2025 14:00:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0378E28025E; Wed, 19 Feb 2025 14:00:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D7A2228025B for ; Wed, 19 Feb 2025 14:00:45 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 88C7181CD9 for ; Wed, 19 Feb 2025 19:00:45 +0000 (UTC) X-FDA: 83137610850.04.B90F66C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id B8317120005 for ; Wed, 19 Feb 2025 19:00:43 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739991643; a=rsa-sha256; cv=none; b=7moreeRgOpK5AvwL5xj3wmxG5MUNB29DNDeGbHcQdpuXPYhUDYsxlThHOsnwUUlxBeBvJx y2sinzv+f9UXF6r1PenxwwIfoRcMOw8Anc4YOYQgqnNvyrn/ABYgPBMapshRDy2Fvg6Yy/ 2piR9CB6/1LsG4UpHT5Is2zvMRU4FdI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739991643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=td/eVubuYPVyc2kjl9H3mLQb28o3N/rmuqKJyhF3/Fc=; b=GaxYFDl9gcTQzgPqziD546dGI4eIFyzvplqmoF5wCJ7zudiCZmjuMG2GROBteiPC2l3nzO ak8t8zZU/G+F03HGuPE1vl8yGp+iXiZZJm2MWgj66WbkKhZxUSrnys+YV0uFfl6rBQdtEQ WflIU6ERkE3KiMy/FvkRgDqjQWCuoME= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4ACE15C5BEE; Wed, 19 Feb 2025 19:00:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13FCEC4CED1; Wed, 19 Feb 2025 19:00:35 +0000 (UTC) Date: Wed, 19 Feb 2025 19:00:33 +0000 From: Catalin Marinas To: Ryan Roberts Cc: Will Deacon , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Andreas Larsson , Arnd Bergmann , Muchun Song , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Dev Jain , Kevin Brodsky , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/4] mm: hugetlb: Add huge page size param to huge_ptep_get_and_clear() Message-ID: References: <20250217140419.1702389-1-ryan.roberts@arm.com> <20250217140419.1702389-2-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250217140419.1702389-2-ryan.roberts@arm.com> X-Stat-Signature: heitimn7x4urbkebr4smp9kccssr6mio X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B8317120005 X-Rspam-User: X-HE-Tag: 1739991643-143659 X-HE-Meta: U2FsdGVkX1/JNkdaRBIpad8mzkisRTvLaoqHgwbuk5qFO2EvdUmtU1mazl0j+LAo/kT5OLH1e4Cw/+BvXRmU9kq8vxw/BPf6zVsByMHPC7HvPuRDOksvBWSBRi6c9WpZvK+vbw5YxHB9+8/AQzLYRbrIpQTIcPK46/v9elZoH1FncuOMd+KBfrvbqPlYWoH+ZpZTnlrzxtA+G+cHmUV7Y3wNZgCmNLd5wlmAYOQXw781PYxvnNf46dn4Q+QWc82fyJXiM7K48doIGGv90pTG1WQPwnVrc+Vkiq61roIcSNHtlebZen1WCRe/0D0TKpDVX5aBgw+MKPwQdO7HSV2PKHnplUR8tTZ0RUHUQw1EyWc8OmTwcKWCymv+6bMyaBs2UYcM9XEetPBgBjuyaS8IM6BSBrkqpgHBaP7+rHgoxc7/de1lDOexrm0nns5czztnlcq8vDI+Lh3R3LEoSeSacHfNNKtKCShkCwwWOl0n0LvfM2lywgEB3q2ip/MQxPQDVPVEYj+at4338QhpzFvc4LMm5qW0O+BRkqhHxzzkfslqfoO9WT/u9rnls6RblX5HtGiSnKai0oApBQ3l9xmF8wxIdT1Sd6+qo4J6mFAKLLZh1LvJ+g2KA8EYs4J9vrDi0/nwQwe/15FwFY8HSkxKoTm2C47QevBCBI2+LZlMzE66TPfC02awTx6uJQFa5rlh1uIlKlVmxK/30JW1dyRrgLOZNq5UAQrkJZmfcM1s+NidFYj0cU6ITKH0WEK9mcR//ujDYrwpY8P3H0X82H3VqPKSHKEuv/ViNKb0AxOLB+lLo+l43OoPGZRmeG1eMyNpa/+kikkVfjzWjEFDystfW/GOIxF+nI+hc4JBCoqGaOYxrI6TP54EIU2YMvAh5UwZbgQHEW/P/fmr02U6dsqFSvPd+LUZfcHKuuS+RcUkeDyWqCDvxr30wPND7qlYjqUWbI7t+4X9eXx94VeTgpG CIH2Ktim KDqZpifkP1LBJGPkkKe+65NX6WjomKeUv9zycNXpNygYIFQrzQQxbx41E0XDxiWqsBMHN9NmdordWkUpTl2Mjlqp1JG5iSLuP+vbrvCXYYXh/6oi23fdH0wg3Q6c/UyS2Mi16vOA/fh6bKwHoommKJqVvD22weCLmqmqCt8RuQyXgsDE0hghOgrd05tW1gSAPI+CP3BpR+0UnRIWt/VbelnjcBuIZrUAmsIbaNIhtJALOn+HyY7P/InqzDqWE1GwgQSMyRkKkBhVkWF/4RN1YQUxv+lcqFy/AfWyGx45xMMVXdaJ6JNcA/uV7XZabTCSm+eNhsBf8i4Rts1FZOlFNpepqXvLt2RReVHYmtyTTIN2hDLcdK/QMu4F5XRwkSWW9vcvBCO+dPTiGWUXuBnutTb7Fm+JmDC+teeDuc12F6jL1oaMrViEM1pOXcs8/xt+NUQw8ujIZzp/j72isD1DRRBsNp6C0jiLDtQzRfmgsbNho8zYgPUBNXeEtdUMA05Kn1nVpO2PLbtKYR80= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 02:04:14PM +0000, Ryan Roberts wrote: > In order to fix a bug, arm64 needs to be told the size of the huge page > for which the huge_pte is being set in huge_ptep_get_and_clear(). > Provide for this by adding an `unsigned long sz` parameter to the > function. This follows the same pattern as huge_pte_clear() and > set_huge_pte_at(). > > This commit makes the required interface modifications to the core mm as > well as all arches that implement this function (arm64, loongarch, mips, > parisc, powerpc, riscv, s390, sparc). The actual arm64 bug will be fixed > in a separate commit. > > Cc: stable@vger.kernel.org > Fixes: 66b3923a1a0f ("arm64: hugetlb: add support for PTE contiguous bit") > Signed-off-by: Ryan Roberts Reviewed-by: Catalin Marinas