From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0544BC021AA for ; Wed, 19 Feb 2025 17:18:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BDB828024A; Wed, 19 Feb 2025 12:18:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66EA1280246; Wed, 19 Feb 2025 12:18:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50F8528024A; Wed, 19 Feb 2025 12:18:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 33B04280246 for ; Wed, 19 Feb 2025 12:18:56 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1E811AF055 for ; Wed, 19 Feb 2025 17:18:37 +0000 (UTC) X-FDA: 83137353474.11.9304A6C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 45D714002B for ; Wed, 19 Feb 2025 17:18:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf12.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739985515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m2y6lrpJMjRgeKBFoMski1ClhCMNuCg7qXrdemKDdH4=; b=Ih38zB9/h3ThIPsb6g6pO0O8LwTVtwSZRIrB/ynE7Z1PxTE4EPvsFhdkuGxoCy7aRrcfDE vBvPCDyK/u17A4+BCOq7tGu6+oIYm0V3ybCtMZRpqot/FGE3ck+srpTlF1RE4pcTat3aLe oswKIC87U7RLzqOcozF/NW2UD4H1p6c= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf12.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739985515; a=rsa-sha256; cv=none; b=Zn8mmiFRq4PlGlNNDG4HnqCdT3Nbdkf6GJV6JUenW7Mx5Pg+N7eQ1HghW05lIAFteFDl85 eN9AspZ95H5uGwcTalx/VoNWrDRf3AQ4uU21ocXZtWR7CPMbxPu+4ePyEO+N9QWIbVQsdd 9VJA/HH4HOxVk3iThmeokZzqyi5C/RM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8E1195C5946; Wed, 19 Feb 2025 17:17:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 358C4C4CEE0; Wed, 19 Feb 2025 17:18:27 +0000 (UTC) Date: Wed, 19 Feb 2025 17:18:24 +0000 From: Catalin Marinas To: Greg Kroah-Hartman , Naresh Kamboju Cc: stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, hargar@microsoft.com, broonie@kernel.org, Linux Crypto Mailing List , linux-fsdevel@vger.kernel.org, linux-mm , Anders Roxell , Dan Carpenter , Arnd Bergmann , Herbert Xu , willy@infradead.org, Pankaj Raghav , Yang Shi , David Hildenbrand Subject: Re: [PATCH 6.6 000/389] 6.6.76-rc2 review Message-ID: References: <20250206155234.095034647@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: 5wz81qii3ymsymmihz6qz5fqqcywpz8u X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 45D714002B X-HE-Tag: 1739985515-100331 X-HE-Meta: U2FsdGVkX18SD4t8FnakS9oX5XTzia+vSmSPQWp0qeiw5WaiZwqWOIFrsedY4PrayHJQWhr3ZVz/ZXC6QuoLDJBl0V2EjbVSAWXb9L1VVEQOWAf3S600TMFlvN6JepTVKLSOfbu784/oUy0iVtrfe6BrYHy4rkNasdz6NavFFpr/mPcVDXlQ3lr1qTPTbue38h/HTjBr5IyHUi8vB6bnNP1SqxFkdqcsUhBkiJtqKzfzlxNgyeN30rEVRevFV1vijkKys4FLOr8BZawvfOZZ21OTCqucnrpLXrvgCO/ia78TpCnc7O3zTKaVUIg7VydhxigPV7RrctAO2PYlloy4uApg5uK0UhEbO0qKb4BdCdalqZPqIXiWc7ScQ5uiLQ9q5UmLgdoV4aWh7j3o9saJbcBo8g3bnJX7P6cgMYdSaRcTHvwFq7/FHj2BmaOxq/rTNFHytFy93VGv3cKNEq/dMcYpYIuDoFstjP8xAXxZNE0zGHG+VCpeXfvwBBNiqCCqW92SVUC3IPisxPXbe1dpmrhnpDLq+tiKDnRqLKNencekeeA/T2cSJSrkZux2J8+JBKWVoXanEjQzbp5MXybPw7C3tDlsr1fdg5sKZTx3CW+x7d8+tqHNfYOG71xeOS/0Y+1JV/UWGXpndlcBNGyPoF6eC9CEo9gap8nN499uCMDushxerLpE8wpZkZlfHTWyNVxHDFl3zKannEiXRgFfTYfRbOzXSWe8JQfetzP3TCeBdiFaA+JFfZFMA4OfBCPz/qavYcsAwoicPnhO53SZoDNrlYWy3EfLiBxrqMxjqIPjSNYoPIZGvgsqkqyQZrvTlufhm3pd0Crl75SdZsvTHJqOFP36kwnWrvFFHUgObNvhRW0PrzghDrV2OW6o/Wp4dqt+mrGqUH1CLqlx2v1JeuRTCIyZzFXOipLMmOsRy2Bigc9z4buK/jIPe+tuChDCo8U5rK3Wz92qe9z+RV7 /RDepAEv EFhTQc8MlbDVm69h2mwh6efniDEID32EE3DEIDJdpKj3RWSEaHckZV8iPK4JG+Wf4273FnvPw8PjqGRTBSyIjLyC2Z1ahPiHTJyxSIOZSxSC81pXCghYV/+6pZlF9Bjj+yntUMv9JWd2+ifQp7cr/PUk+MQ8dP41UNWbC9f8mDwNwCw5nmpsYWB2sSTUJUCxG9vugtp7VUAoM6gB3KGr52v4QniN/c3jomANUmGdl5z9ARiQNugIXqLZBNCm+ogvn3kt5owTitNGRisxqdg8bsbIfrawbhn7UGFxssD2Gy9GcjREZlPOF5+SUtQZjNFQl9sBoVU7+aXfsOGEQv3lCjlKXaUQzn+VdwZVP0f9tpFdSXGawN8ICcTDP+OYurA4ki53tq3aGees+OIVd/qKQLJo2MFOe1QVgktHqW48Vxxg8qNZI96WV+L3WtMwicre8vAfpxy1cGoCXdp2X8KMhVoWihhi2KMxiphbi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 19, 2025 at 02:00:27PM +0000, Catalin Marinas wrote: > > On Sat, 8 Feb 2025 at 16:54, Naresh Kamboju wrote: > > > Regression on qemu-arm64 and FVP noticed this kernel warning running > > > selftests: arm64: check_hugetlb_options test case on 6.6.76-rc1 and > > > 6.6.76-rc2. > > > > > > Test regression: WARNING-arch-arm64-mm-copypage-copy_highpage > > > > > > ------------[ cut here ]------------ > > > [ 96.920028] WARNING: CPU: 1 PID: 3611 at > > > arch/arm64/mm/copypage.c:29 copy_highpage > > > (arch/arm64/include/asm/mte.h:87) > > > [ 96.922100] Modules linked in: crct10dif_ce sm3_ce sm3 sha3_ce > > > sha512_ce sha512_arm64 fuse drm backlight ip_tables x_tables > > > [ 96.925603] CPU: 1 PID: 3611 Comm: check_hugetlb_o Not tainted 6.6.76-rc2 #1 > > > [ 96.926956] Hardware name: linux,dummy-virt (DT) > > > [ 96.927695] pstate: 43402009 (nZcv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) > > > [ 96.928687] pc : copy_highpage (arch/arm64/include/asm/mte.h:87) > > > [ 96.929037] lr : copy_highpage > > > (arch/arm64/include/asm/alternative-macros.h:232 > > > arch/arm64/include/asm/cpufeature.h:443 > > > arch/arm64/include/asm/cpufeature.h:504 > > > arch/arm64/include/asm/cpufeature.h:814 arch/arm64/mm/copypage.c:27) > > > [ 96.929399] sp : ffff800088aa3ab0 > > > [ 96.930232] x29: ffff800088aa3ab0 x28: 00000000000001ff x27: 0000000000000000 > > > [ 96.930784] x26: 0000000000000000 x25: 0000ffff9b800000 x24: 0000ffff9b9ff000 > > > [ 96.931402] x23: fffffc0003257fc0 x22: ffff0000c95ff000 x21: ffff0000c93ff000 > > > [ 96.932054] x20: fffffc0003257fc0 x19: fffffc000324ffc0 x18: 0000ffff9b800000 > > > [ 96.933357] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 > > > [ 96.934091] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 > > > [ 96.935095] x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000 > > > [ 96.935982] x8 : 0bfffc0001800000 x7 : 0000000000000000 x6 : 0000000000000000 > > > [ 96.936536] x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000 > > > [ 96.937089] x2 : 0000000000000000 x1 : ffff0000c9600000 x0 : ffff0000c9400080 > > > [ 96.939431] Call trace: > > > [ 96.939920] copy_highpage (arch/arm64/include/asm/mte.h:87) > > > [ 96.940443] copy_user_highpage (arch/arm64/mm/copypage.c:40) > > > [ 96.940963] copy_user_large_folio (mm/memory.c:5977 mm/memory.c:6109) > > > [ 96.941535] hugetlb_wp (mm/hugetlb.c:5701) > > > [ 96.941948] hugetlb_fault (mm/hugetlb.c:6237) > > > [ 96.942344] handle_mm_fault (mm/memory.c:5330) > > > [ 96.942794] do_page_fault (arch/arm64/mm/fault.c:513 > > > arch/arm64/mm/fault.c:626) > > > [ 96.943341] do_mem_abort (arch/arm64/mm/fault.c:846) > > > [ 96.943797] el0_da (arch/arm64/kernel/entry-common.c:133 > > > arch/arm64/kernel/entry-common.c:144 > > > arch/arm64/kernel/entry-common.c:547) > > > [ 96.944229] el0t_64_sync_handler (arch/arm64/kernel/entry-common.c:0) > > > [ 96.944765] el0t_64_sync (arch/arm64/kernel/entry.S:599) > > > [ 96.945383] ---[ end trace 0000000000000000 ]--- > > Prior to commit 25c17c4b55de ("hugetlb: arm64: add mte support"), there > was no hugetlb support with MTE, so the above code path should not > happen - it seems to get a PROT_MTE hugetlb page which should have been > prevented by arch_validate_flags(). Or something else corrupts the page > flags and we end up with some random PG_mte_tagged set. The problem is in the arm64 arch_calc_vm_flag_bits() as it returns VM_MTE_ALLOWED for any MAP_ANONYMOUS ignoring MAP_HUGETLB (it's been doing this since day 1 of MTE). The implementation does handle the hugetlb file mmap() correctly but not the MAP_ANONYMOUS case. The fix would be something like below: -----------------8<-------------------------- diff --git a/arch/arm64/include/asm/mman.h b/arch/arm64/include/asm/mman.h index 5966ee4a6154..8ff5d88c9f12 100644 --- a/arch/arm64/include/asm/mman.h +++ b/arch/arm64/include/asm/mman.h @@ -28,7 +28,8 @@ static inline unsigned long arch_calc_vm_flag_bits(unsigned long flags) * backed by tags-capable memory. The vm_flags may be overridden by a * filesystem supporting MTE (RAM-based). */ - if (system_supports_mte() && (flags & MAP_ANONYMOUS)) + if (system_supports_mte() && + ((flags & MAP_ANONYMOUS) && !(flags & MAP_HUGETLB))) return VM_MTE_ALLOWED; return 0; -------------------8<----------------------- This fix won't make sense for mainline since it supports MAP_HUGETLB already. Greg, are you ok with a stable-only fix as above or you'd rather see the full 25c17c4b55de ("hugetlb: arm64: add mte support") backported? Thanks. -- Catalin