From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE9DC021AA for ; Wed, 19 Feb 2025 14:27:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AD61440167; Wed, 19 Feb 2025 09:27:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 55BC5440156; Wed, 19 Feb 2025 09:27:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44C5B440167; Wed, 19 Feb 2025 09:27:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 26F7F440156 for ; Wed, 19 Feb 2025 09:27:32 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BFF171216EA for ; Wed, 19 Feb 2025 14:27:09 +0000 (UTC) X-FDA: 83136921378.29.CA43A2F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 6F0BB180010 for ; Wed, 19 Feb 2025 14:27:07 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=G5lt7oPQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739975227; a=rsa-sha256; cv=none; b=z+Y1d55NZM0c01DStfSQ/aTDdBb38Uton8FSdvzfp3Ln3azQFpfI1vk1z2EEz12hYZPOMI T3QyRFxLQ5spUy7pFuu3RjVoyNA29xsIMw4vOz5y2+aEXdBC++1EWh/wTTigEJbdhGAKxA HzjkR5vtZCKg7NvzDFXlYWqme/Wt/TQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=G5lt7oPQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739975227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l5kXQZ+eC5UGlAspGME2/vd0jXGJDk+3LXqrC+fAcrU=; b=oBCq6eAzSHPZiweycs4hIWFgHdK03RO8QLzej0RyL5g2NINdhH617YXYqtU3//7ZgeAD70 7inOna+9V/P/eeHh78EMKqI6mFu82Ya/kTDrS5ZNhvG2UyRSnNRxH4nUxUNKxOaJUGIgY/ CU4Yc9BUjtSetNm1nV/z2OFzT98HXzs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739975226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l5kXQZ+eC5UGlAspGME2/vd0jXGJDk+3LXqrC+fAcrU=; b=G5lt7oPQLEwrBT1RraIlS2mrWIvSwNnn3DcW2ccF8I5Kbz3LlaAM5FUBGJamu0uHwxJ6gr EsR3LGSUvknRbf2dBL8UjSVbARiWtveM3J2/9sJOfoHC668wdyAWMlg3gQXlGtatCN6sRG 117Jv6IJkAeDpI8eM7eTJOCSn6gSab4= Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-Zy_HxtF3O66A8Z1vC3kIwQ-1; Wed, 19 Feb 2025 09:27:05 -0500 X-MC-Unique: Zy_HxtF3O66A8Z1vC3kIwQ-1 X-Mimecast-MFC-AGG-ID: Zy_HxtF3O66A8Z1vC3kIwQ_1739975225 Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-7272acb753bso2542503a34.1 for ; Wed, 19 Feb 2025 06:27:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739975225; x=1740580025; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l5kXQZ+eC5UGlAspGME2/vd0jXGJDk+3LXqrC+fAcrU=; b=rKaL0d5/K4xyRRCGVKGVIrFCdNaZadR6Yi5XbnPgwWKheZMjnMvGCwy+tKo+QBEFWx ksg+64WWUHYzZFfK65j4+qy4bArbP/xaOVnc9PcReryrDH8odfmNDeY60YnwIiwfVvWi p6ld07whVXTa4pQsMkN1t/KBKahXwid45Rz8WTxaUi9LIPvGlLczy1Fp/ZhhYQ7QhvOx x8uqVjTi8OwJvL9vKmzox3QhdoHYzs9UWRG7L86uYsn7jv2YwdmQYWWlLNGWkttBQZOA rBRPBjfiMVl3T2rXH/gjhYlCgd5gthoXe/qNNc4Q+AhBym1BXRqDIHqDKYb39Yj+M5jI mjCw== X-Forwarded-Encrypted: i=1; AJvYcCWgNDSO7gNRzyI7D0grTHbGbISXrNlCGGpaIjqUYKnGBJ5epU241J941IiLPD7K1nWSQ8t1Ja7u8w==@kvack.org X-Gm-Message-State: AOJu0YwPrBX6MZrbnv6UBv5dKMOWnady6MGfYbKTIBhKae5Vf+1i214i CtMTyat16SAiJuPjaK1n4jCOzkNe35Iw712IEIQDG+sdTg5HTss2VVJuSkSnBEyznxU0NQIUcCf maR8i2LG4Kinc4T0BgcIosBB8o2lK1U0lLG0F5a95CCPzpSkS X-Gm-Gg: ASbGncuN5k2KpqBNnZWTkVd8GYxgVSFdlXYLm1Cw7mlew/sccI5GkkyBExdjpz2y6Tv 7YrrlpFdBB+Nxb9Gcw8uYw8sYx+72WN95htJFaZ5sciJSGKr8HoJ4PDtO89xLPS2ZRnENn2h5XY 57ZojqcAntL01axCFIi69amD3V1q3dGCeyovu/Y0eQ9xexmKu8cpDO//+wZsf2PnBhIISOCCXTe Ar4iPf/wGUNeHB3Op/cSpjmgCOqhPkc/QSv6Ot8jbkn58uhlUg6L9Vd8Ko= X-Received: by 2002:a05:6830:3881:b0:727:2f9d:284c with SMTP id 46e09a7af769-7272f9d28e1mr6334023a34.10.1739975224832; Wed, 19 Feb 2025 06:27:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHe2Jy1S/ef+XCanbcwoVdwjMu3KsSLGol5t9LBgIHWTVgTQUJ5yIjtd/FzoCMUVyUc7zq5gg== X-Received: by 2002:a05:6830:3881:b0:727:2f9d:284c with SMTP id 46e09a7af769-7272f9d28e1mr6334003a34.10.1739975224544; Wed, 19 Feb 2025 06:27:04 -0800 (PST) Received: from x1.local ([2604:7a40:2041:2b00::1000]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-72726ce6bf3sm1768025a34.68.2025.02.19.06.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 06:27:03 -0800 (PST) Date: Wed, 19 Feb 2025 09:26:53 -0500 From: Peter Xu To: Rafael Aquini Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Shuah Khan Subject: Re: [PATCH] selftests/mm: run_vmtests.sh: fix half_ufd_size_MB calculation Message-ID: References: <20250218192251.53243-1-aquini@redhat.com> MIME-Version: 1.0 In-Reply-To: <20250218192251.53243-1-aquini@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vpnlLtKqU8-bw5bPJyBVrKtiW_jQJmX0vT1LaoDRzik_1739975225 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6F0BB180010 X-Stat-Signature: mxwkqwge73xfhocgbq4bjip3ah3y97bd X-Rspam-User: X-HE-Tag: 1739975227-335973 X-HE-Meta: U2FsdGVkX1++BfFGh8fU7tPtyXD/qBg+ATJz8xbRRR+Pppf8IpFf8USkBQ1Ki4TZWFqO7uuZZfCUllGGXXIlTzW8FvyXKLnKBH9rThAM6DGP9I6jnKnL+CmLCMP1iSIdhtpy3C7kXYVV7BRnZZuYdOD2zFykPQwkkR0Wgi0rx6wiBQq2Bv/KSDov2t3a+dYM0PEV6yAwnH3xUdSNt4hIvdDuqBRVjENESZ6doSJCEo4+GG6gbeTiwNq6QaixJETPm6pSn83E4tB8aWgqjL/rX2z6gp8LSH3WKH+w/qD7OSjzZNae+T85C35dtSwSeeLRr5DTAL7jfzVqPx/05XqLNy9iO+8jHqX+kQjfnD0ttgEkWBHiXowSQpUOAUoYH1oZhn8SgDASiH+RntkpBbQF4JZwhN4LR6kN/gNlJGvHR4x0Lt1UvR0jPW+x8u7a/ilCVYUrY1SPGAv7e8pDAaKUQBtvofHaHUAFDEPc/sJdE1+y0pLo4G16hlsnwDs97jVzK4QHYek0WAFSG/L+HNWGPqtXc6WbTrwmju4x10VgK0cS+RX69gAZgJ4umckXP3sWkPAoAUdq+duHAXblfxOaSZq/1cUxCJw2GYjlChJWgP+CjcJSjRMWxw3z6qQ/LQrHfihIrx9jHqljopnzsdJUC3zHEa2bDgtwF8IdFUO2isX2kHgeVoZ3pBS+2yVO4Q72SY8Gc8iIQCodO/UZgi1XwF0TVxQHV3nL5i1BhktbZ+l87Xirt0vXmQ0pdVH0vTqL/7tU6i+LDjW2Vg7Wxerx/yydvIoaARdWsr5EmI4KcLH0ymDgzNmTdSjBKB50J80lPP/rB72ThRHiR04qyYMSlRYze+VBe873aDcrwsPtcJmNDyhv7uQy3WwXEWkkbuiWnuBY5ovIz3Q4r6S+IlauGC4SYkYGZ5+UWe6xnPK++F+HCTrIo4lJx7IKy5gqMgzb1PHaK30m0skoFsbVZ19 WfMnF2JT dIw2QURfEo7LEJaWOQrV5cTZPrYzwB79l2tatzFQjQxoda3ESQBLvb7hf/OKsPpfwonOque2XzZaEiQ3wwmsmHHWoo46mhNfijfCQC/BVmWLBaB45ndnXmTmCyjM7GnYMHXjg99H2Thp9mExToCbZxVkOf0CPZvTD9vJ04IayoG5vE3ZrGamp6DfWeZnNZ669IamXMPiKmddgHTGRrh1PHTazRN+XV0MmbQhgY/Lgexuq+zGeBOesd8mMBUaF5QQLRcEOYHLUub5kl1zaE5pDIdQSSfKupx3A7dXXnjYYR4DIphRfilfICBp84CGxHCdcM1u6Yr+FHNYuy+yhQqgIhU8f6HQT2Jpd2V5+LUrDb/jmzoTqJsByM9hWfYwurqs5FSHfJgNhgH0RwxgbUK+mgVyKM/1QB80mDW0N X-Bogosity: Ham, tests=bogofilter, spamicity=0.000025, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 18, 2025 at 02:22:51PM -0500, Rafael Aquini wrote: > From: Rafael Aquini > > We noticed that uffd-stress test was always failing to run when invoked > for the hugetlb profiles on x86_64 systems with a processor count of 64 > or bigger: > ... > # ------------------------------------ > # running ./uffd-stress hugetlb 128 32 > # ------------------------------------ > # ERROR: invalid MiB (errno=9, @uffd-stress.c:459) > ... > # [FAIL] > not ok 3 uffd-stress hugetlb 128 32 # exit=1 > ... > > The problem boils down to how run_vmtests.sh (mis)calculates the size > of the region it feeds to uffd-stress. The latter expects to see an > amount of MiB while the former is just giving out the number of free > hugepages halved down. This measurement discrepancy ends up violating > uffd-stress' assertion on number of hugetlb pages allocated per CPU, > causing it to bail out with the error above. > > This commit fixes that issue by adjusting run_vmtests.sh's half_ufd_size_MB > calculation so it properly renders the region size in MiB, as expected, > while maintaining all of its original constraints in place. > > Fixes: 2e47a445d7b3 ("selftests/mm: run_vmtests.sh: fix hugetlb mem size calculation") > Signed-off-by: Rafael Aquini Oops.. thanks! Reviewed-by: Peter Xu -- Peter Xu