From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66751C021AA for ; Wed, 19 Feb 2025 14:00:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B90F4280233; Wed, 19 Feb 2025 09:00:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B40A328022F; Wed, 19 Feb 2025 09:00:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A30E5280233; Wed, 19 Feb 2025 09:00:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3F21128022F for ; Wed, 19 Feb 2025 09:00:46 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7A6354BF08 for ; Wed, 19 Feb 2025 14:00:44 +0000 (UTC) X-FDA: 83136854808.13.1B02792 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 6124640014 for ; Wed, 19 Feb 2025 14:00:37 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf12.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739973639; a=rsa-sha256; cv=none; b=amNVxl3IrYJvvWRaejRYT001y4gX+hjVZzXpnhC2jf7HY7CirDH0mUG9jec6SJxAV9sFd+ Zy2v0ejLs0R79rZBAPKz2rOIvefsmOcbHuYE7+IA1i6kTdmipCRe3lE0hX073i22lQloZ9 vZf55ceian4qq7J0jbqFumNlKVBnbes= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf12.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739973639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9WknG9vi/s4lSbLCjosyL8Fe7sJ3ym+OsMJ+rTvJhhM=; b=LT95e26W2c86I9AlxKCHH6s4qb9VxN3a+U03AYJ8lm9qSwVx1Nq3PhJa2AB6/c/wiwVgOq 4ue2ROndDWdSbmvt/eo79fySUASlZgNSAL9QWBmeWVL5aeZPXwkDccq3du820WOAatkpJc brTx1UzunnLms8LSt6nKvDebzbJ3o4s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A2B075C5998; Wed, 19 Feb 2025 13:59:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B8DAC4CED1; Wed, 19 Feb 2025 14:00:30 +0000 (UTC) Date: Wed, 19 Feb 2025 14:00:27 +0000 From: Catalin Marinas To: Naresh Kamboju Cc: Greg Kroah-Hartman , stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, hargar@microsoft.com, broonie@kernel.org, Linux Crypto Mailing List , linux-fsdevel@vger.kernel.org, linux-mm , Anders Roxell , Dan Carpenter , Arnd Bergmann , Herbert Xu , willy@infradead.org, Pankaj Raghav , Yang Shi , David Hildenbrand Subject: Re: [PATCH 6.6 000/389] 6.6.76-rc2 review Message-ID: References: <20250206155234.095034647@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 6124640014 X-Rspamd-Server: rspam12 X-Stat-Signature: b3mt47ei9omp64rz8jxbhyne6md9eqhr X-HE-Tag: 1739973637-64028 X-HE-Meta: U2FsdGVkX19ixIj5uAQxNA7sMv1qFO7CpC+iCwXbgdUmFWUad+nvqeC3hfcnq0PITWcfmAS1iNq+jUsPAZIl88JxvMB/LPKdFfG2yRVwPJYUmzwBTKGhxov/SF/XC9Ev3KHnVZPOD/s7mM6sTEqez2zoZIxVoHSzWMgBay0WtQKjrh+VyQA/bMyIJZwvbYaDWuJN8g1XeagX1RI5uYLc43tVu+b6BpgpzB3S1AKA4cCD3Hv3MLENvY0xu1Xbk/bURU0bHDG7cHzUO+utK9VPxXieCmjhQFsoXOdD4l3WU+tgwRPsZGGjtilv1BOKnjeXJzNwlCOvTbBsmoKU4v5RR8mdmmQu1tzktK+eL+26p69sJbJAd3Ja69ZUgUcjcuBhMItqHs1y+1/nMLh/t4DzhCeIz3XcIcsZzCy/gHUCqrSQJUUdQihxrJMomqvOk7/Uofn0M9aEJzHCpPVmuT4POdBdBIqolqx8aPX1CjdgEKGAP8HWbXYGEtYhq18qfNx5nqGZDLWSOgsAIK4sdQ5ekr09fSfOaM9OJpC+Daoqp9CFWqf6dfjUGvjd9WMNDFjgUGozbo3/FxN9ihKFkzjrTIwwY7gKfemiACXjWSyH/rX5RvwcEHIv8KSMyQsWY0YvCZdr9o+5M+RZHYweUlUuKyzhg07ZOJnqtjB4deiMsbKjTXrrUCnXiTK2QPMZeqrG8e5blZ90+1wKUDpBoXp08Y02TWqlHO78nqCIc2boSXBPkvpmE022+GoQK05xz1ZAazuwaNy4ynkrtZ3IKgklBisnhUxW2x4JQeZFyXrrNuPq+UijE6oUW4KKDyBv49yxkRA8HBTJNUtx935sFeLg7+7+O1ibLRwlnuaFfYVTjt3JJRPB5tM4dO9xILQ0rDUEs1yPH+NvvncJ95pwJuy3bXdQnn6MhGbGINRIXfDxvypFMmX361G+XYgi4dG3ZXuU4FQV0kyPKPg5Fkaph0n xgxu1XXl 6M+Bs+aunihBP5WL5+3z+c3O0scwiIjonC33K4Qe+oRgxtLklltmhWV6l5gwdViVkn+vwJ0m3UakkuxcIZ857sNgPcTD4CHLRV7jW3Z88eAbK2X4yzKF23sap+5vl3CQiE+lkk+fMEHnqVvAAc2N2oAgOnoXemkzTqk5lcsmggynxXUFmZ6csr92kpxjTBXgSVW4jsIqft3+1XAZjCr/JzH0NozjpjfP3PWToMc8LcURhR/khB2lk6BRO5iMhngdlt8xSQLkRUQeLj70UVqznmMRwzWVs0wOXsxYEoCg3Et7cMAHaZuAdFw3rC6qW91YO43awLBr1nJhOmvmd0+azeQd1d/3xZIoXT871QAyOwebdYncjXWwAzUaDNcxL+ApG8+WyPvzLLybEdLYh5LMa6LAR28yjDRXXpBN2g4rs907+KTzfQVGBc7ZJVcPBY6QEYSypbeXILs8ZkDEOpIRQUS5hSAXUdlyZ4/Vp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 05:00:43PM +0530, Naresh Kamboju wrote: > On Sat, 8 Feb 2025 at 16:54, Naresh Kamboju wrote: [...] > We observed a kernel warning on QEMU-ARM64 and FVP while running the > newly added selftest: arm64: check_hugetlb_options. This issue appears > on 6.6.76 onward and 6.12.13 onward, as reported in the stable review [1]. > However, the test case passes successfully on stable 6.13. > > The selftests: arm64: check_hugetlb_options test was introduced following > the recent upgrade of kselftest test sources to the stable 6.13 branch. > As you are aware, LKFT runs the latest kselftest sources (from stable > 6.13.x) on 6.12.x, 6.6.x, and older kernels for validation purposes. > > From Anders' bisection results, we identified that the missing patch on > 6.12 is likely causing this regression: > > First fixed commit: > [25c17c4b55def92a01e3eecc9c775a6ee25ca20f] > hugetlb: arm64: add MTE support I wouldn't backport this and it's definitely not a fix for the problem reported. > Could you confirm whether this patch is eligible for backporting to > 6.12 and 6.6 kernels? > If backporting is not an option, we will need to skip running this > test case on older kernels. > > > 1) > > Regression on qemu-arm64 and FVP noticed this kernel warning running > > selftests: arm64: check_hugetlb_options test case on 6.6.76-rc1 and > > 6.6.76-rc2. > > > > Test regression: WARNING-arch-arm64-mm-copypage-copy_highpage > > > > ------------[ cut here ]------------ > > [ 96.920028] WARNING: CPU: 1 PID: 3611 at > > arch/arm64/mm/copypage.c:29 copy_highpage > > (arch/arm64/include/asm/mte.h:87) > > [ 96.922100] Modules linked in: crct10dif_ce sm3_ce sm3 sha3_ce > > sha512_ce sha512_arm64 fuse drm backlight ip_tables x_tables > > [ 96.925603] CPU: 1 PID: 3611 Comm: check_hugetlb_o Not tainted 6.6.76-rc2 #1 > > [ 96.926956] Hardware name: linux,dummy-virt (DT) > > [ 96.927695] pstate: 43402009 (nZcv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) > > [ 96.928687] pc : copy_highpage (arch/arm64/include/asm/mte.h:87) > > [ 96.929037] lr : copy_highpage > > (arch/arm64/include/asm/alternative-macros.h:232 > > arch/arm64/include/asm/cpufeature.h:443 > > arch/arm64/include/asm/cpufeature.h:504 > > arch/arm64/include/asm/cpufeature.h:814 arch/arm64/mm/copypage.c:27) > > [ 96.929399] sp : ffff800088aa3ab0 > > [ 96.930232] x29: ffff800088aa3ab0 x28: 00000000000001ff x27: 0000000000000000 > > [ 96.930784] x26: 0000000000000000 x25: 0000ffff9b800000 x24: 0000ffff9b9ff000 > > [ 96.931402] x23: fffffc0003257fc0 x22: ffff0000c95ff000 x21: ffff0000c93ff000 > > [ 96.932054] x20: fffffc0003257fc0 x19: fffffc000324ffc0 x18: 0000ffff9b800000 > > [ 96.933357] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 > > [ 96.934091] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 > > [ 96.935095] x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000 > > [ 96.935982] x8 : 0bfffc0001800000 x7 : 0000000000000000 x6 : 0000000000000000 > > [ 96.936536] x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000 > > [ 96.937089] x2 : 0000000000000000 x1 : ffff0000c9600000 x0 : ffff0000c9400080 > > [ 96.939431] Call trace: > > [ 96.939920] copy_highpage (arch/arm64/include/asm/mte.h:87) > > [ 96.940443] copy_user_highpage (arch/arm64/mm/copypage.c:40) > > [ 96.940963] copy_user_large_folio (mm/memory.c:5977 mm/memory.c:6109) > > [ 96.941535] hugetlb_wp (mm/hugetlb.c:5701) > > [ 96.941948] hugetlb_fault (mm/hugetlb.c:6237) > > [ 96.942344] handle_mm_fault (mm/memory.c:5330) > > [ 96.942794] do_page_fault (arch/arm64/mm/fault.c:513 > > arch/arm64/mm/fault.c:626) > > [ 96.943341] do_mem_abort (arch/arm64/mm/fault.c:846) > > [ 96.943797] el0_da (arch/arm64/kernel/entry-common.c:133 > > arch/arm64/kernel/entry-common.c:144 > > arch/arm64/kernel/entry-common.c:547) > > [ 96.944229] el0t_64_sync_handler (arch/arm64/kernel/entry-common.c:0) > > [ 96.944765] el0t_64_sync (arch/arm64/kernel/entry.S:599) > > [ 96.945383] ---[ end trace 0000000000000000 ]--- Prior to commit 25c17c4b55de ("hugetlb: arm64: add mte support"), there was no hugetlb support with MTE, so the above code path should not happen - it seems to get a PROT_MTE hugetlb page which should have been prevented by arch_validate_flags(). Or something else corrupts the page flags and we end up with some random PG_mte_tagged set. Does this happen with vanilla 6.6? I wonder whether we always had this issue, only that we haven't noticed until the hugetlb MTE kselftest. There were some backports in this area but I don't see how they would have caused this. -- Catalin