From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D15C021AA for ; Wed, 19 Feb 2025 11:52:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18E1328022A; Wed, 19 Feb 2025 06:52:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13F5A280226; Wed, 19 Feb 2025 06:52:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05F2328022A; Wed, 19 Feb 2025 06:52:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DC148280226 for ; Wed, 19 Feb 2025 06:52:09 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7DED8C158D for ; Wed, 19 Feb 2025 11:52:09 +0000 (UTC) X-FDA: 83136530778.04.82DF29D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf29.hostedemail.com (Postfix) with ESMTP id C9565120002 for ; Wed, 19 Feb 2025 11:52:07 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739965928; a=rsa-sha256; cv=none; b=vcn9EiIJ18an+1MEQPlK+UDdTRfAIWM3sziKCrrZd4B7boJadgI+qI5lRg2zTsKEejE2xI 2O3MKNb1FseGtB1xaWcRJFKMBxxJ5q76QmHkGlMR8MljSmswiKY3oxtMhuNZGYatrp8Phk x/g0Awr5OC5CRnGuyP1ktDLs9XAQyZY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739965928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=teFEEY27X3Zb4o9qYoLcaC3DWikKd25qT1PCi5W3oTM=; b=xtVwILqvT10qUE+gzEsCgcrr0PlwfqIaTd2jyk0RrjJUow88japZZITn1KVlM+dW5qfiUx IC+7oJgOzmRf+NxcdlXNMcfMjtsO5vocD84hqKkvK43XoK9S7Tl4E2+Altma9vaWXeFILI ysmmd+eZ/Hnu9o4Tj+9A2gLTXZ1BLEU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3E51DA41E00; Wed, 19 Feb 2025 11:50:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C01EC4CED1; Wed, 19 Feb 2025 11:52:03 +0000 (UTC) Date: Wed, 19 Feb 2025 11:52:01 +0000 From: Catalin Marinas To: Anshuman Khandual Cc: linux-mm@kvack.org, Ryan Roberts , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-snps-arc@lists.infradead.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-parisc@vger.kernel.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, loongarch@lists.linux.dev, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/ioremap: Pass pgprot_t to ioremap_prot() instead of unsigned long Message-ID: References: <20250218101954.415331-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218101954.415331-1-anshuman.khandual@arm.com> X-Stat-Signature: fqyo54q3j3k4bin93ymcf6fbh6tupnie X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C9565120002 X-Rspam-User: X-HE-Tag: 1739965927-402090 X-HE-Meta: U2FsdGVkX1/JGgddmzs43jHhi7am8DAFVh5lZsCd9via3YnLmdg/wepw+FY9RO3Gk/+ngzsrbGroyFBUXb1oGznEG47y4k4sdxgz/Gn6M5FbNkaLxWvipffrnZ4obwX6VpNXZIfbTE2aJM6tsfuZAg3DnrBVff0TaUM3ofNgrMKC1vyXQ+bD7L88mf5oBk7r7kptUAy67Ulp3gJ/aqRKu8dJOINPOL08i0e6p+i3shXsxipY1slNPg+rBfIoEh/SllH29SvGw0S+LY3msv85ZeALY4dR7ToVL+b2cb2WYumx76MUyhHJ5hu4X150EIF1n8A3Qmy39R66kaC4+fl4/bUT4u9pZYrlqI0Zye42ZWVt6NBl2ruST+aBdJI2xjD6Z4Otv0dxnLOIE/tY2ekomEwzGPDFr092973rEP42nkWLy8CH68Fkz3yXVCAXqRNiViBK8cc7Z+ihIhJpcMT3Ei22rhKtV3q4n5ZYR7vpHJbjWGnx0hF1tOvKB6kRJlfPb6UVgJTN5OClh6vvkgpdzPfTwbUJCV5mVuvPgJEnwuWtm07KyraUgyknUVxRi/NVO70PeWVVx/v4qPSc+3jjsxVXs/nN6D5LXDjLns9u5mdy/mt7HFoziC4kpviQfmbuuCLXMUF+5sC9uiwbmp25MbXTj8cARHHlXADjRR/3kwjzK0nVGsZXhpJZJPx+cSxSNRoD9XrPROFvVFOxVNZoLEtJ4XIT4/2hyVIHWUtQTyaXWTXBAHn/rpV6YtNVIAz8Wa9f4caLdbx9kgeSMM5ThOm+KlMmPLga6Sz6wBqVrsBB9Ti1tgRmnTj+kVYWiR9DiItPGqkXFMaoBM1KjeeDabEAJ/SH0+j3m4AB9oGK8BgwQucszackeQgZ6FDmIqWqcyFsIOUDgj1lewc47Y0Mps+bVpr0qBQP0goahQ4aPIb88nvcokKAj2hD+Tw07R13lPfwd90aRHDMJHl+Xpc IxMkN9yp FD033mR4lHO8n2FNrsPEW7dX04ZFdi05G1BkBomUGI4zQUalv9o1v2MzqkhjThX9vkeywSV4X/WN209IqXdPtqZs+0tlVhKcpH6N+afHYlOnd5V5SeNyYkTBCtb/kPo46uyo7NVL2Becda42iubPRAZoPLs8zBEIfC6xiIC4BdZ4Ut6sBGJok8y6lX4CKScPd5vaYShzgqL9xZ9S+8Opq++Nb+Zx5UFHJecFQm4+h4p9KuPDZ8TEMI/vmYzy8Opyn80qvmjw+1Y4V+/lF+uj+DofyK8d5D9mRABPkWcD1O2fF/5H5JQEu2WWg2ct+rttzpLBf++ifcfDX2k7UfcB4sx1RhuUPqm3FzqxJUa98cP3sUW7klJohw7nW8JgyJlqfQRmTFMeKla4lDAR67IIn4sjTC772lILzoXLuC7WXkT7iI08ho9Pcw7/R+8JqgipAOSBBC+dTnRZ8C8hGz3UoEnBvidgaSNeX/gaUBSjjhBi/knX0zZzjKB6RLOfT3ZtJ/d48Rpf0EHF+RsEhQ+8VvlFIe5Hur9mtBEUGMgWu7Yxh6EAPiu+CCX4IiLNrelr4NFAQLgqIlrAhDND8ONnbNCUj472jQxIRiwaYkrhNzcCIrPVHkdywLICDl5QZwDLc62NZWzIp+M/uCoF3kdXSf+WCRxNTdOFSTdCSR8/XshlGVF99RJe+tdaXiyTRWzfI8nkdrvye+lrVGjxXEtAIN7xFCYXK3Rii6NPcD+2WgdLw3OYtjFVVgGebyw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 18, 2025 at 03:49:54PM +0530, Anshuman Khandual wrote: > From: Ryan Roberts > > ioremap_prot() currently accepts pgprot_val parameter as an unsigned long, > thus implicitly assuming that pgprot_val and pgprot_t could never be bigger > than unsigned long. But this assumption soon will not be true on arm64 when > using D128 pgtables. In 128 bit page table configuration, unsigned long is > 64 bit, but pgprot_t is 128 bit. > > Passing platform abstracted pgprot_t argument is better as compared to size > based data types. Let's change the parameter to directly pass pgprot_t like > another similar helper generic_ioremap_prot(). > > Without this change in place, D128 configuration does not work on arm64 as > the top 64 bits gets silently stripped when passing the protection value to > this function. > > Cc: Andrew Morton > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-snps-arc@lists.infradead.org > Cc: linux-riscv@lists.infradead.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-parisc@vger.kernel.org > Cc: linux-csky@vger.kernel.org > Cc: linux-mips@vger.kernel.org > Cc: linux-s390@vger.kernel.org > Cc: linux-arch@vger.kernel.org > Cc: loongarch@lists.linux.dev > Cc: linux-sh@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Ryan Roberts > Co-developed-by: Anshuman Khandual > Signed-off-by: Anshuman Khandual For arm64: Acked-by: Catalin Marinas