From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 122DDC021AA for ; Wed, 19 Feb 2025 09:38:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48C36440152; Wed, 19 Feb 2025 04:38:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 43B0E44014A; Wed, 19 Feb 2025 04:38:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32A54440152; Wed, 19 Feb 2025 04:38:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 15CBA44014A for ; Wed, 19 Feb 2025 04:38:27 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AD891A2F2C for ; Wed, 19 Feb 2025 09:38:26 +0000 (UTC) X-FDA: 83136193812.21.97F555A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id F408F1A0008 for ; Wed, 19 Feb 2025 09:38:24 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Mk4X7I+4; spf=pass (imf19.hostedemail.com: domain of jaegeuk@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jaegeuk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739957905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c/CteVhV3+o2NFoojWeZ9o5NAWQUMvgTRUAkB89CE3w=; b=16STJUmErRoM/OyJ8w6tLrbZNt5aSPqer63cFDdM+dbX4oA8+Y7bGWvE8lh1CzEcnl8PZI qzzS5+Hgj+lAUejSSggNkRIWLLse7gYh2uiSEXLIHd17jMtUoKSnhDnPhtDuHf6G/2hNbG uQiK4U6KYZ6/R8ehCKiBpYUANpA54gU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Mk4X7I+4; spf=pass (imf19.hostedemail.com: domain of jaegeuk@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jaegeuk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739957905; a=rsa-sha256; cv=none; b=T9Q6qNtNQhNDr99Q1ZpqGGRsyvJidu00W4x3TW0Ht9pRsyUMD20ZPBGpN+YQtnJkwHekD/ UNSyTJ7C+3rccaAVcu32aPoXaBxZB+fdoDuwMEzB+AjudyZTTwG6Oo6Endw/EUjUT1aEVg cAVLjFoXexs7W8gObhFl7Iv4OV852Hg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CDCD65C5687; Wed, 19 Feb 2025 09:37:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D3B1C4CED1; Wed, 19 Feb 2025 09:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739957903; bh=80I3NFEQ9dB3idbQ3rrlutO1WpxNEwV3ESxpvEHssw8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mk4X7I+4NK641JPh0lH3mxXQjPoMemeHNJVvxuFmmLHC/ixCa1WumSq6dDN+UTlpw zpUgxeiJXqYBElyQ0DUuYW0guCtjDYpCi78mBTZdKc1ZYh1YOvEi9mJvXP9b6EHWlm YQERNL01Ou2rIWZUSUECfVGTKQQXNoBJ3nDyfpn9bhl6froDTMMH46SmIILX7oxuAg Gc9nPV0WuyOoDvloGJC95f13CxxB9MO5/fFpM0spaDwQ25NgZy/oitF3thNmdPPSOc 4MrXUl8X5T49bOg9sM1P1IOiNOngbfg1IgoTW8bfr/EAseOp0qJHA7zCpi7XDqslBr ZZRGTJCy24gpQ== Date: Wed, 19 Feb 2025 09:38:21 +0000 From: Jaegeuk Kim To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org Subject: Re: [PATCH 0/2 v9] reclaim file-backed pages given POSIX_FADV_NOREUSE Message-ID: References: <20250212023518.897942-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: F408F1A0008 X-Stat-Signature: 751gwrdhmpwrjibhxcy8ghq3bd6rby5j X-HE-Tag: 1739957904-812458 X-HE-Meta: U2FsdGVkX1+os6gwx/0bL7eAXf8hpiHYzC+6WBbuEC9be2NKd41mDUJ0H7MaPG9FwxAK09hvdV61dt/ZjtNwuGq3cBAj26d5jLRLzyb9HweCdMIvDybSMqykRqUGx+BHFFSi1AmmJSLDdMP8JrfX+DYajprmBl6OCTJufETdMQW/eCrFhz9oDUTqXDUuatj2ecCvMSi+zrJPz4JvE+rdD2kMg7SstTyDHeH3M/rgKY+5dCQu5kwr3GDGQrTpfPtr1nUokR/KCAEg+xkAY90RMA2aKCn8u46OaZvmTTuRoU9cofUH3BfEiu4OGPBa488mhkhkDwt6hWa4te+C4rDfWOAME3GQpt9dEoYuYiBvKS/V1agktobkKcwgXzaQxAR8zBKlOXICZGwR/tqx5O8YSVGScDOvXh3nA3Oq/Rrjjua3LMf8kW7xqE0HoOAKYCVMKv9hADt8u96eh2mkY5be0CIXUEy/2W3xDcVvMMrXjtb5chG7aN0s+MJAwc1WVXAqYgEZdbxnuZXM/zXADBDFO91jsBig6FpE815lARiE+0qnqIw0Z47q/0eVmTbxmkwtH0nKkQ3P3Z4yGVf5HUPrV8zTQFo8igqfxG9Tg6dDiBERJ+Isc9lcQFHEVfVSBhDbbaSEDwdV6/Fj9Vk1HbNx614I9h72a2zI46avUUMFaDgJ/bMwectJ54ylNdmt08+41UQQDoI2arCXKMIZX+egDG7pxMdW+GW9hkQxVLflnUPVjkU5shd8oHur3i05DF3ZKkOz/k1o+WzyQ2AYVjKXbYAY4Uzz0tZ7A/AZhsCjYiFLmUyt8eP4n8vDAJ9qgSdNkKlsbXdQcMn1l5yccKO2aMou/2r4AUaNI3Y0QahX9gHL/I6BP8WYuEEkQ2k5iLRYNyZW9+uDby+5naIdRtvKMNJZ+lGNzNWJcX+6pY84ddUiGZxySeHOcufiH5TnS5IlCh7n7vKSTh7ky7Fjb4i 04OV2lZs LNWvwYnsTj4+XN7xEyo/a+qoSo7zKrpP/jbUYdIfxc45kwPF3ZTyVKsvVtAuzCSGhEVPcW0OgDz++PPlZtHHyJRSrapYJ4xg6fYj51UMRp+2Ksy/MElyYDOR+mE68FmDWDc7SYfZOWRdnM7InN13oW8TLpllk39ztmCXIrXIiwEZMCn4QhBADFxz7S7XTazhZPkeSMt7urZlH5roVgFW+XBFktN5PaJT7zWcaxrcl1ADvLOYbDVoeI6Kr1rfseHsSXYUacbmU8rx2nUGFxCe+0/0M20nBaAnrXDhcvXCFLo76EVZQ8K1LHPuCe5QR6fINUSrsDE6BioKw6ao= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/18, Christoph Hellwig wrote: > This still has a file system sysfs HACK, you're still not Ccing the > right list, etc. > > Can you pleae at least try to get it right? I was modifying the patch having 1) declaring a static global list, 2) adding some fields to superblock and inode structures to keep the given range in the inode through fadvise, 3) adding hooks in evict_inode to handle the list, 4) exploring which sysfs entry in MM to reclaim them explicitly. But, I stopped at some point, as it looks not good at all. Moreover, I started to be questioning why not just doing in F2FS back, given sementically I didn't change anything on general behavior of fadvise(POSIX_FADV_NOREUSE), IIUC, which moves pages back to LRU. In addiiton to that, I'd like to keep the range hint in a filesystem and provide a sysfs entry to manage the hints additionally. In addition, I don't think there's rule that filesystem cannot reclaim file-back pages, as it just uses the exported symbol that all filesystems are using in various different purpose. Hence, I don't get the point which is wrong. Thanks, > > On Wed, Feb 12, 2025 at 02:31:55AM +0000, Jaegeuk Kim wrote: > > This patch series does not add new API, but implements POSIX_FADV_NOREUSE where > > it keeps the page ranges in the f2fs superblock and add a way for users to > > reclaim the pages manually. > > > > Change log from v8: > > - remove new APIs, but use fadvise(POSIX_FADV_NOREUSE) > > > > Jaegeuk Kim (2): > > f2fs: keep POSIX_FADV_NOREUSE ranges > > f2fs: add a sysfs entry to reclaim POSIX_FADV_NOREUSE pages > > > > Documentation/ABI/testing/sysfs-fs-f2fs | 7 ++ > > fs/f2fs/debug.c | 3 + > > fs/f2fs/f2fs.h | 14 +++- > > fs/f2fs/file.c | 60 +++++++++++++++-- > > fs/f2fs/inode.c | 14 ++++ > > fs/f2fs/shrinker.c | 90 +++++++++++++++++++++++++ > > fs/f2fs/super.c | 1 + > > fs/f2fs/sysfs.c | 63 +++++++++++++++++ > > 8 files changed, 246 insertions(+), 6 deletions(-) > > > > -- > > 2.48.1.601.g30ceb7b040-goog > > > > > ---end quoted text---