From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58275C021AA for ; Wed, 19 Feb 2025 09:07:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBF5A6B8001; Wed, 19 Feb 2025 04:07:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4841280215; Wed, 19 Feb 2025 04:07:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E8E26B8001; Wed, 19 Feb 2025 04:07:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7ED17280215 for ; Wed, 19 Feb 2025 04:07:49 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4230D141445 for ; Wed, 19 Feb 2025 09:07:49 +0000 (UTC) X-FDA: 83136116658.13.477EDFC Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf01.hostedemail.com (Postfix) with ESMTP id 09C8540002 for ; Wed, 19 Feb 2025 09:07:46 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="FBjrR0s/"; spf=pass (imf01.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739956067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ryfr0CU36vN7+jmzrOyt57Ph/Uv1z6uRDIAhIKlsULY=; b=Kp3mTPnbEOz2cYLlps/eVsbVYU+GnoyZgeTZnmAdIS1djUiqR0l5L/HJppA1/GaM6SCUAn T40uw6TCX9cdtJHpZjsvzqleN2b4VLHvBLFMiaiZxQprA+P5Bh/l7BVSF9Z/3KvpBcZUBc 2X/SiC5rGoSvMGkh7Kp6IT3zYYNY1KU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="FBjrR0s/"; spf=pass (imf01.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739956067; a=rsa-sha256; cv=none; b=e1z5elyb4J8aEGGrIETueHdf37gu/UHvfYPNURNsH7M6jwOqnxfeD/8rkR07jWqrj9Raiu eztKf5WmvkQlbVnr4OAoXt2PS6cPy22TgoGgDhfDCXfMhxepoY1GDFt+lEkyY0Xvno/Kb3 2dtb4jj0GX2io1U4loJSFXrIGzCzbvE= Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51J7WiEE002845; Wed, 19 Feb 2025 09:07:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=ryfr0CU36vN7+jmzrOyt57Ph/Uv1z6 uRDIAhIKlsULY=; b=FBjrR0s/QNsCmVCSuEP7i/53obfYBs/I2MBFXEICWNjEdn vphgR3aGnO1T8iLmK+14DsPyJD9wxaoA+5CTGTw2OlLamCTD6VGjiHOtyWAlNFUN YYZT7jDNumAF75ada+/wnCkBpEf+xHbE6aRBBr6JoGc3G70rFk0ZHFDCiB1G3hsY gFead0eedT6XQdUW4gRJ+qAH+Ctnl9apL2VgAeZtfaEO7v9IbQEsiod6ytR8SWdf 09SN3Aq4sBOGtYXleXw7UTeN8Yv5Li4l/2zbZtx3lFMl0gVuahhaKYehI8Nqoz/h jfofbcP0XgZjR4bt9907Vu+Z7aDMW9rthjW057JQ== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44wb0nrdrd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Feb 2025 09:07:41 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 51J70NCq005776; Wed, 19 Feb 2025 09:07:41 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 44w02xb5vq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Feb 2025 09:07:40 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 51J97cMe50921894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Feb 2025 09:07:39 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CEE232004E; Wed, 19 Feb 2025 09:07:38 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4AAA520040; Wed, 19 Feb 2025 09:07:38 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.179.14.227]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 19 Feb 2025 09:07:38 +0000 (GMT) Date: Wed, 19 Feb 2025 10:07:36 +0100 From: Alexander Gordeev To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org Subject: Re: [PATCH 2/7] mm: Introduce a common definition of mk_pte() Message-ID: References: <20250217190836.435039-1-willy@infradead.org> <20250217190836.435039-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250217190836.435039-3-willy@infradead.org> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: XeW0LQaSRH8r_Q5pce4tEmQwYdTmhkwx X-Proofpoint-GUID: XeW0LQaSRH8r_Q5pce4tEmQwYdTmhkwx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-19_04,2025-02-18_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 mlxlogscore=547 malwarescore=0 lowpriorityscore=0 mlxscore=0 phishscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 bulkscore=0 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502190071 X-Rspamd-Queue-Id: 09C8540002 X-Stat-Signature: fbgb3wgry4qht3qhozhc1y1jc43xdbqu X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739956066-50875 X-HE-Meta: U2FsdGVkX193HrMLKY0Mdko+6jFE83I653plWtnm98df4tkGUuc6HG7i5OGWJlB1DA0MDaE2mHxFOVktpPmQgky4TKGG0f8HXdl1nLCFA8el65kGGnQSoaIsP+DNnxykklcoMUoC+NPCYnE/zNptR9xtJalfDxshpJ3isMq6Zf/iRvpPWLLb8IZ8MzYXsMPZNfswVysSPHZy2Rrhqztx19b/Ut7AKCIFzBXQL7I6pB8pFERb3eJ5+jEiUfplsGFD8oJSYT8k7K2Cy6/APAqPe+hUkrKRnDVZOVm4NpUejwmMzfQZ0SRCqG9cyBBOawrLiZq+zw4uBsnINc//SENdtb+IE9ZOxcnfosK5gKNQyhinWMdJt/OfSTQT6BiFzNolHS/Urgb+LtPlBm1nZ4kBIR7Ep5puZfLeQBPxkgSdH6hK1ALJWrEToZI54eZn6PSmmoRGjH2YwGhiRFsx5EIX/GTuiQGR04ncA55wykf7KX3D4Z/83yQzLMeoyM6Okf/Hk3uhsCMSVhqVIlBHa+alrOpiIuR2ur7i7GA5+rxJuNs4s9NUVcywKFIh9HHHR7dP93pxSPBW5FWWOahi3L9/aymkKFFL3XlhHzJvqL3JPnhdCVQbGIFGSTgLwfc2FQESLNKwWoF386+NzSMDTA8YoZDUFuUwteIxaO74BphhHXi2LkxDLrhE3YYKyAl0AhMWapLuPZ0tc4kZ//zuEZi8nN4EEdOPBAiWtAwJv87Zp9hWeSPiPBzylC978iJAqsr7S2uU1OegGt9yphAj9rENDW4gWvIs5UunLZX1ZJ03b0KL99ojajR2VA+SBo4zBQ8a5CkeG4eWujyQx2GvojFLIsoDDTzSyKDzzSwjYUAcyG5Hq9KknriHvAmBqoboPcriniaM2CKzuhKIi2W1AxjGj8PepxWSj/2PFCK8g2yTpwYyXAdKnYKPmZz8C2Ueo0jI/8yhZYOx0UFCuORM6pF 3iJTzT9Z J9qd6qElxLBUGIn7r72Q2uwNyTUqKy/cxR8kuUb11+hZC/784DYLAjzL+9x3FN2LIJSZ+8SbLXFtd5BeljaRZdi39eIh9OJWeVzdNEjsk7eomvTEcfC16BLsfTV49DGH0Kr4oifUPXW4PEHjBAPIYRG4wkV5dZHrwtOTtNH8Pl78fdWmVNj2SeHWxFpm5OQFAfUP7ZXO/lwMhNdWX9T4HypcRkfSTuMWTp/e7QB9phf3boyGkNFPJA+4O7UlZDDWRc9EiAgkkYXMmNe9aJA65hkOIXOfh5HrNAC/VPD5b70q+w+tRjsbaGfZaAqFTQ/0ANlptFADY4sEYKdW43q2yv8gK6iYAIWe0ZSPO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 07:08:29PM +0000, Matthew Wilcox (Oracle) wrote: > Most architectures simply call pfn_pte(). Centralise that as the normal > definition and remove the definition of mk_pte() from the architectures > which have either that exact definition or something similar. > > Signed-off-by: Matthew Wilcox (Oracle) > --- ... > arch/s390/include/asm/pgtable.h | 5 ----- ... > include/linux/mm.h | 9 +++++++++ > 22 files changed, 10 insertions(+), 99 deletions(-) > ... > diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h > index 3ee495b5171e..db932beabc87 100644 > --- a/arch/s390/include/asm/pgtable.h > +++ b/arch/s390/include/asm/pgtable.h > @@ -1449,11 +1449,6 @@ static inline pte_t mk_pte_phys(unsigned long physpage, pgprot_t pgprot) > return pte_mkyoung(__pte); > } > > -static inline pte_t mk_pte(struct page *page, pgprot_t pgprot) > -{ > - return mk_pte_phys(page_to_phys(page), pgprot); > -} > - > #define pgd_index(address) (((address) >> PGDIR_SHIFT) & (PTRS_PER_PGD-1)) > #define p4d_index(address) (((address) >> P4D_SHIFT) & (PTRS_PER_P4D-1)) > #define pud_index(address) (((address) >> PUD_SHIFT) & (PTRS_PER_PUD-1)) ... > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 7b1068ddcbb7..3ef11ff3922f 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1916,6 +1916,15 @@ static inline struct folio *pfn_folio(unsigned long pfn) > return page_folio(pfn_to_page(pfn)); > } > > +#ifndef mk_pte > +#ifdef CONFIG_MMU > +static inline pte_t mk_pte(struct page *page, pgprot_t pgprot) > +{ > + return pfn_pte(page_to_pfn(page), pgprot); > +} > +#endif > +#endif > + > /** > * folio_maybe_dma_pinned - Report if a folio may be pinned for DMA. > * @folio: The folio. For s390: Reviewed-by: Alexander Gordeev Thanks!