From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29CB6C021AA for ; Wed, 19 Feb 2025 07:27:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DCB6440009; Wed, 19 Feb 2025 02:27:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 88B702801F6; Wed, 19 Feb 2025 02:27:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 754A3440009; Wed, 19 Feb 2025 02:27:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 54C802801F6 for ; Wed, 19 Feb 2025 02:27:36 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B8E2E160805 for ; Wed, 19 Feb 2025 07:27:35 +0000 (UTC) X-FDA: 83135864070.23.BD53669 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf30.hostedemail.com (Postfix) with ESMTP id 83F478000D for ; Wed, 19 Feb 2025 07:27:33 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=R7iIvY16; spf=pass (imf30.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739950053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7cnvWzA7RfaVCOT66pTUOghWekuaZgxsFcMzX2h0QBE=; b=HoV/ms94QFCBOueUIzJLfIJnxVK3MRZ69aY7kz77CrOsmlMiFWeTNzIPEjPyw5/K76ljmC Qr4WCxBcpknuNJaUsY2/tfSXjjWWY5pa1YrvjyTjxR7nmRtOGzeXduRuU12TrYg/I54QwP Zwl6X3cCrjyPGtzGQUu2OpzAUZ7PRaU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=R7iIvY16; spf=pass (imf30.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739950053; a=rsa-sha256; cv=none; b=eonfJP4fnyb6dglwlEy8hlVNfZA3GEtE7DrQHjpNAqPlBNFOtnZ0GMxBbW/GB/XlYgPPQM kL6Bnp9sfv1PilFqJlxhj8L3WwszNvDqmfG7pNXBAr83J2BpKWwhAt+d0m0x9nH6X/V17E IYu0yvpjhB1tifK6eXvUyiAlzAnGQKE= Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51J75IAE001899; Wed, 19 Feb 2025 07:27:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=7cnvWzA7RfaVCOT66pTUOghWekuaZg xsFcMzX2h0QBE=; b=R7iIvY16LPJs0SC10eTbpwjNLhVbolsSaxD1XsJbVDUqmu j4aNluI6Y1sE0K+zEiv+hGEYnp0ZLBp6q53QAlxiBhjkdesvKL1K0ElytuHPKi0n WbRK5AYvW3AlKsWQE4yXqn6SstVjzpQ3wldstJeOkCSTZ7xTwjdyMDOdWlPmtWsT ReuIq8iltTpXJtI2o+ZHhbPNvUJ9YscNhq55EeiKZp2boaLjcz1R/049dXNPAbLA 6TO9/wW9TSwevn9l4JL2JQ/Q885FhOWw511FosvgHbEM4zjCrvOthqydWnv0h+Kk gse7GpwQ29bhz9qD3tX8hc6MY/G5BAYdFLw8PdrQ== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44vyyptgrs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Feb 2025 07:27:27 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 51J6bfxa030158; Wed, 19 Feb 2025 07:27:26 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 44w01x2spq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Feb 2025 07:27:26 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 51J7RNGk50594202 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Feb 2025 07:27:24 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 63ADA2004E; Wed, 19 Feb 2025 07:27:23 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E17AA20043; Wed, 19 Feb 2025 07:27:22 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.179.14.227]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 19 Feb 2025 07:27:22 +0000 (GMT) Date: Wed, 19 Feb 2025 08:27:21 +0100 From: Alexander Gordeev To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org Subject: Re: [PATCH 1/7] mm: Set the pte dirty if the folio is already dirty Message-ID: References: <20250217190836.435039-1-willy@infradead.org> <20250217190836.435039-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Qw4yE85lztD2877JVVqO7QrP47WEM6hu X-Proofpoint-ORIG-GUID: Qw4yE85lztD2877JVVqO7QrP47WEM6hu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-19_03,2025-02-18_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=332 clxscore=1015 suspectscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0 spamscore=0 impostorscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502190053 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 83F478000D X-Stat-Signature: 9jews4pk7wrzcrrhjqwnbp8453gbzpm9 X-HE-Tag: 1739950053-588108 X-HE-Meta: U2FsdGVkX19fLstXr+ofTbTnlyEC2M2bgY7Zq5WPpnl6jf7S+COXm5+xl2/HVrQm6cB9RdK7bSv2w2HgV9cyJkzqQPXnTJmu9lOjkOcDkmgUtDkPp5FxQxmkpUcfHB4G9+bG++3U5UzF9rVw/jSUJRqCKdxNAcmxOXQq+RgRLF7cZsCEdGIpIoYCEntva0QFHShwvVyYfxpOlVRSYH4p4VWzgXLu9yUqVWWiNsKRc8KLdI4N/QIGoHW5h4U0ohsjKDMFOYda4Q3ddBejMM5mGcjTJoNgpfkRCle9HfwJJ1LeosCToVK/lw7PotKK27o1kI7ZpkrlYSeh383YfofGmU7VtqpAzyEmvxIa2y/HuOpb5uZ7hB7vd60Y/B/A8lgQ9gn5IXPl9t/v07tEzskpd6qtqEa12RgoKSWWDPBInPP0NOQcp3Pm0uFPcSr4ZKCwEqda82fBJaS8KrrWJnk5P7LriGBpI2ZIOikOX+Cy5lWiAuPWgBq3hGpstLT10ClPcjh+tHuq/YFUNygHjKm2HFsPdWHbclKUdLVx0ewWo9+zXcE7kQZ1cTe6mrMji7oT0aDkY+Icqasi+5SY2P2J7A7/CKJIY5O8fQ9T4NRcAI4Eh4HCiUemJtHmmCCpiRpcYVIThE7OyGINTrDVPI8oji9IFjd3RSdbMelcF92RXbHyLMaeGrqf4dj0zpOMiJ2izZ32t+GxhXQmjlf1tSN68I89kjla8gOAWU96FpBS1v+apEAGmglXPYNCw92ye2FsVAGECfiiTJuUDYZugPh+RKObB3ovYKyRqJNnLM2Gx6bZJQu/0iheK9vDr7iubHFPdwCcWU7NdBP8TcW/pX8IsjEZCUumdkMRXzD/Yn6yMzHgRQziymj5sx5fC+F5/8YJisPAi74Ai1tGdBT5+/4VQMc4jsboSS+z7HUu6uENPsV3ilTFioZXlngnWnAJZyMTAZSF4G7OW+xuwzFIer1 Upq+qJ1q /P63lNi9WGF4RyjSOT2ZTQU81flY1IgMMipfihfrVcU8vO1XXO9pU8M9CjaKpqhnM2wtzkY8dSiy+Tdg803fKwG0xYAkW6gdQ1fMLhC/W9HelL4NHfYGyYi5LC4xgHzTZf8UPg5xIk8gad62LPkPOE3jdjgV+ptg7tcj0Xq1Zf8N5FJ4Glxj0o/mXiAemghWeTb/j0H5h9UgYwALZhNbSxHCUYdQL04huFPnl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 18, 2025 at 05:06:38PM +0000, Matthew Wilcox wrote: ... > > With the above the implicit dirtifying of hugetlb PTEs (as result of > > mk_huge_pte() -> mk_pte()) in make_huge_pte() is removed: > > > > static pte_t make_huge_pte(struct vm_area_struct *vma, struct page *page, > > bool try_mkwrite) > > { > > ... > > if (try_mkwrite && (vma->vm_flags & VM_WRITE)) { > > entry = huge_pte_mkwrite(huge_pte_mkdirty(mk_huge_pte(page, > > vma->vm_page_prot))); > > } else { > > entry = huge_pte_wrprotect(mk_huge_pte(page, > > vma->vm_page_prot)); > > } > > Took me a moment to spot how this was getting invoked; for anyone else > playing along, it's mk_huge_pte() which calls mk_pte(). > > But I'm not sure how you lose out on the PTE being marked dirty. In > the first arm that you've quoted, the pte is made dirty anyway. In the > second arm, it's being writeprotected, so marking it dirty isn't a > helpful thing to do because writing to it will cause a fault anyway? > > I know s390 is a little different, so there's probably something I'm > missing. No, it is just me missing the obvious.