From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55804C021AA for ; Wed, 19 Feb 2025 07:13:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C53592801FC; Wed, 19 Feb 2025 02:13:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C03E52801F6; Wed, 19 Feb 2025 02:13:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACC532801FC; Wed, 19 Feb 2025 02:13:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8F8682801F6 for ; Wed, 19 Feb 2025 02:13:48 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1009FB4A6F for ; Wed, 19 Feb 2025 07:13:48 +0000 (UTC) X-FDA: 83135829336.04.5293562 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf08.hostedemail.com (Postfix) with ESMTP id 763E2160004 for ; Wed, 19 Feb 2025 07:13:46 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qduPPg28; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739949226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jnJdwFcCP5YS3M6eDMp4EEzAiQ1HzVDUaylHfaqpvE0=; b=P6DOA4bbeTRK3m8KWNh2GV/2oS01HphMC7Cwd9eGfqriTyY7PRlJAtQFx47IToCv+zRdGA OOxDK3vhkHH1K4FCbV4IhruhrpwuRUP+TaTEb6vIq2iktNbdaXDKcVJxpxSP1Yx02+Xl/B 325pQMK4ugktYs6q4pS070JzyJ1GfQU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qduPPg28; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739949226; a=rsa-sha256; cv=none; b=vbYSyyIpAWjyZevLx6x9lIH2s6xCMDDOMJ/5tCb3zTCzkZZj4QGLtfBE5KU6BK5YmR3NWj FsZQv6vIWzcn4hY0wC5lTgHfuigXKyNBGHFAVEDf44tjZS+YrS02A8K+NAY+/FolC9tO4A LXzKN04vZYTzmsWHjcaa9fGlgnUiGSA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A5ED7A41D17; Wed, 19 Feb 2025 07:12:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC035C4CED1; Wed, 19 Feb 2025 07:13:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739949225; bh=OOkIIvDjmX+t2iEfuOMs0YPPPkHDOiOCixy3iRv3A8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qduPPg28qy6v/QB2ER32fPvjQoDtpyv930crMRnp0aN8TEE8OmFoqthIOFykZwRUv Pu5NZzJrifM/eee11PWKY563kbOVj9pdGQINPO0kLF/ykiEYMlFp8If0rTc0bF+qMH z4jFYGZUOaph33hZ8GK2cqPKJAyLPh1mo2vjjrA51c1No2p8SQlBkCAgrWnZQda/KS v6D8f2jjdG79HKjq8kSAwlDcO8BzV7Sa2td93q5On4iUy0BIocozKb6VSGbhwKR88x Ia27HNWGMlRKtVxcp2oFAUWuILbF8hDquZj1kRt4RWMWLpZKKmNxCS+wn4F23U8iXo Mew6Mqit71sDA== Date: Wed, 19 Feb 2025 09:13:22 +0200 From: Mike Rapoport To: Wei Yang Cc: linux-kernel@vger.kernel.org, Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Krzysztof Kozlowski , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v4 01/14] mm/mm_init: rename init_reserved_page to init_deferred_page Message-ID: References: <20250206132754.2596694-1-rppt@kernel.org> <20250206132754.2596694-2-rppt@kernel.org> <20250218145904.x57chhz3whvckzu3@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218145904.x57chhz3whvckzu3@master> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 763E2160004 X-Stat-Signature: f9jnea47k7kzmkxatrs4g5smxpk3dkux X-Rspam-User: X-HE-Tag: 1739949226-162885 X-HE-Meta: U2FsdGVkX1+lx3Lu8RfZICJSIJZy3wDszWLeVfaQ56oNQHkD0YwfyY0I2OAKPwdJ9WVy5tHu6kUoUSJgk0s0uTbbgO75HJBpTxotBT9SkmCKVd9vNZj1O6GhIQwmC0ygtpRP4ZGj0wJNN2cPPLFjv6PcC8hJYonXk4k2U1UyI8p0x2q1PLNXRp7CB6IjxQNipCpAwaPSVRbDXhq9YntbcZnUTF1oiF5Ieh76SQuqEkVs68LgcY+SE9EdfSzgschlGPWocR5e+Aob6Sfrifw8GW/Hjh4jaXJdc6K65kLJPulVILgbvmPXuxLs6Ina40zJnQrgOUdCV6i0zsgrlEl3p3jjBSzwvwneaGnG9LgThv2KWIKPdDx22X9TXip4pn1GJFjFURTvqjdBrP9MhHEpk5xIc2Tk6oVBdNL+mY9Gjxlgkrfxke9e1b4NHU50jBb1F+Mq2Nf+gDaT9cJNeu7IlP6wm72ya3W2116ja8V3wLWvypUGikVFJ+omjFI3prqlpPZOlJl/9RG68z/QEtMnem01+ns2eaYjdcWSkcw/eDk+bNjwWEy0UH7fr3sEVSkSuy3SXaTeYex31jZQ22ejxI37TsN38xI6qHHet8gdVIPB/JXd4xRPHxh8QI7veQwAva//2XcJwIXldNiGmYzJPo6PvystxZq7QkCN9zzfk3Iekz5vSVGhXTSVfPAcA4nxIapd2DMXMO6c8D4zsKFyHw54dN3mdUcGTtZTbFb3KRxlPOUktSPIMJ7yxFV9ac1irQ9fechGdLlzROMjnrsQsj6klW1vyBBjiKu+iJwfN1xa1Zujx2y4qsnsXT8ADPbuKUB5hYnoM/leLkPJvTavo/143BaG+B7iswGJm4gmSMyFKbOhaZlcCUd1aGQoLMFuxR7vwNNREDob+K3oanLOjjhBC1LImA91IgBVrzUsozNR97tUv6GGaTqMFbL/qkFRHykEKoN5SjumAQb5zs8 yBEXUlry Sy9ANvHmaLSW4W8sG2WgKmy/OFRszJDaV2TNXTUJ3j89icVYF99ufeOQUbR7Ls6PW/FyOAtq5yu3wlFLsSDoc73WR3syLxIr6PytoVeJnhdQ/eXU4aXm2zfb0Pk8D0V0WuPhgPyiq+tccd44wK7Zbs+ePuemu0LZ6ZLVxvPACenpifB3sIzDkkNbaFZv8S2sSJEEOYt7HywXfPID7rGySRZ2waNXhz4Zj6ZlRH33tQZGlxUO9XR7nP1ei9FOmDCFtbRxngZjkV0CYrnG0pFpE7/eZrLVi+PJTGKyEgsOnBA958Tdq1z6B+935Lb1VLIW22T6EWEN6OolrrkroshwuPj1zax1ImmNqGr0LaHzwmUAVAyW6lGasUlBQ9A2a+GfRIPkoQMTfoUwBKs07hco66ibmAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Tue, Feb 18, 2025 at 02:59:04PM +0000, Wei Yang wrote: > On Thu, Feb 06, 2025 at 03:27:41PM +0200, Mike Rapoport wrote: > >From: "Mike Rapoport (Microsoft)" > > > >When CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, init_reserved_page() > >function performs initialization of a struct page that would have been > >deferred normally. > > > >Rename it to init_deferred_page() to better reflect what the function does. > > Would it be confused with deferred_init_pages()? Why? It initializes a single page, deferred_init_pages() initializes many. > And it still calls __init_reserved_page_zone(), even we __SetPageReserved() > after it. Current logic looks not clear. There's no __init_reserved_page_zone(). Currently init_reserved_page() detects the zone of the page and calls __init_single_page(), so essentially it initializes one struct page. And we __SetPageReserved() in reserve_bootmem_region() after call to init_reseved_page() because pages there are indeed reserved. > -- > Wei Yang > Help you, Help me -- Sincerely yours, Mike.