From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EEA9C021AA for ; Wed, 19 Feb 2025 00:11:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3ED42801C0; Tue, 18 Feb 2025 19:11:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC8552801BB; Tue, 18 Feb 2025 19:11:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D41402801C0; Tue, 18 Feb 2025 19:11:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B5FA12801BB for ; Tue, 18 Feb 2025 19:11:09 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 402E7B13C8 for ; Wed, 19 Feb 2025 00:11:09 +0000 (UTC) X-FDA: 83134764258.06.C85E798 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf17.hostedemail.com (Postfix) with ESMTP id 2FD4C40010 for ; Wed, 19 Feb 2025 00:11:07 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=dKI+fBOT; spf=pass (imf17.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739923867; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wje+37OUw3EOY3E8DdGEm6PdRUyXBW2L3woHBy7T6PU=; b=TjXzZkD91I77KcdeEdj7qhOt9TRVTzeHET880jcBj5kRL9S3p6Yils+9u545cpFmt22OWq 6Wq5OVFwjZt238EGE+9LKDuOpdNvGgH+R+EWbaaV1YhCan6R1aSUmCMqNKIeUkhE7nxgN9 qlpNy+jlRDa1h0IQmbRz6hsSvuJZ7VQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=dKI+fBOT; spf=pass (imf17.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739923867; a=rsa-sha256; cv=none; b=nhUgd1WU3Qjsf5s5pr0oKSMMmLqKsyP4f6sLcdMs2P2eOpgNCjlk4d1EXWhxRSjpl8Y9q8 CoYJzKjU/C7FXvBR7fxGsLVaCuCgpikIKIrKxBbCDw4RFrhJ6qKZjyLCUbrLeUQo/zNvCX rm1NDuDSP1iWY2CY827zdHKDk9Rp7rw= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-22113560c57so65432935ad.2 for ; Tue, 18 Feb 2025 16:11:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1739923866; x=1740528666; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Wje+37OUw3EOY3E8DdGEm6PdRUyXBW2L3woHBy7T6PU=; b=dKI+fBOTcH7rL6gIMY+ZYZsD5lkQEROKWEvIFcJOPpNl9XSKK/GfzC8IFMymuGyKx7 VKF7W38RTxLVNHITMIz6Qg6TWNIA6DuLTtZa61pZTuDkE1f9MQ6xjuQW7efYBBcEYtIc 9qGMqWDSq7yJp2srBXrZ9lfsdtZHs66MIiOLLxtM5CklWdCJ6hzbt7K4lCnkEe0LgbTL dguIGDLG5zE5bkIX96Z+k5f+34Pn/AMcZqCxjd5BZU/UmmhZuGjSdzTNiXBq32f4Rd8F GV91gu2OxTCtC7xNSJyQr1HpXiwEvvRFObeDWngEXGpn/MeB6XqXgpVs/eEOFKpoe8vi LBhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739923866; x=1740528666; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Wje+37OUw3EOY3E8DdGEm6PdRUyXBW2L3woHBy7T6PU=; b=wWtI6LTq96EyvLLuzMWWRMm+0GbYWTyIBDP/EFgxxjqM7ufw7+y9dzTz7kTKNzlyA7 bap1UC+FxXc6W7/uwsO4otC0jc6U92SAxCq3/nalxlYBTFhKbbr/jr3fPoGKO9jlSPzt v3C2TNX5Z+aHzoTD37yv4HblbI6RubDeXU6RmrBEH1YpOy8cdCeP6wrJs4QCJX4CWZHQ TFqEBhsc/mEzGtkDaPdPTu8cVV69JMw8vaLYviy9RKhisKGZkkmxPhIbzkm9ul34MPht Gk+scPNOme6P55KRnxJaLTYXsvbl7r07FM8xyNHWwn2/QpCnSKXoEpdCIlISZ9TJHxfR 3wkg== X-Forwarded-Encrypted: i=1; AJvYcCXNEjxncsUlxrArY6PLYUhEofn/4ONDnDSlXoIZesztPgSUvSW6QfSpTt0PjGIkkwz+Rj/jJgZt2w==@kvack.org X-Gm-Message-State: AOJu0YxGnFYRmBWgFmy30ZnCNTwZYXNWaDHzvoF/F0w5lDtKkAFKZDc2 LhMiZ5LZ+b7X/EYEFjNamP0cF3fK2Ex1S9MeuDBwnnj1caA+6EdirB0bKGi3ipA= X-Gm-Gg: ASbGncvWtAibuzvZ6brV5IWv2AWp9CxdkqlVRh0yBVJxk7lEEmPhLpPe9dOG8x0nphR lOSTSIjQBnSd3q7G6xWQFvM0C1AH+/z8sIc37VhMs2VLRO+lkIXYjzBMZjmHZQW2frxidWb0VCR oPldT0cPboKRdTIhGMfakdLJFoOC3vfTXwA4XGNFArDg1Fh5a/9EHdsIMMg5Gt7xo4zsvb1HjQo SJki5K1LUSt9xPw4u3rPmtnpFXfjDY6AnZJONXh1DZdnwBM96PU9f0k+WsmmgmpjkGg7ErleZzh a4+6MVpLadf7gQVLCVOs4IxX/3FONwIkEQA9veiUe+kUGMSHmoN8Bxya/UCv8IpJ6B8= X-Google-Smtp-Source: AGHT+IGzNw9N6vIVHFFoSDN7U/7f25cr4Ncvov37jFAYdeOGbe9w5NFdAS1CNJKBD1dXb4wW4OuzXQ== X-Received: by 2002:a05:6a00:3d42:b0:730:8d0c:1066 with SMTP id d2e1a72fcca58-73261911238mr28880688b3a.24.1739923865977; Tue, 18 Feb 2025 16:11:05 -0800 (PST) Received: from dread.disaster.area (pa49-186-89-135.pa.vic.optusnet.com.au. [49.186.89.135]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73272a28fe5sm5802089b3a.101.2025.02.18.16.11.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 16:11:05 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.98) (envelope-from ) id 1tkXg7-0000000314I-00od; Wed, 19 Feb 2025 11:11:03 +1100 Date: Wed, 19 Feb 2025 11:11:02 +1100 From: Dave Chinner To: Jingbo Xu Cc: axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, brauner@kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH 2/2] mm/truncate: don't skip dirty page in folio_unmap_invalidate() Message-ID: References: <20250218120209.88093-1-jefflexu@linux.alibaba.com> <20250218120209.88093-3-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218120209.88093-3-jefflexu@linux.alibaba.com> X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2FD4C40010 X-Stat-Signature: kn146jdn9161pb47fxygcw5iznamcwxq X-HE-Tag: 1739923867-76242 X-HE-Meta: U2FsdGVkX196Q1sRjWLQFLxx8UIerox/0tXqI6Gmr0UEyQ6VpvIPKgvhh8E7d5u6oxmsAqTDQtU+UsghxTwmadTBPuIC+0/jxNYK8rEGIdoj96ZmiY4Mq5fAp8VEsmRHyk4zqpkO+OPoxAu0f11PSWDtDZHGB7XretcR8vJdzOVZEEsI4VoFf800dylLOEC7Lbv0+EX3e1Xme4xEQo6wjWs2siplrGkr8QdIOVcTk0H5lCU0E/ewAHxkWS/X+RgIGR77ShkjFsgDSM6/0/3heASCWJB1wFXHo3Ww3xEYHBs5mprgXPXXdSgEbg4x23GiojXTO9DPZq3wsIKUVjWl4DOVJTHP/IcVVvosDJyVbamuKQpdE+S3kkwfRTeL4ExUeNystrysrJBuv5AkVQYPxawhQzy/+Jyk3LC2TCGNFzWU5vF1yq/5yL9nWg9u8SUAm/+8astb+S8sKo9BU/Pm4Z8bMRAaipOC7bU1q/RTguziaQ2ASy1/tIujBTQyn8sYlu0taJ/sSjPvPXzV97I60MFj66qg1z2OyAH8wWYcNWPvp9KKxAdIUsMlsUKdTNBJgEFeB9HlAA9ade9hLPmMaq5f9N0FH55lLi8w9TdgaFdwA/KZowSRKlapOV8e5Bn9SpHLUvyYoNDXq+YHZVB7fJ7xid/Pn4iHA9MpXFQCWgtPJpIGzGMcUe3vJfskuM22NryRaMYhc/d3d+NEKYTNBl2zdzM6x7CII71a4RquLfHKAwRH1+Oe+39Kz9IaBy7lf8f6MRjOK0U0GQZGTx30hNx+6PiElx5xhLo8jYc4uiKOg+NFoWmfS9XCLjzYJV7j44c54bVMR9Tve+ASGoQRlzW/xnYxDw48os3zbSuoTHuUl/BSyXN3+VW49mJxO6B+7YfOmr5+gNPyLlzEf9ezEzpdZj/3LDHYO33mYjLm2kK1YqlH+S3lLaqOg9YtT15SBiwfdMMl+5PA3wK0eMp N1OQPUc1 tzWxTcOZtYXfZovRTUbI5YCPE7ytaA8LRKCCh7rMQiVsshVma+bke6Oj0OB+1jbvbliDfz1w0bah0PmWTj7huEJsO3Oj40noGAxO2uohzRcAY/fAEc3+43nEekBY5hO5jUZ2+JXFAkIZ90Pe9sZk/2WHWQs4Pqep3thxWhxLHkCGfDPM2ZlD94cR2KDNqFWuwLlomGdW+j1SPGxrO/qGxZ1qMC2yB2ipBBQOFbDDRGCg4WWlU2ojIwqOF2gwZclxQX+tnllJco8Wrfn6ZrwIuWDPKbQWRcnaiGNNJ4OR1M9KNsn0v3z6YcJtYRZVGhqF3Ap4YzLD0Bw/nEphnXUBoNFywOFcFPag2Jf+LTn4i2dMnoN8dkTfHrFoo5uL2reewIqhrQXEVFFR25xb9Jjm+P5m313dGIfB6DublngILsE3Ailho4GNgB1XB6bu82dEjjiWGEJrN4Q7ua98tbuTp3o/Q78+p7JCLGCyOfn8z75esmASq3tRBgC21L+dpEpDslymN X-Bogosity: Ham, tests=bogofilter, spamicity=0.072249, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 18, 2025 at 08:02:09PM +0800, Jingbo Xu wrote: > ... otherwise this is a behavior change for the previous callers of > invalidate_complete_folio2(), e.g. the page invalidation routine. > > Fixes: 4a9e23159fd3 ("mm/truncate: add folio_unmap_invalidate() helper") > Signed-off-by: Jingbo Xu > --- > mm/truncate.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/truncate.c b/mm/truncate.c > index e2e115adfbc5..76d8fcd89bd0 100644 > --- a/mm/truncate.c > +++ b/mm/truncate.c > @@ -548,8 +548,6 @@ int folio_unmap_invalidate(struct address_space *mapping, struct folio *folio, > > VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio); > > - if (folio_test_dirty(folio)) > - return 0; Shouldn't that actually return -EBUSY because the folio could not be invalidated? Indeed, further down the function the folio gets locked and the dirty test is repeated. If it fails there it returns -EBUSY.... -Dave. -- Dave Chinner david@fromorbit.com