From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF32DC021AA for ; Wed, 19 Feb 2025 01:46:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE2742801C8; Tue, 18 Feb 2025 20:46:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C930B2801BB; Tue, 18 Feb 2025 20:46:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5A832801C8; Tue, 18 Feb 2025 20:46:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 992952801BB for ; Tue, 18 Feb 2025 20:46:21 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 47BD544E39 for ; Wed, 19 Feb 2025 01:46:21 +0000 (UTC) X-FDA: 83135004162.24.BECAAF5 Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [91.218.175.187]) by imf25.hostedemail.com (Postfix) with ESMTP id 6EF6DA0009 for ; Wed, 19 Feb 2025 01:46:19 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xQkuOlOf; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739929579; a=rsa-sha256; cv=none; b=RyN+GzQTkH5mMttW+fQFR28Y1HTaNX/Eudpk72uJtUaXjFeZ0cv6eG7SxFYo6Xfw7kzbei kFESBek0Jr4m89/nWX1ibNphbM9pEYwLAcAh7mNeYyDud6YI9EiEX1PNu1dOk6b5Vgx9V8 Oebk3Mb7qCUzw3VdW25gl86Y7dExeBY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xQkuOlOf; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739929579; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AKmhfFcxXVuJp7LOFK6fPKPUccc9ndXGwrERNozYUpE=; b=4RHFQu/PrcpDcIY4xFw5IjH88aMMhepcVhQuZOSEFCofHE43XcQXQtdw8N79bgh8fpV1Hw EgEQ0cQUPqzpBTWQXgVFSuXYgBRWZdbPj3BdmYA61LhGHnrNYhyu+QHX9FC9Mtx6ZcVAom ItGPSP593eU+kA/1b/YzfzXRp9QSyIc= Date: Wed, 19 Feb 2025 01:46:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1739929576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AKmhfFcxXVuJp7LOFK6fPKPUccc9ndXGwrERNozYUpE=; b=xQkuOlOfS9i7vpsZbh9HlQ7rxQKmBxSKYBa/zm9IJw8T8ufR95Cq3i1Wyr2oyPpPUxwCaf l6T07kIRFrsTQHITwkyUV34UeZC20CGkjzfX68wkRvN7jQL3usue4A7h8vmC1BrtCdEHFH fX7gQyhQFxl5aLtNvhnPRO/PWD3gM/Q= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Dave Hansen Cc: Rik van Riel , Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Subject: Re: [PATCH v11 06/12] x86/mm: use INVLPGB for kernel TLB flushes Message-ID: References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-7-riel@surriel.com> <20250214194013.GA2198@noisy.programming.kicks-ass.net> <3e26626aa1c01aaa5d1e7b42d3ffbd632c3264fb.camel@surriel.com> <724d17ce3fbe07d1d9404f8f32ba518071bcfa4a.camel@surriel.com> <5f4d58fe-4fa1-4b59-81a7-e8c8d3030d0a@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f4d58fe-4fa1-4b59-81a7-e8c8d3030d0a@intel.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 6EF6DA0009 X-Rspamd-Server: rspam12 X-Stat-Signature: kqsg9m8ur3u3nf1fhz4ni49qs3wxer8d X-HE-Tag: 1739929579-461110 X-HE-Meta: U2FsdGVkX18n5sG91Kzeqj68f2jDU+X/u+esL8dzOZaUhdu08X/WT1sdjpRw8+0mw/mxKBltbxgrfIfnY6QeA83Qqugt7zfWP/QYvKMsAlgZDJXtAfZ80NlNAkzxbofjEcuiO7tE65JNGoxdi7gywVLQ7F4w9uSFtrk7fHZltY2MKlFIZts4T/qBJMK48W6DbmQT0TEFKhxUAnJoR2wQCLd3rCtbtXKjl2+D4HmpXcci/rEWGQ7QKVLvWfASGTcyijAziW/JDS9VIdgkx2S3sWXTtqt0AYsw6cI/+KpuIFWSxtq5I4YOdmA3V2MitpmYm35IPxmC3Sqka9Xyf8My7GuW6C+y2PldzrW7YYxsFX7R5YAmOuLnY3QuYdEX+ALGrfSJEzzrw2wLmXzwuHNQtFMBCLpLhdwBSR+zI83LHANaXvL3r0aMyV0H3q41aB+DZOHNshpH7LlmiTWiUaXdjlIiENbKcL7Opsj+OvBqmF5q7nwS6hRAYFmzqFeJq89JU6GjGczHHzHSvg+x8MXZPdCYQkUg6AJnK5pHFS92APtMN6UO/deGTbaaCSRQIeJNzYquu/3AWCkYOAbarkUrApWiurq8Vkuu6+4zHeZ9EKf520kOwF+ck81fb5x+QMWIjeC6LwykYjpF7OCXvhzBxpQwA7gcTPU0W7GvTrhWmDXh5WMAUYIq+C0LNRDi1jZhwvwgbWZumlzOWaB5cZRJ0+3GLnhPGiW9FLrkbHey6h5LuSzdzEpl/iWwWw0w/on3F6qUEt9ZylfIKc0rPZOJXENHiQSqroki6KG6n8uWxixQQL6HA8TtOY0pbfTEpiggDishl3X3ObYCahbgcXnBT44d1RL2N8pADIrZg7JAJ2MQMmJZpZI8n1EsSAKbh/S0+DtPBk7nNuL3BlinByZOfixHxlRpWiPhnZu9K0Hg3ekE+q64jHlfimFA6F7wKBJWbRxfG3HAcc4ooTv4lVx DPT3/Ndi oLMQ+kz/wq3E54DxALSjCo9vvox3i0CdF0SC0WIDarRNj6wzxEmZuChkzJR+hBFFu7FoPXEyvb+blaH0Q/vsdLFUHt5hCCoxZ5qaPEiFyVWqz4es2Etc1b96wpjmVRclQWQWXJVKFulRNUGFgOE+9wXXvbmBa6j1ATiHMqEjM2Fu7BZnzQyHS7RfSKAS4bpEMfnxiPZD64CsQYotVKcVF4dFpvKVT/ADBmFubQ1qfu0UQ3cUo0P9VcVl0KgLI6hTgzra4RVwNBTYuVoERAlDsnt9PU57tD0LlFK9V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 18, 2025 at 02:27:31PM -0800, Dave Hansen wrote: > On 2/18/25 10:00, Rik van Riel wrote: > > On Sat, 2025-02-15 at 02:08 +0000, Yosry Ahmed wrote: > >> So I think what Dave wants (and I agree) is: > >> if (!broadcast_kernel_range_flush(info)) > >> ipi_kernel_range_flush(info) > >> > >> Where ipi_kernel_range_flush() contains old_thing1() and oldthing2(). > > That's OK-ish. But it still smells of hacking in the new concept without > refactoring things properly. > > Let's logically inline the code that we've got. I think it actually > ends up looking something like this: > > if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { > if (info->end == TLB_FLUSH_ALL) { > invlpgb_flush_all(); > } else { > for_each(addr) > invlpgb_flush_addr_nosync(addr, nr); > } > } else { > if (info->end == TLB_FLUSH_ALL) > on_each_cpu(do_flush_tlb_all, NULL, 1); > else > on_each_cpu(do_kernel_range_flush, info, 1); > } > > Where we've got two inputs: > > 1. INVLPGB support (or not) > 2. TLB_FLUSH_ALL (basically ranged or full flush) > > So I think we should group by *one* of those. The above groups by > INVLPGB support and this groups by TLB_FLUSH_ALL: > > if (info->end == TLB_FLUSH_ALL) { > if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { > invlpgb_flush_all(); > } else { > on_each_cpu(do_flush_tlb_all, NULL, 1); > } > } else { > if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) > for_each(addr) > invlpgb_flush_addr_nosync(addr, nr); > else > on_each_cpu(do_kernel_range_flush, info, 1); > } Yeah an if/else structure is better than using the invlpgb helper and falling back to IPIs if it returns false, and I also prefer grouping by the flush scope (range/flush). Thanks for the illustrations :) > > So, if we create some helpers that give some consistent naming: > > static tlb_flush_all_ipi(...) > { > on_each_cpu(do_flush_tlb_all, NULL, 1); > } > > static tlb_flush_all(...) > { > if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) > invlpgb_flush_all(...); > else > tlb_flush_all_ipi(...); > } > > and then also create the ranged equivalents (which internally have the > same cpu_feature_enabled() check): > > tlb_flush_range_ipi(...) > invlpgb_flush_range(...) > > Then we can have the top-level code be: > > if (info->end == TLB_FLUSH_ALL) > tlb_flush_all(info); > else > tlb_flush_range(info); > > That actually looks way nicer than what we have today. For bonus points, > if a third way of flushing the TLB showed up, it would slot right in: > > static tlb_flush_all(...) > { > if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) > invlpgb_flush_all(...); > + else if cpu_feature_enabled(X86_FEATURE_RAR)) > + rar_flush_all(...); > else > tlb_flush_all_ipi(...); > } > > That's *exactly* the way we want the code to read. At the higher level, > it's deciding based on the generic thing that *everybody* cares about: > ranged or full flush. Then, at the lower level, it's deciding how to > implement that high-level flush concept. >