From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F317C021AA for ; Tue, 18 Feb 2025 16:41:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A464C280156; Tue, 18 Feb 2025 11:41:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F637280152; Tue, 18 Feb 2025 11:41:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BD75280156; Tue, 18 Feb 2025 11:41:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6E31F280152 for ; Tue, 18 Feb 2025 11:41:38 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D0B53C023F for ; Tue, 18 Feb 2025 16:41:37 +0000 (UTC) X-FDA: 83133631434.08.0736F74 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by imf02.hostedemail.com (Postfix) with ESMTP id 5FBFA80021 for ; Tue, 18 Feb 2025 16:41:35 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=DAaEdpsM; dmarc=none; spf=pass (imf02.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.179 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739896896; a=rsa-sha256; cv=none; b=bE8+I+V6CiXEgE9zaFEv6gZ5Ps2soua2fYyPHWfN863Oiq/q2rXrTxfLzEYO4a3exIq9JY TpyVc8kt9ZBzrVq430X+s7iZe3wk29+Xaxspd6olRNDBZezTL/STUFbLKhkIuwCzX54/Lz BMI2pAxsf59W3xmL0QcGvnI6QcBT9Qk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=DAaEdpsM; dmarc=none; spf=pass (imf02.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.179 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739896896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rmsfBQHnCAScxM6nmCidjf0ZN6wkrlqUq24dJxHvMmY=; b=NABMpCldi1Fgw/PHHet4IAhbQG623AwaCVkeqPGHT73aCF5ccAyAyf4C5b/iSNTzeBuUh9 xoTyqDQNgRRbBQ8EXHyhAqW1wCyc7kXn52lX+15hPyW0PTHnveyIf2xrkPNr/UNFEqWSdX uFBmuvmGmWjn/d6E0Aep858LD7Cfasg= Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-7be8f28172dso373284185a.3 for ; Tue, 18 Feb 2025 08:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1739896894; x=1740501694; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rmsfBQHnCAScxM6nmCidjf0ZN6wkrlqUq24dJxHvMmY=; b=DAaEdpsMaLZStKUTdBPk0XNrRZhmfJtIbx7g+C+ShkAv82uA7uHJHKEDdktPQ4M5cs 75Y+8mXZ6aTJvMky0FVKniFigpQidS6oDXjL8hLeqYFvrqupO2M9kMfZ3nY9peZF6w/A cxsdg71032dMgZcSD9LEvhu+mr3OoYf8nvBsFQ6LpcEUWp3imO2IJi+AYEReelNOeFG2 rqGvoTwQTW+3ZuL8m9XH7J4NHOWkE3cd0JPDdbp2eTiGCb2h+rqWGiLTxO0v+2igJf9t Elwf3GMWqDCo7woOJHivySD3NuhZGyWt0mv5q6klPpVJ9+a1rsRo3Dc5c5zVudVyLPzb Z8uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739896894; x=1740501694; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rmsfBQHnCAScxM6nmCidjf0ZN6wkrlqUq24dJxHvMmY=; b=CKNrywDsEPf/KS33/0r6l0xE41pJAPT5JK4N+ejgVCCIutTNb95DT7+0vcbpmxDb0D gGeR7wPaA+6wYNmFhPsgwtvrbbG9704rilGYaHObTSVvwTQbKThPaRrFEIU/KlrP7CtO 0S/vzHH5qVuT0lyBh+EsmFhWWCcAEaQ5Jne0F2nmhFhEtnPBS3DLmB1/7pEAmTv2gnwo 18AN/XBJ2gY1F9bGBUMccgLefcLo+NOgVc7xkV5GroMWBYtd9mMEoyTRHjpbzmzK9+/r FkfPl6GcnNr/hHzxNrGHBjTncigiS+uKKJfm/xBUqQfu1NHaBNh6uAlqg5cmTyztlokh bOrA== X-Forwarded-Encrypted: i=1; AJvYcCW4IKe/pNiTTC5RY8G/4inEalRlXbNO/YflwEZTlTYpsN01uKEoHFz3ShvMDVjkGL+WTX9uIeSgeg==@kvack.org X-Gm-Message-State: AOJu0YyRYLKrU4PzbU1l+tzSDGRWIyDN22hxbYs1CpsedyNwd10Fap8A RdRlwSkfARckku3uEuQGmrsAvJQzpT82rPQ7stqmxY0zZIF5SEtzKc6snOgbXmk= X-Gm-Gg: ASbGnctc6D4K5rrUNUFRGEJzHEqVI46Xd3UjFfVzP2hBtDker7ujcQTHkPdFIMH9jor 8LHG62wtmtYC3NBlOBBgrcvA5AN2FaDlv/AgaKUkGNug6jPWwzXGzg2p6BpQm4OawfsPoGH8O97 NakA5dzaHcAD0kUSh0MfNmvDtVPoUt9fSBnSGPIs9gBnNYJnIMSBwXkEVGwn3A6Cx32DYBu03qr waJvudi25TBkgHaRfgmSX7WWwF06F7fAiEvirs9JJ9C6mrtDQh0bSCRX8JXsDeXJFYb/qXL0A/g ww5tW+g3fgSTRepV8XMVeiBnfZ6h1kh6JmetIi09Oh1SqqxoIOJc+e7RbieaeNUAf//HfiYW3A= = X-Google-Smtp-Source: AGHT+IHqSTsgS1MHZWT9YcvdUMT3mLGQwAnc7hzUDsBCZtRCdA5TqG74rLwt96h3vo5NR8FuteSDMg== X-Received: by 2002:a05:620a:3184:b0:7c0:b018:593b with SMTP id af79cd13be357-7c0b5246cf6mr24558385a.15.1739896893973; Tue, 18 Feb 2025 08:41:33 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c0b1aabcd7sm48475385a.71.2025.02.18.08.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 08:41:33 -0800 (PST) Date: Tue, 18 Feb 2025 11:41:31 -0500 From: Gregory Price To: Dan Carpenter Cc: Joshua Hahn , linux-mm@kvack.org Subject: Re: [bug report] mm/mempolicy: Weighted Interleave Auto-tuning Message-ID: References: <547331c1-5332-432b-83f0-911b96a79d72@stanley.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <547331c1-5332-432b-83f0-911b96a79d72@stanley.mountain> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5FBFA80021 X-Stat-Signature: igbjs4whc4xk5w94mkiocc9o863ai9ud X-Rspam-User: X-HE-Tag: 1739896895-979911 X-HE-Meta: U2FsdGVkX190pgUZ+XQpqswe2x6BHY/D1Y1kF43Pd3ps6D187oPaxxU+qdQCftXmh7Pw6MKw8MHZ/NeSRzfjSli3gNR9ebJHhK/junKm1eUg02rAYdx/MxVDUdrfcGHWD72a8yQ/5z6gOPjFWRibaFgeg7aQnMNLGhTYyorARbf+sW8p3kGni7IjqtyGPl5xS+1qKEynCk36mh/KEhMk8ReMo6So0plr2Bcivr8T7njy3EJ/9b3EpwDGxdDw3h+uSY5Tg86VfpyjuqKnJMu7lVlTYx5LLJjqj8Us8DIBAHFM9erpY5OCshG10alnvkRe4GqSW2wiaKGQvQU/WmKQJCaTTajZwlcBiVnFgVkNd5765hzPvIYsBjrQSa0rTZ6xjgeJhLhvhgOJ0D+r+vd98dxKbQjhPcwuGQ5z+2yl4FklsuNDq0m9q0CSb2S8HtH/dA1Qt/NEaDZYnX3zdcq+XDOKqFnmt9gA5PAz2zi2iMOBQparB3zF+bN3TuL60PN9y+Z/3J0mEkshWPztBIfOM+bMJJU0WdjmSnTc/wHLkhJgQyEeBFO//Awpzel9uXJfaY+a5jo1RHa+3WcFb6mjjzprt4ApJ24KXar349yWLbxwq2vLKsIGp8QU61NHLmcLK+Fg2qTH1nDC8PjABA5ljCN4c/Och+Hnww7r+Gz3+jYoiVOH+fdVhp3Uc1KUeAiiEC2WKCr0YY5IgIKlWPfZHmy5/15xeqZ7LvYAtC9Z+xWfcWQAEbFoaBaovevXtm3WyiEoSbqt3rTgDVo/pXois9rgnB/bKjgKxURhUkWI8sI1TVjUolHJ3+jsBYLcWdVcNQ1zRNQL6vBDK8LOzEKWMEaDus83oSN99sfXPrLskJYlK60oCetNj4d93w3RAfOnLJWq6vt5Tjsa6q0NQRKCOTdUxMlaqLKcmAZ3HNSbqWCEpHV7qqKvrLUmbVn3O3VAqdAEt7IVPfzKixYdIbA 1B6kn8sp Ztc2VdTqU+PrKna4D9zAVncvi7wV9qn2LSiynyYgeT0ZmRgn56cgAH9Y3uaruJ7dhQXlyOonvfysrGnKYB+uISEak524eNS2SDuDf7GyJSXhCeCD40SST7SfQNCObUKUE2Z+t/FY17R8QOMavxZykFUrU1EExio8Y0zxJE/407hj2oXDIw88PQqTLWbLFwcFHppvCduw3HppLgPmNWlwJbWhJ4g13EEP8CZl5L5pxs9QhaZpTpvejd+AKrlNPnY6WYAIOFgbrfh2m/4jf6aN5i03VcI4vSqw6XNWbxOcbsuNrHeeFRNxeyZ/HdCTgPzVwz4B08Mdmbx8uFHYrMKNyD998BZDagpKhy6phHoGRG+5DIpY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000496, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 10:35:20AM +0300, Dan Carpenter wrote: > Hello Joshua Hahn, > > Commit aab5f6eb05fd ("mm/mempolicy: Weighted Interleave Auto-tuning") > from Feb 7, 2025 (linux-next), leads to the following Smatch static > checker warning: > > mm/mempolicy.c:220 mempolicy_set_node_perf() > warn: assigned value is less than '1844674407370955161' > > mm/mempolicy.c > 209 int mempolicy_set_node_perf(unsigned int node, struct access_coordinate *coords) > 210 { > 211 uint64_t *old_bw, *new_bw; > 212 uint64_t bw_val; > 213 u8 *old_iw, *new_iw; > 214 > 215 /* > 216 * Bandwidths above this limit cause rounding errors when reducing > 217 * weights. This value is ~16 exabytes, which is unreasonable anyways. > > I see this comment about exabytes > > 218 */ > 219 bw_val = min(coords->read_bandwidth, coords->write_bandwidth); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > but these values are u32s > > --> 220 if (bw_val > (U64_MAX / 10)) > ^^^^^^^^^^^^ > There is no way they're going to be more than U64_MAX / 10. > hm, not sure why we thought these were u64. Anyway, agreed, pointless check since the condition can't be met. It's possible we wanted to apply this to sum_bw instead. Will take a look. ~Gregory