From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC2EAC021AA for ; Mon, 17 Feb 2025 22:01:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 581532800AF; Mon, 17 Feb 2025 17:01:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5313C2800A6; Mon, 17 Feb 2025 17:01:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F9602800AF; Mon, 17 Feb 2025 17:01:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 20F162800A6 for ; Mon, 17 Feb 2025 17:01:38 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A2D84160F60 for ; Mon, 17 Feb 2025 22:01:37 +0000 (UTC) X-FDA: 83130809034.17.2E1663A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 052A2120005 for ; Mon, 17 Feb 2025 22:01:35 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CrrSfvxY; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739829696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lykvh8EenMgekboDKJkwHqwiihLh3ixvLzc2NNaJgVw=; b=A1j38LYD3zkV422jKDu4ihOvza3QK/2X7rk5Mrr+ohLacIKs2fkiwj8bFQd8Ln7DEAZOqm EdbUBQ6cCbBoYjDhuQ//Vk6rmWa+dGDUghdUA9OSYBw96AAg5IYr4gr9pKJ8NWsE311fmJ 3mJSELw94FZSk/QBGuRczuLDY2mKUTE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CrrSfvxY; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739829696; a=rsa-sha256; cv=none; b=oLZX7ya7YpIAek+kykeenmRHBbWfrvGpStUVmnOWHe3ILcs4oYfM8bwPoD5T7UERAF8LCD kW4du9sEDXI5vC4nRHDdL9bLMdl2a+Z1//ZxJyBeh6CefnAhtKSoW8An9cjZv0MVHVT2XK qTSHBFLxwWP0JtAkfrzo6UG1/KIBGgw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lykvh8EenMgekboDKJkwHqwiihLh3ixvLzc2NNaJgVw=; b=CrrSfvxYnkAy1LcSd5BRaGEXMk hXtIvwYg0oEaKE1W6ubvyTRZZIVCiOortDXhG0sEuM++bKxKYznkad23wEG7NIXLU8UcywWhyFjWm PbM1hPOus9EQI4QGWYfdGLHz9KIx+Zql28VKUC+4KHSlHzVbupFa46ooSb8hAwbGJmc1oDOajd6g/ 3HMq0VAeIf487c32soWoj2vZNSJaIik5/n8qemkajfi3o1Hg1an10p5+41b5vQ1zX+PxXnefU9nOn H0F371b6+29CRdg+sNw7OPBzXIBifCwwOHxgWHK4wb3yttEgzZbNQ+eJvR6g4jUSm8wVqfMkVj20m L13iPBoA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tk9BD-000000020Ag-1V40; Mon, 17 Feb 2025 22:01:31 +0000 Date: Mon, 17 Feb 2025 22:01:31 +0000 From: Matthew Wilcox To: Luis Chamberlain Cc: hare@suse.de, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org, john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v2 7/8] block/bdev: lift block size restrictions to 64k Message-ID: References: <20250204231209.429356-1-mcgrof@kernel.org> <20250204231209.429356-8-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250204231209.429356-8-mcgrof@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 052A2120005 X-Stat-Signature: kdoc1un4ucettfj5s8yeitx3ntppehkn X-HE-Tag: 1739829695-658702 X-HE-Meta: U2FsdGVkX1/hTzc3joDXngfnmAtmR7AbaKMKywo+UFKw4roR1FxL7WLSK83N24fKKhwuPd00MhdScC0V1uW5Sd1zbJPUk+EK2OZOvjWsr5LRfytD+xOPTb7IBDgXYVAYntM1Qx8brsnsU8s1WycvHxsH32fD31NiJIpFluYQOMzmxGV78ukHKde9T10TkVwdNIdqhz6SV6KQFDCHSfkfEpI/E0P8kvci3dOWLBM6byO9N77pzpcPLjKpQPQjeagLrE9Dir57TJ6OgmdWi7lM4wnw96T5L5QP5TSDKt8U1V3QIuR+lz6U9LOKM4KuseTDQERVxwKfCivKG+zCSlVwKVbksEsLSOCIatkVkocgFb0fiUO//d85flGAKC+8AACpscz6y1RSHMkUTM4Ox/cMknKWOkANp1KiDlgHkLN2L5t4K22rUcqUuyuBY7Xf6f5/SrsKn0F81vwxULujVn74dxopz0F2H5FVzfh5USHyL7z5zazylOfLNQ37eYU0stvEXidnGqe1bEhB3yBw6pYw1rtSsjq1j0YDzRgknMD+g2T+xdrlnlroOd/CRtbznJCnY1cNvVSbjq49+Uv+Cvgypb8Rjtwe6KbnoGsg6hFKE9k75STNvsrbfOqZGXzheozijD+xPsoC8xyMEZyftxT6TZK+iaFt8dqRjOGy+CgorMeVFl2jwlIz+ScldhjbnEN7bQZ3HHz0Z2BDqQ7aGyt9AEr1+pYysCMcf0/MMcIhXtD49kJ31doIa2fkukAS7eznq3nByO+dh6VLppcayLRoEZe16InT2R7cqeCCud30i0ZFAa4js1rydgrUhsPbBCHYfPr1dOGiMVqcmWGjLBhgWxdrdmp0SIvPSTeYKxnNpu/TSIff5YE33KWUPMRCNF5YrcANnlkWX08hqhUGKEsVbjj0WrfzSZB4GQ934a99iuwufEgl1m0HeaW8ZoQaoxV6bWRBq5c4AGwZHSO9z2G soDmB32Z 29FiJBMtY9+24QP+KDfUWvMn3z8ML0dw3ZILQDcJcQL3VPEwc442fmlDL6za6L3sdvNf/iGTeuyx39vYxlUbic9gw2Ca+1jnEu9If/Dj9fuesEiHfOpSwIUiZUZBevGw1blYffnjoOWfNnXsvAO3YKHedxNvQ45pbIz/9kILLTYsIUhz+Rcb6zwUY7pHfDv0zJJtsaefj7Z3lqO9VK3C4iz61fJIAsRUjjVA1X379qUu35tIUfj0HxJMAppk/Pnied2T4pojgDaIfHdj0kNSWiTIe7v/v1blkiZ7oKOUrEZJqPyXrUvs/Oy4X1mj2E1SgcxZYmh1SSUPjLDCpS3FgyUPBzrbN1wcuX6XhhB6Y1iZTdW+7NV2euYhQkc+DlY1cSWIR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 04, 2025 at 03:12:08PM -0800, Luis Chamberlain wrote: > We now can support blocksizes larger than PAGE_SIZE, so in theory > we should be able to lift the restriction up to the max supported page > cache order. However bound ourselves to what we can currently validate > and test. Through blktests and fstest we can validate up to 64k today. > > Reviewed-by: Hannes Reinecke > Signed-off-by: Luis Chamberlain Reviewed-by: Matthew Wilcox (Oracle) > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 248416ecd01c..a89513302977 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include We can drop this until we actually use > + * We should strive for 1 << (PAGE_SHIFT + MAX_PAGECACHE_ORDER) right? I don't see anything else that needs this include.