From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A33F8C021A9 for ; Mon, 17 Feb 2025 21:58:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 162302800AC; Mon, 17 Feb 2025 16:58:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 113042800A6; Mon, 17 Feb 2025 16:58:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1BA82800AC; Mon, 17 Feb 2025 16:58:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D34A12800A6 for ; Mon, 17 Feb 2025 16:58:29 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8361280C81 for ; Mon, 17 Feb 2025 21:58:29 +0000 (UTC) X-FDA: 83130801138.28.FA178C0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id E3D721C0006 for ; Mon, 17 Feb 2025 21:58:27 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uWsw9uPd; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739829508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PrNDBC1sbGLUzqSwtEbYk6pr/8n6DX4iFAB7GbUfDO8=; b=Hk4kH6CN8PYWIc7zzMBpCnYqn1h4JxT0nNyDdQogJ8/VzjpXe2XMzN4RV7JubWkWvgicKA YVyrVCB+m3vQ7N5VC5vmIenGTxeidR8ov3LxeCzrWo3uAdxmWz7fmYVU9hAubJqKZdHew0 baFr2E34CVX44//MdS1Y3w4pOzFTKjc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uWsw9uPd; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739829508; a=rsa-sha256; cv=none; b=p3c/liqOOVnp5stlKYKRHPY6NsMla04BaDkwlav+LDDS4jJFpI/VeQVWveJEnuzBA1HMab GG9iyunS2rdvATX1Jmyhdg3oWbx1Ap/LgoEPR1d5sjuoagjmMCgzkCP44O9zc5IUW4HT2X FBiL9pmxJFkxPei1+7NuTbZzaakDe70= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PrNDBC1sbGLUzqSwtEbYk6pr/8n6DX4iFAB7GbUfDO8=; b=uWsw9uPdM3QWIN9LS4bX0w4JCZ BJGLajT/fgExjSDJrZtHPhg9XnwavdGL/b5gpXXVqvgJbgDHu4/91eP5RJ8HzvQMrWJ3EtXim8T3l AmATyXTylbF0TdHVuHAqXU4LJRI5ruCZywn3GqAGedNsQ7g3qnBPKKYAS2Z64T9fxTe5AxAogFJHe 7wj4hOvHrsLCUH4dsJr4NUzzhWAERQY6qNjYwGq2X8imb5hg/Q8O9OIQRuCw4LcmQYa1lgzBRwZRU QjxvjYfk+/etzf3FI0I9WSH3416+NllDKtNt/o2k5uQhOaEhYCsBE2I5syapka6S8u6JSWKCptJBl N715YWRg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tk98A-00000001zyK-2Xqn; Mon, 17 Feb 2025 21:58:22 +0000 Date: Mon, 17 Feb 2025 21:58:22 +0000 From: Matthew Wilcox To: Luis Chamberlain Cc: hare@suse.de, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org, john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v2 4/8] fs/mpage: use blocks_per_folio instead of blocks_per_page Message-ID: References: <20250204231209.429356-1-mcgrof@kernel.org> <20250204231209.429356-5-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250204231209.429356-5-mcgrof@kernel.org> X-Rspam-User: X-Stat-Signature: n4s8ae338gx6tr68ebw3qrk9u1et6wjd X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E3D721C0006 X-HE-Tag: 1739829507-118071 X-HE-Meta: U2FsdGVkX1+wrHY1lCFwo29ZIoI+2Jr3uJdfDzlNRL2bYfHxZIwAcuMZPlJCpgPqUOmOU6jCAJykYgNxZ+60lPa3qOeJu3prQl2ml9Krw43tBKpaKqZFo+3amc05z4NVC/Akt7mdTPf1NH4bqEFAKyTyV1ylXZgE39RroLltbZ97xS5+fqG4rcBBcT3HR+2CUK+5+H+AlvBsNHhvfr3vOafQLf2nVJSq3+xzGEMBOuT33hwxAqoq+1CbLPVGubijWwR84ZY1sDWarBnqF8ZYwn2YbRubRiMBSQmevJ7bPZ5pG/yWLBxSYJUUqB5L1jjD3s7+7a3A1f8GZQG6dtxyvekci7VPGLl8vs5E78DMalcMNWu0EMF4To+v36PAV5nbgvYiLDHgwhBgjyJG68JowGi68WnlPYwBZDoRc2Velh2ExzUYRgYornZ8gC+60kQiqPUwnWBB3pTvNSABnaCBzVTn7elTbFWEt4z1J0QhbioC6BVc1qXfN2/PDrL5HxWn41BeYhahklLy3hVRLjFHrwLMO2YnkxWrFO1J+OP7z5xKPNmd2qY98MFyvYvtdzxbFpb1mMYUoG0fwSDydSnZ95HCCkh4Rrfv6wQhtAFZSuwLJdX4fmSZzG3cCNaoI/R+YQxFCHs8287A7oCP/IACh3xJmhagyYtJ219+JEqfLaJKs2RejaJTBCsUut+vkCLn7DvrnfOq/kt8Wu0xnhAKBklopDtjzZ3zVrV6tJ+uiytDG7toiQq2flJQ+OxpnSsIFIPf66bItnmNX/CWQumt3VdQMuZEVjJIwgmhoIH3YmyyaOWRjxjndYYU9/DZR8YeJnX0ghpvbxMOb4dm3xuQtEkYS0b9zhwP2h1H3Hspj6xDR9lb+FP6zlh9vyYvJ7/l+TRjHFIOntMm1bso6PgQEB0rCo4sKYqU7QZaJLckzN77hC81lg0y2C/fJ/YlLzaluHYkNK+rnFxDOsZg/vz JqjeQGK+ Y2ASWJ0Dy5g0p4xmyL30QITOPYrLi0QGtsP1pm/4JaYBAJfaYheYqUOCk0RU0Oe7mc3e0TJ3gbXuRvsneTXT7IkS37C6uubfTl9iiLADyHBEkVGkEHMithKmwa1C82kjGV3+1C29Bed7o0sBl5PAEqmkDR/PJbPrg7EOZWrb+V7S9OZh/644sDD6AZBGuZqvx/+BiHthqZ0N9vyug3EbonzlMVqZETaefQk4gYAPclvIoSaQYdhpT7MUS2aZ/OzlmFaODLkvy2rerBA9prKkwIXVArUf8+FY4Y1EGuE35e/T8lYEna5ZKqPBY9ooJ1wb0g4AB5ThiHbUmcZtwR9EZL+NFDmUZNenw6ndw5QRXZZ91za0LYtGP35j9Nw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 04, 2025 at 03:12:05PM -0800, Luis Chamberlain wrote: > @@ -182,7 +182,7 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args) > goto confused; > > block_in_file = folio_pos(folio) >> blkbits; > - last_block = block_in_file + args->nr_pages * blocks_per_page; > + last_block = block_in_file + args->nr_pages * blocks_per_folio; In mpage_readahead(), we set args->nr_pages to the nunber of pages (not folios) being requested. In mpage_read_folio() we currently set it to 1. So this is going to read too far ahead for readahead if using large folios. I think we need to make nr_pages continue to mean nr_pages. Or we pass in nr_bytes or nr_blocks.