From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68676C021A9 for ; Mon, 17 Feb 2025 21:48:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D442A2800A8; Mon, 17 Feb 2025 16:48:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CF4072800A6; Mon, 17 Feb 2025 16:48:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBB6A2800A8; Mon, 17 Feb 2025 16:48:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9EB092800A6 for ; Mon, 17 Feb 2025 16:48:21 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 59BF8120E86 for ; Mon, 17 Feb 2025 21:48:21 +0000 (UTC) X-FDA: 83130775602.16.495D326 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id C0E8A80006 for ; Mon, 17 Feb 2025 21:48:19 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=snooRglJ; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739828899; a=rsa-sha256; cv=none; b=G1EG/kaF1FcIQfUMzuh6KgYqVmJlbebFVwmxRpG6Qkb7zMPcYC57fy7x+cpZAEVbn2wY3A tJfzMoipi4N34iBub5g9r8vtZOXs5ExnUOpYW+L0z1Qd0rp1qsFB97fLzQlMnpxqHyASBL 37f7iRkrdH5wMDo3lxpAqlYQXTJUNKE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=snooRglJ; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739828899; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7NX9+n2GikSH7WhNZS96Bu/nUIoIDhQGpH/Y02dbejM=; b=NB38sG4L4JY/TQO6LjQon72TrPzy8B8SyX5Ke0kBtYSZn+48/EyQF4IMGAa+aTV+GhjIUf fDv4qgcXfOO2Hmy8oOnwiOXHf4Uy28+eWF/luLQREAILgp9lhKboX2iBCnJr5AAywfHu3P tOdFGPN+iEtLn4BNob58gcDqg6aYmGk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7NX9+n2GikSH7WhNZS96Bu/nUIoIDhQGpH/Y02dbejM=; b=snooRglJtwQHv417bt1phSz65b N76elZcvJqgT8oosuO+2D4h8/jCPZi0PhC50+Niyeys8XUm7Pp91NXE/1f0ZXWt7cRAkIU+IkvTNX 72mWC4Lis0+zKg1DViNxHyhhc6VcxpTd0Y/x2Q8TutFFqUQed83I+gIlJUi8DqWzZuw/8wF8LbinP tBzMFM3QiCF3+I6AY0usGxmOhZfigRcF6BMaPrYs3QpbRkr+GF+M9unOy4k9XYMC9JIX5Ba/rKpSh I4xxjXatdAA+t2Sk0fRULHkEE1cb7U/KhAEU16RCMPN46RskRWKhGGzLa7HrcngU4ENOPd3+20zUP dfAKsyzQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tk8yK-00000001zNZ-38tF; Mon, 17 Feb 2025 21:48:12 +0000 Date: Mon, 17 Feb 2025 21:48:12 +0000 From: Matthew Wilcox To: Luis Chamberlain Cc: hare@suse.de, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org, john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com, Hannes Reinecke Subject: Re: [PATCH v2 3/8] fs/mpage: avoid negative shift for large blocksize Message-ID: References: <20250204231209.429356-1-mcgrof@kernel.org> <20250204231209.429356-4-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250204231209.429356-4-mcgrof@kernel.org> X-Rspamd-Queue-Id: C0E8A80006 X-Stat-Signature: ux83unqcki7tr7zigtqkt5wn66r6zna4 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739828899-519984 X-HE-Meta: U2FsdGVkX1+I205HPm65A95FZlkGBpvZDtgssebvMbxSpeI3x9RJnNcf+OiFOtEuBfS+kW5+dTej9KzdcZ8+NWjQKGEiAQIpfAWG+0LbmgxP/umwXwKetvThdPa5kuWbNMp8srhcAkR0X6Ck9SOZvs9xqSlskMZMVcu+8uwynhdsSaRgrM9k+diwoAcUOUwmEEMAPdTA1WDCKHz4Kh+lwZ9Y9S72FFBgFWC1k9zimwuMvgH82h22z4HCWv1OrNMRctLiqtz61uDFOnYMIDix4ao9aUljwnfU6qNdXpBNqPVVOPTSv2WvHbr6kWavIIOWTVz3YFEg7d3aTZvY4sB4r9+ijfRHBdTWlHTwMVQajBZGyjYVZI7y2IVTOKLIQWG83DHXDha3vQb6NpatsEFX/SxWqadu9m+vODEcheuhkOLl16BPOtl14AcxMSN1V/9Jyv2j/A6rEPxj7HJqaAR1v64Qpq7Oh6TqlIW9eXXXYgWS6L3Dn4zLY6k9GinsdJ2whK8TcQaLc6qpfeZPdVktgYlqmliYaBWxzVyWDSJzS5IFS47r6FJUVwHXz2csUHbf9pHSHfjIa1HD7xtwMrlLDSp423l3uz7vY+0UuzCii+WFeJ3T0u67TII8AfBXa/YZFrVQs+vk5f6gj78/W45wwAykksV/Q0aDvXqcuW2wpVYCXJhPYkBN5Tyda3rfj2PDkZTA1jcl/ejKHqTnPo9A7rbd48OpSl4inS/pzoFQggea4lz0UQgYrQwupS9CrM0wQ3Ikq7vUmyrlutWOsmcfasoJ20qvwqod49gOPPou9YbQvStroHBwHvXLaTc4QgSt+z7iDju41RIl308yzKAopksqtp2OHAPcAp3bGHW7LwMNf5iJJGTu80pgEC5/F19WApHvSbdkPKk0f2EHIB39BlCXHJysuY0g7aJrHJrEr+d/RBeSROlbFN+7cC55RwD9ZffjCvhPn/gLsgZQrg9 Y7DEhvlW qszh3SaioUDzKnplUbLlgFmJQKnrdAffCT6VRHIJAQQh8Mt66YhIU76rlx4e9dcH6wwCXx5+Xu2YluQzqNJxMoxBhaC8XcTzU4raq75k/+qjpCvA4HE+sPhPuqBvNEULnjDvY+urTvYhWuxwscgQYvd9+z/nW3VP1EA2PzT0U8kYhzZVmww8y1NNwGYWeiUemtnsr63ScqWnfcCpbw+5pVItgcDmyg1faiPVGusdmmaGrQNof7m/OfKH0jnSlvIdYHroih9A4GP2jweMGr3AbaugwWHcMnEb6ad9A2Loj+1ZhS7KxkfXrKuueaIzgVcaqF4b9yVAPrp5vP+z5oTsV1LxjErfrTOvBzCnO7MOVSXShZAh8iIJW6c+bHtGu7WDoB3sN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 04, 2025 at 03:12:04PM -0800, Luis Chamberlain wrote: > From: Hannes Reinecke > > For large blocksizes the number of block bits is larger than PAGE_SHIFT, > so use instead use folio_pos(folio) >> blkbits to calculate the sector "so calculate the sector number from the byte offset instead" > number. This is required to enable large folios with buffer-heads. > > Signed-off-by: Luis Chamberlain > Signed-off-by: Hannes Reinecke Reviewed-by: Matthew Wilcox (Oracle)