From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46845C021B8 for ; Wed, 26 Feb 2025 20:43:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D77166B0085; Wed, 26 Feb 2025 15:43:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D266A6B0088; Wed, 26 Feb 2025 15:43:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BED676B0089; Wed, 26 Feb 2025 15:43:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A15CD6B0085 for ; Wed, 26 Feb 2025 15:43:51 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4E7661C854B for ; Wed, 26 Feb 2025 20:43:51 +0000 (UTC) X-FDA: 83163272262.21.4598A87 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id E30CC10000F for ; Wed, 26 Feb 2025 20:43:48 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eB8+emjF; spf=pass (imf14.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740602629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P0dzl5SDcbfWTKxhGQl5HtUv9pp6OHwLmqZpG5FxCO8=; b=iPBYSSiCIbFOENnY2F6C/cWJXX3ZfT9aQ+yWEbMQTm2VcneiwPSaTNAVhKTAm3hHqwIar8 bMgHBT26kPz75/2WUgWr0WBbxUzHuqgKUCR4PgJIXEatrJY94Ov0zh6JDGM4mzm+DLYwkT OklN7oArdntmJevE2zXoAhVvDX6Mxkw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eB8+emjF; spf=pass (imf14.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740602629; a=rsa-sha256; cv=none; b=gAMdYIrwdpgvWsbedtIJr6mqImE1Lyw4epmueVu0aTJAVOUlXaTx/S9ns2QGegGP5N+CPB Rs0o63MKSdTJRbYeBs1slm4NPg64sUW32TskWoFz6rbBIf4Ne+v5KicqBJw5oQJklp6q4W FIlNT5xQr+2AxybjR5oxX3DDglLFCMw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740602628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P0dzl5SDcbfWTKxhGQl5HtUv9pp6OHwLmqZpG5FxCO8=; b=eB8+emjF5ZvR8PgN4jYLpnyBNZXMZoVLJOarIRZCtoTKktFeGgFkd+fFYcA1doVRXZKhHy TuLjwBWx8SEoFc8Dj5ph/35Mh9hRjJL1FXqfufnIHORqjksFGjn2Bi1g9Rp6woogq5AkW5 vjWyJhndRUdylf9OKOxHXtGsQmNqoWA= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-eNZWz3F2NxGaco0Qt5-G1A-1; Wed, 26 Feb 2025 15:43:47 -0500 X-MC-Unique: eNZWz3F2NxGaco0Qt5-G1A-1 X-Mimecast-MFC-AGG-ID: eNZWz3F2NxGaco0Qt5-G1A_1740602626 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6e67c58f0f7so3015476d6.3 for ; Wed, 26 Feb 2025 12:43:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740602626; x=1741207426; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P0dzl5SDcbfWTKxhGQl5HtUv9pp6OHwLmqZpG5FxCO8=; b=abEksN+SXil7Rx8F6A9cufnGuu8r0uxUrz4KXvrz04NpH1ZoyKe1zguQzeIeFiYt5A HfqS7ERWcehTODDEg86/BCLDyFtE6UuRAETPg9YmSJ/BiZFSSwH1JCsf7b1/0BDRaSxb y5+rczrzzAKQsZ5jMUwmAeQRDly1ETWf67m93mtrodLEJH9PBft9FeLGPF6jkDDZa2s5 JC4r1bsU/y5XwGQTfbTsr+5X/JyNFfwqOjfmwMQzwN9W3qdUy7qjTX2iSIErl5LgffX/ 7oyhrcRqJHzpjy1tke9/xffiZUiMtxA3ybd35kRgkLHbLpEvd+pAj0vE3TcBKfR97rGo Iikg== X-Forwarded-Encrypted: i=1; AJvYcCUDiiyBlkMDl/U9ENl/Wx8g8sOsYT/RCPkYmGhN9oLytktIThpblJuSSeXJsvzkoJhOX1cyIlcU5A==@kvack.org X-Gm-Message-State: AOJu0Yy0rz/mAHem6Prmje+v7niggedI/Kps8T2+lnnglQls0w4ZHMaO bzhrpUIEYiVhnx4nWfik4Ff2LubBCs0iyseIgEyVX93b3xfjVw3YdykLAk8HO3QJirAbzHh2u0D 1wUvyJTj9G8mNe1oz+aLbZtZAoMchccwAHcdg+2hvralO/M9N X-Gm-Gg: ASbGncuw6+rvrD0d8GwDkveElcXEyIkDBTeW9afiwfYa9nMLhPn4NcqT8+c6EbVDaxP h+Y+gwKJrgAuB5Yf4eVl9ex07lGggQ1257+QykHTVbhQIeZVYu3NbtvsAwNEbr0iiHB8c0mNz4U BSZ44yG9eFstCrG4F9NnYKYLuXSIB+XAKLEAxEfdOEY/Ivk7XglbGMLq3oh5/jVa1rbx7vJadej uLXrWPB92D8IrSZ8vgaWIfq1OmRHD0zxDuuBz2H24vh+YUjeFdQIRqy84dvIHJsKVjAGQ== X-Received: by 2002:a05:6214:492:b0:6e6:630c:71e8 with SMTP id 6a1803df08f44-6e886870f50mr77100546d6.7.1740602626560; Wed, 26 Feb 2025 12:43:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IGKXwQVAgk3jgl/49xngaYBX6oKJbXhVjpUcSNtUjB7QKk0vvqdGgR/UdpT1mhsnTG/+3HOWQ== X-Received: by 2002:a05:6214:492:b0:6e6:630c:71e8 with SMTP id 6a1803df08f44-6e886870f50mr77100256d6.7.1740602626235; Wed, 26 Feb 2025 12:43:46 -0800 (PST) Received: from x1.local ([2604:7a40:2041:2b00::1001]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6e8976608e7sm514216d6.51.2025.02.26.12.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 12:43:44 -0800 (PST) Date: Wed, 26 Feb 2025 15:43:42 -0500 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, lokeshgidra@google.com, aarcange@redhat.com, 21cnbao@gmail.com, v-songbaohua@oppo.com, david@redhat.com, willy@infradead.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, hughd@google.com, jannh@google.com, kaleshsingh@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/2] userfaultfd: fix PTE unmapping stack-allocated PTE copies Message-ID: References: <20250226185510.2732648-1-surenb@google.com> <20250226185510.2732648-3-surenb@google.com> MIME-Version: 1.0 In-Reply-To: <20250226185510.2732648-3-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zoD-k3EXu0rTZZU7DveGUBVnWyzWUuImK-dO4GcKemg_1740602626 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E30CC10000F X-Stat-Signature: 4zbpt1udm5ebqja9coxkk9ttk3qh5zbk X-Rspam-User: X-HE-Tag: 1740602628-654692 X-HE-Meta: U2FsdGVkX19LA2IKDCNxyFl9fvsRtDbE3Cy/E51zjegbOwoxk1WlkBQWHePPc4mBHMdG4QSHnZSMMur6FFNkdGMwoLJ1HYaqD/cmKidv9aeUScVk4nYIjZ7jzOr33rA+fuj/TnpUgPmQnN3ozoodRiL0Hi+DlqJjv6Q3mVgWyIA701CUAP7qAug11BJZW9z/nuIln6KEKwydWBe7a1FkKfiV5KCDmF7JmvAc5o9UrG6uTIb9yAIHx8PWMixaAJx42IL6umrfZVU9ISwLx9p6EhCdv4J1aU+1iNiiDo095iS2zAnaJytchOFpigEFrYejkDAlec/j/XW7riN9qds8U50ti0b9mTfI9AT8daIeeF96h/0l0AlI7+mfrlEMOm6kmo/1skRBTtjO9s71ib+06Xvna6IcpQvRuKdPJYROivMVBrOTwgAfRWscEmVHT1Xv+mJnr9u368aJ9fU1vRjORw5QQLR9FN/+ahQra2x9SPeZtydzid8Gc9LOVgnIw/U9dMd2NYK8Ldzq4DfpY5DkQfZLRUex/E/is6oHXLGJuvSvhvDkShIySLr1M8TodFC1e06skaCWGSW3sihrF7ZGBhEc/4AA2q9KegndCB8XzBchJUBrJcXh48s7y8+Tu5Fbi4n/PA2pqcavroKz5+KKMrPt5VFvbCP6ztzY6mAwkaNSN2lgdFFrDT4FDZI8Uiqy/bnGTvdH5nQW1qkx4ZgMhxKIxo7ZiM93SpZkm3qvSu9rkqwkz/8RFhpzuZYrd9xJmcov3mq1HYPcm1f6Sfi7MvIVJxYRfIkKMG+KunvMX125EyneJDzZ6wj13mibEVQ468mvagHxtLs4CplqPG3NbtpEjjZJQfzOrweRGL2zeaCTCDHDu1Y7hJ5lRoc6SdfocT966JEf67EvUvCcgPbUlkDwNFig9v12OlSVQmlVDAakUf9bf5cjiS4nc8B2g13xb+AAZtCEuam53V6vaGN IlFilbrZ fzsdCMAoJvrlKGtPPQyag8iDvFP594yMQbxfFh+DJ7whsLbTa6ZHZL09IlZgxyA5uB8HyYVMarGGiFNbnFGlKb31oLg6D1IDs1t3S1qMllEgkaAO9pgjxoWVmL0xqi/23tuVHGeMvB8oJajbqc3ROo3qOnipTBhUepuDnDlYfsVRV/ho2Pu2a0rSi9z8Uu0GzG9MT2cd7NjQpo7yW0B8Xdto802DQ5VoROnutQlOnpemcLvgg6QtBcVSMlRoPF3q0IUcIVNxz05tAeWW70IpW0k1EbMPTb5SpiPKAKwRyXihLJn/1y0ORMJNdHIcbNZskgtZMBT7AKa5fPvssa07iTf56HvsMsiQDYNKCBp8Cj9kiwT///AtwR2b5G62KHWDP7qUDiAZcp4tXJrz52F1na6fSmBBD65/5uNUv X-Bogosity: Ham, tests=bogofilter, spamicity=0.016185, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 26, 2025 at 10:55:09AM -0800, Suren Baghdasaryan wrote: > Current implementation of move_pages_pte() copies source and destination > PTEs in order to detect concurrent changes to PTEs involved in the move. > However these copies are also used to unmap the PTEs, which will fail if > CONFIG_HIGHPTE is enabled because the copies are allocated on the stack. > Fix this by using the actual PTEs which were kmap()ed. > > Fixes: adef440691ba ("userfaultfd: UFFDIO_MOVE uABI") > Reported-by: Peter Xu > Signed-off-by: Suren Baghdasaryan > Cc: stable@vger.kernel.org Reviewed-by: Peter Xu -- Peter Xu