From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BBCAC021B8 for ; Wed, 26 Feb 2025 15:16:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 919566B007B; Wed, 26 Feb 2025 10:16:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A10C280003; Wed, 26 Feb 2025 10:16:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 742606B0085; Wed, 26 Feb 2025 10:16:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 512166B007B for ; Wed, 26 Feb 2025 10:16:01 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 34C2FB7810 for ; Wed, 26 Feb 2025 15:15:57 +0000 (UTC) X-FDA: 83162445954.27.4B69202 Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf02.hostedemail.com (Postfix) with ESMTP id AB4AA8003A for ; Wed, 26 Feb 2025 15:15:54 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TUIq6S9W; spf=pass (imf02.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740582955; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u6MaTWCXdufan1Q+mAXcn5rxDeHl7k5+QDzGK91XsNI=; b=U/UUAR+qnwvdwLgb3NZ30yXMNTXLKMxnMAgurPGAVy5MZLY6+ynSqSHHvzVSJbPKBj+CzX 9SLwZXhPyK0pYDhSVHVk/fxI7RtxwieqQYRSa9GwPQH8TLikYVly+gv8do+uDt458EMC78 IJxqMgcrYe55bt8SxshblFcMJWvXAIc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TUIq6S9W; spf=pass (imf02.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740582955; a=rsa-sha256; cv=none; b=bbrzU9kAs/DEnt8i0ogYF7l4rn+HpWYggAmwI7f5+ifkMNDXKIcsON1VhbNB9w5hGt0nN0 1uKtqBXa1Bc6DBQfiQjXIbrznplq8A7vtobNLrzlwcxGkcgtJlUJr7lppj4fya2oqTELio 4YyNw8TPsH++dPpqvJqJpUhwjiMuzpo= Date: Wed, 26 Feb 2025 15:15:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740582951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u6MaTWCXdufan1Q+mAXcn5rxDeHl7k5+QDzGK91XsNI=; b=TUIq6S9W2bLCSf8d/SOPkgtJ3Tm7sT4BDirXHJheDDjh7trduImrx/eJYO/2PMuQI4mzh0 IfN/RUb3qFsERsINDoe/+lLT330hEsCkEYPMz+3fn62dC9QoIgif+fl7XTP1Zo+bCDCWQB 1hxFMitzDD3HOiEF/6hp2xtHCPTlLbU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Sun YangKai Cc: nphamcs@gmail.com, Johannes Weiner , Chengming Zhou , Andrew Morton , Kanchana P Sridhar , "open list:ZSWAP COMPRESSED SWAP CACHING" , open list Subject: Re: [PATCH] mm: zswap: use ATOMIC_LONG_INIT to initialize zswap_stored_pages Message-ID: References: <20250226124141.22218-1-sunk67188@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250226124141.22218-1-sunk67188@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: duozprqxe8gy7omy4nt8u343he6h4drf X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AB4AA8003A X-HE-Tag: 1740582954-554480 X-HE-Meta: U2FsdGVkX1+vUEaN4DlULuW5vqhZGmItAEbyfSvqAny0J7ZZn/SExr+ePAD7CLLHA2ucEDzP8IjmttyPlPkPJpIhdVurwOGquzPyNSd1q6rtdnz+SXVe7VK+rivQNQe/X1IWv4IlzI/diwS2U4ZeTX+bYBccivk3MDBfTVefRni9ImaNTncz5KrMK0Ndf+zCoZ5CX23rSyFrowlasbX+fqbOYn8BYI/HPIWePDyt7pC9ELr4/v4zUNK+4iu3RdqKYxYCAoPY3iX6V8hty8MLkn42/SCRsFoMFWytadDDLB/KK3MRciVO5tCgg1htm75vOBjHj3DM+ypI3iJklOW3ywFUOkxrxOYmqzDOD0JgQpg5Y1B3aVPGJLeRQ/h1w1tqaqVT4zZ+xDtde444HZJ2fDB7LVfKC3gbiNy4Cg06urZjvocEqsAvh8qQXnPiBqTiqxScPO1FdO19S2plLarwz/TIAPQ9wt5eV0XZJ/nSv9Q6PFjaVqyNO/4fMuv6M2c1Quu899gigwWIQhDMjJlRHm5rXh1PGWXw6GxOsub8n+H36k89GnLZEUWDuNS3WoEd0VCh4G+C2EWFzOUHMPCsd3lKutNkqaRBEVeGzxsgqBJ8tVFCjE6Hj6+TrMmQpXePLmZ3NtTBM4setukf/Uirkz1XPEfORT29t08HU2NTiHQeTcewb+HAcrOsm6hXhhrMyT3Ail9Cf0F697yf8hjKL6kf4E5xu2uCz7RpjnVpZfyD8sJNWAU5LsfnS7SUAtdCirmMlM497/O+G4CstTGu2bZe6huFd30vrzr6nhL73kSJ5w1w4RXPWk1usVv0na3vVxLXqgGm+Us8hyLFWOn6l9JwsnSjVEdquubdeJ+WLaV7IhCL5B4bIigv+//Eh84O2iqwhq+KisVDNevS3BSF7PfFuTk37O5B498Ozux66rSfoXXplGcKLiU3QXsaBkmo2KAEJdbdExjORM17nbG LFq+Fhdq ub2TuSsfcooFP0GrVMKst+Cf9auHOw44YO+kgyYv7zTTrcxGZDCbJdiuLD6bszMEfzd7kr8KR9EnjafRuEw5ke1ZuZdoBCkkO8d9GEkHZV13BBf+vb+a+RMLwsPV0+LZP/rAAl1u4qu7yyJRmWw0IwEHLGkiVQx4405pXzHtZlxc2S9ky1RgH5RnwzAl5b66WBkFhOWc4nO9OJeAi0xPbbWnB+O1o1+/Bz3I/eQ8okPaFyL/FKk5A9ajS2kUlxWfaqEXjHQFRWiDS+OS1sfGtZyOFXRsmLSL7ko2Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 26, 2025 at 08:41:39PM +0800, Sun YangKai wrote: > This is currently the only atomic_long_t variable initialized by > ATOMIC_INIT macro found in the kernel by using > `grep -r atomic_long_t | grep ATOMIC_INIT` > > This was introduced in 6e1fa55, in which we modified We use the first 12 characters in the SHA1 to minimize collisions (same in 'Fixes' below), so both should be 6e1fa555ec77. > the type of zswap_stored_pages to atomic_long_t, > but didn't change the initialization. > > Fixes: 6e1fa55 ("mm: zswap: modify zswap_stored_pages to be atomic_long_t") > Signed-off-by: Sun YangKai Acked-by: Yosry Ahmed > --- > mm/zswap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index ac9d299e7d0c..23365e76a3ce 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -43,7 +43,7 @@ > * statistics > **********************************/ > /* The number of compressed pages currently stored in zswap */ > -atomic_long_t zswap_stored_pages = ATOMIC_INIT(0); > +atomic_long_t zswap_stored_pages = ATOMIC_LONG_INIT(0); > > /* > * The statistics below are not protected from concurrent access for > -- > 2.48.1 >