From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 855DCC18E7C for ; Wed, 26 Feb 2025 14:31:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6422280015; Wed, 26 Feb 2025 09:31:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D12E828000F; Wed, 26 Feb 2025 09:31:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8C31280015; Wed, 26 Feb 2025 09:31:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9CE8828000F for ; Wed, 26 Feb 2025 09:31:12 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 26E171C7667 for ; Wed, 26 Feb 2025 14:31:12 +0000 (UTC) X-FDA: 83162333184.05.F761863 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf17.hostedemail.com (Postfix) with ESMTP id 87CE04004E for ; Wed, 26 Feb 2025 14:31:07 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HGCKlj0Z; spf=pass (imf17.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740580267; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eswWLfkEnQpdtu+isG+K14u+ZfJSvAbvqWCgztSMnzs=; b=s1z/GZY7ZGkDU7sZfiHl1zl7aJS5VzcO/HO4Jfbriz512QoameLHGMIwOwEFjqUcUzrNav SB2/UIZ6Bmwaf4Cq2ze7uw65xAnXV1UtOyO5pkQTtS8H45rnEkd5bKGub47Ph6P6sgcWsG L0RgkeQZ6MBBJLNY+U/ICv1gyvb04k8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740580267; a=rsa-sha256; cv=none; b=g0IOBi4NWH1T1JiV2JEAYIy6B4c/klh3frzu4QwnVZpcCt8Lfsty58qq4IhsDSorjzOz+i BbW0WAMbkTRuZZ318Fo05L8J3zaOQn50TY6PzbQsYdgWlLqk2KTDVrXCvUa4izL4bOCyO/ mJcfMjgkqQXGJEyzdI4zbOYnebRIjjg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HGCKlj0Z; spf=pass (imf17.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-309311e7b39so63260181fa.2 for ; Wed, 26 Feb 2025 06:31:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740580266; x=1741185066; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=eswWLfkEnQpdtu+isG+K14u+ZfJSvAbvqWCgztSMnzs=; b=HGCKlj0ZbpJCmqGIQ92/IgDuTbxVtf7FN1cO6h9QH4MDDXfy3FyR4zW16fXCbPPSRk 0pSvUBssayrZPlwmwg7xeS45d/7l14s80HCuEVBzynyuBlANs+2k761/GtJwafFdyCbY 8j63QwK7bN0Kd/DdoF8W1e8lrVxFRh9unfbGIX3YdVBBm6PS0VbIrdEnXCvWnpDAIdxZ HTLmGJO+qCngdxntj7xRG7O5pnoOJDhdtTe4etO1pQf1wSV8O3QCrkIUYBKZedxS2ErC gtuFO2zcIZGFtoekNKReQ8DE0T0cdcl8enh98kUdIHAf+H0aW6rma0XG5jl+1MUfgfUC skcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740580266; x=1741185066; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eswWLfkEnQpdtu+isG+K14u+ZfJSvAbvqWCgztSMnzs=; b=p/ciDi5uuBKKdhMUylJhJIEOaxhGPZviLZIOQ4dEnNqEPXDyPc8H/DzHV/Gvz8DEw9 igZQqXb63a8gQGuB4hsSVw7IygW6bICZyN96vx3CHw20m9JwxIl6mSGC/hL4PrhF2Fu3 Ytr0R1jBETqurLUq5dt0QCciRx8wAUt01A2UVGoHBGsD//Jk9SDauFSdGV/v4oez6xAf CjzaMTA/r5cUVuQ8iYIsXli+TnjvOHCK/lT2ivCpSaavi3LnuDOrB4c5K14QaQWeFGxU gN4keFw5oFP3eQzAt3+TH+r96vqSmLgIGMOkmQXVQd95HUqk64aVF5qS/zEDBf7KhXv1 1Q/w== X-Forwarded-Encrypted: i=1; AJvYcCXYWchPW4gkn9YRyAclFt6ITqko3miDLCAkRPTX87Y3LnzT9DJJNjpLCQKUqeVBxHHjZ9TT5L+wgg==@kvack.org X-Gm-Message-State: AOJu0Yw2CjNqJnJWFJYVwZC4V/BMgq27OsCTHhNKPz4e2OapEJagr/Dh 4Xy9jdDAtToEH8CNppX0qp7j/eYO98ePJh3nb/fy/h3cpADMQ14+ X-Gm-Gg: ASbGnctwvxJu6LAdNkhp3MAw/YM1GW/Lp2L4ZmfHs0ZTXBvDU1NEIEureYEN4VqPsqX SzE6deKmTZRWZ5aaSUUfMOGuU6Dfp9+82yfo23jiiv4BPFq/UzzDJX/LJ/nAXj0NNOp887pBBr/ IhNYCOfYMI5Zw+WwhkXRv12/h8lhe6jHIEJf24q+qpjW+6f36fDCAen7kKetuGEAurafcfHARHe oxmQaVhCYaWjkGi7/izWjwCbZ8pEKGJzpBc/+Qj825iqQXbzm0go32ltNqk/G9AcnliUOPHeIzM u2B5ezV0afBuKueyRChIbzSONARKSLqjyDOivMu6kjp3RUxA X-Google-Smtp-Source: AGHT+IGJW1NAlywvROVKX3Fy47FV/keZ7CVdQO/S4ffINoO6dO3Lou+LoCLXMQL+bGSH5kPPCn5/wg== X-Received: by 2002:a2e:9a98:0:b0:307:5879:e7d8 with SMTP id 38308e7fff4ca-30b792cb29cmr26025521fa.30.1740580265244; Wed, 26 Feb 2025 06:31:05 -0800 (PST) Received: from pc636 (host-95-203-6-24.mobileonline.telia.com. [95.203.6.24]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30a819f5e4asm5422341fa.63.2025.02.26.06.31.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 06:31:04 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 26 Feb 2025 15:31:01 +0100 To: Vlastimil Babka Cc: Uladzislau Rezki , Keith Busch , "Paul E. McKenney" , Joel Fernandes , Josh Triplett , Boqun Feng , Christoph Lameter , David Rientjes , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Julia Lawall , Jakub Kicinski , "Jason A. Donenfeld" , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, Jann Horn , Mateusz Guzik , linux-nvme@lists.infradead.org, leitao@debian.org Subject: Re: [PATCH v2 6/7] mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy() Message-ID: References: <20240807-b4-slab-kfree_rcu-destroy-v2-6-ea79102f428c@suse.cz> <2811463a-751f-4443-9125-02628dc315d9@suse.cz> <8d7aabb2-2836-4c09-9fc7-8bde271e7f23@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d7aabb2-2836-4c09-9fc7-8bde271e7f23@suse.cz> X-Rspam-User: X-Rspamd-Queue-Id: 87CE04004E X-Rspamd-Server: rspam07 X-Stat-Signature: tikjqpufqe8wzum9oygwuedcdrsofid6 X-HE-Tag: 1740580267-884190 X-HE-Meta: U2FsdGVkX18ECTNT8GhGkcm3XG4IWWt+awfMbkASXMyNkmPphqFyngw9hFIJeX9igwMdM151NX24RGdoNephMSnj7HbAmCdsiFiPk/4ELiuVyDJd7h9BFwjLF8dqvjDYzcRCQqVBdJDs6w6RUFoVRKOKUdqmY0JplV8GHFUGLaBTymxDl3z1omZh7rfKyWkgrHMO8VXG+tNTW7tVkHPyqSsCb3FuRTMj1rs2WXeicBGkhiRBxboO+9TPAxboiTsGSoTXS7GB5l/Qve+8cWdmCRq4updrRWnqt9nFPgAHZLgk61fXovCUh84wYNaISKu0cDlJbv9jaj8TDlEI1IAyfcZveDl4IVLKBoRLlggHRWPD21SXhU8g+mHNCNcrTwVCKK3Lc74cshh9i0XyZvB9EbGxJ1V8EPePZ8UCukh5MDSCov9dpidmFjTqyvaqN5TEpWsszXCT6Qj09vosXFhlke35P0JFbFbRX33NQpL+pJy+zxVw18WQRnF+D+yMTrDAxptt1lCosCreTEIEI3evlhuZKdUA4vU5KEwlkjhKCuZaco4ahXnIQXe28luZWnBHrExL4LIRt9a3JBi1B95n5x+zlVuDJCCVrUxi+4ImXqFZETqqh6No2A9kwxBVnqAFtMYUnDiXV+CZFF7Wjj3sKeZw4HIJW5PrymYhmGJGvq/ACW5QWGqxVo/cnb6jp80ToG1UYIeb3ZJocR+TDI9NMTEj+CcJBRyj6V3Vy90/I+22a/s/rilvtPtWxWTxfBfWXbkzlh6wAPBwVGWpu8hhYBiKciiB2Ac5bXJ0hog7MXyRxXl0Q8b38QFVcHLtzYGJN1mrOrml4RJRBTX2ny9mnt/NOdmP+rhrm2C/a8LM6+MrXrLBoAMj4WucQl+uXbwdL8hxYgWUh0VTbCuPRszLS8TadiM9Kcy36xjqlE2DLTjEQcUW6Sc68VjFSw6+ezBK6Qc1mDZ4bncv6ZL6F3v JwOrzS6k QETk/p5EeOZvLqVmgoWQdQmVQnm9BOd08FDC/56zX7J/p39id4EI8pklOO08jTF5EihDin4nScgaJdYnaT9oNyYwYDkRXmqn66Vb029TlIrsNDXSJPYWHOBM2+RvRwrb+zw3zcA+9ov1FTafEIXy1ktMotV8yZqC/mOkR4wZ8noOGR14hD5rr52is2/XWpVU4O1eOL/u3PgsEzcAGLveQ54BvRu/jbRu6Cvf3gIIJ7C0JnasUbHJcLoUEOmyeyLhWE5Z/w6NeyDT5q6Z/5sG4LE0Nl4JdIbA8ahISDtX/qR8CGi4c+Z6c9KfZ+NKCh4XsyyJ70CWJrVLhLL3b1X3Oy0RTXUUr7+FBQgmjTMYw7MZA7I4I5TKvXuS6c8QP+8hAPP0cwDQUk+Ljp1k68frbffhqBIS1k6n32m5NMWmowchlKK9UPu8BuvE98Dhbf5vl0LEnUGi/GgrHPCwr+LPlLx6J2OzE3vwZ2Y7Unf3LxqU4BvunNEqi/aCEjvMfLXybXVCi0UNQgH6wOH0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 26, 2025 at 11:59:53AM +0100, Vlastimil Babka wrote: > On 2/25/25 7:21 PM, Uladzislau Rezki wrote: > >> > > WQ_MEM_RECLAIM-patch fixes this for me: > > Sounds good, can you send a formal patch then? > Do you mean both? Test case and fix? I can :) > Some nits below: > > > > > diff --git a/mm/slab_common.c b/mm/slab_common.c > > index 4030907b6b7d..1b5ed5512782 100644 > > --- a/mm/slab_common.c > > +++ b/mm/slab_common.c > > @@ -1304,6 +1304,8 @@ module_param(rcu_min_cached_objs, int, 0444); > > static int rcu_delay_page_cache_fill_msec = 5000; > > module_param(rcu_delay_page_cache_fill_msec, int, 0444); > > > > +static struct workqueue_struct *rcu_reclaim_wq; > > + > > /* Maximum number of jiffies to wait before draining a batch. */ > > #define KFREE_DRAIN_JIFFIES (5 * HZ) > > #define KFREE_N_BATCHES 2 > > @@ -1632,10 +1634,10 @@ __schedule_delayed_monitor_work(struct kfree_rcu_cpu *krcp) > > if (delayed_work_pending(&krcp->monitor_work)) { > > delay_left = krcp->monitor_work.timer.expires - jiffies; > > if (delay < delay_left) > > - mod_delayed_work(system_unbound_wq, &krcp->monitor_work, delay); > > + mod_delayed_work(rcu_reclaim_wq, &krcp->monitor_work, delay); > > return; > > } > > - queue_delayed_work(system_unbound_wq, &krcp->monitor_work, delay); > > + queue_delayed_work(rcu_reclaim_wq, &krcp->monitor_work, delay); > > } > > > > static void > > @@ -1733,7 +1735,7 @@ kvfree_rcu_queue_batch(struct kfree_rcu_cpu *krcp) > > // "free channels", the batch can handle. Break > > // the loop since it is done with this CPU thus > > // queuing an RCU work is _always_ success here. > > - queued = queue_rcu_work(system_unbound_wq, &krwp->rcu_work); > > + queued = queue_rcu_work(rcu_reclaim_wq, &krwp->rcu_work); > > WARN_ON_ONCE(!queued); > > break; > > } > > @@ -1883,7 +1885,7 @@ run_page_cache_worker(struct kfree_rcu_cpu *krcp) > > if (rcu_scheduler_active == RCU_SCHEDULER_RUNNING && > > !atomic_xchg(&krcp->work_in_progress, 1)) { > > if (atomic_read(&krcp->backoff_page_cache_fill)) { > > - queue_delayed_work(system_unbound_wq, > > + queue_delayed_work(rcu_reclaim_wq, > > &krcp->page_cache_work, > > msecs_to_jiffies(rcu_delay_page_cache_fill_msec)); > > } else { > > @@ -2120,6 +2122,10 @@ void __init kvfree_rcu_init(void) > > int i, j; > > struct shrinker *kfree_rcu_shrinker; > > > > + rcu_reclaim_wq = alloc_workqueue("rcu_reclaim", > > Should we name it "kvfree_rcu_reclaim"? rcu_reclaim sounds too generic > as if it's part of rcu itself? > > > + WQ_UNBOUND | WQ_MEM_RECLAIM, 0); > > Do we want WQ_SYSFS? Or maybe only when someone asks, with a use case? > If someone asks, IMO. -- Uladzislau Rezki