From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 513D0C021BF for ; Wed, 26 Feb 2025 02:47:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEB4928000A; Tue, 25 Feb 2025 21:47:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D746B280007; Tue, 25 Feb 2025 21:47:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3C6A28000A; Tue, 25 Feb 2025 21:47:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A34E9280007 for ; Tue, 25 Feb 2025 21:47:01 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 496E2160792 for ; Wed, 26 Feb 2025 02:47:01 +0000 (UTC) X-FDA: 83160558642.10.669BB9D Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) by imf05.hostedemail.com (Postfix) with ESMTP id 8538E100003 for ; Wed, 26 Feb 2025 02:46:59 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=QzYFiPnY; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740538019; a=rsa-sha256; cv=none; b=xWIvp++FYqPpBueNJY6qS3I99mI+s4kDCIswxh11qson489hQeP0w0BVlFUXpZVxn5z03W vR7c6qoWkZbR/MNxpPHgEb3wXhF4w6LaXK+06vYEKhq12GW2BNFK2+JsCtZMBaFwJMeYsA vqzK8L35hTwUymY2rZOJ8MCsSDaBAQw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=QzYFiPnY; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740538019; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PNQREzBUoxFxQC1/e8FKtyGb+Q7/bb7nwwjKa99py3U=; b=nz9UsPbIZdBQ22bhVfQVofFlBk9nC5LSbGkunlkXnL+8OI7FUTbqj4/6ZabEt6Qkk4LrCf jdnKp/9c0lPgXr7llafRz8EYQB6Q8OD4apE494R2HVEORKIr9FHf4q04uLxm64LjO7Xf6C bQV9bSn2MuRNyPTbeMxQnItlggaX/YI= Date: Wed, 26 Feb 2025 02:46:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740538018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PNQREzBUoxFxQC1/e8FKtyGb+Q7/bb7nwwjKa99py3U=; b=QzYFiPnYne0hV2XOpE1d7tPmtG1cJziA1H08fMY70Pz58C0xPOCeYla7VgDTnkrOOGymDf hc3iZysvaUwRGDfWRzwfDDHBhq2GuQhiY6ZLvA3FWvmUlcvMdpNDcz8VZtHMMw4H11CgmF 5ae30sMl1UdWTExtrUhTmd9NDui1nJ0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Herbert Xu Cc: syzbot , davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Andrew Morton , linux-mm@kvack.org Subject: Re: mm: zswap: fix crypto_free_acomp deadlock in zswap_cpu_comp_dead Message-ID: References: <67bcea51.050a0220.bbfd1.0096.GAE@google.com> <3482501981b13aedda3c1c6b54d83d496bd05922@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 8538E100003 X-Rspamd-Server: rspam12 X-Stat-Signature: 7eot93qa19cchxucnzmszb4568y49rpg X-HE-Tag: 1740538019-300471 X-HE-Meta: U2FsdGVkX18J0LLOLvuIpGoviLRxfxnnuOSaeI4pHc4Ce4JG2wcWCz3RH5HAf+Kn+YaNuT01wbLwMLUdE87Ud8nBYcLIHoo0BeqTwNpfiEXrWJb7WaxAiy0MrzvBdQfece8cFhsuVUlGc+8C8aIOXqlmJqu/3TdNQmD/bL1nQydSmGEKdHRX3Mf9y+dEGf2qq7GfU4xpyHsh42CQhCBNm89O5dANt+cyzFTvOMBcnkQphGYfB1R1EMstbmpn70DXTKgGy4eUCxlilol6shWSa4OtCVEwx7i3ODCssnDea5hETGcWkMBQpu/4Vee5t70ylB/iREymcGWy8WyzwMqVHmHhESsX14HT04ZeRhmXi46SuLLcjR7I/1I1rZUAGJadjD9FerkrK7xY49lfCLPkBwbo+PI8KJ3qhRzU3k7JqgXE/x2Gfj0OFOzeykF+ZeqwEbw6RmvUAIme8eJhwPrgjyjevsrxLBrcrGD1JU23mB++b4dkMhyXudHNQqVg0c4CA7aO9f36AtAYFLY3yiDoeNw8/mk3DyKu+pk30E2mBXe82pEoe69pDrne3/WTf1C2cQuFy4JNxbH1ygNcHx0hBd3yLZq5UuIGxyHo9FfJmIA+THEDBKmaXMuOnxQXwWDFnSdWyZpeBKWA1poZnNQ6mk4FPcHEi+Ks2eHeJV1MwX6lsv0oz3E/hBDZ4yq16mtLSOBT/s+ohrm9Gv/Rs5abjLOMdNbBn1xbZC9p/CIF5Vv/4RaIPYdF4nO8E3PznfQ3z71tqgCUkCd99kluTS5QguwFuSWqQ1TqdPENLQLNNkZRa9RDYNoPSNcdxUdN5r/pqLBYYPu/8xMuNLidHozwah1T7jctOUywSNworDW2sdIbsvO/HlULyTWQ4etchi9HTgXWEFbVf1naMTvfEnu7wq4cWhRuf+FCtfwLJ3U6IpVFCrLwhiSqb5BLDnBqMAI77Bpx3Wo3JKDAlD4PUgQ W6FJ+Or7 6D34PurSF2fC/fFGC4u5/V0GlbHCfc7WmdXUzlrDaU6IGVMrO8XIsP3uyS5TWdkGI4wiq5kuJ9MnddvBgJmpeB8kk4SW41NGfG0we/gq+u3fmVsONkTWO0bhA27FaIbYPjak4T21OfJWZ9SNfY6MqSZGslwzwD9zPnqJ5b1qNqTITueU+3jTfOjj+qjjyydGv/Vxstb2YEtwle8wu520sNxGVNAa4PrAW/9ffzTOGSELGmpaRZT6+P+hKJ5lMV2bUPCzuB1li1w/2eUymhzFbUvMGMEykU4j58r1Zf66OfrI9RWy4iWlR5hcvbzTH/SWTvUyEdCK3qDwSnvoQdDGiNfm/i7mkzNZVwxRLvAmKx16UP3E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 26, 2025 at 10:10:22AM +0800, Herbert Xu wrote: > On Wed, Feb 26, 2025 at 02:08:14AM +0000, Yosry Ahmed wrote: > > > > Could you please: > > > > (1) Explain the exact scenario in the commit log, I did not understand > > it at first, only after looking at the syzbot dashboard for a while (and > > I am not sure how long this persists). > > > > (2) Move all the freeing operations outside the mutex? Right now > > crypto_free_acomp() was the problematic call but it could be > > acomp_request_free() next. > > > > Something like: > > Looks good to me. Feel free to send this patch since it is your > system after all :) Can do :) May I add your Co-developed-by and Signed-off-by since this would be based off your patch?