From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 167B2C021B8 for ; Wed, 26 Feb 2025 07:16:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84FD728000C; Wed, 26 Feb 2025 02:16:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FF4428000B; Wed, 26 Feb 2025 02:16:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6784B28000C; Wed, 26 Feb 2025 02:16:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 48C7828000B for ; Wed, 26 Feb 2025 02:16:42 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F35B0160D37 for ; Wed, 26 Feb 2025 07:16:40 +0000 (UTC) X-FDA: 83161238160.13.6B3B5AA Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf25.hostedemail.com (Postfix) with ESMTP id B2D3AA0009 for ; Wed, 26 Feb 2025 07:16:38 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=fJmBCwMR; spf=pass (imf25.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740554198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s0daWTZ+h3e4CYzqQrGN8s4MZibHUnZL7K/uuxn95uA=; b=SUtYQapvm6XcprQzmWD9JfnKG0Uv1XRHZVjllqac6wFVQjp6dkCQ5kl59JginKWZKOeX4f AZawOW7Oqh4gbPYAPFAEVaN7u34WYIbLVKqgSahGAE34W3RuK6PrnH7+Ej0bvdgVq2AI+O LrZv0BtwUgG8BPXgSKO6M7YJeCcBySQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740554198; a=rsa-sha256; cv=none; b=5nq7umWQK0h+tvwSTlmUNvqy24fHw8X2aAFs8mUbBRGe+FeQmPw2e4ka2Lx1YiIjmWlCE0 2/Lr+u/Jfe7VzjKWT6NBgAo2xvJk8P0oycIAMJ5HbLa4R5Avj0iOf7BDXJTt0uPx83Tkyc BHCuq+0JlAQJZIiGBPXBIU4bMSXynvE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=fJmBCwMR; spf=pass (imf25.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51Q6PclK028516; Wed, 26 Feb 2025 07:16:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=s0daWTZ+h3e4CYzqQrGN8s4MZibHUn ZL7K/uuxn95uA=; b=fJmBCwMRObf/ZnmW9sa5kvECELdq3pHny4YsS08gG4Q/gi cHvYhexKdM49XUtPcMrfs73oN/ZdfMLz6FY2OmcsUNM0SZZDnM5/HvUF6h4zwFBe vFi5tLlUP/a5CAAfTf3GozhcWZ68RkW8rgvEm8VIj/UJFvQeTAGP2/m8MdcG+wFS daCY2Rk1F27oScWMb820pAU2LMDCMe6sT8sTjJ8XcQO7ZrI+4V3we7Kbolu27cGQ eJ2dy8AMJpgFvKxeLbjjXwerdyzBz9CiHa8VOFLzS+gydJZSPoDSW21uUznHjMXa 388ehXkYWD9DEqwggjCN/SeJCK0D0qwXKl1/AeAA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 451wp6864a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Feb 2025 07:16:15 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 51Q7DWT5027408; Wed, 26 Feb 2025 07:16:14 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 451wp68648-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Feb 2025 07:16:14 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 51Q4rJnR027390; Wed, 26 Feb 2025 07:16:14 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 44ytdkh853-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Feb 2025 07:16:14 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 51Q7G82A17170924 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Feb 2025 07:16:10 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A1A112004B; Wed, 26 Feb 2025 07:16:08 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 519E420049; Wed, 26 Feb 2025 07:16:06 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.171.19.83]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 26 Feb 2025 07:16:06 +0000 (GMT) Date: Wed, 26 Feb 2025 08:16:04 +0100 From: Alexander Gordeev To: Ryan Roberts Cc: Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Andreas Larsson , Arnd Bergmann , Muchun Song , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Dev Jain , Kevin Brodsky , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/4] mm: hugetlb: Add huge page size param to huge_ptep_get_and_clear() Message-ID: References: <20250217140419.1702389-1-ryan.roberts@arm.com> <20250217140419.1702389-2-ryan.roberts@arm.com> <290f858c-07d4-4690-998c-2aefac664d7b@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <290f858c-07d4-4690-998c-2aefac664d7b@arm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: XY_V547MWzFXGjFNryOxXjG0TG-cKJAp X-Proofpoint-ORIG-GUID: vG3krsx3_W2UnseQJeBqT6t6C7a6pKKC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-25_08,2025-02-26_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=592 clxscore=1015 adultscore=0 spamscore=0 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502260055 X-Rspam-User: X-Rspamd-Queue-Id: B2D3AA0009 X-Rspamd-Server: rspam07 X-Stat-Signature: mymsszc1px865xum5ktn9z48f6tcahzu X-HE-Tag: 1740554198-362771 X-HE-Meta: U2FsdGVkX1/qeC0WsDtFWhJ/1Y8Ojr7PGIiHxPCVhY/aRcl9zbcxDHep6Tp5HONXmQ71MTFWx66FZJ80+Ee1RfKZ+aO2qNbgA071VzoJtYaQsMTkp4/QY8IE8O6KFGF0XAytVMzsKcAATeNJUJ6JyvXyFtRrDdoY3GphJPKeyciFWiYHg2kTN8vqoD7JiyvklTAhogHzPWVIGHtppGsZtGm2U+wn7hN4kaDu/DSvXYNvr1Oo+NFo8YnjycUM9hT8nUgKeOXYgjd35QlVSwR6oQcNX7wjlX3ZoGIFSp0j/zLpYjJG/ytkEEDwGwDVoHvtsJYBcwd4yRHw3r03KAroZUhXgn3kfeVao+Yo+o9dHaKBp4uQZPtVgYGcl1K6srxywezOPtUQrCde+C5MBl2JRFSPp8giLHHD1+8lTAJ0kFlqbqxNMHlAeARZSsnLXpSpwAS4xTkBVGynUXzj0M7OO06CvT3mMXuwPZ86XdYhoIDqjKULebPbTs94td9q1cTU8CGoAkfqwCb1bGF9q5h0aMqzx80YO2pPetFycPVJrF7uaD40Uo4KGFas45So2ifRdv0JAGADlCobyy4XBjQ6bF7DDwtnCXHZFbLSqWiDQRpPzA5KgY1cvY6lpEpnsGKSK+k9O6ozbl999VmkEsOVyVeKNwZMXdYoMHcrMRj71sHOenP2G+Q0qygPOQPoZM2zhQGWhRaT2vQmyDkEBoIZkJ1wENxcG1v+1/XbQ8TIH/fWjA6Yp9bTUDDatQCfbnAQc1EUaPNh1G6lt4LJLBNEqeJ6Scrwlfh7TxoO3vmIBdydIv3mfsDDmdENsWWa8lflhv49ZrTfdYUA1JdXWQfXhaVqK8vtpZXE3jdeSdvUBg96vcbc/otrFhsAFh3RcfC0em/NHNnPzWOKiZZnXCH0WT1kmC8gu+jw9BWxKoixBPmaEIdP+MuQWXjnElAC0pEmbBTyg2hod/3IW7PJl6i HrjyYQmC YYDYGWwgVqGSR0vNyKij2+eR10ovJnaPoXorXwK8ALIiLOE0RtZ66RkSZNGFuKvvVqBmFgWYdnl1zNM03dd7t7naQcMkc/wMvklix/wNaH5OWyS2uPkThgclKVEUrx3kSUZK2zJqcFPqYHsQgmRVlkT+26NrnIsTBYKxpcwlGEOk+h7xg6+B98cpKlu52YjjdV1Y6xhlZ2wYtDVeh4rW0X3IJQjVRVQBhh5FeQ+3GyqNvHQqaMlQBsokNOnAuR4pk4caH+njBCK7ObBrF3zPatuZiF5ebT/c9K2LUatOunIVCj7fI2QPkx6lnEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000253, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 25, 2025 at 03:43:04PM +0000, Ryan Roberts wrote: > >> +pte_t huge_ptep_get_and_clear(struct mm_struct *mm, > >> + unsigned long addr, pte_t *ptep, unsigned long sz) > >> +{ > >> + return __huge_ptep_get_and_clear(mm, addr, ptep); > >> +} > > > > Is there a reason why this is not a header inline, as other callers of > > __huge_ptep_get_and_clear()? > > I was trying to make the change as uninvasive as possible, so didn't want to > change the linkage in case I accidentally broke something. Happy to make this an > inline in the header though, if you prefer? Yes, please. > Thanks, > Ryan Thanks!