From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D14A3C021B2 for ; Wed, 26 Feb 2025 01:25:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 500D7280002; Tue, 25 Feb 2025 20:25:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B151280001; Tue, 25 Feb 2025 20:25:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39ED4280002; Tue, 25 Feb 2025 20:25:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 23B4F280001 for ; Tue, 25 Feb 2025 20:25:52 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CDFE01C7E07 for ; Wed, 26 Feb 2025 01:25:51 +0000 (UTC) X-FDA: 83160354102.28.E010DB0 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf07.hostedemail.com (Postfix) with ESMTP id 3B96B4000F for ; Wed, 26 Feb 2025 01:25:48 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=hzo57jvN; spf=pass (imf07.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740533150; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u6gjY0GvWz0cVjCLNjZik1ey32U4+7GO7hXOEyOYVlI=; b=xoqO8xQ7YJIZkMnX3GR1EuX3822KM4kW85AMn3lGtLES6CDLTPkdcotrGUFy4WHv2sIh86 yqmMiXC0F9K9womYXQBFvjeoomWzz06Sykj++2WLh5a0ZSA7QOoc9ojtkkY/Z+y/Nm5lJt zz+jC47X2S676FUo0AJ7VYTY517j58k= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=hzo57jvN; spf=pass (imf07.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740533150; a=rsa-sha256; cv=none; b=g6GKv/2z9SbM7oNDU5LL1CMNHtxbboHgmaR16q2AkINDlCGXZtM0ylDy7Wth3TUNe0bohy 0mv0jD3OIrw+bZrRKcaatkSA66By4rlED1FgS/0nXU0gIw/R3bvEXtdP74UHHkSabPIyNe wxeTlrFI4jLBZfHb0NtrvWXMIpzR1Sc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=u6gjY0GvWz0cVjCLNjZik1ey32U4+7GO7hXOEyOYVlI=; b=hzo57jvN/49WD2nfGGCFbgsRSk PcrzaiZeZXiOoog5+EFpmrRY0gstm1NYesYMJ4jTRGgENptDSllijGjPabXAD2eBHun6oPKgbBvz6 QywVuZQazdwChoay34Esf8tHHLNyXoA3fnmzX6CjajsMg4KV+C+bSVP/jT2Wxw6y/yp/UforDTRSh inclI03KaMGAehbCCBMC62wNDc8xPJRIsfiNSTQJb52P9hpfKsnIMDDUjAnIImnyKGTckNOhRgiOZ Z7TOSrTPl/7Wt2YfMm2O9crOXW0FYCpeCoCxkbbz8SxqKzczJZKO37lfu7V8ovGKTirTRx0xx9OC5 psgW+/Xg==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1tn6At-001n78-0X; Wed, 26 Feb 2025 09:25:24 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Wed, 26 Feb 2025 09:25:23 +0800 Date: Wed, 26 Feb 2025 09:25:23 +0800 From: Herbert Xu To: Yosry Ahmed Cc: syzbot , davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Andrew Morton , linux-mm@kvack.org Subject: Re: mm: zswap: fix crypto_free_acomp deadlock in zswap_cpu_comp_dead Message-ID: References: <67bcea51.050a0220.bbfd1.0096.GAE@google.com> <3482501981b13aedda3c1c6b54d83d496bd05922@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3482501981b13aedda3c1c6b54d83d496bd05922@linux.dev> X-Rspamd-Queue-Id: 3B96B4000F X-Stat-Signature: 8aes1xuh1jfiw6nikea5f1j61h6d4czm X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740533148-17366 X-HE-Meta: U2FsdGVkX18hBt7S/bg3kKmX/GBd6cWYq3fgYD4ofaqKRkdUudJ054kVu8xOjDT2nkfytQ5vQuWXPwfN7b53O0GU0doTzW0mhVkxUCqegKsXS19l7h/pCanBifnRFG5M5xjdtWlnUmcq9pnxXwyRxiYRnxUkHRpnfjkLD++SkZefMg6ZqROg5ok1/cXOZoYvvBJL795dy7yBfaQCxuAd72cPyOipfjPJmceqVG+/3jytiD0GTRD/SF7b0RVr8lacdL/iStQykcv0qk3pLlcDyKOPzu1Qs1zl3WIZHa4/kv1KZ7KgkI9IQBuaiwDidNtufBShdP04Cu1S2wamGiJKGmOT8GaSChsosPnCNjxJHwqO9RFS4E4QjmdaETzpOmv/e0SP8BI2lEu8UxTVx7g/SL75AZiuQdyyc1RwMWrCJJja4Bw7h0fuZi6gqQEhTUFYcdeQMAKF2Wk5aJsDmsVmGCIAzzuXbpN8747ctFPOdKARBvMfN8MV10dMgjnmgDFdwcU7GLJFQNTszS4/hHh4cfFyKNXLSsofydcY4Pw62wXQgsKRuWt9sOhDIFLFqc/SRBYMX61whN+Q7aCiKtCg1agS9J/xWqDO8kMxVrikuPvddK2RCXrPo0q4fqBVr3lwkFkp8LU6R4VAuq9Lfifxii/x0FXTyR/AdI1/R5tsPi2OwmrDQ+WO/34BFPHAYjcS/p5q3ty2W1mgPHYFjntJPHvSr8QqxPMKMs07Q8Ot3PUUI8VajNuMmxptWHk8efd1HAzUra/WAKmRLPRe2Dm1aFUpMA7sRvlzaqsHhgETBfZop7ti7wCxKjtaqf/xTbZp6kyuxaeWeGM2R5OlM1h0YsOttjg9BA7+Kw5D83evZsx0vyiGG0MJs4MVcKPJHRSCmlHiO3ET3tkyXYOQgyCe3XMfEefSNZbAZapkSFkPufhO5bRXiXgR7aBgxG6kwFj5k0Ogg+YCeW3Ori6oP0L NcxCtl/1 TC8166DiPVnYch53j5ua+2NGtXXS3tXEqUukyOmL6zbxfW3RJXQwlFcDdLh1sT6P3g9S9n8k2ccs0tfE5zYR4RwMrvRu8Wpi9uJIIHYmPrSFLTdaSUxyGZofoxqkBWKpcSh+dymQpxj+XIp6uT31oD3uMCJG/oPe669JW07WBNleKGmCfPZRy16hZloLlITC4xHGPnWRUVVYCA1gvOCTUca6IE+iNdXFC1iLxi6Qu+0lrNLn92azn7xji2BDijZlpgPzRMwj1elBS+qzJOCzK1hEEpEyGi15i6HFRotb28lAf756BtkvRcW9BjmjO8rVcYoMDy37hphxj5fqYl+aCnXcBE9PZ8LbxAnJveSdp112o6KdQHIhO24bM8Rw6GwbO5Zyr+TU8O39unnTfYT0itTNAAwnWeWNtgyduxKO0Wv0Rxw/Y4d5Fnmt3xZ0thsut8PVBxIRK3/WX79E1fVzJCBBkLQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 25, 2025 at 01:43:41PM +0000, Yosry Ahmed wrote: > > Interesting, it's weird that crypto_free_acomp() allocates memory. Do you have the specific call path? crypto_free_acomp does not allocate memory. However, it takes the same mutex that is also taken on the allocation path. The specific call path can be seen in the original report: https://syzkaller.appspot.com/bug?extid=1a517ccfcbc6a7ab0f82 Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt