From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3345C021BE for ; Wed, 26 Feb 2025 02:10:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6541D280007; Tue, 25 Feb 2025 21:10:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6043E280001; Tue, 25 Feb 2025 21:10:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D616280007; Tue, 25 Feb 2025 21:10:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2DC84280001 for ; Tue, 25 Feb 2025 21:10:46 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C925F1407C0 for ; Wed, 26 Feb 2025 02:10:45 +0000 (UTC) X-FDA: 83160467250.10.71D97C6 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf19.hostedemail.com (Postfix) with ESMTP id 55EE31A0010 for ; Wed, 26 Feb 2025 02:10:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=MWGoz4fW; dmarc=pass (policy=quarantine) header.from=apana.org.au; spf=pass (imf19.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740535844; a=rsa-sha256; cv=none; b=Z3bLurbq3jubYmPx+sMlDHaC2p0sr/288y+EY393L01itX5n5qLcKU9tSdxmu4BXWvVgbm Er8y/QtwKmKyBlqfEN+RvoHWjSf7aI5Qc1hw4s33oZ8kuXbeazDsVYhcpIzFg6h9daIauL U36PSrImTqeTToALD6sEUa8QPm6M+mw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=MWGoz4fW; dmarc=pass (policy=quarantine) header.from=apana.org.au; spf=pass (imf19.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740535844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4UaxEhn+opD9ww6UUfnZ4q2QQDf5316tUr+NMRLN7X0=; b=UDoquEaARgnFG50AldxTt6K5AVdVou4EWHAW1X/NEV6SywhuMdoz6v/DucOUxTXevXk7jG R/KDOBTh9koQ6uoeH+wgQIJz1KIsNdd7lH3QUzQa/CHdEluGws0rc9sXq1vszOE6gd1zaC g4RLGpwHvi2c2tb6VA1JSKAkPuWif68= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4UaxEhn+opD9ww6UUfnZ4q2QQDf5316tUr+NMRLN7X0=; b=MWGoz4fWs/xAd/6OgBVijOW0J6 x4GBtTchVEg9eyE1QCxHr3M3CjdqBFN/7YsYKXT1+hkgEHHE7VMApuJEZPEi2pIY3Dj/KXsnhNnuw eYfF5PCag3sh5cmhCUYpqLp4r4js4gQTxlC1LQM3Q6qZFectjymws2D8JtLgpNGysfWnwpH8qd7rY Y2J3p1A++n54v7m/ocdVHRodQoXCQOfKi/7xuk9Hu5mOJERq9HUPM3jQtXisRmywVtYI0IVM50tQ5 LGUd1Qc6XPgYtOZ6laRA5dtcFJ/YpQnqt61i4KpioZ/KFNtAFMmDDe0G2idiXKjovRfEAyPmbBByR kjMBfBWg==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1tn6sQ-001o3g-0l; Wed, 26 Feb 2025 10:10:23 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Wed, 26 Feb 2025 10:10:22 +0800 Date: Wed, 26 Feb 2025 10:10:22 +0800 From: Herbert Xu To: Yosry Ahmed Cc: syzbot , davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Andrew Morton , linux-mm@kvack.org Subject: Re: mm: zswap: fix crypto_free_acomp deadlock in zswap_cpu_comp_dead Message-ID: References: <67bcea51.050a0220.bbfd1.0096.GAE@google.com> <3482501981b13aedda3c1c6b54d83d496bd05922@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 55EE31A0010 X-Stat-Signature: sex8re5ib18yb7mnoaqgb66wttjwutum X-Rspam-User: X-HE-Tag: 1740535842-838825 X-HE-Meta: U2FsdGVkX1+RmOYh8LYlt3ErbQ4K2vhpoHWQ6v6008E6vymcn3AUOLDbTYGOY2Bf14bR9RzTciv/+kmfr+Jb8urWK2CC4gWWZHobTw9cQ991yAhPBPs4IZPhyRJsVl0o5zuCrvbl/1tUhHgo7IcDa2zNmnlCmdXesx+jw5dkYjvT8bdD5BmqDnrrfRTUrASvPSY4tM/vjJzQ9mWJ9qFIqjHZMHLuFtu8pND6Kt6lJR5OkVPryee3izapgPE2yHSSgSbrzAEUjiOYq/UWn9PPG7gOuSqDIlXFVkLKM7JE0ifRdis9G2hvJ8JVTFkuFlISyJ2tERrsUYVSbgkwiXWGiY5B/F21P5F0z/iPDg3sdZJ9l56Rl40M4ci64UYr1GYH9VP8BFpOaO+Qa+UbjQvnPN4FnMLvS8eW1If+6WlUmSn1zAQZ4r2mLv/M+lQH9QQ/akyqSI3lQcuA4C9PGSZECB+WSpxKFg/7qs+6m9G3S3cIwShziD+AlOAU4QFqrpGAVRa63+5FHlxYPrcFBYABD7HhmuYXRYCYEi9yexLav9In7dinH/J5hwwSo0ueMsPqgRSD2MTLzCN8I4PxdlMQXGXzaVQGJVjcLCMHgPqlrift7cM64Ei5F+nPO/rsKmHU5outcJqJhDhB55cgNU8tLRXFlDhz/ysFXGR1nXdYVn6CUCqpdAameB6qbdWyAn7N1dhWCePM3oXCCdEy7gcT7C8+FmrSVUMYG/od1VrqJCZi7sNiOpmS7Cy5VmQugVqOm5ac3pisEYe7pJgwpXKCrOM06x5WdlRPWIfS0gqSw5N+A/RswbeqcjNO/UwjEAkJ1OpIy4Mat4xohaWxqzlSYpvnueJXFy8J651o6YbTGrOlqou71Gr6NH58OI/l77WAwgdmezsSIxchrKSKdoflCcLgmPRH98NLjWpFnPJCJPknCE8+TCe6rGmvjOGvwUEb4GPvu+WL/NTF9EiEbYB ayThsdoN Tdr9NDHJtgvnrlqLwDmkaO/XDC1098XDnx6LUyejsUK0hx+rSQKIKu3l4zx7e0mjrxs1656CJMxHwfr8VWInzc2vmIQie/TwgbpAnw21zaxIdzoarbyKX4gM6hF3TTlC3wbtdJisi6zdL6af9klI+eczJqH4L4YqR9XWv//uFr1me5vXBS9DM6JkTjEA0j85nYEDR1ake+VAkUQjQgUR7Kv63Rb2W33fIeYdx4ZXPOaFGbvi6HHOD7C+GtT1Yj8wKO27oOut3NC8wPMU1CE7Ii8yCNdS7Z0Ne9iEhHS5Np5S5zgj9ZYuo6yPo/zcTTHD59KXTLf/xLRSYseDIJI5F+nN/NsRpFSoA+PPsl3ZeyuTovvYlx8x032WdDA6+M6YQ7OY9GMUDrgHAUHMfWFAJF3CeeOApnMf1pbRB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 26, 2025 at 02:08:14AM +0000, Yosry Ahmed wrote: > > Could you please: > > (1) Explain the exact scenario in the commit log, I did not understand > it at first, only after looking at the syzbot dashboard for a while (and > I am not sure how long this persists). > > (2) Move all the freeing operations outside the mutex? Right now > crypto_free_acomp() was the problematic call but it could be > acomp_request_free() next. > > Something like: Looks good to me. Feel free to send this patch since it is your system after all :) Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt