From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B891FC021B2 for ; Tue, 25 Feb 2025 20:37:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EAF96B008A; Tue, 25 Feb 2025 15:37:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49BA76B0093; Tue, 25 Feb 2025 15:37:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 363326B0095; Tue, 25 Feb 2025 15:37:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 17C1D6B008A for ; Tue, 25 Feb 2025 15:37:21 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BB46A121D02 for ; Tue, 25 Feb 2025 20:37:20 +0000 (UTC) X-FDA: 83159627040.26.5F42D8E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 633581C0003 for ; Tue, 25 Feb 2025 20:37:18 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=INVMDQqM; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740515838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zRqlIAwXEZAt9A8J1cznfUQsjJ6aJaejVBOoC9QBm/E=; b=nlSWRzmBzpZ/2Ul7CZBTv2fk7fV1sQ9uOe2KYFkIdcT5aFHir+zI14UhMppne7dMWRM3If MdYtmRERB/pAKDIEgCNQf5ox0dJFv/1UOgZZ5rQ23oj5x3F2Xk4sr25woYiZR7ZAP3z9Sv iGiQEaPH9GFyj9eQc6hMxe4ur1H+c6s= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=INVMDQqM; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740515838; a=rsa-sha256; cv=none; b=N9iZ8H7lZJiQXVcoRnRYOUIIYqRVRexYSHp5L0umXC/nh8VgG8arVa+OazhpoWEJmAz7UT zKI+NvVHhrW5ChvpmcFx7FEGC+FhWM1JPoKP22j3dLKVYHMmb7pJbTRVs42cnpJq6wRJWl bP3wjhB/cCSpeCTsvkELwjvu2HjDL5c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740515837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zRqlIAwXEZAt9A8J1cznfUQsjJ6aJaejVBOoC9QBm/E=; b=INVMDQqMeA9brzFdAo8ZE0zr4jlMguV2JZHgSdiIvzc3A7mtvAEtoYbr5790dElqtvNbkc idMN7wSMFtUSMTboNEvwvQyWATBO0QvlXbmmiC5J01GzCBgcDalWtCcq5mIhT/yR06C5E9 BztrYLB/brkh/YG7q6aNeQomDpTz13Y= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-551-EGBcm5EtNiK-s_IfHJyHGA-1; Tue, 25 Feb 2025 15:37:14 -0500 X-MC-Unique: EGBcm5EtNiK-s_IfHJyHGA-1 X-Mimecast-MFC-AGG-ID: EGBcm5EtNiK-s_IfHJyHGA_1740515833 Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-727358c6405so5986650a34.2 for ; Tue, 25 Feb 2025 12:37:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740515833; x=1741120633; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zRqlIAwXEZAt9A8J1cznfUQsjJ6aJaejVBOoC9QBm/E=; b=oIEno5fcB7SVBdidA6uPQBcQtfG8ufigA2Bc4D1E4lcc1O9WEQ9T3SGiiuFgMcnpuI 3a+dL76rGZGA6Tjm9JdbjANVyIQlXKH2u0b3vuNmwopgSWhuPGC7FGFoqLKcjfwltX0C UPdnFG9+VAq7jYtvC5xjMc67urdmMiwavylftTpKqZORfz8/zSgI8dAYG3F8GAnYCgNa 0CDAo2iv1G4U2YDqFzVBaW67p/Hahhwv3Ui3/fHFPi6eCq+2FMDlzX6KaqPiyjIsIDdi SlLy1p0cFnK3UJA/x3OHhXEbMYTUGoHXZo2itkbxPl9+JcpS5O6Q6YzD9p3zEo/lPos1 RdOQ== X-Forwarded-Encrypted: i=1; AJvYcCUpVZ28XbsuEXMeLfsDadmT0NwK4fuFzCY0N59T5lIbqztXlUUOEEwZ8kmMc4gvHO6znYP2KfWu+A==@kvack.org X-Gm-Message-State: AOJu0YwtkYbEpASOjwTFv1GL9aeLGzc/M7xXot64di1iOqG/IZnhRsNr 6+a1eSAWgVkqyVW0X/O25skWjiyxu08wFHgcbqjyK+ozLWoXeNWn5IYBb1p7VqAFIL8n9XnB+L/ QPSn/skYcDYUrLz6nXjCdxNTJve2k74R704HOFc1oNOSBh97G X-Gm-Gg: ASbGncstm7u1q/wX2U1J/xGqUIJI2jswC+oL451LcvhcspNUZ+nuPQYf3E2ifqcZTeU u7OHX49ZbnVWj9Qd45VLadY1q/1l7JzGKe56fJ/gizTQK3nB2C59+nURILdxZgNQImZ1EbuD3bg sIgMDdTIa44cRzcTOT2sUjA0iqUZw5DPVIVt9FFOKJzKZ1xn+WcHzYzmZsKBGy6NzPjOfXoiLOf myEhX6UXymx2pja2dWZzfx08bx0EkGdqHIMHEr7rdpbhgMP3rWCbUd4zI3nNFGBhfn3wg== X-Received: by 2002:a05:6830:6c11:b0:727:25c6:1b60 with SMTP id 46e09a7af769-7274c1840famr14524671a34.5.1740515833604; Tue, 25 Feb 2025 12:37:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFotTZ/dQhUmhniqjIu8SiEBEne0EGahBIhmibL4OkgpDX+sNTQXhjiXbEsxwXRiWLeeDe4Vw== X-Received: by 2002:a05:6830:6c11:b0:727:25c6:1b60 with SMTP id 46e09a7af769-7274c1840famr14524623a34.5.1740515833295; Tue, 25 Feb 2025 12:37:13 -0800 (PST) Received: from x1.local ([2604:7a40:2041:2b00::1000]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7289deed409sm431155a34.40.2025.02.25.12.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 12:37:12 -0800 (PST) Date: Tue, 25 Feb 2025 15:37:07 -0500 From: Peter Xu To: Ackerley Tng Cc: tabba@google.com, quic_eberman@quicinc.com, roypat@amazon.co.uk, jgg@nvidia.com, david@redhat.com, rientjes@google.com, fvdl@google.com, jthoughton@google.com, seanjc@google.com, pbonzini@redhat.com, zhiquan1.li@intel.com, fan.du@intel.com, jun.miao@intel.com, isaku.yamahata@intel.com, muchun.song@linux.dev, mike.kravetz@oracle.com, erdemaktas@google.com, vannapurve@google.com, qperret@google.com, jhubbard@nvidia.com, willy@infradead.org, shuah@kernel.org, brauner@kernel.org, bfoster@redhat.com, kent.overstreet@linux.dev, pvorel@suse.cz, rppt@kernel.org, richard.weiyang@gmail.com, anup@brainfault.org, haibo1.xu@intel.com, ajones@ventanamicro.com, vkuznets@redhat.com, maciej.wieczor-retman@intel.com, pgonda@google.com, oliver.upton@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-fsdevel@kvack.org Subject: Re: [RFC PATCH 26/39] KVM: guest_memfd: Track faultability within a struct kvm_gmem_private Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DLZDcvg9H6rWUpI5wfQcIHrHu6t1P9qlMaAM2Db8oZg_1740515833 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: 633581C0003 X-Stat-Signature: zsu77h53gdzf77n8j9eu8xahyo5skhuc X-Rspamd-Server: rspam03 X-HE-Tag: 1740515838-361442 X-HE-Meta: U2FsdGVkX18xjlnFA+1iarbpRRJed/UyWZvAy4bL0tpReKsznzKn5a3wmq6QkDHAT32yNEYFewXRuzy3Or6xdv75zyKGLF70X8UgzwY0oszQH4DNh2oX4h3XaIpnqqeCwRszC39MDZ2FgMi7K35ULn13eU+lHm7DxXcH8ccQZo8RCO+xfk7Y91dalDsq9L5HRVNmG4gwwGl1B9eM4JNgAQuyD5rdkCRFMkgRHVst8VW8efYIUnpk80nwkLomxHDlDYmo5h/aDgEVGbirL3ADCj0mGKfDZxA8Z5ydiOi7ayLlWnW3wKVeojsIYrOEyGGzGP4qzYTdaG2OZof7J/Llqjl4rvQGwRFzBwZL3cKJDzMmoapK1q0uo2uqKovYp9UOo8DxSVfAJGo7Ejn/LnZwf2f8gju12heW89AT7WqICSpl+Kg0jBol1qGve8sx5UeMLfCiaSe9XwtUPTNVRpKKLfuH5y53apGP/rEON6xztavcyJUUlR1gXszmPoQCrOJ7Quik7f+OemsSMR1iszmmG4sn/lnaz22ws+Ol3FQnedMs/rcuCAK7rQmyNmVJ6mOC0z3WNvcQFmZvC1aImuBwqD8dzLsgJvLhnLTn8vkuBDwYP+cQZu6zG8zscAcTJf/pA/Kol0xZIts0kHZTod+ViVHihVl7Ob9uKKsOlLKiOlSIvLRulWBHYBmHGH4EpZ1ZMnI6p5vKxrB7jtZ4ASoHnFBA9ZJaLLy7yrIpUlcE9hMJgFQwUo1awtDwu35BrY59Ym83PNIGPZHRE9jnj+SQeaS9gUcEi8b7e/qupJmM1ApROKLA6wfPXfQD38WMBywTnkMkdqu3FQP4IGV4bjwB7kitkl3fkSe/4gO4OVa2ePwtDo999Ea9Fj4/GYbGkVDhchuWWCr9XjduTjDoaUj1ecD5eymbU0koZKuiqPALFVwA5Lick+yHrr6eygSJi19wTAEUivQl+ix8GDIxSsk //C05R+B yNesql3DDpQAHFoXiCPoOF7tuMud6AKOCeUeOJBHTvsYCthvCQpTHa9LqHpwA3tb0C4Q60dN7gsc2WX/denxEOLA7jDW+x3ohI6eN+TDchzuUk9l9QxgYTRX3TQbg0XeNr2TRKarcW09mgPWPlnhjT8MjYebKjmu/+RH1Jt94xP8Kw36qPZeT07//E213X2+seu7HWCiSK0pWPOAtIyyy95xVif+y5Ji1hcOt07TRiFsTXwW6KrJRmIPeaaycsKd8e7Nbu9l/FCOTa5WCLXNcyl2iRFnr3g3Y7zbSJcgp7jKbgE2map0RlsYOtga2dnClgfB9peaIGmao/zzMNTgjTqba7xuKIzTzlc12qjIDrmxjiPFs1qddc02LLojX0PY85v3ZvMTw8UZvHlnQdJDBrOSEWiYTTbquSp0mfEYtvl0eulU5gdBiGL5/laB9TwgjEqm3cFHDZ4inM2I5v2gDyYKUOLDpHX4OLO801taB7r1px+9rJiUi3pfutg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 10, 2024 at 11:43:57PM +0000, Ackerley Tng wrote: > @@ -1079,12 +1152,20 @@ static struct inode *kvm_gmem_inode_make_secure_inode(const char *name, > if (err) > goto out; > > + err = -ENOMEM; > + private = kzalloc(sizeof(*private), GFP_KERNEL); > + if (!private) > + goto out; > + > if (flags & KVM_GUEST_MEMFD_HUGETLB) { > - err = kvm_gmem_hugetlb_setup(inode, size, flags); > + err = kvm_gmem_hugetlb_setup(inode, private, size, flags); > if (err) > - goto out; > + goto free_private; > } > > + xa_init(&private->faultability); > + inode->i_mapping->i_private_data = private; > + > inode->i_private = (void *)(unsigned long)flags; Looks like inode->i_private isn't used before this series; the flags was always zero before anyway. Maybe it could keep kvm_gmem_inode_private instead? Then make the flags be part of the struct. It avoids two separate places (inode->i_mapping->i_private_data, inode->i_private) to store gmem private info. > inode->i_op = &kvm_gmem_iops; > inode->i_mapping->a_ops = &kvm_gmem_aops; > @@ -1097,6 +1178,8 @@ static struct inode *kvm_gmem_inode_make_secure_inode(const char *name, > > return inode; > > +free_private: > + kfree(private); > out: > iput(inode); > > -- > 2.46.0.598.g6f2099f65c-goog > -- Peter Xu