From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA949C021B2 for ; Tue, 25 Feb 2025 16:03:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 646A5280006; Tue, 25 Feb 2025 11:03:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CF48280001; Tue, 25 Feb 2025 11:03:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4971E280006; Tue, 25 Feb 2025 11:03:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 28109280001 for ; Tue, 25 Feb 2025 11:03:45 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C4A1D1C5F9D for ; Tue, 25 Feb 2025 16:03:44 +0000 (UTC) X-FDA: 83158937568.03.8587833 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 0C8671A0006 for ; Tue, 25 Feb 2025 16:03:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Zg+BK2ZN; spf=pass (imf19.hostedemail.com: domain of kbusch@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740499423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZA/z7q9kCF5Lt65d14NWTfWdgZTE+Al3KkUXcPo/sbk=; b=g4sbyGed9fUbwq71cliGiNqriOmMGjuqRcIUJPQQs9/RWkeqUAdNR1toT8+0iixRkzkLHl jZMRSyvlBFQLtc4KU4+z1DcND9p68DixUXrpWYCtsMYYh5htHLsgIaRhgD7HurWVb45pnU Uw5wC738Euy/uJ0+j2eWfSAR6ANXDYE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Zg+BK2ZN; spf=pass (imf19.hostedemail.com: domain of kbusch@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740499423; a=rsa-sha256; cv=none; b=vi8XDNkl5FCJNTCuhF3u+bD0fVzaLDTjvaX1SjLFNxBEdQTE6nYqOtU5X0D/2ycyN2IJfg PxJD/Kqro6oTUkbS8qR6vKDfzfXP4BTKZlqiY0WN25wlWIFojd08dEc93o1TjuGW2v8GJ3 z+/fV4VXOeLCJe6miM8XjYHuR1MJ1KE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 09EE85C5879; Tue, 25 Feb 2025 16:03:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 482EFC4CEDD; Tue, 25 Feb 2025 16:03:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740499421; bh=PZRqScTDAfxk6yafOLzJqKVISoJHPiEo/RN9hzakm1s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zg+BK2ZNe/cpHw1WeZ2txYRfdHFFu4cwTtPsLhtR2YZG+pHez6IBObAtYUO3a8jl9 XqVYAK7O88nFucQjxhvx1XvyC/u697CpGxKMhyDceAAs55fhBOibEjfRFvGdjfU3pm p4fG6B3PlXiY2vcMlDEPmr3RX+5Dyx90XKldqih4pW1vWLBZq3qDlkddnlDQmRxytY TQ7ef2jr9aL2aucgpewlGfgmH7xPzvTovaF+Jwobf5rqkLbDQk/RB03Nlw6wdv6ks6 r+S02CXubr5GroPFchEgPO//fzaDOgXanGLdP/VU0v5ycy1eM2aCGnAVfFGB4P/VkW 5MuWrP3TZR7YA== Date: Tue, 25 Feb 2025 09:03:38 -0700 From: Keith Busch To: Vlastimil Babka Cc: Uladzislau Rezki , "Paul E. McKenney" , Joel Fernandes , Josh Triplett , Boqun Feng , Christoph Lameter , David Rientjes , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Julia Lawall , Jakub Kicinski , "Jason A. Donenfeld" , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, Jann Horn , Mateusz Guzik , linux-nvme@lists.infradead.org, leitao@debian.org Subject: Re: [PATCH v2 6/7] mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy() Message-ID: References: <20240807-b4-slab-kfree_rcu-destroy-v2-0-ea79102f428c@suse.cz> <20240807-b4-slab-kfree_rcu-destroy-v2-6-ea79102f428c@suse.cz> <2811463a-751f-4443-9125-02628dc315d9@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: c9hbtrsytyifnctij6d8hd4fkukdfa1w X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0C8671A0006 X-HE-Tag: 1740499422-151083 X-HE-Meta: U2FsdGVkX18uuOlb5WSSF+keO8EfAnZPVK0JW1w88GJHEkhFo7RBDCt2DAzBAJK7W6enAkqmiV7jprF89BWDaVaSprVeazOQBmwqdT1eSYA0waEJorjUEwunWc0Y2t98p5VwUUn9tAYgNOdAwUBAu+0aLwOlgq2Gpr3+MyQfO/XfWl8lqc6/iJBclzVLewNX6+r8UCMgM4uAL9tt1o8LVb2mhkra7qYyhw45KRrd+ldEEdPWb6wxbh5x09htJ51xYdnaaBkdQPz35nbuUxBprshL8aGD++FGw2kwj1coy4pmoa6/454RFwvN8PsBW1ldmgw/+qz7Q6VMOaxuhxCyhmlNoyO7I4OuOEdYhVs/x9kubd1xEscO+j604vQ/xipVs+Inpn7PwZ8OqoSELOq6+KAlJba9tXUtJdyTfhEBeSX9KyJ9qn/1mM1bcNpJuMDqz41nTGwMc9L3rPTCY/Ycq3acz2ERkUpkhB87Ik26x8n2TIQbW5/aEx0B5o919ZJuI5eEJ42JrEwmWFjett42DQjraidyMN623s+LNraSAFBhQcAMlbQ0/kRGUwkryNeLKtTVUF55fZJXLv/pZOaiWWMCnW/RWXpPyY84l+Oi3+lf9+c5SuuN2GqrynypjtD24GAxw6THSvw1Hd5OPvQMQQ2fVIt/SjqDXgV/qfJ53Tv5u/Z7Hw11sxK9ukSVmUVbqoemQYtOr4/3gUfLeE+RP0NJgRIY2k0ZpNLu6QZW1mtxtX/XT9gFfIFayhYcOMqoUSDvYzIp8ejt4xaAKsNrFninVp4OYY+/RJEXNCgMpKGUtalgLmxP1UwxYnx2+QbEuKYdOt7tLEm0CjwKVLE+n6IcgbdsMahzx6Fy/YGk0Rje+M7H+zD7b7yIlGSDua+TH4fpbJCFDDxfKcRZzcuEYwOxsDj4HmPEWDlKQxIyTVqPt19oDLtUjWshDx9ZYzqtLtI6ePKJFVm5D+i1jS+ urSuK0ur EP6JWYeM8yNt/KWJNhFxQ6k59NATbhpAaP5WuzoccZYJQ6jlwNYQ7bkjTgE4Zwzodxw/AE+7xQTNTRM3LJYAiJGm3Yj0nlFJ91bpBUoO29MLjzG9C1zho7eYK8kJqzixq7pgoGJLLDYUOmc3jafz/binVZ58rVNvhm6RqTxW7Y4S9pED8vag+AHVIskFi4PLwWH0zCTJjOn6+eqGHpXLpXn3ikD0gDg6II6IlkHmHhOwRGJ6VEsdmpqJ/YAt7FWskeoOU4EPTe31ohBxw38089SHvdAl3wUfAxxS1T6eaZw0hoZ57LREnXKj17XD6LUjVcNWHwogoLBTCJKtjRzqQB/z3IQ1EyKZthUT7XaSOCosY+3hxNYmjQbQKk4js0q2DVHvgCk/LtkE6A9RWb53kw0DyNi/wSktUHwUMA90TXX9wYYo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 25, 2025 at 10:57:38AM +0100, Vlastimil Babka wrote: > I tried to create a kunit test for it, but it doesn't trigger anything. Maybe > it's too simple, or racy, and thus we are not flushing any of the queues from > kvfree_rcu_barrier()? Thanks, your test readily triggers it for me, but only if I load rcutorture at the same time. [ 142.223220] CPU: 11 UID: 0 PID: 186 Comm: kworker/u64:11 Tainted: G E N 6.13.0-04839-g5e7b40f0ddce-dirty #831 [ 142.223222] Tainted: [E]=UNSIGNED_MODULE, [N]=TEST [ 142.223223] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.16.3-0-ga6ed6b701f0a-prebuilt.qemu.org 04/01/2014 [ 142.223224] Workqueue: test_kfree_rcu_destroy_wq cache_destroy_workfn [slub_kunit] [ 142.223230] Call Trace: [ 142.223231] [ 142.223233] dump_stack_lvl+0x64/0x90 [ 142.223239] print_circular_bug+0x2c5/0x400 [ 142.223243] check_noncircular+0x103/0x120 [ 142.223246] ? save_trace+0x3e/0x360 [ 142.223249] __lock_acquire+0x1481/0x24b0 [ 142.223252] lock_acquire+0xaa/0x2a0 [ 142.223253] ? console_lock_spinning_enable+0x3e/0x60 [ 142.223255] ? lock_release+0xb3/0x250 [ 142.223257] console_lock_spinning_enable+0x5a/0x60 [ 142.223258] ? console_lock_spinning_enable+0x3e/0x60 [ 142.223260] console_flush_all+0x2b1/0x490 [ 142.223262] ? console_flush_all+0x29/0x490 [ 142.223264] console_unlock+0x49/0xf0 [ 142.223266] vprintk_emit+0x12b/0x300 [ 142.223269] ? kfree_rcu_shrink_scan+0x120/0x120 [ 142.223270] _printk+0x48/0x50 [ 142.223272] ? kfree_rcu_shrink_scan+0x120/0x120 [ 142.223273] __warn_printk+0xb4/0xe0 [ 142.223276] ? 0xffffffffa05d6000 [ 142.223278] ? kfree_rcu_shrink_scan+0x120/0x120 [ 142.223279] check_flush_dependency.part.0+0xad/0x100 [ 142.223282] __flush_work+0x38a/0x4a0 [ 142.223284] ? find_held_lock+0x2b/0x80 [ 142.223287] ? flush_rcu_work+0x26/0x40 [ 142.223289] ? lock_release+0xb3/0x250 [ 142.223290] ? __mutex_unlock_slowpath+0x2c/0x270 [ 142.223292] flush_rcu_work+0x30/0x40 [ 142.223294] kvfree_rcu_barrier+0xe9/0x130 [ 142.223296] kmem_cache_destroy+0x2b/0x1f0 [ 142.223297] cache_destroy_workfn+0x20/0x40 [slub_kunit] [ 142.223299] process_one_work+0x1cd/0x560 [ 142.223302] worker_thread+0x183/0x310 [ 142.223304] ? rescuer_thread+0x330/0x330 [ 142.223306] kthread+0xd8/0x1d0 [ 142.223308] ? ret_from_fork+0x17/0x50 [ 142.223310] ? lock_release+0xb3/0x250 [ 142.223311] ? kthreads_online_cpu+0xf0/0xf0 [ 142.223313] ret_from_fork+0x2d/0x50 [ 142.223315] ? kthreads_online_cpu+0xf0/0xf0 [ 142.223317] ret_from_fork_asm+0x11/0x20 [ 142.223321] [ 142.371052] workqueue: WQ_MEM_RECLAIM test_kfree_rcu_destroy_wq:cache_destroy_workfn [slub_kunit] is flushing !WQ_MEM_RECLAIM events_unbound:kfree_rcu_work [ 142.371072] WARNING: CPU: 11 PID: 186 at kernel/workqueue.c:3715 check_flush_dependency.part.0+0xad/0x100 [ 142.375748] Modules linked in: slub_kunit(E) rcutorture(E) torture(E) kunit(E) iTCO_wdt(E) iTCO_vendor_support(E) intel_uncore_frequency_common(E) skx_edac_common(E) nfit(E) libnvdimm(E) kvm_intel(E) kvm(E) evdev(E) bochs(E) serio_raw(E) drm_kms_helper(E) i2c_i801(E) e1000e(E) i2c_smbus(E) intel_agp(E) intel_gtt(E) lpc_ich(E) agpgart(E) mfd_core(E) drm_shm]