From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D43C021B2 for ; Tue, 25 Feb 2025 15:37:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE1B46B0085; Tue, 25 Feb 2025 10:37:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E6ADA6B008A; Tue, 25 Feb 2025 10:37:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0C606B008C; Tue, 25 Feb 2025 10:37:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B2A276B0085 for ; Tue, 25 Feb 2025 10:37:25 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 66108B6A15 for ; Tue, 25 Feb 2025 15:37:25 +0000 (UTC) X-FDA: 83158871250.19.3AC30F5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id C100540024 for ; Tue, 25 Feb 2025 15:37:23 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740497843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5RsOOvv4/v4k8q1hK8YiYnK0f9T2HxNOpQanU6J/Cfc=; b=UbOSvLnDk+Wp4Z5MjSyKaRMZowhy4noIYksZE58UzZLEhMhDK4Lf6ocsKSgv0vdKtEy6XB /O8dJ3zMJOtKIFVx+mnBCerYpiBau6epScBt3kjuujXmxUo4T7mtMSV5EU0qypO2sbY/7U +90EtfyJRg9IQNsEHpaA84xFYn/bkBc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740497843; a=rsa-sha256; cv=none; b=1VxHu/PD2DtnOYmd3YGRDTaxlywN5kzDtrBwSIRu+kPGqQ7KtKXYBne82+xZgs+Hu+4Nkt zVDSgYSEPXp2V73JxsJUGi4a1nX+iaVoynsDvYujJEVNoaR96wEg9kwFvdb9PrY7KxP1KN b/X3+/2WIp84WCX90YDWC84AIu+pDpw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E4CF85C71D4; Tue, 25 Feb 2025 15:36:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2BD3C4CEDD; Tue, 25 Feb 2025 15:37:19 +0000 (UTC) Date: Tue, 25 Feb 2025 15:37:17 +0000 From: Catalin Marinas To: Ryan Roberts Cc: Will Deacon , Pasha Tatashin , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Alexandre Ghiti , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 11/14] mm/vmalloc: Batch arch_sync_kernel_mappings() more efficiently Message-ID: References: <20250217140809.1702789-1-ryan.roberts@arm.com> <20250217140809.1702789-12-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250217140809.1702789-12-ryan.roberts@arm.com> X-Rspam-User: X-Rspamd-Queue-Id: C100540024 X-Stat-Signature: tfhu7gddh1znh4xz3xzbcwmxkipyqu1h X-Rspamd-Server: rspam03 X-HE-Tag: 1740497843-862033 X-HE-Meta: U2FsdGVkX19Ua5wcoLvZa7FbPzHxtkTUxylDjjwPIHWCGXqNVzTZD0ROwIGrhDvBRiRgMXHeJ2x9ScUt4AeVXMrARqaeIVn3QggxueM/9ya0Wb23C6S6jfv2RMw1g3/uj82754xhBfSWUlEX2CXE5G80D5f/4FjwAGzTgiDjzDCsF2tU9ccFczcCdaI8Qto987fjGeUzIglFTS9bFmEgYgXQQuJXTfeQvRPH+/UIZL8lUmouRGrNdv/79JUREsILFWpRCqOmr9HAhz0hxYncNnE7a18ZMhsdtN41AxyKDr4tJ/oGAdZTiBFzEwEHG7m+KA1bEcKDbVzFmcw4llJ/fZEUV+SYDZ1bkV1mylFCH6IPyymOwoi8pMh0dR8rtN+tTlfubhGbiFu0LDiB/e31DbD/3JNMdBLAB35gDqAlKwKcuI54KOiFmnx3rQI1pgFn3pmSHaQ8kyzTrJfC3QuVVtCWMaZJoV2Rkc/fl9gZx5bJ2DFtat5VajTodYVAaDoE8l2PZchJUnPVt9UnEqIJ9IO99PkQ/BU0JvvjFDR30ZR5//tZNhKRmq2x+ITbbZuo67ex79jLujEha5pS63W1azWYvV7Z4/TkpLgiipbA/jK9Ep/rDV12a055/Y2izHET0P0xZTxjZHnZL4HQJfLFw8IGE1ZQ8qRFYB92kx9nf5LdVL7sS9D7MVrYVwMrawMytHNaeHXUnCDpjomOPATMNHbgzUcX7j5URXdcLzu5tKgOBcyOcWfUab4bKIIQEPVj9FleuvgaZqQ5P/OAIx2FmNFSC0EB4GsV2OGjOJH5Yi1/KaqKO2M/bYQxGLoGpbsHi9g8rl3cI2IEaS6kwU3Fs8zgQFqVVaRvcxkddAZmdSEYIOB1cfwd0YpplXUyBiO6otAMU8V6FbhmBMpMj1Q6lQSlnJ4Ie0jkMMMHofRgmdDDYP/5qjS6Lbs5VcLA1dVlBuH1v6uIi7YWJG8cdrR 52mdSsN8 rnkIiwpVZd1D4n6LbcPJX0/wE9V8CG8xLzTpZoPGy0qSoJ0t99OT7oqWU6hSqueFPXP0+NHIu9bgVonhnGuhKgn8y0lZ7dbSwgP6j1HYxqt99D4LQbGek8+t42vCVWtrdudUL1ZUHObFt5XUhMtISZevtrxTWNF9MJhXW6MV51Ih3oN6bXnncA0LTDcHTx8CVVwqFqUv6SeUcDa99Hzu85JDuny2Rt4jL3VzhDR39OWqW2MluM2yHIgehfyYVMq4Ko+tvUOQjekHXFs63tj3dhe1ScWGzurZ/SMw/Pwjd/MgK3xbY12sty47njayqWJqQ7HN1frCF8K2+Uxr/ag2wT5ZFjnFE3feEe0C3ads2rldZLaDhpVhvCdhADb3sUcLCCVVw6pA0W3ELgox/CzsdSrMpXifVKROxiijJCDKbJHgo0foqcRgyJvSYpyVCViCDxpMyTcKDhUlExeCLqm4GKexkjE4kYqSgRvej X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 02:08:03PM +0000, Ryan Roberts wrote: > When page_shift is greater than PAGE_SIZE, __vmap_pages_range_noflush() s/PAGE_SIZE/PAGE_SHIFT/ Otherwise it looks fine. Reviewed-by: Catalin Marinas